February 2011 - mkgmap-dev - The mkgmap lists

NPE in splitter crosby_integration branch
by Jeffrey Ollie 19 Feb '11

19 Feb '11

I think that I've tracked down an NPE in the crosby_integration branch of the splitter. The SplitProcessor is using a BlockingQueue to queue up elements for writing. The poll() method can potentially return a null if the queue is empty. My question is, should the poll() method call be switched to a take() method call - the take() method will block if the queue is empty, or should I guard the usage of elements for null like in the patch below? Index: src/uk/me/parabola/splitter/SplitProcessor.java =================================================================== --- src/uk/me/parabola/splitter/SplitProcessor.java (revision 161) +++ src/uk/me/parabola/splitter/SplitProcessor.java (working copy) @@ -320,13 +320,14 @@ } else { synchronized (workPackage) { while (!workPackage.inputQueue.isEmpty()) { - ArrayList<Element> elements =null; + ArrayList<Element> elements = null; try { elements = workPackage.inputQueue.poll(); - for (Element element : elements ) { - processElement(element, workPackage.writer); + if (elements != null) { + for (Element element : elements ) { + processElement(element, workPackage.writer); + } } - } catch (IOException e) { throw new RuntimeException("Thread " + Thread.currentThread().getName() + " failed to write element ", e); } -- Jeff Ollie

2 2

dropping place:village,hamlet,suburb in city search
by maning sambale 19 Feb '11

19 Feb '11

Any suggested hexcode to use for place:village,hamlet,suburb in city search that will make it searcheable as a POI but not in the current city search? The idea is to declutter the city search of these minor places and just the actual city/town will be used to index streets and cities. -- cheers, maning ------------------------------------------------------ "Freedom is still the most radical idea of all" -N.Branden wiki: http://esambale.wikispaces.com/ blog: http://epsg4253.wordpress.com/ ------------------------------------------------------

4 4

Index branch: broken routing and sea generation
by Carlos Dávila 18 Feb '11

18 Feb '11

Any attempt to compile map of Spain with index branch results in a map with all tiles with coast flooded and broken routing. I have tried many combinations of options for mkgmap between the two extremes below: a: /usr/lib/jvm/java-6-sun/bin/java -Xmx1500m -enableassertions -Dlog.config=logging.properties -jar mkgmap-index.jar \ --route --family-id=18 --product-id=1 --index -c spain-index.args b: /usr/lib/jvm/java-6-sun/bin/java -Xmx1500m -enableassertions -Dlog.config=logging.properties -jar mkgmap-index.jar \ --max-jobs --generate-sea=polygons,extend-sea-sectors --route --latin1 --code-page=1252 --gmapsupp --country-name=ESPAÑA --country-abbr=ESP --area-name=España --family-name="OpenStreetMap España" --family-id=18 --product-id=1 --series-name="OSM-España-index" --index --ignore-maxspeeds --remove-short-arcs --add-pois-to-areas --adjust-turn-headings --report-similar-arcs --link-pois-to-ways --location-autofill=0 --style=mio -c spain-index.args Other things I have tried are OpenJDK instead of sun-Java, jar from mkgmap.org instead of self compiled, reducing max-nodes in splitter, etc. but all with the same result. If I compile just one or two of the tiles, routing works as usual (sea generation not tested).

3 3

Generating sea
by Josef Latt 18 Feb '11

18 Feb '11

Hi, I use the German extract from cloudmade.com. With mkgmap-r1815, 1827, 1829 generating sea (--generate-sea=extend-sea-sectors,close-gaps=5000) is incomplete. See screenshot sea_bad.jpg. Using mkgmap-r1625 generating sea is o.k. but there are some ghost rivers. See screenshots sea_good.jpg and Ghostriver.jpg. Vou can download the screenshots as ZIP here: http://ge.tt/#70BMn5z Greetings Josef -- PGP Schlüssel: 311D1055 http://keyserver.pgp.com

2 7

--make-cycleways labels invisible
by Minko 18 Feb '11

18 Feb '11

Hi, If I use the option --make-opposite-cycleways or --make-all-cycleways, an extra label is placed with "street (cycleway)". Is it possible to turn this label off or make it invisible in the style line file and how? Cheers, Minko

6 16

Address search and index.
by Steve Ratcliffe 18 Feb '11

18 Feb '11

There is a big problem with address search with poor and inconsistent map data. With my map of England I get the choice of four different variations on the name of the country to choose from. One must be chosen and doing so means that you can only find streets that have that particular country name. Now there is no way for me to know since after all everything is really in the same country. So to make address search really useful the country names have to be cleaned up, (other countries may be in a better state). Does anyone have any good ideas about this? ..Steve

12 29

Building the splitter with Eclipse?
by Jeffrey Ollie 17 Feb '11

17 Feb '11

Can anyone give me tips on building the splitter (the crosby integration branch) with Eclipse? Whenever I try I end up with a jar file that can't find any of the dependencies on the classpath, even though I specify all of the external jars with the '-classpath' argument. I had similar problems building from the command line with ant until I modified the build.xml to copy all of the class files from the external jars into the splitter.jar file. I'm sure this is probably just a Java newbie thing... I only really deal with Java for OSM so it's taking me a little while to get accustomed to the tools. I'd like to use Eclipse as an editor because of the inline help that it can give you, as opposed to Emacs which is my usual editor. -- Jeff Ollie

1 1

search and address test (index-r1860)
by maning sambale 17 Feb '11

17 Feb '11

Hi, Some test results using the index-r1860 for the Philippines using nuvi 1310. 1. Select country now has one option for the Philippines 2. Search by address by street name works. You can use both "Spell City" and "Search All" . One quirk, I noticed is that a street is assigned to a single place/"city" depending on the location of the place node. For example, "Street x Y village, Z City" can be found either in in X or Y and not both. The problem is that if there are many place=village or hamlet tags within a City, very few results will come out when using the actual city name. (I am aware that this is due to the use of the is_in tags and there are proposed ideas on using boundaries and relations and nominatim in the future) 3. City search now works. 4. Intersection works! However, it suffers the one-street-one-city-only issue as item 2. Moreover, when selecting "Street1", you are given another window to select "Street2". Pressing the "Done" button, you are given a list of street, but the provided street doesn't necessarily intersect with "Street1". In some cases it can't find an intersection which I know has one but I think this is more of a data issue. 5. Search via substring works for POI search but not for City search. For example, with POI search, the word "Pablo" gives result like: San Pablo Pablo S. Pablo In the city search, you only get results when the query string is in the first word, like: Pablo Pablo, Laguna Overall, great work on the index! -- cheers, maning ------------------------------------------------------ "Freedom is still the most radical idea of all" -N.Branden wiki: http://esambale.wikispaces.com/ blog: http://epsg4253.wordpress.com/ ------------------------------------------------------

1 0

Patch: Add Ireland to LocatorConfig.xml
by Dermot McNally 16 Feb '11

16 Feb '11

It would be great if somebody could add the following patch to improve the address support in Ireland: Index: LocatorConfig.xml =================================================================== --- LocatorConfig.xml (revision 1852) +++ LocatorConfig.xml (working copy) @@ -26,6 +26,11 @@ <variant>Italy</variant> <variant>IT</variant> </country> + <country name="Ireland" abr="IRL" regionOffset="3"> + <variant>Republic of Ireland</variant> + <variant>Éire</variant> + <variant>IE</variant> + </country> <country name="France" abr="FRA"> </country> <country name="España" abr="ESP" poiDispFlag="0xc"> Thanks, Dermot -- -------------------------------------- Igaühel on siin oma laul ja ma oma ei leiagi üles

6 5

java.lang.IllegalArgumentException
by Thorsten Kukuk 16 Feb '11

16 Feb '11

Hi, with the mkgmap sr1846 I see now this java exception: Exception in thread "main" java.lang.IllegalArgumentException at java.nio.ByteBuffer.allocate(ByteBuffer.java:311) at uk.me.parabola.imgfmt.sys.Directory.sync(Directory.java:176) at uk.me.parabola.imgfmt.sys.ImgFS.sync(ImgFS.java:230) at uk.me.parabola.imgfmt.sys.ImgFS.close(ImgFS.java:240) at uk.me.parabola.mkgmap.combiners.GmapsuppBuilder.onFinish(GmapsuppBuilder.java:119) at uk.me.parabola.mkgmap.main.Main.endOptions(Main.java:413) at uk.me.parabola.mkgmap.CommandArgsReader.readArgs(CommandArgsReader.java:126) at uk.me.parabola.mkgmap.main.Main.main(Main.java:127) Don't know if this is serious, at least the process finished and I get a map which works fine for my region. It's SUN Java 1.6.0_23-b05 It this something introduced with the last mkgmap changes, something broken in the OSM file or a problem with my config? Thanks, Thorsten -- Thorsten Kukuk, Project Manager/Release Manager SLES SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg GF: Markus Rex, HRB 16746 (AG Nuernberg)

2 3