Bug in Road Merging - actually doubling roads.
I just noticed that mkgmap sometimes creates a lot more routable roads for a certain stretch than actually defined in the style-file. https://www.openstreetmap.org/way/130665733 should be only once as a routable line in my map, however it ends up 6 times! Once is correct, but 5 iterations are actually the way from the south (3 times) and the way from the East (2 times). Now each of these ways should be created that often, however it should not overlay into this short stretch of way. While doubling up ways can be beneficial for routing, having a way more than 5 times on top of each other let's Garmin devices crash on routing over them. Also it leads to detours - as it will not always route straight from the Way from South to the Way going to the West, but follow along after the intersection for 4.3m until hitting up north, then reversing and finally going to the way in the West. I've uploaded the tile here: https://openmtbmap.org/gmapsupp_copied.img I'm pretty sure that with other style-files - the way will also be copied past the intersection and end up too often in the map for that 4.3m stretch... I kinda guess it is related to it being so short - that place has some remarkable micro-mapping detail. Or is this really expected? If needed I can try to create a reduced style to only create that problem - but I think the bug should be obvious. -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Felix, I can reproduce the problem with a small download around the way and just the --route option. The problem seems to be in WrongAngleFixer, it says "... all points of way http://www.openstreetmap.org/way/130665733 are rounded to equal map units" No idea why the way is not reduced to a single point, will investigate further. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Donnerstag, 22. Februar 2018 19:27:44 An: Development list for mkgmap Betreff: [mkgmap-dev] Bug in Road Merging - actually doubling roads. I just noticed that mkgmap sometimes creates a lot more routable roads for a certain stretch than actually defined in the style-file. https://www.openstreetmap.org/way/130665733 should be only once as a routable line in my map, however it ends up 6 times! Once is correct, but 5 iterations are actually the way from the south (3 times) and the way from the East (2 times). Now each of these ways should be created that often, however it should not overlay into this short stretch of way. While doubling up ways can be beneficial for routing, having a way more than 5 times on top of each other let's Garmin devices crash on routing over them. Also it leads to detours - as it will not always route straight from the Way from South to the Way going to the West, but follow along after the intersection for 4.3m until hitting up north, then reversing and finally going to the way in the West. I've uploaded the tile here: https://openmtbmap.org/gmapsupp_copied.img I'm pretty sure that with other style-files - the way will also be copied past the intersection and end up too often in the map for that 4.3m stretch... I kinda guess it is related to it being so short - that place has some remarkable micro-mapping detail. Or is this really expected? If needed I can try to create a reduced style to only create that problem - but I think the bug should be obvious. -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Perfect. I guess my maps are the only one causing bsod here on devices, but without the bug they would be fine... On 22 Feb 2018 20:03, "Gerd Petermann" <gpetermann_muenchen@hotmail.com> wrote:
Hi Felix,
I can reproduce the problem with a small download around the way and just the --route option. The problem seems to be in WrongAngleFixer, it says "... all points of way http://www.openstreetmap.org/way/130665733 are rounded to equal map units" No idea why the way is not reduced to a single point, will investigate further.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Donnerstag, 22. Februar 2018 19:27:44 An: Development list for mkgmap Betreff: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
I just noticed that mkgmap sometimes creates a lot more routable roads for a certain stretch than actually defined in the style-file.
https://www.openstreetmap.org/way/130665733
should be only once as a routable line in my map, however it ends up 6 times! Once is correct, but 5 iterations are actually the way from the south (3 times) and the way from the East (2 times). Now each of these ways should be created that often, however it should not overlay into this short stretch of way.
While doubling up ways can be beneficial for routing, having a way more than 5 times on top of each other let's Garmin devices crash on routing over them. Also it leads to detours - as it will not always route straight from the Way from South to the Way going to the West, but follow along after the intersection for 4.3m until hitting up north, then reversing and finally going to the way in the West.
I've uploaded the tile here: https://openmtbmap.org/gmapsupp_copied.img
I'm pretty sure that with other style-files - the way will also be copied past the intersection and end up too often in the map for that 4.3m stretch...
I kinda guess it is related to it being so short - that place has some remarkable micro-mapping detail. Or is this really expected?
If needed I can try to create a reduced style to only create that problem - but I think the bug should be obvious.
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Felix, I have to think about this for a while. There are three very short ways connected in node 412440328: way 130665733 : the northern node 1263658617 is close to a Garmin grid point, the sourthern node 412440328 is also closer to this grid point than to any other, so both are rounded to the same grid point in the north, and finally it is ignored. way 110722884: the way is only ~1m long and both nodes are far from any Garmin grid point. This is the way that is causing the trouble. It is not removed, instead the initial rounding changes it to a ~3m way going north -> south. way 130663479: the way has 3 nodes, and the one in the middle (node 1263658804) is rounded to the same coords as the ends of the bridge (way 103567847) and way 110722884, while the northern node 412440328 is moved up. I've attached 4 files to document the problem. Please load into JOSM to visualize: orig.osm.pbf: the original osm data init_hp.osm.pbf: the road network as input to WrongAngleFixer in so called "high precision" init_mu.osm.pbf: like init_hp.osm.pbf, but rounded to Garmin map units after-WO_mu.osm.pbf: the result of WrongAngleFixer with coords rounded to Garmin map units (please ignore the fact that the node ids in non-orig files are wrong) Somehow I have to teach mkgmap that it would be better to ignore (also) way 110722884. I don't know yet what criteria I should use for that. Normally we try to keep all routable ways, as they may contain access restrictions. BTW: There is more such trouble near way 111528851. ciao, Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Donnerstag, 22. Februar 2018 20:19:15 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Perfect. I guess my maps are the only one causing bsod here on devices, but without the bug they would be fine... On 22 Feb 2018 20:03, "Gerd Petermann" <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, I can reproduce the problem with a small download around the way and just the --route option. The problem seems to be in WrongAngleFixer, it says "... all points of way http://www.openstreetmap.org/way/130665733 are rounded to equal map units" No idea why the way is not reduced to a single point, will investigate further. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Donnerstag, 22. Februar 2018 19:27:44 An: Development list for mkgmap Betreff: [mkgmap-dev] Bug in Road Merging - actually doubling roads. I just noticed that mkgmap sometimes creates a lot more routable roads for a certain stretch than actually defined in the style-file. https://www.openstreetmap.org/way/130665733 should be only once as a routable line in my map, however it ends up 6 times! Once is correct, but 5 iterations are actually the way from the south (3 times) and the way from the East (2 times). Now each of these ways should be created that often, however it should not overlay into this short stretch of way. While doubling up ways can be beneficial for routing, having a way more than 5 times on top of each other let's Garmin devices crash on routing over them. Also it leads to detours - as it will not always route straight from the Way from South to the Way going to the West, but follow along after the intersection for 4.3m until hitting up north, then reversing and finally going to the way in the West. I've uploaded the tile here: https://openmtbmap.org/gmapsupp_copied.img I'm pretty sure that with other style-files - the way will also be copied past the intersection and end up too often in the map for that 4.3m stretch... I kinda guess it is related to it being so short - that place has some remarkable micro-mapping detail. Or is this really expected? If needed I can try to create a reduced style to only create that problem - but I think the bug should be obvious. -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd, Maybe it's better to try to merge these small ways as they anyway only creates 'ugly' roads. With increasing level of details in OSM I think mkgmap will need some preprocessing to generalise the data first. I'm not only thinking about these very small ways, but also have the lane-mapping and other mapping details, which are not important for Garmin maps. Henning On 23 Feb 2018, 15:21, at 15:21, Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote:
Hi Felix,
I have to think about this for a while. There are three very short ways connected in node 412440328: way 130665733 : the northern node 1263658617 is close to a Garmin grid point, the sourthern node 412440328 is also closer to this grid point than to any other, so both are rounded to the same grid point in the north, and finally it is ignored. way 110722884: the way is only ~1m long and both nodes are far from any Garmin grid point. This is the way that is causing the trouble. It is not removed, instead the initial rounding changes it to a ~3m way going north -> south. way 130663479: the way has 3 nodes, and the one in the middle (node 1263658804) is rounded to the same coords as the ends of the bridge (way 103567847) and way 110722884, while the northern node 412440328 is moved up.
I've attached 4 files to document the problem. Please load into JOSM to visualize: orig.osm.pbf: the original osm data init_hp.osm.pbf: the road network as input to WrongAngleFixer in so called "high precision" init_mu.osm.pbf: like init_hp.osm.pbf, but rounded to Garmin map units after-WO_mu.osm.pbf: the result of WrongAngleFixer with coords rounded to Garmin map units (please ignore the fact that the node ids in non-orig files are wrong)
Somehow I have to teach mkgmap that it would be better to ignore (also) way 110722884. I don't know yet what criteria I should use for that. Normally we try to keep all routable ways, as they may contain access restrictions.
BTW: There is more such trouble near way 111528851.
ciao, Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Donnerstag, 22. Februar 2018 20:19:15 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Perfect. I guess my maps are the only one causing bsod here on devices, but without the bug they would be fine...
On 22 Feb 2018 20:03, "Gerd Petermann" <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix,
I can reproduce the problem with a small download around the way and just the --route option. The problem seems to be in WrongAngleFixer, it says "... all points of way http://www.openstreetmap.org/way/130665733 are rounded to equal map units" No idea why the way is not reduced to a single point, will investigate further.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Donnerstag, 22. Februar 2018 19:27:44 An: Development list for mkgmap Betreff: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
I just noticed that mkgmap sometimes creates a lot more routable roads for a certain stretch than actually defined in the style-file.
https://www.openstreetmap.org/way/130665733
should be only once as a routable line in my map, however it ends up 6 times! Once is correct, but 5 iterations are actually the way from the south (3 times) and the way from the East (2 times). Now each of these ways should be created that often, however it should not overlay into this short stretch of way.
While doubling up ways can be beneficial for routing, having a way more than 5 times on top of each other let's Garmin devices crash on routing over them. Also it leads to detours - as it will not always route straight from the Way from South to the Way going to the West, but follow along after the intersection for 4.3m until hitting up north, then reversing and finally going to the way in the West.
I've uploaded the tile here: https://openmtbmap.org/gmapsupp_copied.img
I'm pretty sure that with other style-files - the way will also be copied past the intersection and end up too often in the map for that 4.3m stretch...
I kinda guess it is related to it being so short - that place has some remarkable micro-mapping detail. Or is this really expected?
If needed I can try to create a reduced style to only create that problem - but I think the bug should be obvious.
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
------------------------------------------------------------------------
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
I think merging is fine - maybe just add restrictions to the adjoining ways if preset. And it really should not happen that ways are merged past a junction - I now think this happens in some more places. Because it's not the first time I notice that a routing turns 180° to return to the junction to actually turn. And maybe could there be a filter that there are never more than 5 routable ways from continue command? From 6 onwards it crashes devices. Maybe even from 5 onwards. 1 routable original and 3 routable overlays are definitely fine. (Basecamp/Mapsource don't care - it only crashes GPS devices). On 23 February 2018 at 09:12, Henning Scholland <osm@hscholland.de> wrote:
Hi Gerd, Maybe it's better to try to merge these small ways as they anyway only creates 'ugly' roads. With increasing level of details in OSM I think mkgmap will need some preprocessing to generalise the data first. I'm not only thinking about these very small ways, but also have the lane-mapping and other mapping details, which are not important for Garmin maps. Henning On 23 Feb 2018, at 15:21, Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote:
Hi Felix,
I have to think about this for a while. There are three very short ways connected in node 412440328: way 130665733 : the northern node 1263658617 is close to a Garmin grid point, the sourthern node 412440328 is also closer to this grid point than to any other, so both are rounded to the same grid point in the north, and finally it is ignored. way 110722884: the way is only ~1m long and both nodes are far from any Garmin grid point. This is the way that is causing the trouble. It is not removed, instead the initial rounding changes it to a ~3m way going north -> south. way 130663479: the way has 3 nodes, and the one in the middle (node 1263658804) is rounded to the same coords as the ends of the bridge (way 103567847) and way 110722884, while the northern node 412440328 is moved up.
I've attached 4 files to document the problem. Please load into JOSM to visualize: orig.osm.pbf: the original osm data init_hp.osm.pbf: the road network as input to WrongAngleFixer in so called "high precision" init_mu.osm.pbf: like init_hp.osm.pbf, but rounded to Garmin map units after-WO_mu.osm.pbf: the result of WrongAngleFixer with coords rounded to Garmin map units (please ignore the fact that the node ids in non-orig files are wrong)
Somehow I have to teach mkgmap that it would be better to ignore (also) way 110722884. I don't know yet what criteria I should use for that. Normally we try to keep all routable ways, as they may contain access restrictions.
BTW: There is more such trouble near way 111528851.
ciao, Gerd
------------------------------
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Donnerstag, 22. Februar 2018 20:19:15 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Perfect. I guess my maps are the only one causing bsod here on devices, but without the bug they would be fine...
On 22 Feb 2018 20:03, "Gerd Petermann" <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix,
I can reproduce the problem with a small download around the way and just the --route option. The problem seems to be in WrongAngleFixer, it says "... all points of way http://www.openstreetmap.org/way/130665733 are rounded to equal map units" No idea why the way is not reduced to a single point, will investigate further.
Gerd
------------------------------
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Donnerstag, 22. Februar 2018 19:27:44 An: Development list for mkgmap Betreff: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
I just noticed that mkgmap sometimes creates a lot more routable roads for a certain stretch than actually defined in the style-file.
https://www.openstreetmap.org/way/130665733
should be only once as a routable line in my map, however it ends up 6 times! Once is correct, but 5 iterations are actually the way from the south (3 times) and the way from the East (2 times). Now each of these ways should be created that often, however it should not overlay into this short stretch of way.
While doubling up ways can be beneficial for routing, having a way more than 5 times on top of each other let's Garmin devices crash on routing over them. Also it leads to detours - as it will not always route straight from the Way from South to the Way going to the West, but follow along after the intersection for 4.3m until hitting up north, then reversing and finally going to the way in the West.
I've uploaded the tile here: https://openmtbmap.org/gmapsupp_copied.img
I'm pretty sure that with other style-files - the way will also be copied past the intersection and end up too often in the map for that 4.3m stretch...
I kinda guess it is related to it being so short - that place has some remarkable micro-mapping detail. Or is this really expected?
If needed I can try to create a reduced style to only create that problem - but I think the bug should be obvious.
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ------------------------------
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
------------------------------
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi all, I don't think this problem is caused by merging, at least not the problem that I see with the default style. I also don't think that merging can help to solve the problem. This is just a problem of resolution. The junction is simply too far away from any Garmin grid point and there will always be distortions. The question is if this has an effect on routing. Although the map shows a u-turn the angles that are stored in the img file should be very different from 180°. With the default style Basecamp shows an angle of ~45° in the routing directions for a turn from west to south-east. So, I think Felix is right that the real problem is the number of routable ways that his style produces and - maybe - how the road merger connects them. @Felix: Please, can you create a map with your style for the small extract in the previously posted orig.osm.pbf and post a link for further anylyses? If possible, please use the attached patch to compile a special version of mkgmap first. Note the hard coded path "e:/ld/" in the patch, please change that to a directory on your machine. To compile please use the command ant resolve-optional dist Make sure that you don't use this module for normal input files, it creates a lot of debug files! Just zip all the files and post them as well if possible. thanks, Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Freitag, 23. Februar 2018 19:08:45 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. I think merging is fine - maybe just add restrictions to the adjoining ways if preset. And it really should not happen that ways are merged past a junction - I now think this happens in some more places. Because it's not the first time I notice that a routing turns 180° to return to the junction to actually turn. And maybe could there be a filter that there are never more than 5 routable ways from continue command? From 6 onwards it crashes devices. Maybe even from 5 onwards. 1 routable original and 3 routable overlays are definitely fine. (Basecamp/Mapsource don't care - it only crashes GPS devices). On 23 February 2018 at 09:12, Henning Scholland <osm@hscholland.de<mailto:osm@hscholland.de>> wrote: Hi Gerd, Maybe it's better to try to merge these small ways as they anyway only creates 'ugly' roads. With increasing level of details in OSM I think mkgmap will need some preprocessing to generalise the data first. I'm not only thinking about these very small ways, but also have the lane-mapping and other mapping details, which are not important for Garmin maps. Henning On 23 Feb 2018, at 15:21, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, I have to think about this for a while. There are three very short ways connected in node 412440328: way 130665733 : the northern node 1263658617 is close to a Garmin grid point, the sourthern node 412440328 is also closer to this grid point than to any other, so both are rounded to the same grid point in the north, and finally it is ignored. way 110722884: the way is only ~1m long and both nodes are far from any Garmin grid point. This is the way that is causing the trouble. It is not removed, instead the initial rounding changes it to a ~3m way going north -> south. way 130663479: the way has 3 nodes, and the one in the middle (node 1263658804) is rounded to the same coords as the ends of the bridge (way 103567847) and way 110722884, while the northern node 412440328 is moved up. I've attached 4 files to document the problem. Please load into JOSM to visualize: orig.osm.pbf: the original osm data init_hp.osm.pbf: the road network as input to WrongAngleFixer in so called "high precision" init_mu.osm.pbf: like init_hp.osm.pbf, but rounded to Garmin map units after-WO_mu.osm.pbf: the result of WrongAngleFixer with coords rounded to Garmin map units (please ignore the fact that the node ids in non-orig files are wrong) Somehow I have to teach mkgmap that it would be better to ignore (also) way 110722884. I don't know yet what criteria I should use for that. Normally we try to keep all routable ways, as they may contain access restrictions. BTW: There is more such trouble near way 111528851. ciao, Gerd ________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Donnerstag, 22. Februar 2018 20:19:15 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Perfect. I guess my maps are the only one causing bsod here on devices, but without the bug they would be fine... On 22 Feb 2018 20:03, "Gerd Petermann" <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix, I can reproduce the problem with a small download around the way and just the --route option. The problem seems to be in WrongAngleFixer, it says "... all points of way http://www.openstreetmap.org/way/130665733 are rounded to equal map units" No idea why the way is not reduced to a single point, will investigate further. Gerd ________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> Gesendet: Donnerstag, 22. Februar 2018 19:27:44 An: Development list for mkgmap Betreff: [mkgmap-dev] Bug in Road Merging - actually doubling roads. I just noticed that mkgmap sometimes creates a lot more routable roads for a certain stretch than actually defined in the style-file. https://www.openstreetmap.org/way/130665733 should be only once as a routable line in my map, however it ends up 6 times! Once is correct, but 5 iterations are actually the way from the south (3 times) and the way from the East (2 times). Now each of these ways should be created that often, however it should not overlay into this short stretch of way. While doubling up ways can be beneficial for routing, having a way more than 5 times on top of each other let's Garmin devices crash on routing over them. Also it leads to detours - as it will not always route straight from the Way from South to the Way going to the West, but follow along after the intersection for 4.3m until hitting up north, then reversing and finally going to the way in the West. I've uploaded the tile here: https://openmtbmap.org/gmapsupp_copied.img I'm pretty sure that with other style-files - the way will also be copied past the intersection and end up too often in the map for that 4.3m stretch... I kinda guess it is related to it being so short - that place has some remarkable micro-mapping detail. Or is this really expected? If needed I can try to create a reduced style to only create that problem - but I think the bug should be obvious. -- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Felix, maybe this helps already: Attached is a small patch that changes StyledConverter so that it only accepts 4 routable ways for one OSM way. Any further routable way for the same OSM way creates just a warning. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Freitag, 23. Februar 2018 19:08:45 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. I think merging is fine - maybe just add restrictions to the adjoining ways if preset. And it really should not happen that ways are merged past a junction - I now think this happens in some more places. Because it's not the first time I notice that a routing turns 180° to return to the junction to actually turn. And maybe could there be a filter that there are never more than 5 routable ways from continue command? From 6 onwards it crashes devices. Maybe even from 5 onwards. 1 routable original and 3 routable overlays are definitely fine. (Basecamp/Mapsource don't care - it only crashes GPS devices). On 23 February 2018 at 09:12, Henning Scholland <osm@hscholland.de<mailto:osm@hscholland.de>> wrote: Hi Gerd, Maybe it's better to try to merge these small ways as they anyway only creates 'ugly' roads. With increasing level of details in OSM I think mkgmap will need some preprocessing to generalise the data first. I'm not only thinking about these very small ways, but also have the lane-mapping and other mapping details, which are not important for Garmin maps. Henning On 23 Feb 2018, at 15:21, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, I have to think about this for a while. There are three very short ways connected in node 412440328: way 130665733 : the northern node 1263658617 is close to a Garmin grid point, the sourthern node 412440328 is also closer to this grid point than to any other, so both are rounded to the same grid point in the north, and finally it is ignored. way 110722884: the way is only ~1m long and both nodes are far from any Garmin grid point. This is the way that is causing the trouble. It is not removed, instead the initial rounding changes it to a ~3m way going north -> south. way 130663479: the way has 3 nodes, and the one in the middle (node 1263658804) is rounded to the same coords as the ends of the bridge (way 103567847) and way 110722884, while the northern node 412440328 is moved up. I've attached 4 files to document the problem. Please load into JOSM to visualize: orig.osm.pbf: the original osm data init_hp.osm.pbf: the road network as input to WrongAngleFixer in so called "high precision" init_mu.osm.pbf: like init_hp.osm.pbf, but rounded to Garmin map units after-WO_mu.osm.pbf: the result of WrongAngleFixer with coords rounded to Garmin map units (please ignore the fact that the node ids in non-orig files are wrong) Somehow I have to teach mkgmap that it would be better to ignore (also) way 110722884. I don't know yet what criteria I should use for that. Normally we try to keep all routable ways, as they may contain access restrictions. BTW: There is more such trouble near way 111528851. ciao, Gerd ________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Donnerstag, 22. Februar 2018 20:19:15 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Perfect. I guess my maps are the only one causing bsod here on devices, but without the bug they would be fine... On 22 Feb 2018 20:03, "Gerd Petermann" <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix, I can reproduce the problem with a small download around the way and just the --route option. The problem seems to be in WrongAngleFixer, it says "... all points of way http://www.openstreetmap.org/way/130665733 are rounded to equal map units" No idea why the way is not reduced to a single point, will investigate further. Gerd ________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> Gesendet: Donnerstag, 22. Februar 2018 19:27:44 An: Development list for mkgmap Betreff: [mkgmap-dev] Bug in Road Merging - actually doubling roads. I just noticed that mkgmap sometimes creates a lot more routable roads for a certain stretch than actually defined in the style-file. https://www.openstreetmap.org/way/130665733 should be only once as a routable line in my map, however it ends up 6 times! Once is correct, but 5 iterations are actually the way from the south (3 times) and the way from the East (2 times). Now each of these ways should be created that often, however it should not overlay into this short stretch of way. While doubling up ways can be beneficial for routing, having a way more than 5 times on top of each other let's Garmin devices crash on routing over them. Also it leads to detours - as it will not always route straight from the Way from South to the Way going to the West, but follow along after the intersection for 4.3m until hitting up north, then reversing and finally going to the way in the West. I've uploaded the tile here: https://openmtbmap.org/gmapsupp_copied.img I'm pretty sure that with other style-files - the way will also be copied past the intersection and end up too often in the map for that 4.3m stretch... I kinda guess it is related to it being so short - that place has some remarkable micro-mapping detail. Or is this really expected? If needed I can try to create a reduced style to only create that problem - but I think the bug should be obvious. -- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Felix, any feedback? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com> Gesendet: Samstag, 24. Februar 2018 10:36:29 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, maybe this helps already: Attached is a small patch that changes StyledConverter so that it only accepts 4 routable ways for one OSM way. Any further routable way for the same OSM way creates just a warning. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Freitag, 23. Februar 2018 19:08:45 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. I think merging is fine - maybe just add restrictions to the adjoining ways if preset. And it really should not happen that ways are merged past a junction - I now think this happens in some more places. Because it's not the first time I notice that a routing turns 180° to return to the junction to actually turn. And maybe could there be a filter that there are never more than 5 routable ways from continue command? From 6 onwards it crashes devices. Maybe even from 5 onwards. 1 routable original and 3 routable overlays are definitely fine. (Basecamp/Mapsource don't care - it only crashes GPS devices). On 23 February 2018 at 09:12, Henning Scholland <osm@hscholland.de<mailto:osm@hscholland.de>> wrote: Hi Gerd, Maybe it's better to try to merge these small ways as they anyway only creates 'ugly' roads. With increasing level of details in OSM I think mkgmap will need some preprocessing to generalise the data first. I'm not only thinking about these very small ways, but also have the lane-mapping and other mapping details, which are not important for Garmin maps. Henning On 23 Feb 2018, at 15:21, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, I have to think about this for a while. There are three very short ways connected in node 412440328: way 130665733 : the northern node 1263658617 is close to a Garmin grid point, the sourthern node 412440328 is also closer to this grid point than to any other, so both are rounded to the same grid point in the north, and finally it is ignored. way 110722884: the way is only ~1m long and both nodes are far from any Garmin grid point. This is the way that is causing the trouble. It is not removed, instead the initial rounding changes it to a ~3m way going north -> south. way 130663479: the way has 3 nodes, and the one in the middle (node 1263658804) is rounded to the same coords as the ends of the bridge (way 103567847) and way 110722884, while the northern node 412440328 is moved up. I've attached 4 files to document the problem. Please load into JOSM to visualize: orig.osm.pbf: the original osm data init_hp.osm.pbf: the road network as input to WrongAngleFixer in so called "high precision" init_mu.osm.pbf: like init_hp.osm.pbf, but rounded to Garmin map units after-WO_mu.osm.pbf: the result of WrongAngleFixer with coords rounded to Garmin map units (please ignore the fact that the node ids in non-orig files are wrong) Somehow I have to teach mkgmap that it would be better to ignore (also) way 110722884. I don't know yet what criteria I should use for that. Normally we try to keep all routable ways, as they may contain access restrictions. BTW: There is more such trouble near way 111528851. ciao, Gerd ________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Donnerstag, 22. Februar 2018 20:19:15 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Perfect. I guess my maps are the only one causing bsod here on devices, but without the bug they would be fine... On 22 Feb 2018 20:03, "Gerd Petermann" <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix, I can reproduce the problem with a small download around the way and just the --route option. The problem seems to be in WrongAngleFixer, it says "... all points of way http://www.openstreetmap.org/way/130665733 are rounded to equal map units" No idea why the way is not reduced to a single point, will investigate further. Gerd ________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> Gesendet: Donnerstag, 22. Februar 2018 19:27:44 An: Development list for mkgmap Betreff: [mkgmap-dev] Bug in Road Merging - actually doubling roads. I just noticed that mkgmap sometimes creates a lot more routable roads for a certain stretch than actually defined in the style-file. https://www.openstreetmap.org/way/130665733 should be only once as a routable line in my map, however it ends up 6 times! Once is correct, but 5 iterations are actually the way from the south (3 times) and the way from the East (2 times). Now each of these ways should be created that often, however it should not overlay into this short stretch of way. While doubling up ways can be beneficial for routing, having a way more than 5 times on top of each other let's Garmin devices crash on routing over them. Also it leads to detours - as it will not always route straight from the Way from South to the Way going to the West, but follow along after the intersection for 4.3m until hitting up north, then reversing and finally going to the way in the West. I've uploaded the tile here: https://openmtbmap.org/gmapsupp_copied.img I'm pretty sure that with other style-files - the way will also be copied past the intersection and end up too often in the map for that 4.3m stretch... I kinda guess it is related to it being so short - that place has some remarkable micro-mapping detail. Or is this really expected? If needed I can try to create a reduced style to only create that problem - but I think the bug should be obvious. -- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Had no time the last 3 days, I'm right now testing some things will post back in a couple of hours.... On 27 February 2018 at 12:01, Gerd Petermann < gpetermann_muenchen@hotmail.com> wrote:
Hi Felix,
any feedback?
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com> Gesendet: Samstag, 24. Februar 2018 10:36:29 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix,
maybe this helps already: Attached is a small patch that changes StyledConverter so that it only accepts 4 routable ways for one OSM way. Any further routable way for the same OSM way creates just a warning.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Freitag, 23. Februar 2018 19:08:45 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
I think merging is fine - maybe just add restrictions to the adjoining ways if preset. And it really should not happen that ways are merged past a junction - I now think this happens in some more places. Because it's not the first time I notice that a routing turns 180° to return to the junction to actually turn. And maybe could there be a filter that there are never more than 5 routable ways from continue command? From 6 onwards it crashes devices. Maybe even from 5 onwards. 1 routable original and 3 routable overlays are definitely fine. (Basecamp/Mapsource don't care - it only crashes GPS devices).
On 23 February 2018 at 09:12, Henning Scholland <osm@hscholland.de<mailto: osm@hscholland.de>> wrote: Hi Gerd, Maybe it's better to try to merge these small ways as they anyway only creates 'ugly' roads. With increasing level of details in OSM I think mkgmap will need some preprocessing to generalise the data first. I'm not only thinking about these very small ways, but also have the lane-mapping and other mapping details, which are not important for Garmin maps. Henning On 23 Feb 2018, at 15:21, Gerd Petermann <gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com>> wrote:
Hi Felix,
I have to think about this for a while. There are three very short ways connected in node 412440328: way 130665733 : the northern node 1263658617 is close to a Garmin grid point, the sourthern node 412440328 is also closer to this grid point than to any other, so both are rounded to the same grid point in the north, and finally it is ignored. way 110722884: the way is only ~1m long and both nodes are far from any Garmin grid point. This is the way that is causing the trouble. It is not removed, instead the initial rounding changes it to a ~3m way going north -> south. way 130663479: the way has 3 nodes, and the one in the middle (node 1263658804) is rounded to the same coords as the ends of the bridge (way 103567847) and way 110722884, while the northern node 412440328 is moved up.
I've attached 4 files to document the problem. Please load into JOSM to visualize: orig.osm.pbf: the original osm data init_hp.osm.pbf: the road network as input to WrongAngleFixer in so called "high precision" init_mu.osm.pbf: like init_hp.osm.pbf, but rounded to Garmin map units after-WO_mu.osm.pbf: the result of WrongAngleFixer with coords rounded to Garmin map units (please ignore the fact that the node ids in non-orig files are wrong)
Somehow I have to teach mkgmap that it would be better to ignore (also) way 110722884. I don't know yet what criteria I should use for that. Normally we try to keep all routable ways, as they may contain access restrictions.
BTW: There is more such trouble near way 111528851.
ciao, Gerd
________________________________
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann < extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Donnerstag, 22. Februar 2018 20:19:15 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Perfect. I guess my maps are the only one causing bsod here on devices, but without the bug they would be fine...
On 22 Feb 2018 20:03, "Gerd Petermann" <gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com><mailto:g petermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix,
I can reproduce the problem with a small download around the way and just the --route option. The problem seems to be in WrongAngleFixer, it says "... all points of way http://www.openstreetmap.org/way/130665733 are rounded to equal map units" No idea why the way is not reduced to a single point, will investigate further.
Gerd
________________________________
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@ lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto: extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto: extremecarver@gmail.com>>> Gesendet: Donnerstag, 22. Februar 2018 19:27:44 An: Development list for mkgmap Betreff: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
I just noticed that mkgmap sometimes creates a lot more routable roads for a certain stretch than actually defined in the style-file.
https://www.openstreetmap.org/way/130665733
should be only once as a routable line in my map, however it ends up 6 times! Once is correct, but 5 iterations are actually the way from the south (3 times) and the way from the East (2 times). Now each of these ways should be created that often, however it should not overlay into this short stretch of way.
While doubling up ways can be beneficial for routing, having a way more than 5 times on top of each other let's Garmin devices crash on routing over them. Also it leads to detours - as it will not always route straight from the Way from South to the Way going to the West, but follow along after the intersection for 4.3m until hitting up north, then reversing and finally going to the way in the West.
I've uploaded the tile here: https://openmtbmap.org/gmapsupp_copied.img
I'm pretty sure that with other style-files - the way will also be copied past the intersection and end up too often in the map for that 4.3m stretch...
I kinda guess it is related to it being so short - that place has some remarkable micro-mapping detail. Or is this really expected?
If needed I can try to create a reduced style to only create that problem - but I think the bug should be obvious.
-- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org< http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists. mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
I looked into the files for sometime - and right now tried to compile it with the patched mkgmap version - however I get: C:\OpenMTBMap\maps>start /low /b /wait java -jar -XX:StringTableSize=100003 -Xms6000M -Xmx13300M C:\openmtbmap\mkgmap.jar --max-jobs=8 "--generate-sea" --code-page=1252 "--precomp-sea=C:\openmtbmap\maps\sea.zip" "--style-file=C:\openmtbmap\test_style" --lower-case --nsis --index --levels="0:24, 1:23, 2:22, 3:21, 4:20, 5:19, 6:18" --overview-levels="7:17, 8:16, 9:15, 10:14, 11:13, 12:12" --add-pois -to-areas --pois-to-areas-placement=entrance=main;entrance=yes;building=entrance;barrier=entrance --reduce-point-density=3.4 --reduce-point-density-polygon=6 --cycle-map --ignore-fixme-values --housenumbers --link-pois-to-ways --ignore-turn-restrictions --polygon-size-limits="24:16, 23:14, 22:12, 21:11, 20:10, 19:9, 18:8, 17:7, 16:6, 15:5, 14:4, 13:3, 12:2, 11:0, 10:0" --description=openmtbmap_it --show-profiles=1 --location-autofill=bounds,is_in,nearest --bounds=C:\openmtbmap\maps\bounds.zip --route --country-abbr=it --country-name=italy --mapname=63670000 --family-id=6367 --product-id=1 --series-name=openmtbmap_italy_27.02.2018 --family-name=mtbmap_it_27.02.2018 --tdbfile --overview-mapname=mapsetc --keep-going --area-name="italy_27.02.2018_openmtbmap.org" c:\openmtbmap\orig.osm.pbf 1
NUL java.lang.NoClassDefFoundError: uk/me/parabola/splitter/Area at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.writeOSM(WrongAngleFixer.java:1279) at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.printBadAngles(WrongAngleFixer.java:733) at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.optimizeWays(WrongAngleFixer.java:90) at uk.me.parabola.mkgmap.osmstyle.StyledConverter.end(StyledConverter.java:609) at uk.me.parabola.mkgmap.reader.osm.ElementSaver.convert(ElementSaver.java:243) at uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMapDataSource.java:157) at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:154) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:52) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:290) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:286) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) Caused by: java.lang.ClassNotFoundException: uk.me.parabola.splitter.Area at java.net.URLClassLoader.findClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) ... 14 more
As for compiling the orig.osm.pbf with my style - the resulting map is here: https://openmtbmap.org/orig_osm_compiled.zip On 27 February 2018 at 13:48, Felix Hartmann <extremecarver@gmail.com> wrote:
Had no time the last 3 days, I'm right now testing some things will post back in a couple of hours....
On 27 February 2018 at 12:01, Gerd Petermann <gpetermann_muenchen@hotmail. com> wrote:
Hi Felix,
any feedback?
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com> Gesendet: Samstag, 24. Februar 2018 10:36:29 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix,
maybe this helps already: Attached is a small patch that changes StyledConverter so that it only accepts 4 routable ways for one OSM way. Any further routable way for the same OSM way creates just a warning.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Freitag, 23. Februar 2018 19:08:45 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
I think merging is fine - maybe just add restrictions to the adjoining ways if preset. And it really should not happen that ways are merged past a junction - I now think this happens in some more places. Because it's not the first time I notice that a routing turns 180° to return to the junction to actually turn. And maybe could there be a filter that there are never more than 5 routable ways from continue command? From 6 onwards it crashes devices. Maybe even from 5 onwards. 1 routable original and 3 routable overlays are definitely fine. (Basecamp/Mapsource don't care - it only crashes GPS devices).
On 23 February 2018 at 09:12, Henning Scholland <osm@hscholland.de <mailto:osm@hscholland.de>> wrote: Hi Gerd, Maybe it's better to try to merge these small ways as they anyway only creates 'ugly' roads. With increasing level of details in OSM I think mkgmap will need some preprocessing to generalise the data first. I'm not only thinking about these very small ways, but also have the lane-mapping and other mapping details, which are not important for Garmin maps. Henning On 23 Feb 2018, at 15:21, Gerd Petermann <gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com>> wrote:
Hi Felix,
I have to think about this for a while. There are three very short ways connected in node 412440328: way 130665733 : the northern node 1263658617 is close to a Garmin grid point, the sourthern node 412440328 is also closer to this grid point than to any other, so both are rounded to the same grid point in the north, and finally it is ignored. way 110722884: the way is only ~1m long and both nodes are far from any Garmin grid point. This is the way that is causing the trouble. It is not removed, instead the initial rounding changes it to a ~3m way going north -> south. way 130663479: the way has 3 nodes, and the one in the middle (node 1263658804) is rounded to the same coords as the ends of the bridge (way 103567847) and way 110722884, while the northern node 412440328 is moved up.
I've attached 4 files to document the problem. Please load into JOSM to visualize: orig.osm.pbf: the original osm data init_hp.osm.pbf: the road network as input to WrongAngleFixer in so called "high precision" init_mu.osm.pbf: like init_hp.osm.pbf, but rounded to Garmin map units after-WO_mu.osm.pbf: the result of WrongAngleFixer with coords rounded to Garmin map units (please ignore the fact that the node ids in non-orig files are wrong)
Somehow I have to teach mkgmap that it would be better to ignore (also) way 110722884. I don't know yet what criteria I should use for that. Normally we try to keep all routable ways, as they may contain access restrictions.
BTW: There is more such trouble near way 111528851.
ciao, Gerd
________________________________
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann < extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Donnerstag, 22. Februar 2018 20:19:15 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Perfect. I guess my maps are the only one causing bsod here on devices, but without the bug they would be fine...
On 22 Feb 2018 20:03, "Gerd Petermann" <gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann _muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix,
I can reproduce the problem with a small download around the way and just the --route option. The problem seems to be in WrongAngleFixer, it says "... all points of way http://www.openstreetmap.org/way/130665733 are rounded to equal map units" No idea why the way is not reduced to a single point, will investigate further.
Gerd
________________________________
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@list s.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto: extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto: extremecarver@gmail.com>>> Gesendet: Donnerstag, 22. Februar 2018 19:27:44 An: Development list for mkgmap Betreff: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
I just noticed that mkgmap sometimes creates a lot more routable roads for a certain stretch than actually defined in the style-file.
https://www.openstreetmap.org/way/130665733
should be only once as a routable line in my map, however it ends up 6 times! Once is correct, but 5 iterations are actually the way from the south (3 times) and the way from the East (2 times). Now each of these ways should be created that often, however it should not overlay into this short stretch of way.
While doubling up ways can be beneficial for routing, having a way more than 5 times on top of each other let's Garmin devices crash on routing over them. Also it leads to detours - as it will not always route straight from the Way from South to the Way going to the West, but follow along after the intersection for 4.3m until hitting up north, then reversing and finally going to the way in the West.
I've uploaded the tile here: https://openmtbmap.org/gmapsupp_copied.img
I'm pretty sure that with other style-files - the way will also be copied past the intersection and end up too often in the map for that 4.3m stretch...
I kinda guess it is related to it being so short - that place has some remarkable micro-mapping detail. Or is this really expected?
If needed I can try to create a reduced style to only create that problem - but I think the bug should be obvious.
-- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org< http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkg map-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Felix, sorry, I always use the debugging stuff within Eclipse. Something like this should work: java -XX:StringTableSize=100003 -Xms6000M -Xmx13300M -cp d:\mkgmap\lib\optional\splitter-412.jar;d:\mkgmap\dist\mkgmap.jar uk.me.parabola.mkgmap.main.Main --max-jobs=8 ... Replace d:\mkgmap with the directory where you ran the ant resolve-optional dist command Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Dienstag, 27. Februar 2018 21:29:20 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. I looked into the files for sometime - and right now tried to compile it with the patched mkgmap version - however I get: C:\OpenMTBMap\maps>start /low /b /wait java -jar -XX:StringTableSize=100003 -Xms6000M -Xmx13300M C:\openmtbmap\mkgmap.jar --max-jobs=8 "--generate-sea" --code-page=1252 "--precomp-sea=C:\openmtbmap\maps\sea.zip" "--style-file=C:\openmtbmap\test_style" --lower-case --nsis --index --levels="0:24, 1:23, 2:22, 3:21, 4:20, 5:19, 6:18" --overview-levels="7:17, 8:16, 9:15, 10:14, 11:13, 12:12" --add-pois -to-areas --pois-to-areas-placement=entrance=main;entrance=yes;building=entrance;barrier=entrance --reduce-point-density=3.4 --reduce-point-density-polygon=6 --cycle-map --ignore-fixme-values --housenumbers --link-pois-to-ways --ignore-turn-restrictions --polygon-size-limits="24:16, 23:14, 22:12, 21:11, 20:10, 19:9, 18:8, 17:7, 16:6, 15:5, 14:4, 13:3, 12:2, 11:0, 10:0" --description=openmtbmap_it --show-profiles=1 --location-autofill=bounds,is_in,nearest --bounds=C:\openmtbmap\maps\bounds.zip --route --country-abbr=it --country-name=italy --mapname=63670000 --family-id=6367 --product-id=1 --series-name=openmtbmap_italy_27.02.2018 --family-name=mtbmap_it_27.02.2018 --tdbfile --overview-mapname=mapsetc --keep-going --area-name="italy_27.02.2018_openmtbmap.org<http://italy_27.02.2018_openmtbmap.org>" c:\openmtbmap\orig.osm.pbf 1
NUL java.lang.NoClassDefFoundError: uk/me/parabola/splitter/Area at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.writeOSM(WrongAngleFixer.java:1279) at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.printBadAngles(WrongAngleFixer.java:733) at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.optimizeWays(WrongAngleFixer.java:90) at uk.me.parabola.mkgmap.osmstyle.StyledConverter.end(StyledConverter.java:609) at uk.me.parabola.mkgmap.reader.osm.ElementSaver.convert(ElementSaver.java:243) at uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMapDataSource.java:157) at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:154) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:52) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:290) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:286) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) Caused by: java.lang.ClassNotFoundException: uk.me.parabola.splitter.Area at java.net.URLClassLoader.findClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) ... 14 more
As for compiling the orig.osm.pbf with my style - the resulting map is here: https://openmtbmap.org/orig_osm_compiled.zip On 27 February 2018 at 13:48, Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> wrote: Had no time the last 3 days, I'm right now testing some things will post back in a couple of hours.... On 27 February 2018 at 12:01, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, any feedback? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> Gesendet: Samstag, 24. Februar 2018 10:36:29 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, maybe this helps already: Attached is a small patch that changes StyledConverter so that it only accepts 4 routable ways for one OSM way. Any further routable way for the same OSM way creates just a warning. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Freitag, 23. Februar 2018 19:08:45 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. I think merging is fine - maybe just add restrictions to the adjoining ways if preset. And it really should not happen that ways are merged past a junction - I now think this happens in some more places. Because it's not the first time I notice that a routing turns 180° to return to the junction to actually turn. And maybe could there be a filter that there are never more than 5 routable ways from continue command? From 6 onwards it crashes devices. Maybe even from 5 onwards. 1 routable original and 3 routable overlays are definitely fine. (Basecamp/Mapsource don't care - it only crashes GPS devices). On 23 February 2018 at 09:12, Henning Scholland <osm@hscholland.de<mailto:osm@hscholland.de><mailto:osm@hscholland.de<mailto:osm@hscholland.de>>> wrote: Hi Gerd, Maybe it's better to try to merge these small ways as they anyway only creates 'ugly' roads. With increasing level of details in OSM I think mkgmap will need some preprocessing to generalise the data first. I'm not only thinking about these very small ways, but also have the lane-mapping and other mapping details, which are not important for Garmin maps. Henning On 23 Feb 2018, at 15:21, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix, I have to think about this for a while. There are three very short ways connected in node 412440328: way 130665733 : the northern node 1263658617 is close to a Garmin grid point, the sourthern node 412440328 is also closer to this grid point than to any other, so both are rounded to the same grid point in the north, and finally it is ignored. way 110722884: the way is only ~1m long and both nodes are far from any Garmin grid point. This is the way that is causing the trouble. It is not removed, instead the initial rounding changes it to a ~3m way going north -> south. way 130663479: the way has 3 nodes, and the one in the middle (node 1263658804) is rounded to the same coords as the ends of the bridge (way 103567847) and way 110722884, while the northern node 412440328 is moved up. I've attached 4 files to document the problem. Please load into JOSM to visualize: orig.osm.pbf: the original osm data init_hp.osm.pbf: the road network as input to WrongAngleFixer in so called "high precision" init_mu.osm.pbf: like init_hp.osm.pbf, but rounded to Garmin map units after-WO_mu.osm.pbf: the result of WrongAngleFixer with coords rounded to Garmin map units (please ignore the fact that the node ids in non-orig files are wrong) Somehow I have to teach mkgmap that it would be better to ignore (also) way 110722884. I don't know yet what criteria I should use for that. Normally we try to keep all routable ways, as they may contain access restrictions. BTW: There is more such trouble near way 111528851. ciao, Gerd ________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> Gesendet: Donnerstag, 22. Februar 2018 20:19:15 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Perfect. I guess my maps are the only one causing bsod here on devices, but without the bug they would be fine... On 22 Feb 2018 20:03, "Gerd Petermann" <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>>> wrote: Hi Felix, I can reproduce the problem with a small download around the way and just the --route option. The problem seems to be in WrongAngleFixer, it says "... all points of way http://www.openstreetmap.org/way/130665733 are rounded to equal map units" No idea why the way is not reduced to a single point, will investigate further. Gerd ________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>>> Gesendet: Donnerstag, 22. Februar 2018 19:27:44 An: Development list for mkgmap Betreff: [mkgmap-dev] Bug in Road Merging - actually doubling roads. I just noticed that mkgmap sometimes creates a lot more routable roads for a certain stretch than actually defined in the style-file. https://www.openstreetmap.org/way/130665733 should be only once as a routable line in my map, however it ends up 6 times! Once is correct, but 5 iterations are actually the way from the south (3 times) and the way from the East (2 times). Now each of these ways should be created that often, however it should not overlay into this short stretch of way. While doubling up ways can be beneficial for routing, having a way more than 5 times on top of each other let's Garmin devices crash on routing over them. Also it leads to detours - as it will not always route straight from the Way from South to the Way going to the West, but follow along after the intersection for 4.3m until hitting up north, then reversing and finally going to the way in the West. I've uploaded the tile here: https://openmtbmap.org/gmapsupp_copied.img I'm pretty sure that with other style-files - the way will also be copied past the intersection and end up too often in the map for that 4.3m stretch... I kinda guess it is related to it being so short - that place has some remarkable micro-mapping detail. Or is this really expected? If needed I can try to create a reduced style to only create that problem - but I think the bug should be obvious. -- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Oh sorry, I'm stupid. I did not realise that I need to copy in the optional lib files also to the running instance of mkgmap.jar. Really should have noticed that based on the error message. well anyhow - here is the debug data and the orig.osm.pbf compiled with the patched mkgmap version: https://openmtbmap.org/map_with_debug.zip Felix On 27 February 2018 at 22:49, Gerd Petermann < gpetermann_muenchen@hotmail.com> wrote:
Hi Felix,
sorry, I always use the debugging stuff within Eclipse. Something like this should work:
java -XX:StringTableSize=100003 -Xms6000M -Xmx13300M -cp d:\mkgmap\lib\optional\splitter-412.jar;d:\mkgmap\dist\mkgmap.jar uk.me.parabola.mkgmap.main.Main --max-jobs=8 ... Replace d:\mkgmap with the directory where you ran the ant resolve-optional dist command
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Dienstag, 27. Februar 2018 21:29:20 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
I looked into the files for sometime - and right now tried to compile it with the patched mkgmap version - however I get: C:\OpenMTBMap\maps>start /low /b /wait java -jar -XX:StringTableSize=100003 -Xms6000M -Xmx13300M C:\openmtbmap\mkgmap.jar --max-jobs=8 "--generate-sea" --code-page=1252 "--precomp-sea=C:\openmtbmap\maps\sea.zip" "--style-file=C:\openmtbmap\test_style" --lower-case --nsis --index --levels="0:24, 1:23, 2:22, 3:21, 4:20, 5:19, 6:18" --overview-levels="7:17, 8:16, 9:15, 10:14, 11:13, 12:12" --add-pois -to-areas --pois-to-areas-placement=entrance=main;entrance=yes; building=entrance;barrier=entrance --reduce-point-density=3.4 --reduce-point-density-polygon=6 --cycle-map --ignore-fixme-values --housenumbers --link-pois-to-ways --ignore-turn-restrictions --polygon-size-limits="24:16, 23:14, 22:12, 21:11, 20:10, 19:9, 18:8, 17:7, 16:6, 15:5, 14:4, 13:3, 12:2, 11:0, 10:0" --description=openmtbmap_it --show-profiles=1 --location-autofill=bounds,is_in,nearest --bounds=C:\openmtbmap\maps\bounds.zip --route --country-abbr=it --country-name=italy --mapname=63670000 --family-id=6367 --product-id=1 --series-name=openmtbmap_italy_27.02.2018 --family-name=mtbmap_it_27.02.2018 --tdbfile --overview-mapname=mapsetc --keep-going --area-name=" italy_27.02.2018_openmtbmap.org<http://italy_27.02.2018_openmtbmap.org>" c:\openmtbmap\orig.osm.pbf 1
NUL java.lang.NoClassDefFoundError: uk/me/parabola/splitter/Area at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer. writeOSM(WrongAngleFixer.java:1279) at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.printBadAngles( WrongAngleFixer.java:733) at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer. optimizeWays(WrongAngleFixer.java:90) at uk.me.parabola.mkgmap.osmstyle.StyledConverter.end( StyledConverter.java:609) at uk.me.parabola.mkgmap.reader.osm.ElementSaver.convert( ElementSaver.java:243) at uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load( OsmMapDataSource.java:157) at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile( MapMaker.java:154) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:52) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:290) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:286) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) Caused by: java.lang.ClassNotFoundException: uk.me.parabola.splitter.Area at java.net.URLClassLoader.findClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) ... 14 more
As for compiling the orig.osm.pbf with my style - the resulting map is here: https://openmtbmap.org/orig_osm_compiled.zip
On 27 February 2018 at 13:48, Felix Hartmann <extremecarver@gmail.com< mailto:extremecarver@gmail.com>> wrote: Had no time the last 3 days, I'm right now testing some things will post back in a couple of hours....
On 27 February 2018 at 12:01, Gerd Petermann <gpetermann_muenchen@hotmail. com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix,
any feedback?
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Gerd Petermann < gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> Gesendet: Samstag, 24. Februar 2018 10:36:29 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix,
maybe this helps already: Attached is a small patch that changes StyledConverter so that it only accepts 4 routable ways for one OSM way. Any further routable way for the same OSM way creates just a warning.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann < extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Freitag, 23. Februar 2018 19:08:45 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
I think merging is fine - maybe just add restrictions to the adjoining ways if preset. And it really should not happen that ways are merged past a junction - I now think this happens in some more places. Because it's not the first time I notice that a routing turns 180° to return to the junction to actually turn. And maybe could there be a filter that there are never more than 5 routable ways from continue command? From 6 onwards it crashes devices. Maybe even from 5 onwards. 1 routable original and 3 routable overlays are definitely fine. (Basecamp/Mapsource don't care - it only crashes GPS devices).
On 23 February 2018 at 09:12, Henning Scholland <osm@hscholland.de<mailto: osm@hscholland.de><mailto:osm@hscholland.de<mailto:osm@hscholland.de>>> wrote: Hi Gerd, Maybe it's better to try to merge these small ways as they anyway only creates 'ugly' roads. With increasing level of details in OSM I think mkgmap will need some preprocessing to generalise the data first. I'm not only thinking about these very small ways, but also have the lane-mapping and other mapping details, which are not important for Garmin maps. Henning On 23 Feb 2018, at 15:21, Gerd Petermann <gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com><mailto:g petermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote:
Hi Felix,
I have to think about this for a while. There are three very short ways connected in node 412440328: way 130665733 : the northern node 1263658617 is close to a Garmin grid point, the sourthern node 412440328 is also closer to this grid point than to any other, so both are rounded to the same grid point in the north, and finally it is ignored. way 110722884: the way is only ~1m long and both nodes are far from any Garmin grid point. This is the way that is causing the trouble. It is not removed, instead the initial rounding changes it to a ~3m way going north -> south. way 130663479: the way has 3 nodes, and the one in the middle (node 1263658804) is rounded to the same coords as the ends of the bridge (way 103567847) and way 110722884, while the northern node 412440328 is moved up.
I've attached 4 files to document the problem. Please load into JOSM to visualize: orig.osm.pbf: the original osm data init_hp.osm.pbf: the road network as input to WrongAngleFixer in so called "high precision" init_mu.osm.pbf: like init_hp.osm.pbf, but rounded to Garmin map units after-WO_mu.osm.pbf: the result of WrongAngleFixer with coords rounded to Garmin map units (please ignore the fact that the node ids in non-orig files are wrong)
Somehow I have to teach mkgmap that it would be better to ignore (also) way 110722884. I don't know yet what criteria I should use for that. Normally we try to keep all routable ways, as they may contain access restrictions.
BTW: There is more such trouble near way 111528851.
ciao, Gerd
________________________________
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@ lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto: extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto: extremecarver@gmail.com>>> Gesendet: Donnerstag, 22. Februar 2018 20:19:15 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Perfect. I guess my maps are the only one causing bsod here on devices, but without the bug they would be fine...
On 22 Feb 2018 20:03, "Gerd Petermann" <gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com><mailto:g petermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
<mailto:gpetermann_muenchen@hotmail.com<mailto: gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com>>>> wrote: Hi Felix,
I can reproduce the problem with a small download around the way and just the --route option. The problem seems to be in WrongAngleFixer, it says "... all points of way http://www.openstreetmap.org/way/130665733 are rounded to equal map units" No idea why the way is not reduced to a single point, will investigate further.
Gerd
________________________________
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@ lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk
<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mk gmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev- bounces@lists.mkgmap.org.uk>>>> im Auftrag von Felix Hartmann < extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto: extremecarver@gmail.com<mailto:extremecarver@gmail.com>><mailto: extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremec arver@gmail.com<mailto:extremecarver@gmail.com>>>> Gesendet: Donnerstag, 22. Februar 2018 19:27:44 An: Development list for mkgmap Betreff: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
I just noticed that mkgmap sometimes creates a lot more routable roads for a certain stretch than actually defined in the style-file.
https://www.openstreetmap.org/way/130665733
should be only once as a routable line in my map, however it ends up 6 times! Once is correct, but 5 iterations are actually the way from the south (3 times) and the way from the East (2 times). Now each of these ways should be created that often, however it should not overlay into this short stretch of way.
While doubling up ways can be beneficial for routing, having a way more than 5 times on top of each other let's Garmin devices crash on routing over them. Also it leads to detours - as it will not always route straight from the Way from South to the Way going to the West, but follow along after the intersection for 4.3m until hitting up north, then reversing and finally going to the way in the West.
I've uploaded the tile here: https://openmtbmap.org/gmapsupp_copied.img
I'm pretty sure that with other style-files - the way will also be copied past the intersection and end up too often in the map for that 4.3m stretch...
I kinda guess it is related to it being so short - that place has some remarkable micro-mapping detail. Or is this really expected?
If needed I can try to create a reduced style to only create that problem - but I think the bug should be obvious.
-- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org< http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists. mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto: mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk< mailto:mkgmap-dev@lists.mkgmap.org.uk>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists. mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists. mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
and yeah - way 111528851 is causing even more troubles. If you simply create a rule like route=hiking [0x13 road_class=4 road_speed=2 resolution 24 continue] then mkgmap puts in a long merged road, however a road with a 180° turn in itself - and routing in this case is going pretty havoc in Basecamp - on the other junction you're right - it seems that it's only visually incorrect, but routing instructions are correct - while in this case routing also goes wild. (oh I changed the patch from 4 to 5 instances - I do think 5 overall instances of a single road is okay, 6 is too much and causes some devices (reportedly edge) to switch off, while others will simply draw a long straight line through the air or not route along that section at all. On 27 February 2018 at 23:17, Felix Hartmann <extremecarver@gmail.com> wrote:
Oh sorry, I'm stupid. I did not realise that I need to copy in the optional lib files also to the running instance of mkgmap.jar. Really should have noticed that based on the error message.
well anyhow - here is the debug data and the orig.osm.pbf compiled with the patched mkgmap version: https://openmtbmap.org/map_with_debug.zip
Felix
On 27 February 2018 at 22:49, Gerd Petermann <gpetermann_muenchen@hotmail. com> wrote:
Hi Felix,
sorry, I always use the debugging stuff within Eclipse. Something like this should work:
java -XX:StringTableSize=100003 -Xms6000M -Xmx13300M -cp d:\mkgmap\lib\optional\splitter-412.jar;d:\mkgmap\dist\mkgmap.jar uk.me.parabola.mkgmap.main.Main --max-jobs=8 ... Replace d:\mkgmap with the directory where you ran the ant resolve-optional dist command
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Dienstag, 27. Februar 2018 21:29:20 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
I looked into the files for sometime - and right now tried to compile it with the patched mkgmap version - however I get: C:\OpenMTBMap\maps>start /low /b /wait java -jar -XX:StringTableSize=100003 -Xms6000M -Xmx13300M C:\openmtbmap\mkgmap.jar --max-jobs=8 "--generate-sea" --code-page=1252 "--precomp-sea=C:\openmtbmap\maps\sea.zip" "--style-file=C:\openmtbmap\test_style" --lower-case --nsis --index --levels="0:24, 1:23, 2:22, 3:21, 4:20, 5:19, 6:18" --overview-levels="7:17, 8:16, 9:15, 10:14, 11:13, 12:12" --add-pois -to-areas --pois-to-areas-placement=entrance=main;entrance=yes;building=entrance;barrier=entrance --reduce-point-density=3.4 --reduce-point-density-polygon=6 --cycle-map --ignore-fixme-values --housenumbers --link-pois-to-ways --ignore-turn-restrictions --polygon-size-limits="24:16, 23:14, 22:12, 21:11, 20:10, 19:9, 18:8, 17:7, 16:6, 15:5, 14:4, 13:3, 12:2, 11:0, 10:0" --description=openmtbmap_it --show-profiles=1 --location-autofill=bounds,is_in,nearest --bounds=C:\openmtbmap\maps\bounds.zip --route --country-abbr=it --country-name=italy --mapname=63670000 --family-id=6367 --product-id=1 --series-name=openmtbmap_italy_27.02.2018 --family-name=mtbmap_it_27.02.2018 --tdbfile --overview-mapname=mapsetc --keep-going --area-name=" italy_27.02.2018_openmtbmap.org<http://italy_27.02.2018_openmtbmap.org>" c:\openmtbmap\orig.osm.pbf 1
NUL java.lang.NoClassDefFoundError: uk/me/parabola/splitter/Area at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.writeOSM( WrongAngleFixer.java:1279) at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.printBadAngle s(WrongAngleFixer.java:733) at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.optimizeWays( WrongAngleFixer.java:90) at uk.me.parabola.mkgmap.osmstyle.StyledConverter.end(StyledCon verter.java:609) at uk.me.parabola.mkgmap.reader.osm.ElementSaver.convert(Elemen tSaver.java:243) at uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMa pDataSource.java:157) at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker. java:154) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:52) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:290) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:286) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) Caused by: java.lang.ClassNotFoundException: uk.me.parabola.splitter.Area at java.net.URLClassLoader.findClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) ... 14 more
As for compiling the orig.osm.pbf with my style - the resulting map is here: https://openmtbmap.org/orig_osm_compiled.zip
On 27 February 2018 at 13:48, Felix Hartmann <extremecarver@gmail.com <mailto:extremecarver@gmail.com>> wrote: Had no time the last 3 days, I'm right now testing some things will post back in a couple of hours....
On 27 February 2018 at 12:01, Gerd Petermann < gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix,
any feedback?
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Gerd Petermann < gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> Gesendet: Samstag, 24. Februar 2018 10:36:29 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix,
maybe this helps already: Attached is a small patch that changes StyledConverter so that it only accepts 4 routable ways for one OSM way. Any further routable way for the same OSM way creates just a warning.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann < extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Freitag, 23. Februar 2018 19:08:45 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
I think merging is fine - maybe just add restrictions to the adjoining ways if preset. And it really should not happen that ways are merged past a junction - I now think this happens in some more places. Because it's not the first time I notice that a routing turns 180° to return to the junction to actually turn. And maybe could there be a filter that there are never more than 5 routable ways from continue command? From 6 onwards it crashes devices. Maybe even from 5 onwards. 1 routable original and 3 routable overlays are definitely fine. (Basecamp/Mapsource don't care - it only crashes GPS devices).
On 23 February 2018 at 09:12, Henning Scholland <osm@hscholland.de <mailto:osm@hscholland.de><mailto:osm@hscholland.de<mailto:osm@hschollan d.de>>> wrote: Hi Gerd, Maybe it's better to try to merge these small ways as they anyway only creates 'ugly' roads. With increasing level of details in OSM I think mkgmap will need some preprocessing to generalise the data first. I'm not only thinking about these very small ways, but also have the lane-mapping and other mapping details, which are not important for Garmin maps. Henning On 23 Feb 2018, at 15:21, Gerd Petermann <gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann _muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote:
Hi Felix,
I have to think about this for a while. There are three very short ways connected in node 412440328: way 130665733 : the northern node 1263658617 is close to a Garmin grid point, the sourthern node 412440328 is also closer to this grid point than to any other, so both are rounded to the same grid point in the north, and finally it is ignored. way 110722884: the way is only ~1m long and both nodes are far from any Garmin grid point. This is the way that is causing the trouble. It is not removed, instead the initial rounding changes it to a ~3m way going north -> south. way 130663479: the way has 3 nodes, and the one in the middle (node 1263658804) is rounded to the same coords as the ends of the bridge (way 103567847) and way 110722884, while the northern node 412440328 is moved up.
I've attached 4 files to document the problem. Please load into JOSM to visualize: orig.osm.pbf: the original osm data init_hp.osm.pbf: the road network as input to WrongAngleFixer in so called "high precision" init_mu.osm.pbf: like init_hp.osm.pbf, but rounded to Garmin map units after-WO_mu.osm.pbf: the result of WrongAngleFixer with coords rounded to Garmin map units (please ignore the fact that the node ids in non-orig files are wrong)
Somehow I have to teach mkgmap that it would be better to ignore (also) way 110722884. I don't know yet what criteria I should use for that. Normally we try to keep all routable ways, as they may contain access restrictions.
BTW: There is more such trouble near way 111528851.
ciao, Gerd
________________________________
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@list s.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto: extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto: extremecarver@gmail.com>>> Gesendet: Donnerstag, 22. Februar 2018 20:19:15 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Perfect. I guess my maps are the only one causing bsod here on devices, but without the bug they would be fine...
On 22 Feb 2018 20:03, "Gerd Petermann" <gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann _muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto: gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
<mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@ hotmail.com>>>> wrote: Hi Felix,
I can reproduce the problem with a small download around the way and just the --route option. The problem seems to be in WrongAngleFixer, it says "... all points of way http://www.openstreetmap.org/way/130665733 are rounded to equal map units" No idea why the way is not reduced to a single point, will investigate further.
Gerd
________________________________
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@list s.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>><mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mk gmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev- bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto: extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto: extremecarver@gmail.com>><mailto:extremecarver@gmail.com<mailto: extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecar ver@gmail.com>>>> Gesendet: Donnerstag, 22. Februar 2018 19:27:44 An: Development list for mkgmap Betreff: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
I just noticed that mkgmap sometimes creates a lot more routable roads for a certain stretch than actually defined in the style-file.
https://www.openstreetmap.org/way/130665733
should be only once as a routable line in my map, however it ends up 6 times! Once is correct, but 5 iterations are actually the way from the south (3 times) and the way from the East (2 times). Now each of these ways should be created that often, however it should not overlay into this short stretch of way.
While doubling up ways can be beneficial for routing, having a way more than 5 times on top of each other let's Garmin devices crash on routing over them. Also it leads to detours - as it will not always route straight from the Way from South to the Way going to the West, but follow along after the intersection for 4.3m until hitting up north, then reversing and finally going to the way in the West.
I've uploaded the tile here: https://openmtbmap.org/gmapsupp_copied.img
I'm pretty sure that with other style-files - the way will also be copied past the intersection and end up too often in the map for that 4.3m stretch...
I kinda guess it is related to it being so short - that place has some remarkable micro-mapping detail. Or is this really expected?
If needed I can try to create a reduced style to only create that problem - but I think the bug should be obvious.
-- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org< http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkg map-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk <mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists. mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkg map-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkg map-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
oh - forgot to mention. If roads are thrown away - that's complicated. Actually for my maps I would need to have a rule like 1. throw away any road with type 0x13 (I use that type invisible) - then throw away those created earlier in the style. I build my style that first things like route=hiking are created routable (using continue), or bridges to improve the chance they are used for routing, then the style ends with the actual road being inserted. And well - if something is thrown away because such doubling cannot be fixed - it would be better if the first instances therefore are thrown away, and the last 4 or 5 kept - however 0x13 should always be thrown away first. Felix On 27 February 2018 at 23:26, Felix Hartmann <extremecarver@gmail.com> wrote:
and yeah - way 111528851 is causing even more troubles. If you simply create a rule like route=hiking [0x13 road_class=4 road_speed=2 resolution 24 continue]
then mkgmap puts in a long merged road, however a road with a 180° turn in itself - and routing in this case is going pretty havoc in Basecamp - on the other junction you're right - it seems that it's only visually incorrect, but routing instructions are correct - while in this case routing also goes wild. (oh I changed the patch from 4 to 5 instances - I do think 5 overall instances of a single road is okay, 6 is too much and causes some devices (reportedly edge) to switch off, while others will simply draw a long straight line through the air or not route along that section at all.
On 27 February 2018 at 23:17, Felix Hartmann <extremecarver@gmail.com> wrote:
Oh sorry, I'm stupid. I did not realise that I need to copy in the optional lib files also to the running instance of mkgmap.jar. Really should have noticed that based on the error message.
well anyhow - here is the debug data and the orig.osm.pbf compiled with the patched mkgmap version: https://openmtbmap.org/map_with_debug.zip
Felix
On 27 February 2018 at 22:49, Gerd Petermann < gpetermann_muenchen@hotmail.com> wrote:
Hi Felix,
sorry, I always use the debugging stuff within Eclipse. Something like this should work:
java -XX:StringTableSize=100003 -Xms6000M -Xmx13300M -cp d:\mkgmap\lib\optional\splitter-412.jar;d:\mkgmap\dist\mkgmap.jar uk.me.parabola.mkgmap.main.Main --max-jobs=8 ... Replace d:\mkgmap with the directory where you ran the ant resolve-optional dist command
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Dienstag, 27. Februar 2018 21:29:20 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
I looked into the files for sometime - and right now tried to compile it with the patched mkgmap version - however I get: C:\OpenMTBMap\maps>start /low /b /wait java -jar -XX:StringTableSize=100003 -Xms6000M -Xmx13300M C:\openmtbmap\mkgmap.jar --max-jobs=8 "--generate-sea" --code-page=1252 "--precomp-sea=C:\openmtbmap\maps\sea.zip" "--style-file=C:\openmtbmap\test_style" --lower-case --nsis --index --levels="0:24, 1:23, 2:22, 3:21, 4:20, 5:19, 6:18" --overview-levels="7:17, 8:16, 9:15, 10:14, 11:13, 12:12" --add-pois -to-areas --pois-to-areas-placement=entrance=main;entrance=yes;building=entrance;barrier=entrance --reduce-point-density=3.4 --reduce-point-density-polygon=6 --cycle-map --ignore-fixme-values --housenumbers --link-pois-to-ways --ignore-turn-restrictions --polygon-size-limits="24:16, 23:14, 22:12, 21:11, 20:10, 19:9, 18:8, 17:7, 16:6, 15:5, 14:4, 13:3, 12:2, 11:0, 10:0" --description=openmtbmap_it --show-profiles=1 --location-autofill=bounds,is_in,nearest --bounds=C:\openmtbmap\maps\bounds.zip --route --country-abbr=it --country-name=italy --mapname=63670000 --family-id=6367 --product-id=1 --series-name=openmtbmap_italy_27.02.2018 --family-name=mtbmap_it_27.02.2018 --tdbfile --overview-mapname=mapsetc --keep-going --area-name=" italy_27.02.2018_openmtbmap.org<http://italy_27.02.2018_openmtbmap.org>" c:\openmtbmap\orig.osm.pbf 1
NUL java.lang.NoClassDefFoundError: uk/me/parabola/splitter/Area at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.writeOSM(Wron gAngleFixer.java:1279) at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.printBadAngle s(WrongAngleFixer.java:733) at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.optimizeWays( WrongAngleFixer.java:90) at uk.me.parabola.mkgmap.osmstyle.StyledConverter.end(StyledCon verter.java:609) at uk.me.parabola.mkgmap.reader.osm.ElementSaver.convert(Elemen tSaver.java:243) at uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMa pDataSource.java:157) at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.ja va:154) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:52) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:290) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:286) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) Caused by: java.lang.ClassNotFoundException: uk.me.parabola.splitter.Area at java.net.URLClassLoader.findClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) ... 14 more
As for compiling the orig.osm.pbf with my style - the resulting map is here: https://openmtbmap.org/orig_osm_compiled.zip
On 27 February 2018 at 13:48, Felix Hartmann <extremecarver@gmail.com <mailto:extremecarver@gmail.com>> wrote: Had no time the last 3 days, I'm right now testing some things will post back in a couple of hours....
On 27 February 2018 at 12:01, Gerd Petermann < gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix,
any feedback?
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Gerd Petermann < gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> Gesendet: Samstag, 24. Februar 2018 10:36:29 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix,
maybe this helps already: Attached is a small patch that changes StyledConverter so that it only accepts 4 routable ways for one OSM way. Any further routable way for the same OSM way creates just a warning.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann < extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Freitag, 23. Februar 2018 19:08:45 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
I think merging is fine - maybe just add restrictions to the adjoining ways if preset. And it really should not happen that ways are merged past a junction - I now think this happens in some more places. Because it's not the first time I notice that a routing turns 180° to return to the junction to actually turn. And maybe could there be a filter that there are never more than 5 routable ways from continue command? From 6 onwards it crashes devices. Maybe even from 5 onwards. 1 routable original and 3 routable overlays are definitely fine. (Basecamp/Mapsource don't care - it only crashes GPS devices).
On 23 February 2018 at 09:12, Henning Scholland <osm@hscholland.de <mailto:osm@hscholland.de><mailto:osm@hscholland.de<mailto:osm@hschollan d.de>>> wrote: Hi Gerd, Maybe it's better to try to merge these small ways as they anyway only creates 'ugly' roads. With increasing level of details in OSM I think mkgmap will need some preprocessing to generalise the data first. I'm not only thinking about these very small ways, but also have the lane-mapping and other mapping details, which are not important for Garmin maps. Henning On 23 Feb 2018, at 15:21, Gerd Petermann <gpetermann_muenchen@hotmail.c om<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann _muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote:
Hi Felix,
I have to think about this for a while. There are three very short ways connected in node 412440328: way 130665733 : the northern node 1263658617 is close to a Garmin grid point, the sourthern node 412440328 is also closer to this grid point than to any other, so both are rounded to the same grid point in the north, and finally it is ignored. way 110722884: the way is only ~1m long and both nodes are far from any Garmin grid point. This is the way that is causing the trouble. It is not removed, instead the initial rounding changes it to a ~3m way going north -> south. way 130663479: the way has 3 nodes, and the one in the middle (node 1263658804) is rounded to the same coords as the ends of the bridge (way 103567847) and way 110722884, while the northern node 412440328 is moved up.
I've attached 4 files to document the problem. Please load into JOSM to visualize: orig.osm.pbf: the original osm data init_hp.osm.pbf: the road network as input to WrongAngleFixer in so called "high precision" init_mu.osm.pbf: like init_hp.osm.pbf, but rounded to Garmin map units after-WO_mu.osm.pbf: the result of WrongAngleFixer with coords rounded to Garmin map units (please ignore the fact that the node ids in non-orig files are wrong)
Somehow I have to teach mkgmap that it would be better to ignore (also) way 110722884. I don't know yet what criteria I should use for that. Normally we try to keep all routable ways, as they may contain access restrictions.
BTW: There is more such trouble near way 111528851.
ciao, Gerd
________________________________
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists. mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto: extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto: extremecarver@gmail.com>>> Gesendet: Donnerstag, 22. Februar 2018 20:19:15 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Perfect. I guess my maps are the only one causing bsod here on devices, but without the bug they would be fine...
On 22 Feb 2018 20:03, "Gerd Petermann" <gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann _muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto: gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
<mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@ho tmail.com>>>> wrote: Hi Felix,
I can reproduce the problem with a small download around the way and just the --route option. The problem seems to be in WrongAngleFixer, it says "... all points of way http://www.openstreetmap.org/way/130665733 are rounded to equal map units" No idea why the way is not reduced to a single point, will investigate further.
Gerd
________________________________
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists. mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>><mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkg map-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounc es@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto: extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto: extremecarver@gmail.com>><mailto:extremecarver@gmail.com<mailto: extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto: extremecarver@gmail.com>>>> Gesendet: Donnerstag, 22. Februar 2018 19:27:44 An: Development list for mkgmap Betreff: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
I just noticed that mkgmap sometimes creates a lot more routable roads for a certain stretch than actually defined in the style-file.
https://www.openstreetmap.org/way/130665733
should be only once as a routable line in my map, however it ends up 6 times! Once is correct, but 5 iterations are actually the way from the south (3 times) and the way from the East (2 times). Now each of these ways should be created that often, however it should not overlay into this short stretch of way.
While doubling up ways can be beneficial for routing, having a way more than 5 times on top of each other let's Garmin devices crash on routing over them. Also it leads to detours - as it will not always route straight from the Way from South to the Way going to the West, but follow along after the intersection for 4.3m until hitting up north, then reversing and finally going to the way in the West.
I've uploaded the tile here: https://openmtbmap.org/gmapsupp_copied.img
I'm pretty sure that with other style-files - the way will also be copied past the intersection and end up too often in the map for that 4.3m stretch...
I kinda guess it is related to it being so short - that place has some remarkable micro-mapping detail. Or is this really expected?
If needed I can try to create a reduced style to only create that problem - but I think the bug should be obvious.
-- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org< http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgma p-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk <mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mk gmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgma p-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgma p-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Felix, please check: You should have files like roads_orig*.o5m in the debug dir. Please send all files. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Dienstag, 27. Februar 2018 23:17:05 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Oh sorry, I'm stupid. I did not realise that I need to copy in the optional lib files also to the running instance of mkgmap.jar. Really should have noticed that based on the error message. well anyhow - here is the debug data and the orig.osm.pbf compiled with the patched mkgmap version: https://openmtbmap.org/map_with_debug.zip Felix On 27 February 2018 at 22:49, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, sorry, I always use the debugging stuff within Eclipse. Something like this should work: java -XX:StringTableSize=100003 -Xms6000M -Xmx13300M -cp d:\mkgmap\lib\optional\splitter-412.jar;d:\mkgmap\dist\mkgmap.jar uk.me.parabola.mkgmap.main.Main --max-jobs=8 ... Replace d:\mkgmap with the directory where you ran the ant resolve-optional dist command Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Dienstag, 27. Februar 2018 21:29:20 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. I looked into the files for sometime - and right now tried to compile it with the patched mkgmap version - however I get: C:\OpenMTBMap\maps>start /low /b /wait java -jar -XX:StringTableSize=100003 -Xms6000M -Xmx13300M C:\openmtbmap\mkgmap.jar --max-jobs=8 "--generate-sea" --code-page=1252 "--precomp-sea=C:\openmtbmap\maps\sea.zip" "--style-file=C:\openmtbmap\test_style" --lower-case --nsis --index --levels="0:24, 1:23, 2:22, 3:21, 4:20, 5:19, 6:18" --overview-levels="7:17, 8:16, 9:15, 10:14, 11:13, 12:12" --add-pois -to-areas --pois-to-areas-placement=entrance=main;entrance=yes;building=entrance;barrier=entrance --reduce-point-density=3.4 --reduce-point-density-polygon=6 --cycle-map --ignore-fixme-values --housenumbers --link-pois-to-ways --ignore-turn-restrictions --polygon-size-limits="24:16, 23:14, 22:12, 21:11, 20:10, 19:9, 18:8, 17:7, 16:6, 15:5, 14:4, 13:3, 12:2, 11:0, 10:0" --description=openmtbmap_it --show-profiles=1 --location-autofill=bounds,is_in,nearest --bounds=C:\openmtbmap\maps\bounds.zip --route --country-abbr=it --country-name=italy --mapname=63670000 --family-id=6367 --product-id=1 --series-name=openmtbmap_italy_27.02.2018 --family-name=mtbmap_it_27.02.2018 --tdbfile --overview-mapname=mapsetc --keep-going --area-name="italy_27.02.2018_openmtbmap.org<http://italy_27.02.2018_openmtbmap.org><http://italy_27.02.2018_openmtbmap.org>" c:\openmtbmap\orig.osm.pbf 1
NUL java.lang.NoClassDefFoundError: uk/me/parabola/splitter/Area at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.writeOSM(WrongAngleFixer.java:1279) at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.printBadAngles(WrongAngleFixer.java:733) at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.optimizeWays(WrongAngleFixer.java:90) at uk.me.parabola.mkgmap.osmstyle.StyledConverter.end(StyledConverter.java:609) at uk.me.parabola.mkgmap.reader.osm.ElementSaver.convert(ElementSaver.java:243) at uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMapDataSource.java:157) at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:154) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:52) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:290) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:286) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) Caused by: java.lang.ClassNotFoundException: uk.me.parabola.splitter.Area at java.net.URLClassLoader.findClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) ... 14 more
As for compiling the orig.osm.pbf with my style - the resulting map is here: https://openmtbmap.org/orig_osm_compiled.zip On 27 February 2018 at 13:48, Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> wrote: Had no time the last 3 days, I'm right now testing some things will post back in a couple of hours.... On 27 February 2018 at 12:01, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix, any feedback? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> Gesendet: Samstag, 24. Februar 2018 10:36:29 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, maybe this helps already: Attached is a small patch that changes StyledConverter so that it only accepts 4 routable ways for one OSM way. Any further routable way for the same OSM way creates just a warning. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> Gesendet: Freitag, 23. Februar 2018 19:08:45 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. I think merging is fine - maybe just add restrictions to the adjoining ways if preset. And it really should not happen that ways are merged past a junction - I now think this happens in some more places. Because it's not the first time I notice that a routing turns 180° to return to the junction to actually turn. And maybe could there be a filter that there are never more than 5 routable ways from continue command? From 6 onwards it crashes devices. Maybe even from 5 onwards. 1 routable original and 3 routable overlays are definitely fine. (Basecamp/Mapsource don't care - it only crashes GPS devices). On 23 February 2018 at 09:12, Henning Scholland <osm@hscholland.de<mailto:osm@hscholland.de><mailto:osm@hscholland.de<mailto:osm@hscholland.de>><mailto:osm@hscholland.de<mailto:osm@hscholland.de><mailto:osm@hscholland.de<mailto:osm@hscholland.de>>>> wrote: Hi Gerd, Maybe it's better to try to merge these small ways as they anyway only creates 'ugly' roads. With increasing level of details in OSM I think mkgmap will need some preprocessing to generalise the data first. I'm not only thinking about these very small ways, but also have the lane-mapping and other mapping details, which are not important for Garmin maps. Henning On 23 Feb 2018, at 15:21, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>>> wrote: Hi Felix, I have to think about this for a while. There are three very short ways connected in node 412440328: way 130665733 : the northern node 1263658617 is close to a Garmin grid point, the sourthern node 412440328 is also closer to this grid point than to any other, so both are rounded to the same grid point in the north, and finally it is ignored. way 110722884: the way is only ~1m long and both nodes are far from any Garmin grid point. This is the way that is causing the trouble. It is not removed, instead the initial rounding changes it to a ~3m way going north -> south. way 130663479: the way has 3 nodes, and the one in the middle (node 1263658804) is rounded to the same coords as the ends of the bridge (way 103567847) and way 110722884, while the northern node 412440328 is moved up. I've attached 4 files to document the problem. Please load into JOSM to visualize: orig.osm.pbf: the original osm data init_hp.osm.pbf: the road network as input to WrongAngleFixer in so called "high precision" init_mu.osm.pbf: like init_hp.osm.pbf, but rounded to Garmin map units after-WO_mu.osm.pbf: the result of WrongAngleFixer with coords rounded to Garmin map units (please ignore the fact that the node ids in non-orig files are wrong) Somehow I have to teach mkgmap that it would be better to ignore (also) way 110722884. I don't know yet what criteria I should use for that. Normally we try to keep all routable ways, as they may contain access restrictions. BTW: There is more such trouble near way 111528851. ciao, Gerd ________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>>> Gesendet: Donnerstag, 22. Februar 2018 20:19:15 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Perfect. I guess my maps are the only one causing bsod here on devices, but without the bug they would be fine... On 22 Feb 2018 20:03, "Gerd Petermann" <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>>>> wrote: Hi Felix, I can reproduce the problem with a small download around the way and just the --route option. The problem seems to be in WrongAngleFixer, it says "... all points of way http://www.openstreetmap.org/way/130665733 are rounded to equal map units" No idea why the way is not reduced to a single point, will investigate further. Gerd ________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>>>> Gesendet: Donnerstag, 22. Februar 2018 19:27:44 An: Development list for mkgmap Betreff: [mkgmap-dev] Bug in Road Merging - actually doubling roads. I just noticed that mkgmap sometimes creates a lot more routable roads for a certain stretch than actually defined in the style-file. https://www.openstreetmap.org/way/130665733 should be only once as a routable line in my map, however it ends up 6 times! Once is correct, but 5 iterations are actually the way from the south (3 times) and the way from the East (2 times). Now each of these ways should be created that often, however it should not overlay into this short stretch of way. While doubling up ways can be beneficial for routing, having a way more than 5 times on top of each other let's Garmin devices crash on routing over them. Also it leads to detours - as it will not always route straight from the Way from South to the Way going to the West, but follow along after the intersection for 4.3m until hitting up north, then reversing and finally going to the way in the West. I've uploaded the tile here: https://openmtbmap.org/gmapsupp_copied.img I'm pretty sure that with other style-files - the way will also be copied past the intersection and end up too often in the map for that 4.3m stretch... I kinda guess it is related to it being so short - that place has some remarkable micro-mapping detail. Or is this really expected? If needed I can try to create a reduced style to only create that problem - but I think the bug should be obvious. -- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
No sorry - I don't have them. Only the 4 debug files that I included. ( I just changed my patched mkgmap to only allow 4 copies - but still stay at the debug files provided. No On 27 February 2018 at 23:31, Gerd Petermann < gpetermann_muenchen@hotmail.com> wrote:
Hi Felix,
please check: You should have files like roads_orig*.o5m in the debug dir. Please send all files.
Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Dienstag, 27. Februar 2018 23:17:05 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Oh sorry, I'm stupid. I did not realise that I need to copy in the optional lib files also to the running instance of mkgmap.jar. Really should have noticed that based on the error message.
well anyhow - here is the debug data and the orig.osm.pbf compiled with the patched mkgmap version: https://openmtbmap.org/map_with_debug.zip
Felix
On 27 February 2018 at 22:49, Gerd Petermann <gpetermann_muenchen@hotmail. com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix,
sorry, I always use the debugging stuff within Eclipse. Something like this should work:
java -XX:StringTableSize=100003 -Xms6000M -Xmx13300M -cp d:\mkgmap\lib\optional\splitter-412.jar;d:\mkgmap\dist\mkgmap.jar uk.me.parabola.mkgmap.main.Main --max-jobs=8 ... Replace d:\mkgmap with the directory where you ran the ant resolve-optional dist command
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann < extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Dienstag, 27. Februar 2018 21:29:20 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
I looked into the files for sometime - and right now tried to compile it with the patched mkgmap version - however I get: C:\OpenMTBMap\maps>start /low /b /wait java -jar -XX:StringTableSize=100003 -Xms6000M -Xmx13300M C:\openmtbmap\mkgmap.jar --max-jobs=8 "--generate-sea" --code-page=1252 "--precomp-sea=C:\openmtbmap\maps\sea.zip" "--style-file=C:\openmtbmap\test_style" --lower-case --nsis --index --levels="0:24, 1:23, 2:22, 3:21, 4:20, 5:19, 6:18" --overview-levels="7:17, 8:16, 9:15, 10:14, 11:13, 12:12" --add-pois -to-areas --pois-to-areas-placement=entrance=main;entrance=yes; building=entrance;barrier=entrance --reduce-point-density=3.4 --reduce-point-density-polygon=6 --cycle-map --ignore-fixme-values --housenumbers --link-pois-to-ways --ignore-turn-restrictions --polygon-size-limits="24:16, 23:14, 22:12, 21:11, 20:10, 19:9, 18:8, 17:7, 16:6, 15:5, 14:4, 13:3, 12:2, 11:0, 10:0" --description=openmtbmap_it --show-profiles=1 --location-autofill=bounds,is_in,nearest --bounds=C:\openmtbmap\maps\bounds.zip --route --country-abbr=it --country-name=italy --mapname=63670000 --family-id=6367 --product-id=1 --series-name=openmtbmap_italy_27.02.2018 --family-name=mtbmap_it_27.02.2018 --tdbfile --overview-mapname=mapsetc --keep-going --area-name=" italy_27.02.2018_openmtbmap.org<http://italy_27.02.2018_openmtbmap.org><; http://italy_27.02.2018_openmtbmap.org>" c:\openmtbmap\orig.osm.pbf 1
NUL java.lang.NoClassDefFoundError: uk/me/parabola/splitter/Area at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer. writeOSM(WrongAngleFixer.java:1279) at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.printBadAngles( WrongAngleFixer.java:733) at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer. optimizeWays(WrongAngleFixer.java:90) at uk.me.parabola.mkgmap.osmstyle.StyledConverter.end( StyledConverter.java:609) at uk.me.parabola.mkgmap.reader.osm.ElementSaver.convert( ElementSaver.java:243) at uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load( OsmMapDataSource.java:157) at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile( MapMaker.java:154) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:52) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:290) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:286) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) Caused by: java.lang.ClassNotFoundException: uk.me.parabola.splitter.Area at java.net.URLClassLoader.findClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) ... 14 more
As for compiling the orig.osm.pbf with my style - the resulting map is here: https://openmtbmap.org/orig_osm_compiled.zip
On 27 February 2018 at 13:48, Felix Hartmann <extremecarver@gmail.com< mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto: extremecarver@gmail.com>>> wrote: Had no time the last 3 days, I'm right now testing some things will post back in a couple of hours....
On 27 February 2018 at 12:01, Gerd Petermann <gpetermann_muenchen@hotmail. com<mailto:gpetermann_muenchen@hotmail.com><mailto:g petermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix,
any feedback?
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@ lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto: gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com>>> Gesendet: Samstag, 24. Februar 2018 10:36:29 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix,
maybe this helps already: Attached is a small patch that changes StyledConverter so that it only accepts 4 routable ways for one OSM way. Any further routable way for the same OSM way creates just a warning.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@ lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto: extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto: extremecarver@gmail.com>>> Gesendet: Freitag, 23. Februar 2018 19:08:45 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
I think merging is fine - maybe just add restrictions to the adjoining ways if preset. And it really should not happen that ways are merged past a junction - I now think this happens in some more places. Because it's not the first time I notice that a routing turns 180° to return to the junction to actually turn. And maybe could there be a filter that there are never more than 5 routable ways from continue command? From 6 onwards it crashes devices. Maybe even from 5 onwards. 1 routable original and 3 routable overlays are definitely fine. (Basecamp/Mapsource don't care - it only crashes GPS devices).
On 23 February 2018 at 09:12, Henning Scholland <osm@hscholland.de<mailto: osm@hscholland.de><mailto:osm@hscholland.de<mailto:osm@hscholland.de
<mailto:osm@hscholland.de<mailto:osm@hscholland.de><mailto:osm@ hscholland.de<mailto:osm@hscholland.de>>>> wrote: Hi Gerd, Maybe it's better to try to merge these small ways as they anyway only creates 'ugly' roads. With increasing level of details in OSM I think mkgmap will need some preprocessing to generalise the data first. I'm not only thinking about these very small ways, but also have the lane-mapping and other mapping details, which are not important for Garmin maps. Henning On 23 Feb 2018, at 15:21, Gerd Petermann <gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com><mailto:g petermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com<mailto: gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com>>>> wrote:
Hi Felix,
I have to think about this for a while. There are three very short ways connected in node 412440328: way 130665733 : the northern node 1263658617 is close to a Garmin grid point, the sourthern node 412440328 is also closer to this grid point than to any other, so both are rounded to the same grid point in the north, and finally it is ignored. way 110722884: the way is only ~1m long and both nodes are far from any Garmin grid point. This is the way that is causing the trouble. It is not removed, instead the initial rounding changes it to a ~3m way going north -> south. way 130663479: the way has 3 nodes, and the one in the middle (node 1263658804) is rounded to the same coords as the ends of the bridge (way 103567847) and way 110722884, while the northern node 412440328 is moved up.
I've attached 4 files to document the problem. Please load into JOSM to visualize: orig.osm.pbf: the original osm data init_hp.osm.pbf: the road network as input to WrongAngleFixer in so called "high precision" init_mu.osm.pbf: like init_hp.osm.pbf, but rounded to Garmin map units after-WO_mu.osm.pbf: the result of WrongAngleFixer with coords rounded to Garmin map units (please ignore the fact that the node ids in non-orig files are wrong)
Somehow I have to teach mkgmap that it would be better to ignore (also) way 110722884. I don't know yet what criteria I should use for that. Normally we try to keep all routable ways, as they may contain access restrictions.
BTW: There is more such trouble near way 111528851.
ciao, Gerd
________________________________
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@ lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk
<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mk gmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev- bounces@lists.mkgmap.org.uk>>>> im Auftrag von Felix Hartmann < extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto: extremecarver@gmail.com<mailto:extremecarver@gmail.com>><mailto: extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremec arver@gmail.com<mailto:extremecarver@gmail.com>>>> Gesendet: Donnerstag, 22. Februar 2018 20:19:15 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Perfect. I guess my maps are the only one causing bsod here on devices, but without the bug they would be fine...
On 22 Feb 2018 20:03, "Gerd Petermann" <gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com><mailto:g petermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
<mailto:gpetermann_muenchen@hotmail.com<mailto: gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com>>><mailto:gpetermann_muenchen@ hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:g petermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com<mailto: gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com>>>>> wrote: Hi Felix,
I can reproduce the problem with a small download around the way and just the --route option. The problem seems to be in WrongAngleFixer, it says "... all points of way http://www.openstreetmap.org/way/130665733 are rounded to equal map units" No idea why the way is not reduced to a single point, will investigate further.
Gerd
________________________________
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@ lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk
<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mk gmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev- bounces@lists.mkgmap.org.uk>>><mailto:mkgmap-dev-bounces@ lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@ lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk <mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@ lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto: extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto: extremecarver@gmail.com>><mailto:extremecarver@gmail.com<mailto:extremecar ver@gmail.com><mailto:extremecarver@gmail.com<mailto:extreme carver@gmail.com>>><mailto:extremecarver@gmail.com<mailto:ex tremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto: extremecarver@gmail.com>><mailto:extremecarver@gmail.com<mailto: extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarv er@gmail.com>>>>> Gesendet: Donnerstag, 22. Februar 2018 19:27:44 An: Development list for mkgmap Betreff: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
I just noticed that mkgmap sometimes creates a lot more routable roads for a certain stretch than actually defined in the style-file.
https://www.openstreetmap.org/way/130665733
should be only once as a routable line in my map, however it ends up 6 times! Once is correct, but 5 iterations are actually the way from the south (3 times) and the way from the East (2 times). Now each of these ways should be created that often, however it should not overlay into this short stretch of way.
While doubling up ways can be beneficial for routing, having a way more than 5 times on top of each other let's Garmin devices crash on routing over them. Also it leads to detours - as it will not always route straight from the Way from South to the Way going to the West, but follow along after the intersection for 4.3m until hitting up north, then reversing and finally going to the way in the West.
I've uploaded the tile here: https://openmtbmap.org/gmapsupp_copied.img
I'm pretty sure that with other style-files - the way will also be copied past the intersection and end up too often in the map for that 4.3m stretch...
I kinda guess it is related to it being so short - that place has some remarkable micro-mapping detail. Or is this really expected?
If needed I can try to create a reduced style to only create that problem - but I think the bug should be obvious.
-- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org< http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists. mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto: mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk< mailto:mkgmap-dev@lists.mkgmap.org.uk>>><mailto:mkgmap -dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto: mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists. mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto: mkgmap-dev@lists.mkgmap.org.uk>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists. mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto: mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk< mailto:mkgmap-dev@lists.mkgmap.org.uk>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists. mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto: mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk< mailto:mkgmap-dev@lists.mkgmap.org.uk>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists. mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
oh - drop that last message. I thought it compiled, but actually I'm still stuck. I copied in the libs but still get java.lang.NoClassDefFoundError: uk/me/parabola/splitter/Area at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.writeOSM(WrongAngleFixer.java:1279) at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.printBadAngles(WrongAngleFixer.java:733) at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.optimizeWays(WrongAngleFixer.java:90) at uk.me.parabola.mkgmap.osmstyle.StyledConverter.end(StyledConverter.java:609) at uk.me.parabola.mkgmap.reader.osm.ElementSaver.convert(ElementSaver.java:243) at uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMapDataSource.java:157) at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:154) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:52) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:290) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:286) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) Caused by: java.lang.ClassNotFoundException: uk.me.parabola.splitter.Area at java.net.URLClassLoader.findClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) ... 14 more With your suggestion I get: C:\OpenMTBMap\maps>start /low /b /wait java -jar -XX:StringTableSize=100003 -Xms6000M -Xmx13300M -cp c:\openmtbmap\lib\optional\splitter-412.jar;c:\openmtbmap\mkgmap.jar uk.me.parabola.mkgmap.main.Main --max-jobs=8 "--generate-sea" --code-page=1252 "--precomp-sea=C:\openmtbmap\maps\sea.zip" "--style-file=C:\openmtbmap\openmtbmap_style" --lower-case --nsis --index --levels="0:24, 1:23, 2:22, 3:21, 4:20, 5:19, 6:18" --overview-levels="7:17, 8:16, 9:15, 10:14, 11:13, 12:12" --add-pois-to-areas --pois-to-areas-placement=entrance=main;entrance=yes;building=entrance;barrier=entrance --reduce-point-density=3.4 --reduce-point-density-polygon=6 --cycle-map --ignore-fixme-values --housenumbers --link-pois-to-ways --ignore-turn-restrictions --polygon-size-limits="24:16, 23:14, 22:12, 21:11, 20:10, 19 :9, 18:8, 17:7, 16:6, 15:5, 14:4, 13:3, 12:2, 11:0, 10:0" --description=openmtbmap_it --show-profiles=1 --location-autofill=bounds,is_in,nearest --bounds=C:\openmtbmap\maps\bounds.zip --route --country-abbr=it --country-name=italy --mapname=63670000 --family-id=6367 --product-id=1 --series-name=openmtbmap_italy_27.02.2018 --family-name=mtbmap_it_27.02.2018 --tdbfile --overview-mapname=mapsetc -- keep-going --area-name="italy_27.02.2018_openmtbmap.org" C:\OpenMTBMap\orig.osm.pbf 1>NUL Error: Unable to access jarfile uk.me.parabola.mkgmap.main.Main If I change to C:\OpenMTBMap\maps>start /low /b /wait java -jar -XX:StringTableSize=100003 -Xms6000M -Xmx13300M -cp c:\openmtbmap\lib\optional\splitter-412.jar; c:\openmtbmap\mkgmap.jar uk.me.parabola.mkgmap.main.Main --max-jobs=8 "--generate-sea" --code-page=1252 "--precomp-sea=C:\openmtbmap\maps\sea.zip" "--style-file=C:\openmtbmap\openmtbmap_style" --lower-case --nsis --index --levels="0:24, 1:23, 2:22, 3:21, 4:20, 5:19, 6:18" --overview-levels="7:17, 8:16, 9:15, 10:14, 11:13, 12:12" --add-pois-to-areas --pois-to-areas-placement=entrance=main;entrance=yes;building=entrance;barrier=entrance --reduce-point-density=3.4 --reduce-point-density-polygon=6 --cycle-map --ignore-fixme-values --housenumbers --link-pois-to-ways --ignore-turn-restrictions --polygon-size-limits="24:16, 23:14, 22:12, 21:11, 20:10, 1 9:9, 18:8, 17:7, 16:6, 15:5, 14:4, 13:3, 12:2, 11:0, 10:0" --description=openmtbmap_it --show-profiles=1 --location-autofill=bounds,is_in,nearest --bounds=C:\openmtbmap\maps\bounds.zip --route --country-abbr=it --country-name=italy --mapname=63670000 --family-id=6367 --product-id=1 --series-name=openmtbmap_italy_27.02.2018 --family-name=mtbmap_it_27.02.2018 --tdbfile --overview-mapname=mapsetc - -keep-going --area-name="italy_27.02.2018_openmtbmap.org" C:\OpenMTBMap\orig.osm.pbf 1>NUL Error: Could not find or load main class c:\openmtbmap\mkgmap.jar If I remove the uk.me stuff: C:\OpenMTBMap\maps>start /low /b /wait java -jar -XX:StringTableSize=100003 -Xms6000M -Xmx13300M -cp c:\openmtbmap\lib\optional\splitter-412.jar; c:\openmtbmap\mkgmap.jar --max-jobs=8 "--generate-sea" --code-page=1252 "--precomp-sea=C:\openmtbmap\maps\sea.zip" "--style-file=C:\openmtbmap\openmtbmap_style" --lower-case --nsis --index --levels="0:24, 1:23, 2:22, 3:21, 4:20, 5:19, 6:18" --overview-le vels="7:17, 8:16, 9:15, 10:14, 11:13, 12:12" --add-pois-to-areas --pois-to-areas-placement=entrance=main;entrance=yes;building=entrance;barrier=entrance --reduce-point-density=3.4 --reduce-point-density-polygon=6 --cycle-map --ignore-fixme-values --housenumbers --link-pois-to-ways --ignore-turn-restrictions --polygon-size-limits="24:16, 23:14, 22:12, 21:11, 20:10, 19:9, 18:8, 17:7, 16:6, 15:5, 14: 4, 13:3, 12:2, 11:0, 10:0" --description=openmtbmap_it --show-profiles=1 --location-autofill=bounds,is_in,nearest --bounds=C:\openmtbmap\maps\bounds.zip --route --country-abbr=it --country-name=italy --mapname=63670000 --family-id=6367 --product-id=1 --series-name=openmtbmap_italy_27.02.2018 --family-name=mtbmap_it_27.02.2018 --tdbfile --overview-mapname=mapsetc --keep-going --area-name="italy_2 7.02.2018_openmtbmap.org" C:\OpenMTBMap\orig.osm.pbf 1>NUL Error: Could not find or load main class c:\openmtbmap\mkgmap.jar On 27 February 2018 at 23:41, Felix Hartmann <extremecarver@gmail.com> wrote:
No sorry - I don't have them. Only the 4 debug files that I included. ( I just changed my patched mkgmap to only allow 4 copies - but still stay at the debug files provided. No
On 27 February 2018 at 23:31, Gerd Petermann <gpetermann_muenchen@hotmail. com> wrote:
Hi Felix,
please check: You should have files like roads_orig*.o5m in the debug dir. Please send all files.
Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Dienstag, 27. Februar 2018 23:17:05 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Oh sorry, I'm stupid. I did not realise that I need to copy in the optional lib files also to the running instance of mkgmap.jar. Really should have noticed that based on the error message.
well anyhow - here is the debug data and the orig.osm.pbf compiled with the patched mkgmap version: https://openmtbmap.org/map_with_debug.zip
Felix
On 27 February 2018 at 22:49, Gerd Petermann < gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix,
sorry, I always use the debugging stuff within Eclipse. Something like this should work:
java -XX:StringTableSize=100003 -Xms6000M -Xmx13300M -cp d:\mkgmap\lib\optional\splitter-412.jar;d:\mkgmap\dist\mkgmap.jar uk.me.parabola.mkgmap.main.Main --max-jobs=8 ... Replace d:\mkgmap with the directory where you ran the ant resolve-optional dist command
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann < extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Dienstag, 27. Februar 2018 21:29:20 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
I looked into the files for sometime - and right now tried to compile it with the patched mkgmap version - however I get: C:\OpenMTBMap\maps>start /low /b /wait java -jar -XX:StringTableSize=100003 -Xms6000M -Xmx13300M C:\openmtbmap\mkgmap.jar --max-jobs=8 "--generate-sea" --code-page=1252 "--precomp-sea=C:\openmtbmap\maps\sea.zip" "--style-file=C:\openmtbmap\test_style" --lower-case --nsis --index --levels="0:24, 1:23, 2:22, 3:21, 4:20, 5:19, 6:18" --overview-levels="7:17, 8:16, 9:15, 10:14, 11:13, 12:12" --add-pois -to-areas --pois-to-areas-placement=entrance=main;entrance=yes;building=entrance;barrier=entrance --reduce-point-density=3.4 --reduce-point-density-polygon=6 --cycle-map --ignore-fixme-values --housenumbers --link-pois-to-ways --ignore-turn-restrictions --polygon-size-limits="24:16, 23:14, 22:12, 21:11, 20:10, 19:9, 18:8, 17:7, 16:6, 15:5, 14:4, 13:3, 12:2, 11:0, 10:0" --description=openmtbmap_it --show-profiles=1 --location-autofill=bounds,is_in,nearest --bounds=C:\openmtbmap\maps\bounds.zip --route --country-abbr=it --country-name=italy --mapname=63670000 --family-id=6367 --product-id=1 --series-name=openmtbmap_italy_27.02.2018 --family-name=mtbmap_it_27.02.2018 --tdbfile --overview-mapname=mapsetc --keep-going --area-name=" italy_27.02.2018_openmtbmap.org<http://italy_27.02.2018_openmtbmap.org><; http://italy_27.02.2018_openmtbmap.org>" c:\openmtbmap\orig.osm.pbf 1
NUL java.lang.NoClassDefFoundError: uk/me/parabola/splitter/Area at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.writeOSM( WrongAngleFixer.java:1279) at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.printBadAngle s(WrongAngleFixer.java:733) at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.optimizeWays( WrongAngleFixer.java:90) at uk.me.parabola.mkgmap.osmstyle.StyledConverter.end(StyledCon verter.java:609) at uk.me.parabola.mkgmap.reader.osm.ElementSaver.convert(Elemen tSaver.java:243) at uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMa pDataSource.java:157) at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker. java:154) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:52) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:290) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:286) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) Caused by: java.lang.ClassNotFoundException: uk.me.parabola.splitter.Area at java.net.URLClassLoader.findClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) ... 14 more
As for compiling the orig.osm.pbf with my style - the resulting map is here: https://openmtbmap.org/orig_osm_compiled.zip
On 27 February 2018 at 13:48, Felix Hartmann <extremecarver@gmail.com <mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto: extremecarver@gmail.com>>> wrote: Had no time the last 3 days, I'm right now testing some things will post back in a couple of hours....
On 27 February 2018 at 12:01, Gerd Petermann < gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
<mailto:gpetermann_muenchen@hotmail.com<mailto:g petermann_muenchen@hotmail.com>>> wrote: Hi Felix,
any feedback?
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@list s.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto: gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com>>> Gesendet: Samstag, 24. Februar 2018 10:36:29 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix,
maybe this helps already: Attached is a small patch that changes StyledConverter so that it only accepts 4 routable ways for one OSM way. Any further routable way for the same OSM way creates just a warning.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@list s.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto: extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto: extremecarver@gmail.com>>> Gesendet: Freitag, 23. Februar 2018 19:08:45 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
I think merging is fine - maybe just add restrictions to the adjoining ways if preset. And it really should not happen that ways are merged past a junction - I now think this happens in some more places. Because it's not the first time I notice that a routing turns 180° to return to the junction to actually turn. And maybe could there be a filter that there are never more than 5 routable ways from continue command? From 6 onwards it crashes devices. Maybe even from 5 onwards. 1 routable original and 3 routable overlays are definitely fine. (Basecamp/Mapsource don't care - it only crashes GPS devices).
On 23 February 2018 at 09:12, Henning Scholland <osm@hscholland.de <mailto:osm@hscholland.de><mailto:osm@hscholland.de<mailto:osm@hschollan d.de>><mailto:osm@hscholland.de<mailto:osm@hscholland.de><mailto: osm@hscholland.de<mailto:osm@hscholland.de>>>> wrote: Hi Gerd, Maybe it's better to try to merge these small ways as they anyway only creates 'ugly' roads. With increasing level of details in OSM I think mkgmap will need some preprocessing to generalise the data first. I'm not only thinking about these very small ways, but also have the lane-mapping and other mapping details, which are not important for Garmin maps. Henning On 23 Feb 2018, at 15:21, Gerd Petermann <gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann _muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto: gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
<mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@ hotmail.com>>>> wrote:
Hi Felix,
I have to think about this for a while. There are three very short ways connected in node 412440328: way 130665733 : the northern node 1263658617 is close to a Garmin grid point, the sourthern node 412440328 is also closer to this grid point than to any other, so both are rounded to the same grid point in the north, and finally it is ignored. way 110722884: the way is only ~1m long and both nodes are far from any Garmin grid point. This is the way that is causing the trouble. It is not removed, instead the initial rounding changes it to a ~3m way going north -> south. way 130663479: the way has 3 nodes, and the one in the middle (node 1263658804) is rounded to the same coords as the ends of the bridge (way 103567847) and way 110722884, while the northern node 412440328 is moved up.
I've attached 4 files to document the problem. Please load into JOSM to visualize: orig.osm.pbf: the original osm data init_hp.osm.pbf: the road network as input to WrongAngleFixer in so called "high precision" init_mu.osm.pbf: like init_hp.osm.pbf, but rounded to Garmin map units after-WO_mu.osm.pbf: the result of WrongAngleFixer with coords rounded to Garmin map units (please ignore the fact that the node ids in non-orig files are wrong)
Somehow I have to teach mkgmap that it would be better to ignore (also) way 110722884. I don't know yet what criteria I should use for that. Normally we try to keep all routable ways, as they may contain access restrictions.
BTW: There is more such trouble near way 111528851.
ciao, Gerd
________________________________
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@list s.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>><mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mk gmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev- bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto: extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto: extremecarver@gmail.com>><mailto:extremecarver@gmail.com<mailto: extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecar ver@gmail.com>>>> Gesendet: Donnerstag, 22. Februar 2018 20:19:15 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Perfect. I guess my maps are the only one causing bsod here on devices, but without the bug they would be fine...
On 22 Feb 2018 20:03, "Gerd Petermann" <gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann _muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto: gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
<mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@ hotmail.com>>><mailto:gpetermann_muenchen@hotmail.com<mailto: gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@ hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:g petermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>>>> wrote: Hi Felix,
I can reproduce the problem with a small download around the way and just the --route option. The problem seems to be in WrongAngleFixer, it says "... all points of way http://www.openstreetmap.org/way/130665733 are rounded to equal map units" No idea why the way is not reduced to a single point, will investigate further.
Gerd
________________________________
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@list s.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>><mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mk gmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev- bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk
<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@ lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk <mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mk gmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev- bounces@lists.mkgmap.org.uk>>>>> im Auftrag von Felix Hartmann < extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto: extremecarver@gmail.com<mailto:extremecarver@gmail.com>><mailto: extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto: extremecarver@gmail.com<mailto:extremecarver@gmail.com>>><mailto:extrem ecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:ext remecarver@gmail.com<mailto:extremecarver@gmail.com>><mailto: extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto: extremecarver@gmail.com<mailto:extremecarver@gmail.com>>>>> Gesendet: Donnerstag, 22. Februar 2018 19:27:44 An: Development list for mkgmap Betreff: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
I just noticed that mkgmap sometimes creates a lot more routable roads for a certain stretch than actually defined in the style-file.
https://www.openstreetmap.org/way/130665733
should be only once as a routable line in my map, however it ends up 6 times! Once is correct, but 5 iterations are actually the way from the south (3 times) and the way from the East (2 times). Now each of these ways should be created that often, however it should not overlay into this short stretch of way.
While doubling up ways can be beneficial for routing, having a way more than 5 times on top of each other let's Garmin devices crash on routing over them. Also it leads to detours - as it will not always route straight from the Way from South to the Way going to the West, but follow along after the intersection for 4.3m until hitting up north, then reversing and finally going to the way in the West.
I've uploaded the tile here: https://openmtbmap.org/gmapsupp_copied.img
I'm pretty sure that with other style-files - the way will also be copied past the intersection and end up too often in the map for that 4.3m stretch...
I kinda guess it is related to it being so short - that place has some remarkable micro-mapping detail. Or is this really expected?
If needed I can try to create a reduced style to only create that problem - but I think the bug should be obvious.
-- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org< http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkg map-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk <mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists. mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>><mailto: mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>< mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap- dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto: mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk <mailto:mkgmap-dev@lists.mkgmap.org.uk>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkg map-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk <mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists. mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkg map-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk <mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists. mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkg map-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Felix, please double check, you still have -jar in your command. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Mittwoch, 28. Februar 2018 00:01:18 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. oh - drop that last message. I thought it compiled, but actually I'm still stuck. I copied in the libs but still get java.lang.NoClassDefFoundError: uk/me/parabola/splitter/Area at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.writeOSM(WrongAngleFixer.java:1279) at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.printBadAngles(WrongAngleFixer.java:733) at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.optimizeWays(WrongAngleFixer.java:90) at uk.me.parabola.mkgmap.osmstyle.StyledConverter.end(StyledConverter.java:609) at uk.me.parabola.mkgmap.reader.osm.ElementSaver.convert(ElementSaver.java:243) at uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMapDataSource.java:157) at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:154) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:52) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:290) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:286) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) Caused by: java.lang.ClassNotFoundException: uk.me.parabola.splitter.Area at java.net.URLClassLoader.findClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) ... 14 more With your suggestion I get: C:\OpenMTBMap\maps>start /low /b /wait java -jar -XX:StringTableSize=100003 -Xms6000M -Xmx13300M -cp c:\openmtbmap\lib\optional\splitter-412.jar;c:\openmtbmap\mkgmap.jar uk.me.parabola.mkgmap.main.Main --max-jobs=8 "--generate-sea" --code-page=1252 "--precomp-sea=C:\openmtbmap\maps\sea.zip" "--style-file=C:\openmtbmap\openmtbmap_style" --lower-case --nsis --index --levels="0:24, 1:23, 2:22, 3:21, 4:20, 5:19, 6:18" --overview-levels="7:17, 8:16, 9:15, 10:14, 11:13, 12:12" --add-pois-to-areas --pois-to-areas-placement=entrance=main;entrance=yes;building=entrance;barrier=entrance --reduce-point-density=3.4 --reduce-point-density-polygon=6 --cycle-map --ignore-fixme-values --housenumbers --link-pois-to-ways --ignore-turn-restrictions --polygon-size-limits="24:16, 23:14, 22:12, 21:11, 20:10, 19 :9, 18:8, 17:7, 16:6, 15:5, 14:4, 13:3, 12:2, 11:0, 10:0" --description=openmtbmap_it --show-profiles=1 --location-autofill=bounds,is_in,nearest --bounds=C:\openmtbmap\maps\bounds.zip --route --country-abbr=it --country-name=italy --mapname=63670000 --family-id=6367 --product-id=1 --series-name=openmtbmap_italy_27.02.2018 --family-name=mtbmap_it_27.02.2018 --tdbfile --overview-mapname=mapsetc -- keep-going --area-name="italy_27.02.2018_openmtbmap.org<http://italy_27.02.2018_openmtbmap.org>" C:\OpenMTBMap\orig.osm.pbf 1>NUL Error: Unable to access jarfile uk.me.parabola.mkgmap.main.Main If I change to C:\OpenMTBMap\maps>start /low /b /wait java -jar -XX:StringTableSize=100003 -Xms6000M -Xmx13300M -cp c:\openmtbmap\lib\optional\splitter-412.jar; c:\openmtbmap\mkgmap.jar uk.me.parabola.mkgmap.main.Main --max-jobs=8 "--generate-sea" --code-page=1252 "--precomp-sea=C:\openmtbmap\maps\sea.zip" "--style-file=C:\openmtbmap\openmtbmap_style" --lower-case --nsis --index --levels="0:24, 1:23, 2:22, 3:21, 4:20, 5:19, 6:18" --overview-levels="7:17, 8:16, 9:15, 10:14, 11:13, 12:12" --add-pois-to-areas --pois-to-areas-placement=entrance=main;entrance=yes;building=entrance;barrier=entrance --reduce-point-density=3.4 --reduce-point-density-polygon=6 --cycle-map --ignore-fixme-values --housenumbers --link-pois-to-ways --ignore-turn-restrictions --polygon-size-limits="24:16, 23:14, 22:12, 21:11, 20:10, 1 9:9, 18:8, 17:7, 16:6, 15:5, 14:4, 13:3, 12:2, 11:0, 10:0" --description=openmtbmap_it --show-profiles=1 --location-autofill=bounds,is_in,nearest --bounds=C:\openmtbmap\maps\bounds.zip --route --country-abbr=it --country-name=italy --mapname=63670000 --family-id=6367 --product-id=1 --series-name=openmtbmap_italy_27.02.2018 --family-name=mtbmap_it_27.02.2018 --tdbfile --overview-mapname=mapsetc - -keep-going --area-name="italy_27.02.2018_openmtbmap.org<http://italy_27.02.2018_openmtbmap.org>" C:\OpenMTBMap\orig.osm.pbf 1>NUL Error: Could not find or load main class c:\openmtbmap\mkgmap.jar If I remove the uk.me<http://uk.me> stuff: C:\OpenMTBMap\maps>start /low /b /wait java -jar -XX:StringTableSize=100003 -Xms6000M -Xmx13300M -cp c:\openmtbmap\lib\optional\splitter-412.jar; c:\openmtbmap\mkgmap.jar --max-jobs=8 "--generate-sea" --code-page=1252 "--precomp-sea=C:\openmtbmap\maps\sea.zip" "--style-file=C:\openmtbmap\openmtbmap_style" --lower-case --nsis --index --levels="0:24, 1:23, 2:22, 3:21, 4:20, 5:19, 6:18" --overview-le vels="7:17, 8:16, 9:15, 10:14, 11:13, 12:12" --add-pois-to-areas --pois-to-areas-placement=entrance=main;entrance=yes;building=entrance;barrier=entrance --reduce-point-density=3.4 --reduce-point-density-polygon=6 --cycle-map --ignore-fixme-values --housenumbers --link-pois-to-ways --ignore-turn-restrictions --polygon-size-limits="24:16, 23:14, 22:12, 21:11, 20:10, 19:9, 18:8, 17:7, 16:6, 15:5, 14: 4, 13:3, 12:2, 11:0, 10:0" --description=openmtbmap_it --show-profiles=1 --location-autofill=bounds,is_in,nearest --bounds=C:\openmtbmap\maps\bounds.zip --route --country-abbr=it --country-name=italy --mapname=63670000 --family-id=6367 --product-id=1 --series-name=openmtbmap_italy_27.02.2018 --family-name=mtbmap_it_27.02.2018 --tdbfile --overview-mapname=mapsetc --keep-going --area-name="italy_2 7.02.2018_openmtbmap.org<http://7.02.2018_openmtbmap.org>" C:\OpenMTBMap\orig.osm.pbf 1>NUL Error: Could not find or load main class c:\openmtbmap\mkgmap.jar On 27 February 2018 at 23:41, Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> wrote: No sorry - I don't have them. Only the 4 debug files that I included. ( I just changed my patched mkgmap to only allow 4 copies - but still stay at the debug files provided. No On 27 February 2018 at 23:31, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, please check: You should have files like roads_orig*.o5m in the debug dir. Please send all files. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Dienstag, 27. Februar 2018 23:17:05 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Oh sorry, I'm stupid. I did not realise that I need to copy in the optional lib files also to the running instance of mkgmap.jar. Really should have noticed that based on the error message. well anyhow - here is the debug data and the orig.osm.pbf compiled with the patched mkgmap version: https://openmtbmap.org/map_with_debug.zip Felix On 27 February 2018 at 22:49, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix, sorry, I always use the debugging stuff within Eclipse. Something like this should work: java -XX:StringTableSize=100003 -Xms6000M -Xmx13300M -cp d:\mkgmap\lib\optional\splitter-412.jar;d:\mkgmap\dist\mkgmap.jar uk.me.parabola.mkgmap.main.Main --max-jobs=8 ... Replace d:\mkgmap with the directory where you ran the ant resolve-optional dist command Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> Gesendet: Dienstag, 27. Februar 2018 21:29:20 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. I looked into the files for sometime - and right now tried to compile it with the patched mkgmap version - however I get: C:\OpenMTBMap\maps>start /low /b /wait java -jar -XX:StringTableSize=100003 -Xms6000M -Xmx13300M C:\openmtbmap\mkgmap.jar --max-jobs=8 "--generate-sea" --code-page=1252 "--precomp-sea=C:\openmtbmap\maps\sea.zip" "--style-file=C:\openmtbmap\test_style" --lower-case --nsis --index --levels="0:24, 1:23, 2:22, 3:21, 4:20, 5:19, 6:18" --overview-levels="7:17, 8:16, 9:15, 10:14, 11:13, 12:12" --add-pois -to-areas --pois-to-areas-placement=entrance=main;entrance=yes;building=entrance;barrier=entrance --reduce-point-density=3.4 --reduce-point-density-polygon=6 --cycle-map --ignore-fixme-values --housenumbers --link-pois-to-ways --ignore-turn-restrictions --polygon-size-limits="24:16, 23:14, 22:12, 21:11, 20:10, 19:9, 18:8, 17:7, 16:6, 15:5, 14:4, 13:3, 12:2, 11:0, 10:0" --description=openmtbmap_it --show-profiles=1 --location-autofill=bounds,is_in,nearest --bounds=C:\openmtbmap\maps\bounds.zip --route --country-abbr=it --country-name=italy --mapname=63670000 --family-id=6367 --product-id=1 --series-name=openmtbmap_italy_27.02.2018 --family-name=mtbmap_it_27.02.2018 --tdbfile --overview-mapname=mapsetc --keep-going --area-name="italy_27.02.2018_openmtbmap.org<http://italy_27.02.2018_openmtbmap.org><http://italy_27.02.2018_openmtbmap.org><http://italy_27.02.2018_openmtbmap.org>" c:\openmtbmap\orig.osm.pbf 1
NUL java.lang.NoClassDefFoundError: uk/me/parabola/splitter/Area at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.writeOSM(WrongAngleFixer.java:1279) at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.printBadAngles(WrongAngleFixer.java:733) at uk.me.parabola.mkgmap.osmstyle.WrongAngleFixer.optimizeWays(WrongAngleFixer.java:90) at uk.me.parabola.mkgmap.osmstyle.StyledConverter.end(StyledConverter.java:609) at uk.me.parabola.mkgmap.reader.osm.ElementSaver.convert(ElementSaver.java:243) at uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMapDataSource.java:157) at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:154) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:52) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:290) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:286) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) Caused by: java.lang.ClassNotFoundException: uk.me.parabola.splitter.Area at java.net.URLClassLoader.findClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) ... 14 more
As for compiling the orig.osm.pbf with my style - the resulting map is here: https://openmtbmap.org/orig_osm_compiled.zip On 27 February 2018 at 13:48, Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>>> wrote: Had no time the last 3 days, I'm right now testing some things will post back in a couple of hours.... On 27 February 2018 at 12:01, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>>> wrote: Hi Felix, any feedback? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>>> Gesendet: Samstag, 24. Februar 2018 10:36:29 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, maybe this helps already: Attached is a small patch that changes StyledConverter so that it only accepts 4 routable ways for one OSM way. Any further routable way for the same OSM way creates just a warning. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>>> Gesendet: Freitag, 23. Februar 2018 19:08:45 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. I think merging is fine - maybe just add restrictions to the adjoining ways if preset. And it really should not happen that ways are merged past a junction - I now think this happens in some more places. Because it's not the first time I notice that a routing turns 180° to return to the junction to actually turn. And maybe could there be a filter that there are never more than 5 routable ways from continue command? From 6 onwards it crashes devices. Maybe even from 5 onwards. 1 routable original and 3 routable overlays are definitely fine. (Basecamp/Mapsource don't care - it only crashes GPS devices). On 23 February 2018 at 09:12, Henning Scholland <osm@hscholland.de<mailto:osm@hscholland.de><mailto:osm@hscholland.de<mailto:osm@hscholland.de>><mailto:osm@hscholland.de<mailto:osm@hscholland.de><mailto:osm@hscholland.de<mailto:osm@hscholland.de>>><mailto:osm@hscholland.de<mailto:osm@hscholland.de><mailto:osm@hscholland.de<mailto:osm@hscholland.de>><mailto:osm@hscholland.de<mailto:osm@hscholland.de><mailto:osm@hscholland.de<mailto:osm@hscholland.de>>>>> wrote: Hi Gerd, Maybe it's better to try to merge these small ways as they anyway only creates 'ugly' roads. With increasing level of details in OSM I think mkgmap will need some preprocessing to generalise the data first. I'm not only thinking about these very small ways, but also have the lane-mapping and other mapping details, which are not important for Garmin maps. Henning On 23 Feb 2018, at 15:21, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>>>> wrote: Hi Felix, I have to think about this for a while. There are three very short ways connected in node 412440328: way 130665733 : the northern node 1263658617 is close to a Garmin grid point, the sourthern node 412440328 is also closer to this grid point than to any other, so both are rounded to the same grid point in the north, and finally it is ignored. way 110722884: the way is only ~1m long and both nodes are far from any Garmin grid point. This is the way that is causing the trouble. It is not removed, instead the initial rounding changes it to a ~3m way going north -> south. way 130663479: the way has 3 nodes, and the one in the middle (node 1263658804) is rounded to the same coords as the ends of the bridge (way 103567847) and way 110722884, while the northern node 412440328 is moved up. I've attached 4 files to document the problem. Please load into JOSM to visualize: orig.osm.pbf: the original osm data init_hp.osm.pbf: the road network as input to WrongAngleFixer in so called "high precision" init_mu.osm.pbf: like init_hp.osm.pbf, but rounded to Garmin map units after-WO_mu.osm.pbf: the result of WrongAngleFixer with coords rounded to Garmin map units (please ignore the fact that the node ids in non-orig files are wrong) Somehow I have to teach mkgmap that it would be better to ignore (also) way 110722884. I don't know yet what criteria I should use for that. Normally we try to keep all routable ways, as they may contain access restrictions. BTW: There is more such trouble near way 111528851. ciao, Gerd ________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>>>> Gesendet: Donnerstag, 22. Februar 2018 20:19:15 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Perfect. I guess my maps are the only one causing bsod here on devices, but without the bug they would be fine... On 22 Feb 2018 20:03, "Gerd Petermann" <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>>>>> wrote: Hi Felix, I can reproduce the problem with a small download around the way and just the --route option. The problem seems to be in WrongAngleFixer, it says "... all points of way http://www.openstreetmap.org/way/130665733 are rounded to equal map units" No idea why the way is not reduced to a single point, will investigate further. Gerd ________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>>>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>>><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>>>>> Gesendet: Donnerstag, 22. Februar 2018 19:27:44 An: Development list for mkgmap Betreff: [mkgmap-dev] Bug in Road Merging - actually doubling roads. I just noticed that mkgmap sometimes creates a lot more routable roads for a certain stretch than actually defined in the style-file. https://www.openstreetmap.org/way/130665733 should be only once as a routable line in my map, however it ends up 6 times! Once is correct, but 5 iterations are actually the way from the south (3 times) and the way from the East (2 times). Now each of these ways should be created that often, however it should not overlay into this short stretch of way. While doubling up ways can be beneficial for routing, having a way more than 5 times on top of each other let's Garmin devices crash on routing over them. Also it leads to detours - as it will not always route straight from the Way from South to the Way going to the West, but follow along after the intersection for 4.3m until hitting up north, then reversing and finally going to the way in the West. I've uploaded the tile here: https://openmtbmap.org/gmapsupp_copied.img I'm pretty sure that with other style-files - the way will also be copied past the intersection and end up too often in the map for that 4.3m stretch... I kinda guess it is related to it being so short - that place has some remarkable micro-mapping detail. Or is this really expected? If needed I can try to create a reduced style to only create that problem - but I think the bug should be obvious. -- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Oh thanks - I did not notice that. Here is now the orig_map compiled with the patched mkgmap. Hope this helps you. https://openmtbmap.org/debug_orig_map.zip Felix
Hi Felix, please try also to compile with this additional patch and produce the debug info again. The patch simply executes the road merging before the angle fixing. I am not sure why we don't always do it in this order. By the way, did you read this post? http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2018q1/028260.html Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Mittwoch, 28. Februar 2018 18:29:05 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Oh thanks - I did not notice that. Here is now the orig_map compiled with the patched mkgmap. Hope this helps you. https://openmtbmap.org/debug_orig_map.zip Felix
Hi Gerd will do so tomorrow - cannot get onto my server since 2 hours (if I still cannot get on the server I will compile locally on Friday). As for the mail - yes I read it and replied in here. I think the order for most would be the opposite - throw away the first roads, not the last! Usually you would first put in routes, bridges and so on into your map - then maybe lines just for visualisation - all with continue, and then finally put in the road itself without continue. For my maps the best approach in doubt would be: 1. check if one segment is completely double (same type - fully covered by the same type). 2. Throw away 0x13 (I use this invisibly for routing) 3. Throw away those roads created first if still needed. Felix On 28 February 2018 at 18:49, Gerd Petermann < gpetermann_muenchen@hotmail.com> wrote:
Hi Felix,
please try also to compile with this additional patch and produce the debug info again. The patch simply executes the road merging before the angle fixing. I am not sure why we don't always do it in this order.
By the way, did you read this post? http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2018q1/028260.html
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Mittwoch, 28. Februar 2018 18:29:05 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Oh thanks - I did not notice that.
Here is now the orig_map compiled with the patched mkgmap. Hope this helps you. https://openmtbmap.org/debug_orig_map.zip
Felix
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
well finally could access my server again -- maps with the additional patch and debug file here: https://openmtbmap.org/debug_org_map2.zip On 28 February 2018 at 20:54, Felix Hartmann <extremecarver@gmail.com> wrote:
Hi Gerd will do so tomorrow - cannot get onto my server since 2 hours (if I still cannot get on the server I will compile locally on Friday).
As for the mail - yes I read it and replied in here. I think the order for most would be the opposite - throw away the first roads, not the last! Usually you would first put in routes, bridges and so on into your map - then maybe lines just for visualisation - all with continue, and then finally put in the road itself without continue. For my maps the best approach in doubt would be: 1. check if one segment is completely double (same type - fully covered by the same type). 2. Throw away 0x13 (I use this invisibly for routing) 3. Throw away those roads created first if still needed.
Felix
On 28 February 2018 at 18:49, Gerd Petermann <gpetermann_muenchen@hotmail. com> wrote:
Hi Felix,
please try also to compile with this additional patch and produce the debug info again. The patch simply executes the road merging before the angle fixing. I am not sure why we don't always do it in this order.
By the way, did you read this post? http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2018q1/028260.html
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Mittwoch, 28. Februar 2018 18:29:05 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Oh thanks - I did not notice that.
Here is now the orig_map compiled with the patched mkgmap. Hope this helps you. https://openmtbmap.org/debug_orig_map.zip
Felix
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Felix, tried a few times now but always got "404 Not Found". Please upload the file to http://files.mkgmap.org.uk/ Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Mittwoch, 28. Februar 2018 21:55:16 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. well finally could access my server again -- maps with the additional patch and debug file here: https://openmtbmap.org/debug_org_map2.zip On 28 February 2018 at 20:54, Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> wrote: Hi Gerd will do so tomorrow - cannot get onto my server since 2 hours (if I still cannot get on the server I will compile locally on Friday). As for the mail - yes I read it and replied in here. I think the order for most would be the opposite - throw away the first roads, not the last! Usually you would first put in routes, bridges and so on into your map - then maybe lines just for visualisation - all with continue, and then finally put in the road itself without continue. For my maps the best approach in doubt would be: 1. check if one segment is completely double (same type - fully covered by the same type). 2. Throw away 0x13 (I use this invisibly for routing) 3. Throw away those roads created first if still needed. Felix On 28 February 2018 at 18:49, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, please try also to compile with this additional patch and produce the debug info again. The patch simply executes the road merging before the angle fixing. I am not sure why we don't always do it in this order. By the way, did you read this post? http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2018q1/028260.html Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Mittwoch, 28. Februar 2018 18:29:05 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Oh thanks - I did not notice that. Here is now the orig_map compiled with the patched mkgmap. Hope this helps you. https://openmtbmap.org/debug_orig_map.zip Felix _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Sorry typo: https://openmtbmap.org/debug_orig_map2.zip will work. On 1 Mar 2018 10:40 am, "Gerd Petermann" <gpetermann_muenchen@hotmail.com> wrote:
Hi Felix,
tried a few times now but always got "404 Not Found". Please upload the file to http://files.mkgmap.org.uk/
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Mittwoch, 28. Februar 2018 21:55:16 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
well finally could access my server again -- maps with the additional patch and debug file here: https://openmtbmap.org/debug_org_map2.zip
On 28 February 2018 at 20:54, Felix Hartmann <extremecarver@gmail.com< mailto:extremecarver@gmail.com>> wrote: Hi Gerd will do so tomorrow - cannot get onto my server since 2 hours (if I still cannot get on the server I will compile locally on Friday).
As for the mail - yes I read it and replied in here. I think the order for most would be the opposite - throw away the first roads, not the last! Usually you would first put in routes, bridges and so on into your map - then maybe lines just for visualisation - all with continue, and then finally put in the road itself without continue. For my maps the best approach in doubt would be: 1. check if one segment is completely double (same type - fully covered by the same type). 2. Throw away 0x13 (I use this invisibly for routing) 3. Throw away those roads created first if still needed.
Felix
On 28 February 2018 at 18:49, Gerd Petermann <gpetermann_muenchen@hotmail. com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix,
please try also to compile with this additional patch and produce the debug info again. The patch simply executes the road merging before the angle fixing. I am not sure why we don't always do it in this order.
By the way, did you read this post? http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2018q1/028260.html
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann < extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Mittwoch, 28. Februar 2018 18:29:05 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Oh thanks - I did not notice that.
Here is now the orig_map compiled with the patched mkgmap. Hope this helps you. https://openmtbmap.org/debug_orig_map.zip
Felix
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Felix, okay, now I have it. Doesn't help much because the debug routine simply creates OSM ways for the data, and since your style creates many duplicated ways JOSM cannot handle the data:-( Maybe I'll change the debug code to create unique way ids and store the osm id in a tag later. Did you try if --no-mergeroads helps? Another option for you special style might be to disable the code that adds arcs for major roads. Maybe try to comment this line in line 270 in RoadNetwork.java: addArcsToMajorRoads(); This is improving long distance routing for normal maps but might cause trouble with styles for cycling. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Donnerstag, 1. März 2018 11:21:57 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Sorry typo: https://openmtbmap.org/debug_orig_map2.zip will work. On 1 Mar 2018 10:40 am, "Gerd Petermann" <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, tried a few times now but always got "404 Not Found". Please upload the file to http://files.mkgmap.org.uk/ Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Mittwoch, 28. Februar 2018 21:55:16 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. well finally could access my server again -- maps with the additional patch and debug file here: https://openmtbmap.org/debug_org_map2.zip On 28 February 2018 at 20:54, Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> wrote: Hi Gerd will do so tomorrow - cannot get onto my server since 2 hours (if I still cannot get on the server I will compile locally on Friday). As for the mail - yes I read it and replied in here. I think the order for most would be the opposite - throw away the first roads, not the last! Usually you would first put in routes, bridges and so on into your map - then maybe lines just for visualisation - all with continue, and then finally put in the road itself without continue. For my maps the best approach in doubt would be: 1. check if one segment is completely double (same type - fully covered by the same type). 2. Throw away 0x13 (I use this invisibly for routing) 3. Throw away those roads created first if still needed. Felix On 28 February 2018 at 18:49, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix, please try also to compile with this additional patch and produce the debug info again. The patch simply executes the road merging before the angle fixing. I am not sure why we don't always do it in this order. By the way, did you read this post? http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2018q1/028260.html Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> Gesendet: Mittwoch, 28. Februar 2018 18:29:05 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Oh thanks - I did not notice that. Here is now the orig_map compiled with the patched mkgmap. Hope this helps you. https://openmtbmap.org/debug_orig_map.zip Felix _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Okay - no-merge-lines makes no difference, also removing addArcsToMajorRoads(); function makes no difference. And I just noticed - the patch does not work. It works in it's own way - but not achieving the result that is needed. Whatever I do - I still end up with 6 routable lines. I guess the patch checks for each road that it is not more than 4 times in the map. So I end up with 1, 2, and 3 (1 that is supposed to be in the map, 2 from the east not supposed, and 3 from the south, not supposed). (always using gpsmapedit to check results). On 1 March 2018 at 12:33, Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote:
Hi Felix,
okay, now I have it. Doesn't help much because the debug routine simply creates OSM ways for the data, and since your style creates many duplicated ways JOSM cannot handle the data:-( Maybe I'll change the debug code to create unique way ids and store the osm id in a tag later.
Did you try if --no-mergeroads helps? Another option for you special style might be to disable the code that adds arcs for major roads. Maybe try to comment this line in line 270 in RoadNetwork.java: addArcsToMajorRoads();
This is improving long distance routing for normal maps but might cause trouble with styles for cycling.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Donnerstag, 1. März 2018 11:21:57 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Sorry typo: https://openmtbmap.org/debug_orig_map2.zip will work.
On 1 Mar 2018 10:40 am, "Gerd Petermann" <gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix,
tried a few times now but always got "404 Not Found". Please upload the file to http://files.mkgmap.org.uk/
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann < extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Mittwoch, 28. Februar 2018 21:55:16 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
well finally could access my server again -- maps with the additional patch and debug file here: https://openmtbmap.org/debug_org_map2.zip
On 28 February 2018 at 20:54, Felix Hartmann <extremecarver@gmail.com< mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto: extremecarver@gmail.com>>> wrote: Hi Gerd will do so tomorrow - cannot get onto my server since 2 hours (if I still cannot get on the server I will compile locally on Friday).
As for the mail - yes I read it and replied in here. I think the order for most would be the opposite - throw away the first roads, not the last! Usually you would first put in routes, bridges and so on into your map - then maybe lines just for visualisation - all with continue, and then finally put in the road itself without continue. For my maps the best approach in doubt would be: 1. check if one segment is completely double (same type - fully covered by the same type). 2. Throw away 0x13 (I use this invisibly for routing) 3. Throw away those roads created first if still needed.
Felix
On 28 February 2018 at 18:49, Gerd Petermann <gpetermann_muenchen@hotmail. com<mailto:gpetermann_muenchen@hotmail.com><mailto:g petermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix,
please try also to compile with this additional patch and produce the debug info again. The patch simply executes the road merging before the angle fixing. I am not sure why we don't always do it in this order.
By the way, did you read this post? http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2018q1/028260.html
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@ lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto: extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto: extremecarver@gmail.com>>> Gesendet: Mittwoch, 28. Februar 2018 18:29:05 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Oh thanks - I did not notice that.
Here is now the orig_map compiled with the patched mkgmap. Hope this helps you. https://openmtbmap.org/debug_orig_map.zip
Felix
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists. mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Felix, Felix Hartmann-2 wrote
Okay - no-merge-lines makes no difference, also removing addArcsToMajorRoads(); function makes no difference. And I just noticed - the patch does not work. It works in it's own way - but not achieving the result that is needed. Whatever I do - I still end up with 6 routable lines.
I guess the patch checks for each road that it is not more than 4 times in the map. So I end up with 1, 2, and 3 (1 that is supposed to be in the map, 2 from the east not supposed, and 3 from the south, not supposed). (always using gpsmapedit to check results).
yes, that is what it does. Didn't you suggest something like that? You still did not tell me how I can reproduce a crash with this data, so I can only guess. I didn't see any routing issues so far with your maps, only the ugly rendering. Is this the only problem or is there really a routing issue? If yes, please let me know how to reproduce it. Gerd -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html
routing issues is on devices only - not in Basecamp. Reported so far from Oregon and Edge - routing from North to East over that road. Well what I thought was that mkgmap should check if another road is put above. Right now it's 1 road supposed to be there, 2 and 3 roads overlapping due to that road being too short. Those overlapping somehow would need to be removed (and yes I know they are originally not the same line). My style should I think in maximum create 4 routable lines - however due to overlapping of other lines (due to the sub 4.3m line) it ends up a short stretch with more than 5 routable lines. On 1 March 2018 at 17:47, Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote:
Hi Felix,
Felix Hartmann-2 wrote
Okay - no-merge-lines makes no difference, also removing addArcsToMajorRoads(); function makes no difference. And I just noticed - the patch does not work. It works in it's own way - but not achieving the result that is needed. Whatever I do - I still end up with 6 routable lines.
I guess the patch checks for each road that it is not more than 4 times in the map. So I end up with 1, 2, and 3 (1 that is supposed to be in the map, 2 from the east not supposed, and 3 from the south, not supposed). (always using gpsmapedit to check results).
yes, that is what it does. Didn't you suggest something like that?
You still did not tell me how I can reproduce a crash with this data, so I can only guess. I didn't see any routing issues so far with your maps, only the ugly rendering. Is this the only problem or is there really a routing issue? If yes, please let me know how to reproduce it.
Gerd
-- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Felix, okay, I think I can reproduce a routing problem on my Oregon with your map. I have a route that works from south to north but not in the reverse direction. I'll try to create a similar situation with a modified default style to find out what the problem is. My current prime suspect is the way with type 0x16. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Donnerstag, 1. März 2018 18:09:02 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. routing issues is on devices only - not in Basecamp. Reported so far from Oregon and Edge - routing from North to East over that road. Well what I thought was that mkgmap should check if another road is put above. Right now it's 1 road supposed to be there, 2 and 3 roads overlapping due to that road being too short. Those overlapping somehow would need to be removed (and yes I know they are originally not the same line). My style should I think in maximum create 4 routable lines - however due to overlapping of other lines (due to the sub 4.3m line) it ends up a short stretch with more than 5 routable lines. On 1 March 2018 at 17:47, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, Felix Hartmann-2 wrote
Okay - no-merge-lines makes no difference, also removing addArcsToMajorRoads(); function makes no difference. And I just noticed - the patch does not work. It works in it's own way - but not achieving the result that is needed. Whatever I do - I still end up with 6 routable lines.
I guess the patch checks for each road that it is not more than 4 times in the map. So I end up with 1, 2, and 3 (1 that is supposed to be in the map, 2 from the east not supposed, and 3 from the south, not supposed). (always using gpsmapedit to check results).
yes, that is what it does. Didn't you suggest something like that? You still did not tell me how I can reproduce a crash with this data, so I can only guess. I didn't see any routing issues so far with your maps, only the ugly rendering. Is this the only problem or is there really a routing issue? If yes, please let me know how to reproduce it. Gerd -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Well in general 0x16 does not cause any problems. Do you think if I use another type instead (e.g.) 0x13 it won't be problematic, or do you mean that the 0x16 in itself is the problem? On 1 March 2018 at 18:55, Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote:
Hi Felix,
okay, I think I can reproduce a routing problem on my Oregon with your map. I have a route that works from south to north but not in the reverse direction. I'll try to create a similar situation with a modified default style to find out what the problem is. My current prime suspect is the way with type 0x16.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Donnerstag, 1. März 2018 18:09:02 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
routing issues is on devices only - not in Basecamp. Reported so far from Oregon and Edge - routing from North to East over that road.
Well what I thought was that mkgmap should check if another road is put above. Right now it's 1 road supposed to be there, 2 and 3 roads overlapping due to that road being too short. Those overlapping somehow would need to be removed (and yes I know they are originally not the same line). My style should I think in maximum create 4 routable lines - however due to overlapping of other lines (due to the sub 4.3m line) it ends up a short stretch with more than 5 routable lines.
On 1 March 2018 at 17:47, Gerd Petermann <gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix,
Felix Hartmann-2 wrote
Okay - no-merge-lines makes no difference, also removing addArcsToMajorRoads(); function makes no difference. And I just noticed - the patch does not work. It works in it's own way - but not achieving the result that is needed. Whatever I do - I still end up with 6 routable lines.
I guess the patch checks for each road that it is not more than 4 times in the map. So I end up with 1, 2, and 3 (1 that is supposed to be in the map, 2 from the east not supposed, and 3 from the south, not supposed). (always using gpsmapedit to check results).
yes, that is what it does. Didn't you suggest something like that?
You still did not tell me how I can reproduce a crash with this data, so I can only guess. I didn't see any routing issues so far with your maps, only the ugly rendering. Is this the only problem or is there really a routing issue? If yes, please let me know how to reproduce it.
Gerd
-- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Felix, no, it is just special at this juntion because the other ways have 0x8 or 0x13. On thursday I wrote that I was able to reproduce a problem at this junction but I forgot to set up routing for car (automotive) :-( I can reproduce a problem with "tour cycling", but I think that is expected with your style, because it avoids main roads by default. Maybe your users made the same error? You suggested to add route=hiking [0x13 road_class=4 road_speed=2 resolution 24 continue] to reproduce a problem. I tried that with no effect. Only after I added a rule in the relations file: type=route & route=hiking { apply { add route=hiking } } With that I see additional routable lines in the map and routing is more less broken at node 412440328 when I try to route from north to anywhere below the node , also the inverse way doesn't work. I tried different variants of the rule like other types or other road classes, always saw the same problem. I see working routing again when I remove way 130665733 from the input file and move node 1263658617 down to 412440328 and merge them (see attached file). I'll try to find out why this is so special in this situation. ciao, Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Freitag, 2. März 2018 22:21:35 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Well in general 0x16 does not cause any problems. Do you think if I use another type instead (e.g.) 0x13 it won't be problematic, or do you mean that the 0x16 in itself is the problem? On 1 March 2018 at 18:55, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, okay, I think I can reproduce a routing problem on my Oregon with your map. I have a route that works from south to north but not in the reverse direction. I'll try to create a similar situation with a modified default style to find out what the problem is. My current prime suspect is the way with type 0x16. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Donnerstag, 1. März 2018 18:09:02 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. routing issues is on devices only - not in Basecamp. Reported so far from Oregon and Edge - routing from North to East over that road. Well what I thought was that mkgmap should check if another road is put above. Right now it's 1 road supposed to be there, 2 and 3 roads overlapping due to that road being too short. Those overlapping somehow would need to be removed (and yes I know they are originally not the same line). My style should I think in maximum create 4 routable lines - however due to overlapping of other lines (due to the sub 4.3m line) it ends up a short stretch with more than 5 routable lines. On 1 March 2018 at 17:47, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix, Felix Hartmann-2 wrote
Okay - no-merge-lines makes no difference, also removing addArcsToMajorRoads(); function makes no difference. And I just noticed - the patch does not work. It works in it's own way - but not achieving the result that is needed. Whatever I do - I still end up with 6 routable lines.
I guess the patch checks for each road that it is not more than 4 times in the map. So I end up with 1, 2, and 3 (1 that is supposed to be in the map, 2 from the east not supposed, and 3 from the south, not supposed). (always using gpsmapedit to check results).
yes, that is what it does. Didn't you suggest something like that? You still did not tell me how I can reproduce a crash with this data, so I can only guess. I didn't see any routing issues so far with your maps, only the ugly rendering. Is this the only problem or is there really a routing issue? If yes, please let me know how to reproduce it. Gerd -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Felix, I just noted that I got my results reg. the modified default style with a modified StyledConverter which does the road merging before the wrong angle fixing. Something goes very wrong with this patched version. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com> Gesendet: Samstag, 3. März 2018 11:01:42 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, no, it is just special at this juntion because the other ways have 0x8 or 0x13. On thursday I wrote that I was able to reproduce a problem at this junction but I forgot to set up routing for car (automotive) :-( I can reproduce a problem with "tour cycling", but I think that is expected with your style, because it avoids main roads by default. Maybe your users made the same error? You suggested to add route=hiking [0x13 road_class=4 road_speed=2 resolution 24 continue] to reproduce a problem. I tried that with no effect. Only after I added a rule in the relations file: type=route & route=hiking { apply { add route=hiking } } With that I see additional routable lines in the map and routing is more less broken at node 412440328 when I try to route from north to anywhere below the node , also the inverse way doesn't work. I tried different variants of the rule like other types or other road classes, always saw the same problem. I see working routing again when I remove way 130665733 from the input file and move node 1263658617 down to 412440328 and merge them (see attached file). I'll try to find out why this is so special in this situation. ciao, Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Freitag, 2. März 2018 22:21:35 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Well in general 0x16 does not cause any problems. Do you think if I use another type instead (e.g.) 0x13 it won't be problematic, or do you mean that the 0x16 in itself is the problem? On 1 March 2018 at 18:55, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, okay, I think I can reproduce a routing problem on my Oregon with your map. I have a route that works from south to north but not in the reverse direction. I'll try to create a similar situation with a modified default style to find out what the problem is. My current prime suspect is the way with type 0x16. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Donnerstag, 1. März 2018 18:09:02 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. routing issues is on devices only - not in Basecamp. Reported so far from Oregon and Edge - routing from North to East over that road. Well what I thought was that mkgmap should check if another road is put above. Right now it's 1 road supposed to be there, 2 and 3 roads overlapping due to that road being too short. Those overlapping somehow would need to be removed (and yes I know they are originally not the same line). My style should I think in maximum create 4 routable lines - however due to overlapping of other lines (due to the sub 4.3m line) it ends up a short stretch with more than 5 routable lines. On 1 March 2018 at 17:47, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix, Felix Hartmann-2 wrote
Okay - no-merge-lines makes no difference, also removing addArcsToMajorRoads(); function makes no difference. And I just noticed - the patch does not work. It works in it's own way - but not achieving the result that is needed. Whatever I do - I still end up with 6 routable lines.
I guess the patch checks for each road that it is not more than 4 times in the map. So I end up with 1, 2, and 3 (1 that is supposed to be in the map, 2 from the east not supposed, and 3 from the south, not supposed). (always using gpsmapedit to check results).
yes, that is what it does. Didn't you suggest something like that? You still did not tell me how I can reproduce a crash with this data, so I can only guess. I didn't see any routing issues so far with your maps, only the ugly rendering. Is this the only problem or is there really a routing issue? If yes, please let me know how to reproduce it. Gerd -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Felix, okay, found out again why merging before angle fixing doesn't work, but I still have no clue why this junction would cause trouble reg. routing with a normal mkgmap binary. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com> Gesendet: Samstag, 3. März 2018 11:34:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, I just noted that I got my results reg. the modified default style with a modified StyledConverter which does the road merging before the wrong angle fixing. Something goes very wrong with this patched version. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com> Gesendet: Samstag, 3. März 2018 11:01:42 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, no, it is just special at this juntion because the other ways have 0x8 or 0x13. On thursday I wrote that I was able to reproduce a problem at this junction but I forgot to set up routing for car (automotive) :-( I can reproduce a problem with "tour cycling", but I think that is expected with your style, because it avoids main roads by default. Maybe your users made the same error? You suggested to add route=hiking [0x13 road_class=4 road_speed=2 resolution 24 continue] to reproduce a problem. I tried that with no effect. Only after I added a rule in the relations file: type=route & route=hiking { apply { add route=hiking } } With that I see additional routable lines in the map and routing is more less broken at node 412440328 when I try to route from north to anywhere below the node , also the inverse way doesn't work. I tried different variants of the rule like other types or other road classes, always saw the same problem. I see working routing again when I remove way 130665733 from the input file and move node 1263658617 down to 412440328 and merge them (see attached file). I'll try to find out why this is so special in this situation. ciao, Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Freitag, 2. März 2018 22:21:35 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Well in general 0x16 does not cause any problems. Do you think if I use another type instead (e.g.) 0x13 it won't be problematic, or do you mean that the 0x16 in itself is the problem? On 1 March 2018 at 18:55, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, okay, I think I can reproduce a routing problem on my Oregon with your map. I have a route that works from south to north but not in the reverse direction. I'll try to create a similar situation with a modified default style to find out what the problem is. My current prime suspect is the way with type 0x16. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Donnerstag, 1. März 2018 18:09:02 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. routing issues is on devices only - not in Basecamp. Reported so far from Oregon and Edge - routing from North to East over that road. Well what I thought was that mkgmap should check if another road is put above. Right now it's 1 road supposed to be there, 2 and 3 roads overlapping due to that road being too short. Those overlapping somehow would need to be removed (and yes I know they are originally not the same line). My style should I think in maximum create 4 routable lines - however due to overlapping of other lines (due to the sub 4.3m line) it ends up a short stretch with more than 5 routable lines. On 1 March 2018 at 17:47, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix, Felix Hartmann-2 wrote
Okay - no-merge-lines makes no difference, also removing addArcsToMajorRoads(); function makes no difference. And I just noticed - the patch does not work. It works in it's own way - but not achieving the result that is needed. Whatever I do - I still end up with 6 routable lines.
I guess the patch checks for each road that it is not more than 4 times in the map. So I end up with 1, 2, and 3 (1 that is supposed to be in the map, 2 from the east not supposed, and 3 from the south, not supposed). (always using gpsmapedit to check results).
yes, that is what it does. Didn't you suggest something like that? You still did not tell me how I can reproduce a crash with this data, so I can only guess. I didn't see any routing issues so far with your maps, only the ugly rendering. Is this the only problem or is there really a routing issue? If yes, please let me know how to reproduce it. Gerd -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
well in general 0x16 is not avoided by any transport means (or at least it was not a couple of years ago when I checked the influence of types= - that's strange. 0x01 and 0x02 are avoided by bicycle - but in general I never use avoidances except toll and unpaved - they are pretty straight forward. I should do some checks again if something changed with activity routing over the years. If 6 ways on top of each other are routable problems are common (but do not have to occur - not sure why). (oh yeah I forgot to say to add the route=hiking to relations file, I assumed that is clear as it's a route and they are always relations). On 3 March 2018 at 15:27, Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote:
Hi Felix,
okay, found out again why merging before angle fixing doesn't work, but I still have no clue why this junction would cause trouble reg. routing with a normal mkgmap binary.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com> Gesendet: Samstag, 3. März 2018 11:34:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix,
I just noted that I got my results reg. the modified default style with a modified StyledConverter which does the road merging before the wrong angle fixing. Something goes very wrong with this patched version.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com> Gesendet: Samstag, 3. März 2018 11:01:42 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix,
no, it is just special at this juntion because the other ways have 0x8 or 0x13. On thursday I wrote that I was able to reproduce a problem at this junction but I forgot to set up routing for car (automotive) :-( I can reproduce a problem with "tour cycling", but I think that is expected with your style, because it avoids main roads by default. Maybe your users made the same error?
You suggested to add route=hiking [0x13 road_class=4 road_speed=2 resolution 24 continue] to reproduce a problem. I tried that with no effect. Only after I added a rule in the relations file: type=route & route=hiking { apply { add route=hiking } } With that I see additional routable lines in the map and routing is more less broken at node 412440328 when I try to route from north to anywhere below the node , also the inverse way doesn't work. I tried different variants of the rule like other types or other road classes, always saw the same problem. I see working routing again when I remove way 130665733 from the input file and move node 1263658617 down to 412440328 and merge them (see attached file). I'll try to find out why this is so special in this situation.
ciao, Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Freitag, 2. März 2018 22:21:35 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Well in general 0x16 does not cause any problems. Do you think if I use another type instead (e.g.) 0x13 it won't be problematic, or do you mean that the 0x16 in itself is the problem?
On 1 March 2018 at 18:55, Gerd Petermann <gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix,
okay, I think I can reproduce a routing problem on my Oregon with your map. I have a route that works from south to north but not in the reverse direction. I'll try to create a similar situation with a modified default style to find out what the problem is. My current prime suspect is the way with type 0x16.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann < extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Donnerstag, 1. März 2018 18:09:02 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
routing issues is on devices only - not in Basecamp. Reported so far from Oregon and Edge - routing from North to East over that road.
Well what I thought was that mkgmap should check if another road is put above. Right now it's 1 road supposed to be there, 2 and 3 roads overlapping due to that road being too short. Those overlapping somehow would need to be removed (and yes I know they are originally not the same line). My style should I think in maximum create 4 routable lines - however due to overlapping of other lines (due to the sub 4.3m line) it ends up a short stretch with more than 5 routable lines.
On 1 March 2018 at 17:47, Gerd Petermann <gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com><mailto:g petermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix,
Felix Hartmann-2 wrote
Okay - no-merge-lines makes no difference, also removing addArcsToMajorRoads(); function makes no difference. And I just noticed - the patch does not work. It works in it's own way - but not achieving the result that is needed. Whatever I do - I still end up with 6 routable lines.
I guess the patch checks for each road that it is not more than 4 times in the map. So I end up with 1, 2, and 3 (1 that is supposed to be in the map, 2 from the east not supposed, and 3 from the south, not supposed). (always using gpsmapedit to check results).
yes, that is what it does. Didn't you suggest something like that?
You still did not tell me how I can reproduce a crash with this data, so I can only guess. I didn't see any routing issues so far with your maps, only the ugly rendering. Is this the only problem or is there really a routing issue? If yes, please let me know how to reproduce it.
Gerd
-- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists. mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Felix, attached is a patch that improves WrongAngleFixer. When both ways build a junction and both have another point close to that junction and in OSM they are different nodes mkgmap tries harder to avoid that they are rounded to the same coordinate. This is what happened with these two nodes https://www.openstreetmap.org/node/1263658804 https://www.openstreetmap.org/node/1195812701 I found similar situations at some roundabouts, sometimes a way connected to the roundabout and the roundabout way overlap. I am not sure how this patch works with your style, please try it with r4131. A few special cases to look at: https://www.openstreetmap.org/way/208976154 Coordinates: 38.4082747, 16.0787201 https://www.openstreetmap.org/way/312642720 Coordinates: 39.0259441, 8.5967561 https://www.openstreetmap.org/way/148634420 Coordinates: 41.981263, 12.4114831 Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Samstag, 3. März 2018 19:49:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. well in general 0x16 is not avoided by any transport means (or at least it was not a couple of years ago when I checked the influence of types= - that's strange. 0x01 and 0x02 are avoided by bicycle - but in general I never use avoidances except toll and unpaved - they are pretty straight forward. I should do some checks again if something changed with activity routing over the years. If 6 ways on top of each other are routable problems are common (but do not have to occur - not sure why). (oh yeah I forgot to say to add the route=hiking to relations file, I assumed that is clear as it's a route and they are always relations). On 3 March 2018 at 15:27, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, okay, found out again why merging before angle fixing doesn't work, but I still have no clue why this junction would cause trouble reg. routing with a normal mkgmap binary. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> Gesendet: Samstag, 3. März 2018 11:34:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, I just noted that I got my results reg. the modified default style with a modified StyledConverter which does the road merging before the wrong angle fixing. Something goes very wrong with this patched version. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> Gesendet: Samstag, 3. März 2018 11:01:42 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, no, it is just special at this juntion because the other ways have 0x8 or 0x13. On thursday I wrote that I was able to reproduce a problem at this junction but I forgot to set up routing for car (automotive) :-( I can reproduce a problem with "tour cycling", but I think that is expected with your style, because it avoids main roads by default. Maybe your users made the same error? You suggested to add route=hiking [0x13 road_class=4 road_speed=2 resolution 24 continue] to reproduce a problem. I tried that with no effect. Only after I added a rule in the relations file: type=route & route=hiking { apply { add route=hiking } } With that I see additional routable lines in the map and routing is more less broken at node 412440328 when I try to route from north to anywhere below the node , also the inverse way doesn't work. I tried different variants of the rule like other types or other road classes, always saw the same problem. I see working routing again when I remove way 130665733 from the input file and move node 1263658617 down to 412440328 and merge them (see attached file). I'll try to find out why this is so special in this situation. ciao, Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Freitag, 2. März 2018 22:21:35 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Well in general 0x16 does not cause any problems. Do you think if I use another type instead (e.g.) 0x13 it won't be problematic, or do you mean that the 0x16 in itself is the problem? On 1 March 2018 at 18:55, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix, okay, I think I can reproduce a routing problem on my Oregon with your map. I have a route that works from south to north but not in the reverse direction. I'll try to create a similar situation with a modified default style to find out what the problem is. My current prime suspect is the way with type 0x16. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> Gesendet: Donnerstag, 1. März 2018 18:09:02 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. routing issues is on devices only - not in Basecamp. Reported so far from Oregon and Edge - routing from North to East over that road. Well what I thought was that mkgmap should check if another road is put above. Right now it's 1 road supposed to be there, 2 and 3 roads overlapping due to that road being too short. Those overlapping somehow would need to be removed (and yes I know they are originally not the same line). My style should I think in maximum create 4 routable lines - however due to overlapping of other lines (due to the sub 4.3m line) it ends up a short stretch with more than 5 routable lines. On 1 March 2018 at 17:47, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>>> wrote: Hi Felix, Felix Hartmann-2 wrote
Okay - no-merge-lines makes no difference, also removing addArcsToMajorRoads(); function makes no difference. And I just noticed - the patch does not work. It works in it's own way - but not achieving the result that is needed. Whatever I do - I still end up with 6 routable lines.
I guess the patch checks for each road that it is not more than 4 times in the map. So I end up with 1, 2, and 3 (1 that is supposed to be in the map, 2 from the east not supposed, and 3 from the south, not supposed). (always using gpsmapedit to check results).
yes, that is what it does. Didn't you suggest something like that? You still did not tell me how I can reproduce a crash with this data, so I can only guess. I didn't see any routing issues so far with your maps, only the ugly rendering. Is this the only problem or is there really a routing issue? If yes, please let me know how to reproduce it. Gerd -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Thanks Gerd, I will do some tests on Saturday and then report back. Felix On 8 March 2018 at 11:46, Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote:
Hi Felix,
attached is a patch that improves WrongAngleFixer. When both ways build a junction and both have another point close to that junction and in OSM they are different nodes mkgmap tries harder to avoid that they are rounded to the same coordinate. This is what happened with these two nodes https://www.openstreetmap.org/node/1263658804 https://www.openstreetmap.org/node/1195812701
I found similar situations at some roundabouts, sometimes a way connected to the roundabout and the roundabout way overlap. I am not sure how this patch works with your style, please try it with r4131.
A few special cases to look at: https://www.openstreetmap.org/way/208976154 Coordinates: 38.4082747, 16.0787201 https://www.openstreetmap.org/way/312642720 Coordinates: 39.0259441, 8.5967561 https://www.openstreetmap.org/way/148634420 Coordinates: 41.981263, 12.4114831
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Samstag, 3. März 2018 19:49:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
well in general 0x16 is not avoided by any transport means (or at least it was not a couple of years ago when I checked the influence of types= - that's strange. 0x01 and 0x02 are avoided by bicycle - but in general I never use avoidances except toll and unpaved - they are pretty straight forward. I should do some checks again if something changed with activity routing over the years. If 6 ways on top of each other are routable problems are common (but do not have to occur - not sure why).
(oh yeah I forgot to say to add the route=hiking to relations file, I assumed that is clear as it's a route and they are always relations).
On 3 March 2018 at 15:27, Gerd Petermann <gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix,
okay, found out again why merging before angle fixing doesn't work, but I still have no clue why this junction would cause trouble reg. routing with a normal mkgmap binary.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Gerd Petermann < gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> Gesendet: Samstag, 3. März 2018 11:34:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix,
I just noted that I got my results reg. the modified default style with a modified StyledConverter which does the road merging before the wrong angle fixing. Something goes very wrong with this patched version.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Gerd Petermann < gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> Gesendet: Samstag, 3. März 2018 11:01:42 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix,
no, it is just special at this juntion because the other ways have 0x8 or 0x13. On thursday I wrote that I was able to reproduce a problem at this junction but I forgot to set up routing for car (automotive) :-( I can reproduce a problem with "tour cycling", but I think that is expected with your style, because it avoids main roads by default. Maybe your users made the same error?
You suggested to add route=hiking [0x13 road_class=4 road_speed=2 resolution 24 continue] to reproduce a problem. I tried that with no effect. Only after I added a rule in the relations file: type=route & route=hiking { apply { add route=hiking } } With that I see additional routable lines in the map and routing is more less broken at node 412440328 when I try to route from north to anywhere below the node , also the inverse way doesn't work. I tried different variants of the rule like other types or other road classes, always saw the same problem. I see working routing again when I remove way 130665733 from the input file and move node 1263658617 down to 412440328 and merge them (see attached file). I'll try to find out why this is so special in this situation.
ciao, Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann < extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Freitag, 2. März 2018 22:21:35 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Well in general 0x16 does not cause any problems. Do you think if I use another type instead (e.g.) 0x13 it won't be problematic, or do you mean that the 0x16 in itself is the problem?
On 1 March 2018 at 18:55, Gerd Petermann <gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com><mailto:g petermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix,
okay, I think I can reproduce a routing problem on my Oregon with your map. I have a route that works from south to north but not in the reverse direction. I'll try to create a similar situation with a modified default style to find out what the problem is. My current prime suspect is the way with type 0x16.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@ lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto: extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto: extremecarver@gmail.com>>> Gesendet: Donnerstag, 1. März 2018 18:09:02 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
routing issues is on devices only - not in Basecamp. Reported so far from Oregon and Edge - routing from North to East over that road.
Well what I thought was that mkgmap should check if another road is put above. Right now it's 1 road supposed to be there, 2 and 3 roads overlapping due to that road being too short. Those overlapping somehow would need to be removed (and yes I know they are originally not the same line). My style should I think in maximum create 4 routable lines - however due to overlapping of other lines (due to the sub 4.3m line) it ends up a short stretch with more than 5 routable lines.
On 1 March 2018 at 17:47, Gerd Petermann <gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com><mailto:g petermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
<mailto:gpetermann_muenchen@hotmail.com<mailto: gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com>>>> wrote: Hi Felix,
Felix Hartmann-2 wrote
Okay - no-merge-lines makes no difference, also removing addArcsToMajorRoads(); function makes no difference. And I just noticed - the patch does not work. It works in it's own way - but not achieving the result that is needed. Whatever I do - I still end up with 6 routable lines.
I guess the patch checks for each road that it is not more than 4 times in the map. So I end up with 1, 2, and 3 (1 that is supposed to be in the map, 2 from the east not supposed, and 3 from the south, not supposed). (always using gpsmapedit to check results).
yes, that is what it does. Didn't you suggest something like that?
You still did not tell me how I can reproduce a crash with this data, so I can only guess. I didn't see any routing issues so far with your maps, only the ugly rendering. Is this the only problem or is there really a routing issue? If yes, please let me know how to reproduce it.
Gerd
-- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists. mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto: mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk< mailto:mkgmap-dev@lists.mkgmap.org.uk>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists. mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Felix, okay, thanks. BTW: I still have no good idea how to solve the problem with the spike at node 1270407079. The attached screen shots show the problem. The coloured lines are the input. Many very short ways and all points are far from the Garmin grid points. The picture before.png shows the input to WrongAngleFixer (WAF), the after.png the output. The output is a bit better, but no improvement regarding the spike. I think WAF should collapse the two ways (111528849 and 111528851) which build the spike. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Donnerstag, 8. März 2018 20:47:39 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Thanks Gerd, I will do some tests on Saturday and then report back. Felix On 8 March 2018 at 11:46, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, attached is a patch that improves WrongAngleFixer. When both ways build a junction and both have another point close to that junction and in OSM they are different nodes mkgmap tries harder to avoid that they are rounded to the same coordinate. This is what happened with these two nodes https://www.openstreetmap.org/node/1263658804 https://www.openstreetmap.org/node/1195812701 I found similar situations at some roundabouts, sometimes a way connected to the roundabout and the roundabout way overlap. I am not sure how this patch works with your style, please try it with r4131. A few special cases to look at: https://www.openstreetmap.org/way/208976154 Coordinates: 38.4082747, 16.0787201 https://www.openstreetmap.org/way/312642720 Coordinates: 39.0259441, 8.5967561 https://www.openstreetmap.org/way/148634420 Coordinates: 41.981263, 12.4114831 Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Samstag, 3. März 2018 19:49:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. well in general 0x16 is not avoided by any transport means (or at least it was not a couple of years ago when I checked the influence of types= - that's strange. 0x01 and 0x02 are avoided by bicycle - but in general I never use avoidances except toll and unpaved - they are pretty straight forward. I should do some checks again if something changed with activity routing over the years. If 6 ways on top of each other are routable problems are common (but do not have to occur - not sure why). (oh yeah I forgot to say to add the route=hiking to relations file, I assumed that is clear as it's a route and they are always relations). On 3 March 2018 at 15:27, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix, okay, found out again why merging before angle fixing doesn't work, but I still have no clue why this junction would cause trouble reg. routing with a normal mkgmap binary. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> Gesendet: Samstag, 3. März 2018 11:34:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, I just noted that I got my results reg. the modified default style with a modified StyledConverter which does the road merging before the wrong angle fixing. Something goes very wrong with this patched version. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> Gesendet: Samstag, 3. März 2018 11:01:42 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, no, it is just special at this juntion because the other ways have 0x8 or 0x13. On thursday I wrote that I was able to reproduce a problem at this junction but I forgot to set up routing for car (automotive) :-( I can reproduce a problem with "tour cycling", but I think that is expected with your style, because it avoids main roads by default. Maybe your users made the same error? You suggested to add route=hiking [0x13 road_class=4 road_speed=2 resolution 24 continue] to reproduce a problem. I tried that with no effect. Only after I added a rule in the relations file: type=route & route=hiking { apply { add route=hiking } } With that I see additional routable lines in the map and routing is more less broken at node 412440328 when I try to route from north to anywhere below the node , also the inverse way doesn't work. I tried different variants of the rule like other types or other road classes, always saw the same problem. I see working routing again when I remove way 130665733 from the input file and move node 1263658617 down to 412440328 and merge them (see attached file). I'll try to find out why this is so special in this situation. ciao, Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> Gesendet: Freitag, 2. März 2018 22:21:35 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Well in general 0x16 does not cause any problems. Do you think if I use another type instead (e.g.) 0x13 it won't be problematic, or do you mean that the 0x16 in itself is the problem? On 1 March 2018 at 18:55, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>>> wrote: Hi Felix, okay, I think I can reproduce a routing problem on my Oregon with your map. I have a route that works from south to north but not in the reverse direction. I'll try to create a similar situation with a modified default style to find out what the problem is. My current prime suspect is the way with type 0x16. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>>> Gesendet: Donnerstag, 1. März 2018 18:09:02 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. routing issues is on devices only - not in Basecamp. Reported so far from Oregon and Edge - routing from North to East over that road. Well what I thought was that mkgmap should check if another road is put above. Right now it's 1 road supposed to be there, 2 and 3 roads overlapping due to that road being too short. Those overlapping somehow would need to be removed (and yes I know they are originally not the same line). My style should I think in maximum create 4 routable lines - however due to overlapping of other lines (due to the sub 4.3m line) it ends up a short stretch with more than 5 routable lines. On 1 March 2018 at 17:47, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>>>> wrote: Hi Felix, Felix Hartmann-2 wrote
Okay - no-merge-lines makes no difference, also removing addArcsToMajorRoads(); function makes no difference. And I just noticed - the patch does not work. It works in it's own way - but not achieving the result that is needed. Whatever I do - I still end up with 6 routable lines.
I guess the patch checks for each road that it is not more than 4 times in the map. So I end up with 1, 2, and 3 (1 that is supposed to be in the map, 2 from the east not supposed, and 3 from the south, not supposed). (always using gpsmapedit to check results).
yes, that is what it does. Didn't you suggest something like that? You still did not tell me how I can reproduce a crash with this data, so I can only guess. I didn't see any routing issues so far with your maps, only the ugly rendering. Is this the only problem or is there really a routing issue? If yes, please let me know how to reproduce it. Gerd -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
How about merging ways shorter than 1 unit if they are similar or deleting them and move access to the node? Or just delete such ways only going force and back. And moving access to the node. Henning On 9 Mar 2018, 16:15, at 16:15, Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote:
Hi Felix,
okay, thanks. BTW: I still have no good idea how to solve the problem with the spike at node 1270407079. The attached screen shots show the problem. The coloured lines are the input. Many very short ways and all points are far from the Garmin grid points. The picture before.png shows the input to WrongAngleFixer (WAF), the after.png the output. The output is a bit better, but no improvement regarding the spike. I think WAF should collapse the two ways (111528849 and 111528851) which build the spike.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Donnerstag, 8. März 2018 20:47:39 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Thanks Gerd, I will do some tests on Saturday and then report back.
Felix
On 8 March 2018 at 11:46, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix,
attached is a patch that improves WrongAngleFixer. When both ways build a junction and both have another point close to that junction and in OSM they are different nodes mkgmap tries harder to avoid that they are rounded to the same coordinate. This is what happened with these two nodes https://www.openstreetmap.org/node/1263658804 https://www.openstreetmap.org/node/1195812701
I found similar situations at some roundabouts, sometimes a way connected to the roundabout and the roundabout way overlap. I am not sure how this patch works with your style, please try it with r4131.
A few special cases to look at: https://www.openstreetmap.org/way/208976154 Coordinates: 38.4082747, 16.0787201 https://www.openstreetmap.org/way/312642720 Coordinates: 39.0259441, 8.5967561 https://www.openstreetmap.org/way/148634420 Coordinates: 41.981263, 12.4114831
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Samstag, 3. März 2018 19:49:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
well in general 0x16 is not avoided by any transport means (or at least it was not a couple of years ago when I checked the influence of types= - that's strange. 0x01 and 0x02 are avoided by bicycle - but in general I never use avoidances except toll and unpaved - they are pretty straight forward. I should do some checks again if something changed with activity routing over the years. If 6 ways on top of each other are routable problems are common (but do not have to occur - not sure why).
(oh yeah I forgot to say to add the route=hiking to relations file, I assumed that is clear as it's a route and they are always relations).
On 3 March 2018 at 15:27, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix,
okay, found out again why merging before angle fixing doesn't work, but I still have no clue why this junction would cause trouble reg. routing with a normal mkgmap binary.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> Gesendet: Samstag, 3. März 2018 11:34:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix,
I just noted that I got my results reg. the modified default style with a modified StyledConverter which does the road merging before the wrong angle fixing. Something goes very wrong with this patched version.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> Gesendet: Samstag, 3. März 2018 11:01:42 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix,
no, it is just special at this juntion because the other ways have 0x8 or 0x13. On thursday I wrote that I was able to reproduce a problem at this junction but I forgot to set up routing for car (automotive) :-( I can reproduce a problem with "tour cycling", but I think that is expected with your style, because it avoids main roads by default. Maybe your users made the same error?
You suggested to add route=hiking [0x13 road_class=4 road_speed=2 resolution 24 continue] to reproduce a problem. I tried that with no effect. Only after I added a rule in the relations file: type=route & route=hiking { apply { add route=hiking } } With that I see additional routable lines in the map and routing is more less broken at node 412440328 when I try to route from north to anywhere below the node , also the inverse way doesn't work. I tried different variants of the rule like other types or other road classes, always saw the same problem. I see working routing again when I remove way 130665733 from the input file and move node 1263658617 down to 412440328 and merge them (see attached file). I'll try to find out why this is so special in this situation.
ciao, Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> Gesendet: Freitag, 2. März 2018 22:21:35 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Well in general 0x16 does not cause any problems. Do you think if I use another type instead (e.g.) 0x13 it won't be problematic, or do you mean that the 0x16 in itself is the problem?
On 1 March 2018 at 18:55, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>>> wrote: Hi Felix,
okay, I think I can reproduce a routing problem on my Oregon with your map. I have a route that works from south to north but not in the reverse direction. I'll try to create a similar situation with a modified default style to find out what the problem is. My current prime suspect is the way with type 0x16.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>>> Gesendet: Donnerstag, 1. März 2018 18:09:02 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
routing issues is on devices only - not in Basecamp. Reported so far from Oregon and Edge - routing from North to East over that road.
Well what I thought was that mkgmap should check if another road is put above. Right now it's 1 road supposed to be there, 2 and 3 roads overlapping due to that road being too short. Those overlapping somehow would need to be removed (and yes I know they are originally not the same line). My style should I think in maximum create 4 routable lines - however due to overlapping of other lines (due to the sub 4.3m line) it ends up a short stretch with more than 5 routable lines.
On 1 March 2018 at 17:47, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>>>> wrote: Hi Felix,
Felix Hartmann-2 wrote
Okay - no-merge-lines makes no difference, also removing addArcsToMajorRoads(); function makes no difference. And I just noticed - the patch does not work. It works in it's own way - but not achieving the result that is needed. Whatever I do - I still end up with 6 routable lines.
I guess the patch checks for each road that it is not more than 4 times in the map. So I end up with 1, 2, and 3 (1 that is supposed to be in the map, 2 from the east not supposed, and 3 from the south, not supposed). (always using gpsmapedit to check results).
yes, that is what it does. Didn't you suggest something like that?
You still did not tell me how I can reproduce a crash with this data, so I can only guess. I didn't see any routing issues so far with your maps, only the ugly rendering. Is this the only problem or is there really a routing issue? If yes, please let me know how to reproduce it.
Gerd
-- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
------------------------------------------------------------------------
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Henning, I assume with "move access to the node" you mean something like "create route restrictions similar to the access restrictions of the way"? This would be quite difficult when a style adds the short way multiple times with different attributes. I think this doesn't happen in Felix' style but maybe in others. Merging earlier would be an option to reduce the number of problem cases beforehand but causes trouble with the current code, and in the end we would still see problems when ways are not similar. I think best is to collapse the way. In a later step (after or when merging) mkgmap may decide that the way can be removed. I am working on this now, just have to find the right criteria... Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Henning Scholland <osm@hscholland.de> Gesendet: Freitag, 9. März 2018 11:32:14 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. How about merging ways shorter than 1 unit if they are similar or deleting them and move access to the node? Or just delete such ways only going force and back. And moving access to the node. Henning On 9 Mar 2018, at 16:15, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, okay, thanks. BTW: I still have no good idea how to solve the problem with the spike at node 1270407079. The attached screen shots show the problem. The coloured lines are the input. Many very short ways and all points are far from the Garmin grid points. The picture before.png shows the input to WrongAngleFixer (WAF), the after.png the output. The output is a bit better, but no improvement regarding the spike. I think WAF should collapse the two ways (111528849 and 111528851) which build the spike. Gerd ________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Donnerstag, 8. März 2018 20:47:39 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Thanks Gerd, I will do some tests on Saturday and then report back. Felix On 8 March 2018 at 11:46, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, attached is a patch that improves WrongAngleFixer. When both ways build a junction and both have another point close to that junction and in OSM they are different nodes mkgmap tries harder to avoid that they are rounded to the same coordinate. This is what happened with these two nodes https://www.openstreetmap.org/node/1263658804 https://www.openstreetmap.org/node/1195812701 I found similar situations at some roundabouts, sometimes a way connected to the roundabout and the roundabout way overlap. I am not sure how this patch works with your style, please try it with r4131. A few special cases to look at: https://www.openstreetmap.org/way/208976154 Coordinates: 38.4082747, 16.0787201 https://www.openstreetmap.org/way/312642720 Coordinates: 39.0259441, 8.5967561 https://www.openstreetmap.org/way/148634420 Coordinates: 41.981263, 12.4114831 Gerd ________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Samstag, 3. März 2018 19:49:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. well in general 0x16 is not avoided by any transport means (or at least it was not a couple of years ago when I checked the influence of types= - that's strange. 0x01 and 0x02 are avoided by bicycle - but in general I never use avoidances except toll and unpaved - they are pretty straight forward. I should do some checks again if something changed with activity routing over the years. If 6 ways on top of each other are routable problems are common (but do not have to occur - not sure why). (oh yeah I forgot to say to add the route=hiking to relations file, I assumed that is clear as it's a route and they are always relations). On 3 March 2018 at 15:27, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix, okay, found out again why merging before angle fixing doesn't work, but I still have no clue why this junction would cause trouble reg. routing with a normal mkgmap binary. Gerd ________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> Gesendet: Samstag, 3. März 2018 11:34:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, I just noted that I got my results reg. the modified default style with a modified StyledConverter which does the road merging before the wrong angle fixing. Something goes very wrong with this patched version. Gerd ________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> Gesendet: Samstag, 3. März 2018 11:01:42 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, no, it is just special at this juntion because the other ways have 0x8 or 0x13. On thursday I wrote that I was able to reproduce a problem at this junction but I forgot to set up routing for car (automotive) :-( I can reproduce a problem with "tour cycling", but I think that is expected with your style, because it avoids main roads by default. Maybe your users made the same error? You suggested to add route=hiking [0x13 road_class=4 road_speed=2 resolution 24 continue] to reproduce a problem. I tried that with no effect. Only after I added a rule in the relations file: type=route & route=hiking { apply { add route=hiking } } With that I see additional routable lines in the map and routing is more less broken at node 412440328 when I try to route from north to anywhere below the node , also the inverse way doesn't work. I tried different variants of the rule like other types or other road classes, always saw the same problem. I see working routing again when I remove way 130665733 from the input file and move node 1263658617 down to 412440328 and merge them (see attached file). I'll try to find out why this is so special in this situation. ciao, Gerd ________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> Gesendet: Freitag, 2. März 2018 22:21:35 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Well in general 0x16 does not cause any problems. Do you think if I use another type instead (e.g.) 0x13 it won't be problematic, or do you mean that the 0x16 in itself is the problem? On 1 March 2018 at 18:55, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>>> wrote: Hi Felix, okay, I think I can reproduce a routing problem on my Oregon with your map. I have a route that works from south to north but not in the reverse direction. I'll try to create a similar situation with a modified default style to find out what the problem is. My current prime suspect is the way with type 0x16. Gerd ________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>>> Gesendet: Donnerstag, 1. März 2018 18:09:02 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. routing issues is on devices only - not in Basecamp. Reported so far from Oregon and Edge - routing from North to East over that road. Well what I thought was that mkgmap should check if another road is put above. Right now it's 1 road supposed to be there, 2 and 3 roads overlapping due to that road being too short. Those overlapping somehow would need to be removed (and yes I know they are originally not the same line). My style should I think in maximum create 4 routable lines - however due to overlapping of other lines (due to the sub 4.3m line) it ends up a short stretch with more than 5 routable lines. On 1 March 2018 at 17:47, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>>>> wrote: Hi Felix, Felix Hartmann-2 wrote Okay - no-merge-lines makes no difference, also removing addArcsToMajorRoads(); function makes no difference. And I just noticed - the patch does not work. It works in it's own way - but not achieving the result that is needed. Whatever I do - I still end up with 6 routable lines. I guess the patch checks for each road that it is not more than 4 times in the map. So I end up with 1, 2, and 3 (1 that is supposed to be in the map, 2 from the east not supposed, and 3 from the south, not supposed). (always using gpsmapedit to check results). yes, that is what it does. Didn't you suggest something like that? You still did not tell me how I can reproduce a crash with this data, so I can only guess. I didn't see any routing issues so far with your maps, only the ugly rendering. Is this the only problem or is there really a routing issue? If yes, please let me know how to reproduce it. Gerd -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html ________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd, yes basically I was thinking of more or less the node with only containing the double way and moving all the mkgmap:access information to the left-over node of that double way. So need some post-processing of WAF. Henning On 9 Mar 2018, 19:21, at 19:21, Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote:
Hi Henning,
I assume with "move access to the node" you mean something like "create route restrictions similar to the access restrictions of the way"? This would be quite difficult when a style adds the short way multiple times with different attributes. I think this doesn't happen in Felix' style but maybe in others.
Merging earlier would be an option to reduce the number of problem cases beforehand but causes trouble with the current code, and in the end we would still see problems when ways are not similar.
I think best is to collapse the way. In a later step (after or when merging) mkgmap may decide that the way can be removed. I am working on this now, just have to find the right criteria...
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Henning Scholland <osm@hscholland.de> Gesendet: Freitag, 9. März 2018 11:32:14 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
How about merging ways shorter than 1 unit if they are similar or deleting them and move access to the node? Or just delete such ways only going force and back. And moving access to the node. Henning On 9 Mar 2018, at 16:15, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote:
Hi Felix,
okay, thanks. BTW: I still have no good idea how to solve the problem with the spike at node 1270407079. The attached screen shots show the problem. The coloured lines are the input. Many very short ways and all points are far from the Garmin grid points. The picture before.png shows the input to WrongAngleFixer (WAF), the after.png the output. The output is a bit better, but no improvement regarding the spike. I think WAF should collapse the two ways (111528849 and 111528851) which build the spike.
Gerd
________________________________
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Donnerstag, 8. März 2018 20:47:39 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Thanks Gerd, I will do some tests on Saturday and then report back.
Felix
On 8 March 2018 at 11:46, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix,
attached is a patch that improves WrongAngleFixer. When both ways build a junction and both have another point close to that junction and in OSM they are different nodes mkgmap tries harder to avoid that they are rounded to the same coordinate. This is what happened with these two nodes https://www.openstreetmap.org/node/1263658804 https://www.openstreetmap.org/node/1195812701
I found similar situations at some roundabouts, sometimes a way connected to the roundabout and the roundabout way overlap. I am not sure how this patch works with your style, please try it with r4131.
A few special cases to look at: https://www.openstreetmap.org/way/208976154 Coordinates: 38.4082747, 16.0787201 https://www.openstreetmap.org/way/312642720 Coordinates: 39.0259441, 8.5967561 https://www.openstreetmap.org/way/148634420 Coordinates: 41.981263, 12.4114831
Gerd
________________________________
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Samstag, 3. März 2018 19:49:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
well in general 0x16 is not avoided by any transport means (or at least it was not a couple of years ago when I checked the influence of types= - that's strange. 0x01 and 0x02 are avoided by bicycle - but in general I never use avoidances except toll and unpaved - they are pretty straight forward. I should do some checks again if something changed with activity routing over the years. If 6 ways on top of each other are routable problems are common (but do not have to occur - not sure why).
(oh yeah I forgot to say to add the route=hiking to relations file, I assumed that is clear as it's a route and they are always relations).
On 3 March 2018 at 15:27, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix,
okay, found out again why merging before angle fixing doesn't work, but I still have no clue why this junction would cause trouble reg. routing with a normal mkgmap binary.
Gerd
________________________________
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> Gesendet: Samstag, 3. März 2018 11:34:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix,
I just noted that I got my results reg. the modified default style with a modified StyledConverter which does the road merging before the wrong angle fixing. Something goes very wrong with this patched version.
Gerd
________________________________
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> Gesendet: Samstag, 3. März 2018 11:01:42 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix,
no, it is just special at this juntion because the other ways have 0x8 or 0x13. On thursday I wrote that I was able to reproduce a problem at this junction but I forgot to set up routing for car (automotive) :-( I can reproduce a problem with "tour cycling", but I think that is expected with your style, because it avoids main roads by default. Maybe your users made the same error?
You suggested to add route=hiking [0x13 road_class=4 road_speed=2 resolution 24 continue] to reproduce a problem. I tried that with no effect. Only after I added a rule in the relations file: type=route & route=hiking { apply { add route=hiking } } With that I see additional routable lines in the map and routing is more less broken at node 412440328 when I try to route from north to anywhere below the node , also the inverse way doesn't work. I tried different variants of the rule like other types or other road classes, always saw the same problem. I see working routing again when I remove way 130665733 from the input file and move node 1263658617 down to 412440328 and merge them (see attached file). I'll try to find out why this is so special in this situation.
ciao, Gerd
________________________________
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> Gesendet: Freitag, 2. März 2018 22:21:35 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Well in general 0x16 does not cause any problems. Do you think if I use another type instead (e.g.) 0x13 it won't be problematic, or do you mean that the 0x16 in itself is the problem?
On 1 March 2018 at 18:55, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>>> wrote: Hi Felix,
okay, I think I can reproduce a routing problem on my Oregon with your map. I have a route that works from south to north but not in the reverse direction. I'll try to create a similar situation with a modified default style to find out what the problem is. My current prime suspect is the way with type 0x16.
Gerd
________________________________
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>>> Gesendet: Donnerstag, 1. März 2018 18:09:02 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
routing issues is on devices only - not in Basecamp. Reported so far from Oregon and Edge - routing from North to East over that road.
Well what I thought was that mkgmap should check if another road is put above. Right now it's 1 road supposed to be there, 2 and 3 roads overlapping due to that road being too short. Those overlapping somehow would need to be removed (and yes I know they are originally not the same line). My style should I think in maximum create 4 routable lines - however due to overlapping of other lines (due to the sub 4.3m line) it ends up a short stretch with more than 5 routable lines.
On 1 March 2018 at 17:47, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>>>> wrote: Hi Felix,
Felix Hartmann-2 wrote Okay - no-merge-lines makes no difference, also removing addArcsToMajorRoads(); function makes no difference. And I just noticed - the patch does not work. It works in it's own way - but not achieving the result that is needed. Whatever I do - I still end up with 6 routable lines.
I guess the patch checks for each road that it is not more than 4 times in the map. So I end up with 1, 2, and 3 (1 that is supposed to be in the map, 2 from the east not supposed, and 3 from the south, not supposed). (always using gpsmapedit to check results).
yes, that is what it does. Didn't you suggest something like that?
You still did not tell me how I can reproduce a crash with this data, so I can only guess. I didn't see any routing issues so far with your maps, only the ugly rendering. Is this the only problem or is there really a routing issue? If yes, please let me know how to reproduce it.
Gerd
-- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html ________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd, I don't know anything about this bit of code, but the problem in the before and after pictures look to me like they are not the result of attempting to fix the angle, but look like they are the result of the second and fourth nodes in the spur both rounding to the same point, and it seems to me that the solution is to detect that the way has gone back on itself, and delete the intermediate node. If there are no junctions between two points that loop back on themselves, they should be able to be safely deleted before they are passed to WAF. Of course, I may be completely misunderstanding the intricacies of the problem, in which case I apologise for interrupting. Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 09 March 2018 08:16 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, okay, thanks. BTW: I still have no good idea how to solve the problem with the spike at node 1270407079. The attached screen shots show the problem. The coloured lines are the input. Many very short ways and all points are far from the Garmin grid points. The picture before.png shows the input to WrongAngleFixer (WAF), the after.png the output. The output is a bit better, but no improvement regarding the spike. I think WAF should collapse the two ways (111528849 and 111528851) which build the spike. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Donnerstag, 8. März 2018 20:47:39 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Thanks Gerd, I will do some tests on Saturday and then report back. Felix On 8 March 2018 at 11:46, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, attached is a patch that improves WrongAngleFixer. When both ways build a junction and both have another point close to that junction and in OSM they are different nodes mkgmap tries harder to avoid that they are rounded to the same coordinate. This is what happened with these two nodes https://www.openstreetmap.org/node/1263658804 https://www.openstreetmap.org/node/1195812701 I found similar situations at some roundabouts, sometimes a way connected to the roundabout and the roundabout way overlap. I am not sure how this patch works with your style, please try it with r4131. A few special cases to look at: https://www.openstreetmap.org/way/208976154 Coordinates: 38.4082747, 16.0787201 https://www.openstreetmap.org/way/312642720 Coordinates: 39.0259441, 8.5967561 https://www.openstreetmap.org/way/148634420 Coordinates: 41.981263, 12.4114831 Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgm ap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Samstag, 3. März 2018 19:49:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. well in general 0x16 is not avoided by any transport means (or at least it was not a couple of years ago when I checked the influence of types= - that's strange. 0x01 and 0x02 are avoided by bicycle - but in general I never use avoidances except toll and unpaved - they are pretty straight forward. I should do some checks again if something changed with activity routing over the years. If 6 ways on top of each other are routable problems are common (but do not have to occur - not sure why). (oh yeah I forgot to say to add the route=hiking to relations file, I assumed that is clear as it's a route and they are always relations). On 3 March 2018 at 15:27, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>
wrote: Hi Felix,
okay, found out again why merging before angle fixing doesn't work, but I still have no clue why this junction would cause trouble reg. routing with a normal mkgmap binary. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-b ounces@lists.mkgmap.org.uk>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>
Gesendet: Samstag, 3. März 2018 11:34:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, I just noted that I got my results reg. the modified default style with a modified StyledConverter which does the road merging before the wrong angle fixing. Something goes very wrong with this patched version. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-b ounces@lists.mkgmap.org.uk>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>
Gesendet: Samstag, 3. März 2018 11:01:42 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, no, it is just special at this juntion because the other ways have 0x8 or 0x13. On thursday I wrote that I was able to reproduce a problem at this junction but I forgot to set up routing for car (automotive) :-( I can reproduce a problem with "tour cycling", but I think that is expected with your style, because it avoids main roads by default. Maybe your users made the same error? You suggested to add route=hiking [0x13 road_class=4 road_speed=2 resolution 24 continue] to reproduce a problem. I tried that with no effect. Only after I added a rule in the relations file: type=route & route=hiking { apply { add route=hiking } } With that I see additional routable lines in the map and routing is more less broken at node 412440328 when I try to route from north to anywhere below the node , also the inverse way doesn't work. I tried different variants of the rule like other types or other road classes, always saw the same problem. I see working routing again when I remove way 130665733 from the input file and move node 1263658617 down to 412440328 and merge them (see attached file). I'll try to find out why this is so special in this situation. ciao, Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-b ounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarve r@gmail.com<mailto:extremecarver@gmail.com>>> Gesendet: Freitag, 2. März 2018 22:21:35 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Well in general 0x16 does not cause any problems. Do you think if I use another type instead (e.g.) 0x13 it won't be problematic, or do you mean that the 0x16 in itself is the problem? On 1 March 2018 at 18:55, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> <mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.c om><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmai l.com>>>> wrote: Hi Felix, okay, I think I can reproduce a routing problem on my Oregon with your map. I have a route that works from south to north but not in the reverse direction. I'll try to create a similar situation with a modified default style to find out what the problem is. My current prime suspect is the way with type 0x16. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-b ounces@lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<m ailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@list s.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarve r@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremecarver@gmail.com< mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extrem ecarver@gmail.com>>>> Gesendet: Donnerstag, 1. März 2018 18:09:02 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. routing issues is on devices only - not in Basecamp. Reported so far from Oregon and Edge - routing from North to East over that road. Well what I thought was that mkgmap should check if another road is put above. Right now it's 1 road supposed to be there, 2 and 3 roads overlapping due to that road being too short. Those overlapping somehow would need to be removed (and yes I know they are originally not the same line). My style should I think in maximum create 4 routable lines - however due to overlapping of other lines (due to the sub 4.3m line) it ends up a short stretch with more than 5 routable lines. On 1 March 2018 at 17:47, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> <mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.c om><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmai l.com>>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@h otmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenche n@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_mue nchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_ muenchen@hotmail.com>>>>> wrote: Hi Felix, Felix Hartmann-2 wrote
Okay - no-merge-lines makes no difference, also removing addArcsToMajorRoads(); function makes no difference. And I just noticed - the patch does not work. It works in it's own way - but not achieving the result that is needed. Whatever I do - I still end up with 6 routable lines.
I guess the patch checks for each road that it is not more than 4 times in the map. So I end up with 1, 2, and 3 (1 that is supposed to be in the map, 2 from the east not supposed, and 3 from the south, not supposed). (always using gpsmapedit to check results).
yes, that is what it does. Didn't you suggest something like that? You still did not tell me how I can reproduce a crash with this data, so I can only guess. I didn't see any routing issues so far with your maps, only the ugly rendering. Is this the only problem or is there really a routing issue? If yes, please let me know how to reproduce it. Gerd -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mail to:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mai lto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>>< mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> <mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org. uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org .uk>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mail to:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mai lto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Mike, the problem in the sample is that there are 5 ways, each with 2 nodes. So, we cannot delete any node without also deleting the corresponding way, and that would mean that we might remove important routing information. Besides that you are right, we have to detect that spike. I just think that the solution is to move all nodes to the same Garmin point, so we have two ways at that single point. Anyway, I just found a stupid bug when handling two points rounded to the same Garmin point and that bug causes some of the poor results. In line 1213 it should be if (c.getDistToDisplayedPoint() >= n.getDistToDisplayedPoint()) instead of if (c.getDistToDisplayedPoint() < n.getDistToDisplayedPoint()) I am now trying to find out what other code might be removed when this error is fixed... Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Freitag, 9. März 2018 17:01:27 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Gerd, I don't know anything about this bit of code, but the problem in the before and after pictures look to me like they are not the result of attempting to fix the angle, but look like they are the result of the second and fourth nodes in the spur both rounding to the same point, and it seems to me that the solution is to detect that the way has gone back on itself, and delete the intermediate node. If there are no junctions between two points that loop back on themselves, they should be able to be safely deleted before they are passed to WAF. Of course, I may be completely misunderstanding the intricacies of the problem, in which case I apologise for interrupting. Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 09 March 2018 08:16 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, okay, thanks. BTW: I still have no good idea how to solve the problem with the spike at node 1270407079. The attached screen shots show the problem. The coloured lines are the input. Many very short ways and all points are far from the Garmin grid points. The picture before.png shows the input to WrongAngleFixer (WAF), the after.png the output. The output is a bit better, but no improvement regarding the spike. I think WAF should collapse the two ways (111528849 and 111528851) which build the spike. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Donnerstag, 8. März 2018 20:47:39 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Thanks Gerd, I will do some tests on Saturday and then report back. Felix On 8 March 2018 at 11:46, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, attached is a patch that improves WrongAngleFixer. When both ways build a junction and both have another point close to that junction and in OSM they are different nodes mkgmap tries harder to avoid that they are rounded to the same coordinate. This is what happened with these two nodes https://www.openstreetmap.org/node/1263658804 https://www.openstreetmap.org/node/1195812701 I found similar situations at some roundabouts, sometimes a way connected to the roundabout and the roundabout way overlap. I am not sure how this patch works with your style, please try it with r4131. A few special cases to look at: https://www.openstreetmap.org/way/208976154 Coordinates: 38.4082747, 16.0787201 https://www.openstreetmap.org/way/312642720 Coordinates: 39.0259441, 8.5967561 https://www.openstreetmap.org/way/148634420 Coordinates: 41.981263, 12.4114831 Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgm ap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Samstag, 3. März 2018 19:49:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. well in general 0x16 is not avoided by any transport means (or at least it was not a couple of years ago when I checked the influence of types= - that's strange. 0x01 and 0x02 are avoided by bicycle - but in general I never use avoidances except toll and unpaved - they are pretty straight forward. I should do some checks again if something changed with activity routing over the years. If 6 ways on top of each other are routable problems are common (but do not have to occur - not sure why). (oh yeah I forgot to say to add the route=hiking to relations file, I assumed that is clear as it's a route and they are always relations). On 3 March 2018 at 15:27, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>
wrote: Hi Felix,
okay, found out again why merging before angle fixing doesn't work, but I still have no clue why this junction would cause trouble reg. routing with a normal mkgmap binary. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-b ounces@lists.mkgmap.org.uk>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>
Gesendet: Samstag, 3. März 2018 11:34:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, I just noted that I got my results reg. the modified default style with a modified StyledConverter which does the road merging before the wrong angle fixing. Something goes very wrong with this patched version. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-b ounces@lists.mkgmap.org.uk>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>
Gesendet: Samstag, 3. März 2018 11:01:42 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, no, it is just special at this juntion because the other ways have 0x8 or 0x13. On thursday I wrote that I was able to reproduce a problem at this junction but I forgot to set up routing for car (automotive) :-( I can reproduce a problem with "tour cycling", but I think that is expected with your style, because it avoids main roads by default. Maybe your users made the same error? You suggested to add route=hiking [0x13 road_class=4 road_speed=2 resolution 24 continue] to reproduce a problem. I tried that with no effect. Only after I added a rule in the relations file: type=route & route=hiking { apply { add route=hiking } } With that I see additional routable lines in the map and routing is more less broken at node 412440328 when I try to route from north to anywhere below the node , also the inverse way doesn't work. I tried different variants of the rule like other types or other road classes, always saw the same problem. I see working routing again when I remove way 130665733 from the input file and move node 1263658617 down to 412440328 and merge them (see attached file). I'll try to find out why this is so special in this situation. ciao, Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-b ounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarve r@gmail.com<mailto:extremecarver@gmail.com>>> Gesendet: Freitag, 2. März 2018 22:21:35 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Well in general 0x16 does not cause any problems. Do you think if I use another type instead (e.g.) 0x13 it won't be problematic, or do you mean that the 0x16 in itself is the problem? On 1 March 2018 at 18:55, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> <mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.c om><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmai l.com>>>> wrote: Hi Felix, okay, I think I can reproduce a routing problem on my Oregon with your map. I have a route that works from south to north but not in the reverse direction. I'll try to create a similar situation with a modified default style to find out what the problem is. My current prime suspect is the way with type 0x16. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-b ounces@lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<m ailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@list s.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarve r@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremecarver@gmail.com< mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extrem ecarver@gmail.com>>>> Gesendet: Donnerstag, 1. März 2018 18:09:02 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. routing issues is on devices only - not in Basecamp. Reported so far from Oregon and Edge - routing from North to East over that road. Well what I thought was that mkgmap should check if another road is put above. Right now it's 1 road supposed to be there, 2 and 3 roads overlapping due to that road being too short. Those overlapping somehow would need to be removed (and yes I know they are originally not the same line). My style should I think in maximum create 4 routable lines - however due to overlapping of other lines (due to the sub 4.3m line) it ends up a short stretch with more than 5 routable lines. On 1 March 2018 at 17:47, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> <mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.c om><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmai l.com>>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@h otmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenche n@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_mue nchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_ muenchen@hotmail.com>>>>> wrote: Hi Felix, Felix Hartmann-2 wrote
Okay - no-merge-lines makes no difference, also removing addArcsToMajorRoads(); function makes no difference. And I just noticed - the patch does not work. It works in it's own way - but not achieving the result that is needed. Whatever I do - I still end up with 6 routable lines.
I guess the patch checks for each road that it is not more than 4 times in the map. So I end up with 1, 2, and 3 (1 that is supposed to be in the map, 2 from the east not supposed, and 3 from the south, not supposed). (always using gpsmapedit to check results).
yes, that is what it does. Didn't you suggest something like that? You still did not tell me how I can reproduce a crash with this data, so I can only guess. I didn't see any routing issues so far with your maps, only the ugly rendering. Is this the only problem or is there really a routing issue? If yes, please let me know how to reproduce it. Gerd -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mail to:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mai lto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>>< mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> <mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org. uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org .uk>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mail to:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mai lto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd, I just tried the patched version - and I'm not sure if what I got is intended... Actually the problematic roads now end up not routable at all, meaning in many cases I don't get a routable road at all. I only end up with one instance for each road, or for the hiking route. That one instance is often just used to display (non routable type) while the routable type itself is missing. ( I compiled mkgmap on my laptop with java 9 - if that could possibly cause this behaviour please tell, then I will roll back to java 8) On 9 March 2018 at 17:12, Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote:
Hi Mike,
the problem in the sample is that there are 5 ways, each with 2 nodes. So, we cannot delete any node without also deleting the corresponding way, and that would mean that we might remove important routing information.
Besides that you are right, we have to detect that spike. I just think that the solution is to move all nodes to the same Garmin point, so we have two ways at that single point.
Anyway, I just found a stupid bug when handling two points rounded to the same Garmin point and that bug causes some of the poor results. In line 1213 it should be if (c.getDistToDisplayedPoint() >= n.getDistToDisplayedPoint()) instead of if (c.getDistToDisplayedPoint() < n.getDistToDisplayedPoint())
I am now trying to find out what other code might be removed when this error is fixed...
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Freitag, 9. März 2018 17:01:27 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Gerd, I don't know anything about this bit of code, but the problem in the before and after pictures look to me like they are not the result of attempting to fix the angle, but look like they are the result of the second and fourth nodes in the spur both rounding to the same point, and it seems to me that the solution is to detect that the way has gone back on itself, and delete the intermediate node. If there are no junctions between two points that loop back on themselves, they should be able to be safely deleted before they are passed to WAF. Of course, I may be completely misunderstanding the intricacies of the problem, in which case I apologise for interrupting.
Cheers, Mike
-----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 09 March 2018 08:16 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix,
okay, thanks. BTW: I still have no good idea how to solve the problem with the spike at node 1270407079. The attached screen shots show the problem. The coloured lines are the input. Many very short ways and all points are far from the Garmin grid points. The picture before.png shows the input to WrongAngleFixer (WAF), the after.png the output. The output is a bit better, but no improvement regarding the spike. I think WAF should collapse the two ways (111528849 and 111528851) which build the spike.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Donnerstag, 8. März 2018 20:47:39 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Thanks Gerd, I will do some tests on Saturday and then report back.
Felix
On 8 March 2018 at 11:46, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix,
attached is a patch that improves WrongAngleFixer. When both ways build a junction and both have another point close to that junction and in OSM they are different nodes mkgmap tries harder to avoid that they are rounded to the same coordinate. This is what happened with these two nodes https://www.openstreetmap.org/node/1263658804 https://www.openstreetmap.org/node/1195812701
I found similar situations at some roundabouts, sometimes a way connected to the roundabout and the roundabout way overlap. I am not sure how this patch works with your style, please try it with r4131.
A few special cases to look at: https://www.openstreetmap.org/way/208976154 Coordinates: 38.4082747, 16.0787201 https://www.openstreetmap.org/way/312642720 Coordinates: 39.0259441, 8.5967561 https://www.openstreetmap.org/way/148634420 Coordinates: 41.981263, 12.4114831
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgm ap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Samstag, 3. März 2018 19:49:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
well in general 0x16 is not avoided by any transport means (or at least it was not a couple of years ago when I checked the influence of types= - that's strange. 0x01 and 0x02 are avoided by bicycle - but in general I never use avoidances except toll and unpaved - they are pretty straight forward. I should do some checks again if something changed with activity routing over the years. If 6 ways on top of each other are routable problems are common (but do not have to occur - not sure why).
(oh yeah I forgot to say to add the route=hiking to relations file, I assumed that is clear as it's a route and they are always relations).
On 3 March 2018 at 15:27, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
<mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
wrote: Hi Felix,
okay, found out again why merging before angle fixing doesn't work, but I still have no clue why this junction would cause trouble reg. routing with a normal mkgmap binary.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-b ounces@lists.mkgmap.org.uk>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
<mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
Gesendet: Samstag, 3. März 2018 11:34:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix,
I just noted that I got my results reg. the modified default style with a modified StyledConverter which does the road merging before the wrong angle fixing. Something goes very wrong with this patched version.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-b ounces@lists.mkgmap.org.uk>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
<mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
Gesendet: Samstag, 3. März 2018 11:01:42 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix,
no, it is just special at this juntion because the other ways have 0x8 or 0x13. On thursday I wrote that I was able to reproduce a problem at this junction but I forgot to set up routing for car (automotive) :-( I can reproduce a problem with "tour cycling", but I think that is expected with your style, because it avoids main roads by default. Maybe your users made the same error?
You suggested to add route=hiking [0x13 road_class=4 road_speed=2 resolution 24 continue] to reproduce a problem. I tried that with no effect. Only after I added a rule in the relations file: type=route & route=hiking { apply { add route=hiking } } With that I see additional routable lines in the map and routing is more less broken at node 412440328 when I try to route from north to anywhere below the node , also the inverse way doesn't work. I tried different variants of the rule like other types or other road classes, always saw the same problem. I see working routing again when I remove way 130665733 from the input file and move node 1263658617 down to 412440328 and merge them (see attached file). I'll try to find out why this is so special in this situation.
ciao, Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-b ounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto: extremecarve r@gmail.com<mailto:extremecarver@gmail.com>>> Gesendet: Freitag, 2. März 2018 22:21:35 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Well in general 0x16 does not cause any problems. Do you think if I use another type instead (e.g.) 0x13 it won't be problematic, or do you mean that the 0x16 in itself is the problem?
On 1 March 2018 at 18:55, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
<mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
<mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_ muenchen@hotmail.c om><mailto:gpetermann_muenchen@hotmail.com<mailto:gp etermann_muenchen@hotmai l.com>>>> wrote: Hi Felix,
okay, I think I can reproduce a routing problem on my Oregon with your map. I have a route that works from south to north but not in the reverse direction. I'll try to create a similar situation with a modified default style to find out what the problem is. My current prime suspect is the way with type 0x16.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-b ounces@lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk <m ailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mk gmap-dev-bounces@list s.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto: extremecarve r@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremec arver@gmail.com< mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto: extrem ecarver@gmail.com>>>> Gesendet: Donnerstag, 1. März 2018 18:09:02 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
routing issues is on devices only - not in Basecamp. Reported so far from Oregon and Edge - routing from North to East over that road.
Well what I thought was that mkgmap should check if another road is put above. Right now it's 1 road supposed to be there, 2 and 3 roads overlapping due to that road being too short. Those overlapping somehow would need to be removed (and yes I know they are originally not the same line). My style should I think in maximum create 4 routable lines - however due to overlapping of other lines (due to the sub 4.3m line) it ends up a short stretch with more than 5 routable lines.
On 1 March 2018 at 17:47, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
<mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
<mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_ muenchen@hotmail.c om><mailto:gpetermann_muenchen@hotmail.com<mailto:gp etermann_muenchen@hotmai l.com>>><mailto:gpetermann_muenchen@hotmail.com<mailto:gp etermann_muenchen@h otmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gp etermann_muenche n@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto: gpetermann_mue nchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto: gpetermann_ muenchen@hotmail.com>>>>> wrote: Hi Felix,
Felix Hartmann-2 wrote
Okay - no-merge-lines makes no difference, also removing addArcsToMajorRoads(); function makes no difference. And I just noticed - the patch does not work. It works in it's own way - but not achieving the result that is needed. Whatever I do - I still end up with 6 routable lines.
I guess the patch checks for each road that it is not more than 4 times in the map. So I end up with 1, 2, and 3 (1 that is supposed to be in the map, 2 from the east not supposed, and 3 from the south, not supposed). (always using gpsmapedit to check results).
yes, that is what it does. Didn't you suggest something like that?
You still did not tell me how I can reproduce a crash with this data, so I can only guess. I didn't see any routing issues so far with your maps, only the ugly rendering. Is this the only problem or is there really a routing issue? If yes, please let me know how to reproduce it.
Gerd
-- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mail to:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk <mai lto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
< mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap- dev@lists.mkgmap.org.uk> <mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap- dev@lists.mkgmap.org.uk <mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap- dev@lists.mkgmap.org. uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap- dev@lists.mkgmap.org .uk>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mail to:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk <mai lto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Felix, I assume that you either have other patches active as well or you changed your style, anyway, I am working on a better version but don't have much time this weekend. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Samstag, 10. März 2018 17:54:53 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Gerd, I just tried the patched version - and I'm not sure if what I got is intended... Actually the problematic roads now end up not routable at all, meaning in many cases I don't get a routable road at all. I only end up with one instance for each road, or for the hiking route. That one instance is often just used to display (non routable type) while the routable type itself is missing. ( I compiled mkgmap on my laptop with java 9 - if that could possibly cause this behaviour please tell, then I will roll back to java 8) On 9 March 2018 at 17:12, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Mike, the problem in the sample is that there are 5 ways, each with 2 nodes. So, we cannot delete any node without also deleting the corresponding way, and that would mean that we might remove important routing information. Besides that you are right, we have to detect that spike. I just think that the solution is to move all nodes to the same Garmin point, so we have two ways at that single point. Anyway, I just found a stupid bug when handling two points rounded to the same Garmin point and that bug causes some of the poor results. In line 1213 it should be if (c.getDistToDisplayedPoint() >= n.getDistToDisplayedPoint()) instead of if (c.getDistToDisplayedPoint() < n.getDistToDisplayedPoint()) I am now trying to find out what other code might be removed when this error is fixed... Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Mike Baggaley <mike@tvage.co.uk<mailto:mike@tvage.co.uk>> Gesendet: Freitag, 9. März 2018 17:01:27 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Gerd, I don't know anything about this bit of code, but the problem in the before and after pictures look to me like they are not the result of attempting to fix the angle, but look like they are the result of the second and fourth nodes in the spur both rounding to the same point, and it seems to me that the solution is to detect that the way has gone back on itself, and delete the intermediate node. If there are no junctions between two points that loop back on themselves, they should be able to be safely deleted before they are passed to WAF. Of course, I may be completely misunderstanding the intricacies of the problem, in which case I apologise for interrupting. Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>] Sent: 09 March 2018 08:16 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> Subject: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, okay, thanks. BTW: I still have no good idea how to solve the problem with the spike at node 1270407079. The attached screen shots show the problem. The coloured lines are the input. Many very short ways and all points are far from the Garmin grid points. The picture before.png shows the input to WrongAngleFixer (WAF), the after.png the output. The output is a bit better, but no improvement regarding the spike. I think WAF should collapse the two ways (111528849 and 111528851) which build the spike. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Donnerstag, 8. März 2018 20:47:39 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Thanks Gerd, I will do some tests on Saturday and then report back. Felix On 8 March 2018 at 11:46, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix, attached is a patch that improves WrongAngleFixer. When both ways build a junction and both have another point close to that junction and in OSM they are different nodes mkgmap tries harder to avoid that they are rounded to the same coordinate. This is what happened with these two nodes https://www.openstreetmap.org/node/1263658804 https://www.openstreetmap.org/node/1195812701 I found similar situations at some roundabouts, sometimes a way connected to the roundabout and the roundabout way overlap. I am not sure how this patch works with your style, please try it with r4131. A few special cases to look at: https://www.openstreetmap.org/way/208976154 Coordinates: 38.4082747, 16.0787201 https://www.openstreetmap.org/way/312642720 Coordinates: 39.0259441, 8.5967561 https://www.openstreetmap.org/way/148634420 Coordinates: 41.981263, 12.4114831 Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgm<mailto:mkgmap-dev-bounces@lists.mkgm> ap.org.uk<http://ap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> Gesendet: Samstag, 3. März 2018 19:49:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. well in general 0x16 is not avoided by any transport means (or at least it was not a couple of years ago when I checked the influence of types= - that's strange. 0x01 and 0x02 are avoided by bicycle - but in general I never use avoidances except toll and unpaved - they are pretty straight forward. I should do some checks again if something changed with activity routing over the years. If 6 ways on top of each other are routable problems are common (but do not have to occur - not sure why). (oh yeah I forgot to say to add the route=hiking to relations file, I assumed that is clear as it's a route and they are always relations). On 3 March 2018 at 15:27, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mai lto:gpetermann_muenchen@hotmail.com<mailto:lto%3Agpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>>
wrote: Hi Felix,
okay, found out again why merging before angle fixing doesn't work, but I still have no clue why this junction would cause trouble reg. routing with a normal mkgmap binary. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgm<mailto:mkgmap-dev-bounces@lists.mkgm> ap.org.uk<http://ap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-b<mailto:mkgmap-dev-b> ounces@lists.mkgmap.org.uk<mailto:ounces@lists.mkgmap.org.uk>>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mai lto:gpetermann_muenchen@hotmail.com<mailto:lto%3Agpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>>
Gesendet: Samstag, 3. März 2018 11:34:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, I just noted that I got my results reg. the modified default style with a modified StyledConverter which does the road merging before the wrong angle fixing. Something goes very wrong with this patched version. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgm<mailto:mkgmap-dev-bounces@lists.mkgm> ap.org.uk<http://ap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-b<mailto:mkgmap-dev-b> ounces@lists.mkgmap.org.uk<mailto:ounces@lists.mkgmap.org.uk>>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mai lto:gpetermann_muenchen@hotmail.com<mailto:lto%3Agpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>>
Gesendet: Samstag, 3. März 2018 11:01:42 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, no, it is just special at this juntion because the other ways have 0x8 or 0x13. On thursday I wrote that I was able to reproduce a problem at this junction but I forgot to set up routing for car (automotive) :-( I can reproduce a problem with "tour cycling", but I think that is expected with your style, because it avoids main roads by default. Maybe your users made the same error? You suggested to add route=hiking [0x13 road_class=4 road_speed=2 resolution 24 continue] to reproduce a problem. I tried that with no effect. Only after I added a rule in the relations file: type=route & route=hiking { apply { add route=hiking } } With that I see additional routable lines in the map and routing is more less broken at node 412440328 when I try to route from north to anywhere below the node , also the inverse way doesn't work. I tried different variants of the rule like other types or other road classes, always saw the same problem. I see working routing again when I remove way 130665733 from the input file and move node 1263658617 down to 412440328 and merge them (see attached file). I'll try to find out why this is so special in this situation. ciao, Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgm<mailto:mkgmap-dev-bounces@lists.mkgm> ap.org.uk<http://ap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-b<mailto:mkgmap-dev-b> ounces@lists.mkgmap.org.uk<mailto:ounces@lists.mkgmap.org.uk>>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremecarve<mailto:extremecarve> r@gmail.com<mailto:r@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>>> Gesendet: Freitag, 2. März 2018 22:21:35 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Well in general 0x16 does not cause any problems. Do you think if I use another type instead (e.g.) 0x13 it won't be problematic, or do you mean that the 0x16 in itself is the problem? On 1 March 2018 at 18:55, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mai lto:gpetermann_muenchen@hotmail.com<mailto:lto%3Agpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> <mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.c<mailto:gpetermann_muenchen@hotmail.c> om><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmai<mailto:gpetermann_muenchen@hotmai> l.com<http://l.com>>>>> wrote: Hi Felix, okay, I think I can reproduce a routing problem on my Oregon with your map. I have a route that works from south to north but not in the reverse direction. I'll try to create a similar situation with a modified default style to find out what the problem is. My current prime suspect is the way with type 0x16. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgm<mailto:mkgmap-dev-bounces@lists.mkgm> ap.org.uk<http://ap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-b<mailto:mkgmap-dev-b> ounces@lists.mkgmap.org.uk<mailto:ounces@lists.mkgmap.org.uk>>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><m ailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:ailto%3Amkgmap-dev-bounces@lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces@list<mailto:mkgmap-dev-bounces@list> s.mkgmap.org.uk<http://s.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremecarve<mailto:extremecarve> r@gmail.com<mailto:r@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>< mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extrem<mailto:extrem> ecarver@gmail.com<mailto:ecarver@gmail.com>>>>> Gesendet: Donnerstag, 1. März 2018 18:09:02 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. routing issues is on devices only - not in Basecamp. Reported so far from Oregon and Edge - routing from North to East over that road. Well what I thought was that mkgmap should check if another road is put above. Right now it's 1 road supposed to be there, 2 and 3 roads overlapping due to that road being too short. Those overlapping somehow would need to be removed (and yes I know they are originally not the same line). My style should I think in maximum create 4 routable lines - however due to overlapping of other lines (due to the sub 4.3m line) it ends up a short stretch with more than 5 routable lines. On 1 March 2018 at 17:47, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>><mai lto:gpetermann_muenchen@hotmail.com<mailto:lto%3Agpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> <mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.c<mailto:gpetermann_muenchen@hotmail.c> om><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmai<mailto:gpetermann_muenchen@hotmai> l.com<http://l.com>>>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@h<mailto:gpetermann_muenchen@h> otmail.com<http://otmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenche<mailto:gpetermann_muenche> n@hotmail.com<mailto:n@hotmail.com>>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_mue<mailto:gpetermann_mue> nchen@hotmail.com<mailto:nchen@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_<mailto:gpetermann_> muenchen@hotmail.com<mailto:muenchen@hotmail.com>>>>>> wrote: Hi Felix, Felix Hartmann-2 wrote
Okay - no-merge-lines makes no difference, also removing addArcsToMajorRoads(); function makes no difference. And I just noticed - the patch does not work. It works in it's own way - but not achieving the result that is needed. Whatever I do - I still end up with 6 routable lines.
I guess the patch checks for each road that it is not more than 4 times in the map. So I end up with 1, 2, and 3 (1 that is supposed to be in the map, 2 from the east not supposed, and 3 from the south, not supposed). (always using gpsmapedit to check results).
yes, that is what it does. Didn't you suggest something like that? You still did not tell me how I can reproduce a crash with this data, so I can only guess. I didn't see any routing issues so far with your maps, only the ugly rendering. Is this the only problem or is there really a routing issue? If yes, please let me know how to reproduce it. Gerd -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>><mail to:mkgmap-dev@lists.mkgmap.org.uk<mailto:to%3Amkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mai lto:mkgmap-dev@lists.mkgmap.org.uk<mailto:lto%3Amkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>>>< mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> <mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org<mailto:mkgmap-dev@lists.mkgmap.org>. uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org<mailto:mkgmap-dev@lists.mkgmap.org> .uk>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>><mail to:mkgmap-dev@lists.mkgmap.org.uk<mailto:to%3Amkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mai lto:mkgmap-dev@lists.mkgmap.org.uk<mailto:lto%3Amkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
On 10 March 2018 at 18:28, Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote:
Hi Felix,
I assume that you either have other patches active as well or you changed your style, anyway, I am working on a better version but don't have much time this weekend.
Gerd
Hallo Gerd, No I have no other patches active - well if you work on a better version I will wait before I roll back to java 8 for checking it up. I haven't found any info about mkgmap compatibility with java 9 so far. And style is unchanged. Felix
Hi Felix, please double check. The patch should not have such an effect, at least not in general. Maybe you changed the routing options? Gerd -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html
Hi Gerd, oh - I had a different layout in gpsmapedit with 0x13 set to invisible and not used to opening gpsmapedit from my laptop. So the map was actually correct: https://www.openstreetmap.org/node/1263658804 https://www.openstreetmap.org/node/1195812701 is now fine - though of course the visible rendering is not really representing how it looks in reality - but broken routing is fixed. https://www.openstreetmap.org/node/1270407079 as you said is still spiking - and actually with my style in that case also wrongly ending up in 6 routable lines. For me really a simple remove all semi connected ways at minimum length filter would be fine. I would just remove clutter of micromapping. As for the roundabouts. 1. https://www.openstreetmap.org/way/208976154 looks fine - just strange that way https://www.openstreetmap. org/way/447282006 is not merged - all the others are merged. 2. https://www.openstreetmap.org/way/312642720 a bit strange that it gets split into 2 ways. Routing seems fine. (the NNE section of the roundabout between the exit and entry is separated) 3. https://www.openstreetmap.org/way/148634420 actually looks much better then with older versions of mkgmap. Looks pretty round - with a 3 month old mkgmap version (sorry don't have unpatched to compare) it was not very round. Routing is fine. Although here the north section is split off into a seperate way- it this a need for roundabouts? Felix On 10 March 2018 at 18:36, Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote:
Hi Felix,
please double check. The patch should not have such an effect, at least not in general. Maybe you changed the routing options?
Gerd
-- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Felix, thanks for testing. Yes, roundabouts have to be split as well as all other closed or self intersecting ways. I guess the img format does not allow closed arcs. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Sonntag, 11. März 2018 15:13:06 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Gerd, oh - I had a different layout in gpsmapedit with 0x13 set to invisible and not used to opening gpsmapedit from my laptop. So the map was actually correct: https://www.openstreetmap.org/node/1263658804 https://www.openstreetmap.org/node/1195812701 is now fine - though of course the visible rendering is not really representing how it looks in reality - but broken routing is fixed. https://www.openstreetmap.org/node/1270407079 as you said is still spiking - and actually with my style in that case also wrongly ending up in 6 routable lines. For me really a simple remove all semi connected ways at minimum length filter would be fine. I would just remove clutter of micromapping. As for the roundabouts. 1. https://www.openstreetmap.org/way/208976154 looks fine - just strange that way https://www.openstreetmap.org/way/447282006 is not merged - all the others are merged. 2. https://www.openstreetmap.org/way/312642720 a bit strange that it gets split into 2 ways. Routing seems fine. (the NNE section of the roundabout between the exit and entry is separated) 3. https://www.openstreetmap.org/way/148634420 actually looks much better then with older versions of mkgmap. Looks pretty round - with a 3 month old mkgmap version (sorry don't have unpatched to compare) it was not very round. Routing is fine. Although here the north section is split off into a seperate way- it this a need for roundabouts? Felix On 10 March 2018 at 18:36, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, please double check. The patch should not have such an effect, at least not in general. Maybe you changed the routing options? Gerd -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Felix, attached is a patch that prints an error message when a route node has 4 or more arcs with the same initial bearing.
From your previous posts I understand that this might be the cause for crashes in the device. Please try the patch with r4135 from the angles branch. If it prints messages please try if you can reproduce crashes. The message might look like this: 4 or more arcs with the same initial bearing, expect routing problems at 41.833628,12.887826 when routing to 20° (http://www.openstreetmap.org/browse/way/198926993) The reported way id might not be correct when RoadMerger combined the reported way with others.
Maybe we have to separate forward and backward arcs, in this case the code might produce too many warnings. Once we know what exactly is causing trouble we may be able to find code to avoid it. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com> Gesendet: Sonntag, 11. März 2018 16:39:47 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, thanks for testing. Yes, roundabouts have to be split as well as all other closed or self intersecting ways. I guess the img format does not allow closed arcs. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Sonntag, 11. März 2018 15:13:06 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Gerd, oh - I had a different layout in gpsmapedit with 0x13 set to invisible and not used to opening gpsmapedit from my laptop. So the map was actually correct: https://www.openstreetmap.org/node/1263658804 https://www.openstreetmap.org/node/1195812701 is now fine - though of course the visible rendering is not really representing how it looks in reality - but broken routing is fixed. https://www.openstreetmap.org/node/1270407079 as you said is still spiking - and actually with my style in that case also wrongly ending up in 6 routable lines. For me really a simple remove all semi connected ways at minimum length filter would be fine. I would just remove clutter of micromapping. As for the roundabouts. 1. https://www.openstreetmap.org/way/208976154 looks fine - just strange that way https://www.openstreetmap.org/way/447282006 is not merged - all the others are merged. 2. https://www.openstreetmap.org/way/312642720 a bit strange that it gets split into 2 ways. Routing seems fine. (the NNE section of the roundabout between the exit and entry is separated) 3. https://www.openstreetmap.org/way/148634420 actually looks much better then with older versions of mkgmap. Looks pretty round - with a 3 month old mkgmap version (sorry don't have unpatched to compare) it was not very round. Routing is fine. Although here the north section is split off into a seperate way- it this a need for roundabouts? Felix On 10 March 2018 at 18:36, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, please double check. The patch should not have such an effect, at least not in general. Maybe you changed the routing options? Gerd -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd, I get a huge huge list - and the ones I tried seemed to be quite alright - but the couple that I checked where simply ways that my styles inserts at least 3-4 times (usually ways with hiking/mtb route). Should I increase the counter in the patch to 5 (I guess still alright) or to 6 (I'm pretty sure I get routing errors then)? Felix On 13 March 2018 at 11:03, Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote:
Hi Felix,
attached is a patch that prints an error message when a route node has 4 or more arcs with the same initial bearing. From your previous posts I understand that this might be the cause for crashes in the device. Please try the patch with r4135 from the angles branch. If it prints messages please try if you can reproduce crashes. The message might look like this: 4 or more arcs with the same initial bearing, expect routing problems at 41.833628,12.887826 when routing to 20° (http://www.openstreetmap.org/ browse/way/198926993) The reported way id might not be correct when RoadMerger combined the reported way with others.
Maybe we have to separate forward and backward arcs, in this case the code might produce too many warnings. Once we know what exactly is causing trouble we may be able to find code to avoid it.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com> Gesendet: Sonntag, 11. März 2018 16:39:47 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix,
thanks for testing. Yes, roundabouts have to be split as well as all other closed or self intersecting ways. I guess the img format does not allow closed arcs.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Sonntag, 11. März 2018 15:13:06 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Gerd, oh - I had a different layout in gpsmapedit with 0x13 set to invisible and not used to opening gpsmapedit from my laptop. So the map was actually correct:
https://www.openstreetmap.org/node/1263658804 https://www.openstreetmap.org/node/1195812701 is now fine - though of course the visible rendering is not really representing how it looks in reality - but broken routing is fixed.
https://www.openstreetmap.org/node/1270407079 as you said is still spiking - and actually with my style in that case also wrongly ending up in 6 routable lines. For me really a simple remove all semi connected ways at minimum length filter would be fine. I would just remove clutter of micromapping.
As for the roundabouts. 1. https://www.openstreetmap.org/way/208976154 looks fine - just strange that way https://www.openstreetmap.org/ way/447282006 is not merged - all the others are merged.
2. https://www.openstreetmap.org/way/312642720 a bit strange that it gets split into 2 ways. Routing seems fine. (the NNE section of the roundabout between the exit and entry is separated)
3. https://www.openstreetmap.org/way/148634420 actually looks much better then with older versions of mkgmap. Looks pretty round - with a 3 month old mkgmap version (sorry don't have unpatched to compare) it was not very round. Routing is fine. Although here the north section is split off into a seperate way- it this a need for roundabouts?
Felix
On 10 March 2018 at 18:36, Gerd Petermann <gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix,
please double check. The patch should not have such an effect, at least not in general. Maybe you changed the routing options?
Gerd
-- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Felix, yes, change it to a gigher value first. Gerd Felix Hartmann-2 wrote
Hi Gerd,
I get a huge huge list - and the ones I tried seemed to be quite alright - but the couple that I checked where simply ways that my styles inserts at least 3-4 times (usually ways with hiking/mtb route). Should I increase the counter in the patch to 5 (I guess still alright) or to 6 (I'm pretty sure I get routing errors then)?
Felix
-- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html
Hi Felix, further thoughts about this: Up to now we concentrate on problems caused by rouding errors when OSM (~32 bit) coordinates are placed on the 24 Garmin raster. What about places where OSM data already contains overlapping highways? I think there is currently no code in mkgmap to handle this properly. Don't know if we can find rules to handle this, if not we should print warning messages, as it is likely to cause trouble. Overlapping can mean : * two different OSM ways with identical sequences of 2 or more nodes, e.g. a-b-c-d and x-b-c-y * two different OSM ways with identical sequences of 2 or more nodes, but in reversed order, e.g. a-b-c-d and x--d-c-y My understanding is that these are mapping errors, but as said before there is no code to detect this. There might be warnings, e.g. in the housenumber code. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com> Gesendet: Mittwoch, 14. März 2018 17:25:22 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, yes, change it to a gigher value first. Gerd Felix Hartmann-2 wrote
Hi Gerd,
I get a huge huge list - and the ones I tried seemed to be quite alright - but the couple that I checked where simply ways that my styles inserts at least 3-4 times (usually ways with hiking/mtb route). Should I increase the counter in the patch to 5 (I guess still alright) or to 6 (I'm pretty sure I get routing errors then)?
Felix
-- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Somehow the patch is putting out quite a bit stuff that seems fine even set to 10 - I did find one way that breaks routing on device though http://www.openstreetmap.org/browse/way/310376420 Something is really strange here - the problematic section is the bridge to the East, and with ID I cannot properly select it. Problematic tile: https://openmtbmap.org/63670040.img Routing over it on my Oregon 600 in simulation mode - it get's stuck as soon as it reaches the bridge. I have now changed my style, before if a route contained a bridge, there was supposed to be no extra routable line created for the bridge, this did not work in all cases due to the discussed bug. I changed my style to create no extra routable line for a bridge if part of a relation, but this did not work either, I'm still ending up with 8 routable lines instead of 3 for the bridge itself. Very strange. In general I think quite often it is adjoining ways that are more likely to be problematic. Not so easy what to do with all this long list as often it did not create more than 2-3 routable lines. The most were 8 (linked above). I'm now trying to see what it gives for my changed style. I did go through my style, and without this bug the style should create no more than 4 routable lines at most for a single street (yes this does not solve if there are two streets that get put on top of each other, because of super detailed mapping). However as in the above linked example that was not the case. This is a case where in OSM there is already overlapping data - I'll give it a better check tomorrow: https://www.openstreetmap.org/way/358035804#map=16/44.5885/7.8644 SEVERE (RouteNode): E:\openmtbmap\maps\63670018.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 41.099468,14.210138 when routing to 177░ (http://www.openstreetmap.org/ browse/way/231702644) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.594210,7.870896 when routing to 166░ (http://www.openstreetmap.org/ browse/way/268949386) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.594024,7.870959 when routing to 347░ (http://www.openstreetmap.org/ browse/way/268949386) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.589474,7.868189 when routing to 230░ (http://www.openstreetmap.org/ browse/way/358035804) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.595358,7.869657 when routing to 186░ (http://www.openstreetmap.org/ browse/way/358035804) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.593348,7.870952 when routing to 7░ (http://www.openstreetmap.org/ browse/way/268949386) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.528092,7.857529 when routing to 132░ (http://www.openstreetmap.org/browse/way/310376420) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.527925,7.857784 when routing to 313░ (http://www.openstreetmap.org/browse/way/310376420) SEVERE (RouteNode): E:\openmtbmap\maps\63670035.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.103926,10.499103 when routing to 12░ (http://www.openstreetmap.org/ browse/way/261283126) SEVERE (RouteNode): E:\openmtbmap\maps\63670036.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.197738,9.560527 when routing to 306░ (http://www.openstreetmap.org/ browse/way/216391711) SEVERE (RouteNode): E:\openmtbmap\maps\63670034.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.462818,10.589772 when routing to 260░ (http://www.openstreetmap.org/ browse/way/131304170) SEVERE (RouteNode): E:\openmtbmap\maps\63670054.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.658185,10.045777 when routing to 46░ (http://www.openstreetmap.org/browse/way/50847847) SEVERE (RouteNode): E:\openmtbmap\maps\63670057.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.171695,9.870816 when routing to 327░ (http://www.openstreetmap.org/ browse/way/503763128) SEVERE (RouteNode): E:\openmtbmap\maps\63670059.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.690630,9.675076 when routing to 248░ (http://www.openstreetmap.org/ browse/way/50730378) SEVERE (RouteNode): E:\openmtbmap\maps\63670067.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.142950,9.170384 when routing to 85░ (http://www.openstreetmap.org/ browse/way/243855717) SEVERE (RouteNode): E:\openmtbmap\maps\63670066.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.488240,9.195559 when routing to 201░ (http://www.openstreetmap.org/ browse/way/262420957) SEVERE (RouteNode): E:\openmtbmap\maps\63670066.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.488326,9.195591 when routing to 195░ (http://www.openstreetmap.org/ browse/way/262420957) SEVERE (RouteNode): E:\openmtbmap\maps\63670070.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.586536,8.924042 when routing to 235░ (http://www.openstreetmap.org/ browse/way/450869558) SEVERE (RouteNode): E:\openmtbmap\maps\63670072.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.598025,13.786274 when routing to 68░ (http://www.openstreetmap.org/ browse/way/26661412) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.736224,12.736811 when routing to 94░ (http://www.openstreetmap.org/ browse/way/444595723) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.736221,12.736862 when routing to 275░ (http://www.openstreetmap.org/ browse/way/444595723) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.733896,12.733320 when routing to 145░ (http://www.openstreetmap.org/ browse/way/166104158) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.733569,12.733668 when routing to 325░ (http://www.openstreetmap.org/ browse/way/166104158) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.735211,12.734411 when routing to 19░ (http://www.openstreetmap.org/browse/way/115921194) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.735631,12.734614 when routing to 19░ (http://www.openstreetmap.org/browse/way/115921194) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.737543,12.738809 when routing to 348░ (http://www.openstreetmap.org/ browse/way/205144591) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.991118,12.671455 when routing to 176░ (http://www.openstreetmap.org/ browse/way/226058688) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.990426,12.671494 when routing to 0░ (http://www.openstreetmap.org/ browse/way/226058688) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.733015,12.737255 when routing to 48░ (http://www.openstreetmap.org/ browse/way/394187014) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.737876,12.738618 when routing to 155░ (http://www.openstreetmap.org/ browse/way/205144591) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.735138,12. 735350 when routing to 19░ (http://www.openstreetmap.org/ browse/way/524788388) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.736208,12.736964 when routing to 280░ (http://www.openstreetmap.org/ browse/way/444595723) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.736087,12.737346 when routing to 306░ (http://www.openstreetmap.org/ browse/way/166123198) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.735055,12.734571 when routing to 289░ (http://www.openstreetmap.org/browse/way/115921194) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.735651,12.736162 when routing to 307░ (http://www.openstreetmap.org/browse/way/166104131) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.737428,12.738789 when routing to 13░ (http://www.openstreetmap.org/ browse/way/205144591) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.738709,12.740727 when routing to 340░ (http://www.openstreetmap.org/ browse/way/205131584) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.989677,12.671807 when routing to 149░ (http://www.openstreetmap.org/ browse/way/77223727) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.930978,13.089920 when routing to 3░ (http://www.openstreetmap.org/ browse/way/67628358) SEVERE (RouteNode): E:\openmtbmap\maps\63670077.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.535039,12.757507 when routing to 288░ (http://www.openstreetmap.org/browse/way/62229017) SEVERE (RouteNode): E:\openmtbmap\maps\63670077.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.534998,12.757686 when routing to 288░ (http://www.openstreetmap.org/ browse/way/62229017) SEVERE (RouteNode): E:\openmtbmap\maps\63670080.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.065012,13.246466 when routing to 159░ (http://www.openstreetmap.org/ browse/way/526738082) SEVERE (RouteNode): E:\openmtbmap\maps\63670080.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.063818,13.247116 when routing to 160░ (http://www.openstreetmap.org/ browse/way/526738082) SEVERE (RouteNode): E:\openmtbmap\maps\63670080.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.063818,13.247116 when routing to 340░ (http://www.openstreetmap.org/ browse/way/526738082) SEVERE (RouteNode): E:\openmtbmap\maps\63670080.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.062397,13.247571 when routing to 352░ (http://www.openstreetmap.org/ browse/way/526738082) SEVERE (RouteNode): E:\openmtbmap\maps\63670080.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.066478,13.245662 when routing to 159░ (http://www.openstreetmap.org/ browse/way/526738082) SEVERE (RouteNode): E:\openmtbmap\maps\63670083.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.480502,12.573502 when routing to 57░ (http://www.openstreetmap.org/ browse/way/296891396) SEVERE (RouteNode): E:\openmtbmap\maps\63670083.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.479995,12.572592 when routing to 51░ (http://www.openstreetmap.org/ browse/way/296891396) SEVERE (RouteNode): E:\openmtbmap\maps\63670093.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.423061,11.122175 when routing to 246░ (http://www.openstreetmap.org/browse/way/109792923) SEVERE (RouteNode): E:\openmtbmap\maps\63670090.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.576464,11. 368615 when routing to 287░ (http://www.openstreetmap.org/ browse/way/289500850) SEVERE (RouteNode): E:\openmtbmap\maps\63670093.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.423083,11.122244 when routing to 246░ (http://www.openstreetmap.org/browse/way/109792923) SEVERE (RouteNode): E:\openmtbmap\maps\63670092.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.647965,10.934005 when routing to 210░ (http://www.openstreetmap.org/browse/way/184765377) SEVERE (RouteNode): E:\openmtbmap\maps\63670092.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.641820,10.923750 when routing to 18░ (http://www.openstreetmap.org/browse/way/184119527) SEVERE (RouteNode): E:\openmtbmap\maps\63670096.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.111527,12.391685 when routing to 318░ (http://www.openstreetmap.org/ browse/way/23079043) SEVERE (RouteNode): E:\openmtbmap\maps\63670096.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.453887,12.236974 when routing to 338░ (http://www.openstreetmap.org/ browse/way/134104701) SEVERE (RouteNode): E:\openmtbmap\maps\63670096.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.455952,12.237370 when routing to 241░ (http://www.openstreetmap.org/ browse/way/134104701) SEVERE (RouteNode): E:\openmtbmap\maps\63670096.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.572849,12.138348 when routing to 102░ (http://www.openstreetmap.org/ browse/way/49245384) SEVERE (RouteNode): E:\openmtbmap\maps\63670096.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.111334,12.391722 when routing to 345░ (http://www.openstreetmap.org/ browse/way/23079043) SEVERE (RouteNode): E:\openmtbmap\maps\63670097.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.419061,12.106760 when routing to 18░ (http://www.openstreetmap.org/ browse/way/94916749) SEVERE (RouteNode): E:\openmtbmap\maps\63670101.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.839517,11.616697 when routing to 304░ (http://www.openstreetmap.org/ browse/way/23867528) SEVERE (RouteNode): E:\openmtbmap\maps\63670101.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.839494,11.616747 when routing to 304░ (http://www.openstreetmap.org/ browse/way/23867528) SEVERE (RouteNode): E:\openmtbmap\maps\63670101.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.840777,11.614020 when routing to 305░ (http://www.openstreetmap.org/ browse/way/23867528) SEVERE (RouteNode): E:\openmtbmap\maps\63670101.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.836746,11.619784 when routing to 203░ (http://www.openstreetmap.org/ browse/way/109082692) SEVERE (RouteNode): E:\openmtbmap\maps\63670101.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.839148,11.617493 when routing to 304░ (http://www.openstreetmap.org/ browse/way/23867528) SEVERE (RouteNode): E:\openmtbmap\maps\63670113.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.436562,10.996342 when routing to 140░ (http://www.openstreetmap.org/ browse/way/552651963) SEVERE (RouteNode): E:\openmtbmap\maps\63670114.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.869223,10.886843 when routing to 236░ (http://www.openstreetmap.org/ browse/way/225847075) SEVERE (RouteNode): E:\openmtbmap\maps\63670117.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.570251,11.935898 when routing to 109░ (http://www.openstreetmap.org/ browse/way/132914664) SEVERE (RouteNode): E:\openmtbmap\maps\63670117.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.570286,11.935696 when routing to 103░ (http://www.openstreetmap.org/ browse/way/132914664) SEVERE (RouteNode): E:\openmtbmap\maps\63670116.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.553374,11.778210 when routing to 17░ (http://www.openstreetmap.org/ browse/way/239751200) On 15 March 2018 at 09:53, Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote:
Hi Felix,
further thoughts about this: Up to now we concentrate on problems caused by rouding errors when OSM (~32 bit) coordinates are placed on the 24 Garmin raster. What about places where OSM data already contains overlapping highways? I think there is currently no code in mkgmap to handle this properly. Don't know if we can find rules to handle this, if not we should print warning messages, as it is likely to cause trouble. Overlapping can mean : * two different OSM ways with identical sequences of 2 or more nodes, e.g. a-b-c-d and x-b-c-y * two different OSM ways with identical sequences of 2 or more nodes, but in reversed order, e.g. a-b-c-d and x--d-c-y
My understanding is that these are mapping errors, but as said before there is no code to detect this. There might be warnings, e.g. in the housenumber code.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com> Gesendet: Mittwoch, 14. März 2018 17:25:22 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix, yes, change it to a gigher value first.
Gerd
Hi Gerd,
I get a huge huge list - and the ones I tried seemed to be quite alright
Felix Hartmann-2 wrote -
but the couple that I checked where simply ways that my styles inserts at least 3-4 times (usually ways with hiking/mtb route). Should I increase the counter in the patch to 5 (I guess still alright) or to 6 (I'm pretty sure I get routing errors then)?
Felix
-- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Edit, okay sorry - I think the problematic case above is actually a mapping error in OSM with two ways overlaying themselves, and both being part of the relation - hence my map ends up with 8 routable lines here. It's not mkgmap actually doing something wrong (have to check again- but seems not). Is there a way to detect such an error? On 20 March 2018 at 01:17, Felix Hartmann <extremecarver@gmail.com> wrote:
Somehow the patch is putting out quite a bit stuff that seems fine even set to 10 - I did find one way that breaks routing on device though
http://www.openstreetmap.org/browse/way/310376420 Something is really strange here - the problematic section is the bridge to the East, and with ID I cannot properly select it. Problematic tile: https://openmtbmap.org/63670040.img Routing over it on my Oregon 600 in simulation mode - it get's stuck as soon as it reaches the bridge.
I have now changed my style, before if a route contained a bridge, there was supposed to be no extra routable line created for the bridge, this did not work in all cases due to the discussed bug. I changed my style to create no extra routable line for a bridge if part of a relation, but this did not work either, I'm still ending up with 8 routable lines instead of 3 for the bridge itself. Very strange.
In general I think quite often it is adjoining ways that are more likely to be problematic. Not so easy what to do with all this long list as often it did not create more than 2-3 routable lines. The most were 8 (linked above). I'm now trying to see what it gives for my changed style. I did go through my style, and without this bug the style should create no more than 4 routable lines at most for a single street (yes this does not solve if there are two streets that get put on top of each other, because of super detailed mapping). However as in the above linked example that was not the case.
This is a case where in OSM there is already overlapping data - I'll give it a better check tomorrow: https://www.openstreetmap.org/way/358035804#map=16/44.5885/7.8644
SEVERE (RouteNode): E:\openmtbmap\maps\63670018.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 41.099468,14.210138 when routing to 177░ (http://www.openstreetmap.org/ browse/way/231702644) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.594210,7.870896 when routing to 166░ (http://www.openstreetmap.org/ browse/way/268949386) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.594024,7.870959 when routing to 347░ (http://www.openstreetmap.org/ browse/way/268949386) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.589474,7.868189 when routing to 230░ (http://www.openstreetmap.org/ browse/way/358035804) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.595358,7.869657 when routing to 186░ (http://www.openstreetmap.org/ browse/way/358035804) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.593348,7.870952 when routing to 7░ (http://www.openstreetmap.org/ browse/way/268949386) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.528092,7.857529 when routing to 132░ (http://www.openstreetmap.org/browse/way/310376420) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.527925,7.857784 when routing to 313░ (http://www.openstreetmap.org/browse/way/310376420) SEVERE (RouteNode): E:\openmtbmap\maps\63670035.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.103926,10.499103 when routing to 12░ (http://www.openstreetmap.org/ browse/way/261283126) SEVERE (RouteNode): E:\openmtbmap\maps\63670036.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.197738,9.560527 when routing to 306░ (http://www.openstreetmap.org/ browse/way/216391711) SEVERE (RouteNode): E:\openmtbmap\maps\63670034.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.462818,10.589772 when routing to 260░ (http://www.openstreetmap.org/ browse/way/131304170) SEVERE (RouteNode): E:\openmtbmap\maps\63670054.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.658185,10.045777 when routing to 46░ (http://www.openstreetmap.org/browse/way/50847847) SEVERE (RouteNode): E:\openmtbmap\maps\63670057.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.171695,9.870816 when routing to 327░ (http://www.openstreetmap.org/ browse/way/503763128) SEVERE (RouteNode): E:\openmtbmap\maps\63670059.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.690630,9.675076 when routing to 248░ (http://www.openstreetmap.org/ browse/way/50730378) SEVERE (RouteNode): E:\openmtbmap\maps\63670067.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.142950,9.170384 when routing to 85░ (http://www.openstreetmap.org/ browse/way/243855717) SEVERE (RouteNode): E:\openmtbmap\maps\63670066.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.488240,9.195559 when routing to 201░ (http://www.openstreetmap.org/ browse/way/262420957) SEVERE (RouteNode): E:\openmtbmap\maps\63670066.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.488326,9.195591 when routing to 195░ (http://www.openstreetmap.org/ browse/way/262420957) SEVERE (RouteNode): E:\openmtbmap\maps\63670070.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.586536,8.924042 when routing to 235░ (http://www.openstreetmap.org/ browse/way/450869558) SEVERE (RouteNode): E:\openmtbmap\maps\63670072.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.598025,13.786274 when routing to 68░ (http://www.openstreetmap.org/ browse/way/26661412) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.736224,12.736811 when routing to 94░ (http://www.openstreetmap.org/ browse/way/444595723) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.736221,12.736862 when routing to 275░ (http://www.openstreetmap.org/ browse/way/444595723) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.733896,12.733320 when routing to 145░ (http://www.openstreetmap.org/ browse/way/166104158) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.733569,12.733668 when routing to 325░ (http://www.openstreetmap.org/ browse/way/166104158) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.735211,12.734411 when routing to 19░ (http://www.openstreetmap.org/browse/way/115921194) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.735631,12.734614 when routing to 19░ (http://www.openstreetmap.org/browse/way/115921194) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.737543,12.738809 when routing to 348░ (http://www.openstreetmap.org/ browse/way/205144591) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.991118,12.671455 when routing to 176░ (http://www.openstreetmap.org/ browse/way/226058688) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.990426,12.671494 when routing to 0░ (http://www.openstreetmap.org/ browse/way/226058688) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.733015,12.737255 when routing to 48░ (http://www.openstreetmap.org/ browse/way/394187014) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.737876,12.738618 when routing to 155░ (http://www.openstreetmap.org/ browse/way/205144591) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.735138,12. 735350 when routing to 19░ (http://www.openstreetmap.org/ browse/way/524788388) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.736208,12.736964 when routing to 280░ (http://www.openstreetmap.org/ browse/way/444595723) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.736087,12.737346 when routing to 306░ (http://www.openstreetmap.org/ browse/way/166123198) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.735055,12.734571 when routing to 289░ (http://www.openstreetmap.org/browse/way/115921194) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.735651,12.736162 when routing to 307░ (http://www.openstreetmap.org/browse/way/166104131) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.737428,12.738789 when routing to 13░ (http://www.openstreetmap.org/ browse/way/205144591) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.738709,12.740727 when routing to 340░ (http://www.openstreetmap.org/ browse/way/205131584) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.989677,12.671807 when routing to 149░ (http://www.openstreetmap.org/ browse/way/77223727) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.930978,13.089920 when routing to 3░ (http://www.openstreetmap.org/ browse/way/67628358) SEVERE (RouteNode): E:\openmtbmap\maps\63670077.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.535039,12.757507 when routing to 288░ (http://www.openstreetmap.org/browse/way/62229017) SEVERE (RouteNode): E:\openmtbmap\maps\63670077.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.534998,12.757686 when routing to 288░ (http://www.openstreetmap.org/ browse/way/62229017) SEVERE (RouteNode): E:\openmtbmap\maps\63670080.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.065012,13.246466 when routing to 159░ (http://www.openstreetmap.org/ browse/way/526738082) SEVERE (RouteNode): E:\openmtbmap\maps\63670080.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.063818,13.247116 when routing to 160░ (http://www.openstreetmap.org/ browse/way/526738082) SEVERE (RouteNode): E:\openmtbmap\maps\63670080.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.063818,13.247116 when routing to 340░ (http://www.openstreetmap.org/ browse/way/526738082) SEVERE (RouteNode): E:\openmtbmap\maps\63670080.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.062397,13.247571 when routing to 352░ (http://www.openstreetmap.org/ browse/way/526738082) SEVERE (RouteNode): E:\openmtbmap\maps\63670080.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.066478,13.245662 when routing to 159░ (http://www.openstreetmap.org/ browse/way/526738082) SEVERE (RouteNode): E:\openmtbmap\maps\63670083.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.480502,12.573502 when routing to 57░ (http://www.openstreetmap.org/ browse/way/296891396) SEVERE (RouteNode): E:\openmtbmap\maps\63670083.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.479995,12.572592 when routing to 51░ (http://www.openstreetmap.org/ browse/way/296891396) SEVERE (RouteNode): E:\openmtbmap\maps\63670093.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.423061,11.122175 when routing to 246░ (http://www.openstreetmap.org/browse/way/109792923) SEVERE (RouteNode): E:\openmtbmap\maps\63670090.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.576464,11. 368615 when routing to 287░ (http://www.openstreetmap.org/ browse/way/289500850) SEVERE (RouteNode): E:\openmtbmap\maps\63670093.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.423083,11.122244 when routing to 246░ (http://www.openstreetmap.org/browse/way/109792923) SEVERE (RouteNode): E:\openmtbmap\maps\63670092.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.647965,10.934005 when routing to 210░ (http://www.openstreetmap.org/browse/way/184765377) SEVERE (RouteNode): E:\openmtbmap\maps\63670092.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.641820,10.923750 when routing to 18░ (http://www.openstreetmap.org/browse/way/184119527) SEVERE (RouteNode): E:\openmtbmap\maps\63670096.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.111527,12.391685 when routing to 318░ (http://www.openstreetmap.org/ browse/way/23079043) SEVERE (RouteNode): E:\openmtbmap\maps\63670096.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.453887,12.236974 when routing to 338░ (http://www.openstreetmap.org/ browse/way/134104701) SEVERE (RouteNode): E:\openmtbmap\maps\63670096.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.455952,12.237370 when routing to 241░ (http://www.openstreetmap.org/ browse/way/134104701) SEVERE (RouteNode): E:\openmtbmap\maps\63670096.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.572849,12.138348 when routing to 102░ (http://www.openstreetmap.org/ browse/way/49245384) SEVERE (RouteNode): E:\openmtbmap\maps\63670096.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.111334,12.391722 when routing to 345░ (http://www.openstreetmap.org/ browse/way/23079043) SEVERE (RouteNode): E:\openmtbmap\maps\63670097.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.419061,12.106760 when routing to 18░ (http://www.openstreetmap.org/ browse/way/94916749) SEVERE (RouteNode): E:\openmtbmap\maps\63670101.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.839517,11.616697 when routing to 304░ (http://www.openstreetmap.org/ browse/way/23867528) SEVERE (RouteNode): E:\openmtbmap\maps\63670101.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.839494,11.616747 when routing to 304░ (http://www.openstreetmap.org/ browse/way/23867528) SEVERE (RouteNode): E:\openmtbmap\maps\63670101.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.840777,11.614020 when routing to 305░ (http://www.openstreetmap.org/ browse/way/23867528) SEVERE (RouteNode): E:\openmtbmap\maps\63670101.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.836746,11.619784 when routing to 203░ (http://www.openstreetmap.org/ browse/way/109082692) SEVERE (RouteNode): E:\openmtbmap\maps\63670101.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.839148,11.617493 when routing to 304░ (http://www.openstreetmap.org/ browse/way/23867528) SEVERE (RouteNode): E:\openmtbmap\maps\63670113.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.436562,10.996342 when routing to 140░ (http://www.openstreetmap.org/ browse/way/552651963) SEVERE (RouteNode): E:\openmtbmap\maps\63670114.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.869223,10.886843 when routing to 236░ (http://www.openstreetmap.org/ browse/way/225847075) SEVERE (RouteNode): E:\openmtbmap\maps\63670117.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.570251,11.935898 when routing to 109░ (http://www.openstreetmap.org/ browse/way/132914664) SEVERE (RouteNode): E:\openmtbmap\maps\63670117.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.570286,11.935696 when routing to 103░ (http://www.openstreetmap.org/ browse/way/132914664) SEVERE (RouteNode): E:\openmtbmap\maps\63670116.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.553374,11.778210 when routing to 17░ (http://www.openstreetmap.org/ browse/way/239751200)
On 15 March 2018 at 09:53, Gerd Petermann <gpetermann_muenchen@hotmail.com
wrote:
Hi Felix,
further thoughts about this: Up to now we concentrate on problems caused by rouding errors when OSM (~32 bit) coordinates are placed on the 24 Garmin raster. What about places where OSM data already contains overlapping highways? I think there is currently no code in mkgmap to handle this properly. Don't know if we can find rules to handle this, if not we should print warning messages, as it is likely to cause trouble. Overlapping can mean : * two different OSM ways with identical sequences of 2 or more nodes, e.g. a-b-c-d and x-b-c-y * two different OSM ways with identical sequences of 2 or more nodes, but in reversed order, e.g. a-b-c-d and x--d-c-y
My understanding is that these are mapping errors, but as said before there is no code to detect this. There might be warnings, e.g. in the housenumber code.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com> Gesendet: Mittwoch, 14. März 2018 17:25:22 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix, yes, change it to a gigher value first.
Gerd
Felix Hartmann-2 wrote
Hi Gerd,
I get a huge huge list - and the ones I tried seemed to be quite alright - but the couple that I checked where simply ways that my styles inserts at least 3-4 times (usually ways with hiking/mtb route). Should I increase the counter in the patch to 5 (I guess still alright) or to 6 (I'm pretty sure I get routing errors then)?
Felix
-- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443. html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Actually it's even worse, in part there are three ways on top of each other. So actually I end up with 3 + 3 + 5 ways. Maybe ways on top of each other that share the exact same nodes should be joined before put into the map? Garmin cannot route in 3D anyhow - so a supposed 2 layered highway that shares the same nodes is a problematic case no matter what we do. On 20 March 2018 at 01:37, Felix Hartmann <extremecarver@gmail.com> wrote:
Edit, okay sorry - I think the problematic case above is actually a mapping error in OSM with two ways overlaying themselves, and both being part of the relation - hence my map ends up with 8 routable lines here. It's not mkgmap actually doing something wrong (have to check again- but seems not).
Is there a way to detect such an error?
On 20 March 2018 at 01:17, Felix Hartmann <extremecarver@gmail.com> wrote:
Somehow the patch is putting out quite a bit stuff that seems fine even set to 10 - I did find one way that breaks routing on device though
http://www.openstreetmap.org/browse/way/310376420 Something is really strange here - the problematic section is the bridge to the East, and with ID I cannot properly select it. Problematic tile: https://openmtbmap.org/63670040.img Routing over it on my Oregon 600 in simulation mode - it get's stuck as soon as it reaches the bridge.
I have now changed my style, before if a route contained a bridge, there was supposed to be no extra routable line created for the bridge, this did not work in all cases due to the discussed bug. I changed my style to create no extra routable line for a bridge if part of a relation, but this did not work either, I'm still ending up with 8 routable lines instead of 3 for the bridge itself. Very strange.
In general I think quite often it is adjoining ways that are more likely to be problematic. Not so easy what to do with all this long list as often it did not create more than 2-3 routable lines. The most were 8 (linked above). I'm now trying to see what it gives for my changed style. I did go through my style, and without this bug the style should create no more than 4 routable lines at most for a single street (yes this does not solve if there are two streets that get put on top of each other, because of super detailed mapping). However as in the above linked example that was not the case.
This is a case where in OSM there is already overlapping data - I'll give it a better check tomorrow: https://www.openstreetmap.org/way/358035804#map=16/44.5885/7.8644
SEVERE (RouteNode): E:\openmtbmap\maps\63670018.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 41.099468,14.210138 when routing to 177░ (http://www.openstreetmap.org/ browse/way/231702644) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.594210,7.870896 when routing to 166░ (http://www.openstreetmap.org/ browse/way/268949386) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.594024,7.870959 when routing to 347░ (http://www.openstreetmap.org/ browse/way/268949386) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.589474,7.868189 when routing to 230░ (http://www.openstreetmap.org/ browse/way/358035804) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.595358,7.869657 when routing to 186░ (http://www.openstreetmap.org/ browse/way/358035804) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.593348,7.870952 when routing to 7░ (http://www.openstreetmap.org/ browse/way/268949386) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.528092,7.857529 when routing to 132░ (http://www.openstreetmap.org/browse/way/310376420) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.527925,7.857784 when routing to 313░ (http://www.openstreetmap.org/browse/way/310376420) SEVERE (RouteNode): E:\openmtbmap\maps\63670035.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.103926,10.499103 when routing to 12░ (http://www.openstreetmap.org/ browse/way/261283126) SEVERE (RouteNode): E:\openmtbmap\maps\63670036.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.197738,9.560527 when routing to 306░ (http://www.openstreetmap.org/ browse/way/216391711) SEVERE (RouteNode): E:\openmtbmap\maps\63670034.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.462818,10.589772 when routing to 260░ (http://www.openstreetmap.org/ browse/way/131304170) SEVERE (RouteNode): E:\openmtbmap\maps\63670054.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.658185,10.045777 when routing to 46░ (http://www.openstreetmap.org/browse/way/50847847) SEVERE (RouteNode): E:\openmtbmap\maps\63670057.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.171695,9.870816 when routing to 327░ (http://www.openstreetmap.org/ browse/way/503763128) SEVERE (RouteNode): E:\openmtbmap\maps\63670059.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.690630,9.675076 when routing to 248░ (http://www.openstreetmap.org/ browse/way/50730378) SEVERE (RouteNode): E:\openmtbmap\maps\63670067.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.142950,9.170384 when routing to 85░ (http://www.openstreetmap.org/ browse/way/243855717) SEVERE (RouteNode): E:\openmtbmap\maps\63670066.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.488240,9.195559 when routing to 201░ (http://www.openstreetmap.org/ browse/way/262420957) SEVERE (RouteNode): E:\openmtbmap\maps\63670066.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.488326,9.195591 when routing to 195░ (http://www.openstreetmap.org/ browse/way/262420957) SEVERE (RouteNode): E:\openmtbmap\maps\63670070.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.586536,8.924042 when routing to 235░ (http://www.openstreetmap.org/ browse/way/450869558) SEVERE (RouteNode): E:\openmtbmap\maps\63670072.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.598025,13.786274 when routing to 68░ (http://www.openstreetmap.org/ browse/way/26661412) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.736224,12.736811 when routing to 94░ (http://www.openstreetmap.org/ browse/way/444595723) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.736221,12.736862 when routing to 275░ (http://www.openstreetmap.org/ browse/way/444595723) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.733896,12.733320 when routing to 145░ (http://www.openstreetmap.org/ browse/way/166104158) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.733569,12.733668 when routing to 325░ (http://www.openstreetmap.org/ browse/way/166104158) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.735211,12.734411 when routing to 19░ (http://www.openstreetmap.org/browse/way/115921194) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.735631,12.734614 when routing to 19░ (http://www.openstreetmap.org/browse/way/115921194) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.737543,12.738809 when routing to 348░ (http://www.openstreetmap.org/ browse/way/205144591) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.991118,12.671455 when routing to 176░ (http://www.openstreetmap.org/ browse/way/226058688) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.990426,12.671494 when routing to 0░ (http://www.openstreetmap.org/ browse/way/226058688) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.733015,12.737255 when routing to 48░ (http://www.openstreetmap.org/ browse/way/394187014) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.737876,12.738618 when routing to 155░ (http://www.openstreetmap.org/ browse/way/205144591) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.735138,12. 735350 when routing to 19░ (http://www.openstreetmap.org/ browse/way/524788388) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.736208,12.736964 when routing to 280░ (http://www.openstreetmap.org/ browse/way/444595723) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.736087,12.737346 when routing to 306░ (http://www.openstreetmap.org/ browse/way/166123198) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.735055,12.734571 when routing to 289░ (http://www.openstreetmap.org/browse/way/115921194) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.735651,12.736162 when routing to 307░ (http://www.openstreetmap.org/browse/way/166104131) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.737428,12.738789 when routing to 13░ (http://www.openstreetmap.org/ browse/way/205144591) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.738709,12.740727 when routing to 340░ (http://www.openstreetmap.org/ browse/way/205131584) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.989677,12.671807 when routing to 149░ (http://www.openstreetmap.org/ browse/way/77223727) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.930978,13.089920 when routing to 3░ (http://www.openstreetmap.org/ browse/way/67628358) SEVERE (RouteNode): E:\openmtbmap\maps\63670077.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.535039,12.757507 when routing to 288░ (http://www.openstreetmap.org/browse/way/62229017) SEVERE (RouteNode): E:\openmtbmap\maps\63670077.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.534998,12.757686 when routing to 288░ (http://www.openstreetmap.org/ browse/way/62229017) SEVERE (RouteNode): E:\openmtbmap\maps\63670080.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.065012,13.246466 when routing to 159░ (http://www.openstreetmap.org/ browse/way/526738082) SEVERE (RouteNode): E:\openmtbmap\maps\63670080.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.063818,13.247116 when routing to 160░ (http://www.openstreetmap.org/ browse/way/526738082) SEVERE (RouteNode): E:\openmtbmap\maps\63670080.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.063818,13.247116 when routing to 340░ (http://www.openstreetmap.org/ browse/way/526738082) SEVERE (RouteNode): E:\openmtbmap\maps\63670080.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.062397,13.247571 when routing to 352░ (http://www.openstreetmap.org/ browse/way/526738082) SEVERE (RouteNode): E:\openmtbmap\maps\63670080.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.066478,13.245662 when routing to 159░ (http://www.openstreetmap.org/ browse/way/526738082) SEVERE (RouteNode): E:\openmtbmap\maps\63670083.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.480502,12.573502 when routing to 57░ (http://www.openstreetmap.org/ browse/way/296891396) SEVERE (RouteNode): E:\openmtbmap\maps\63670083.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.479995,12.572592 when routing to 51░ (http://www.openstreetmap.org/ browse/way/296891396) SEVERE (RouteNode): E:\openmtbmap\maps\63670093.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.423061,11.122175 when routing to 246░ (http://www.openstreetmap.org/browse/way/109792923) SEVERE (RouteNode): E:\openmtbmap\maps\63670090.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.576464,11. 368615 when routing to 287░ (http://www.openstreetmap.org/ browse/way/289500850) SEVERE (RouteNode): E:\openmtbmap\maps\63670093.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.423083,11.122244 when routing to 246░ (http://www.openstreetmap.org/browse/way/109792923) SEVERE (RouteNode): E:\openmtbmap\maps\63670092.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.647965,10.934005 when routing to 210░ (http://www.openstreetmap.org/browse/way/184765377) SEVERE (RouteNode): E:\openmtbmap\maps\63670092.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.641820,10.923750 when routing to 18░ (http://www.openstreetmap.org/browse/way/184119527) SEVERE (RouteNode): E:\openmtbmap\maps\63670096.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.111527,12.391685 when routing to 318░ (http://www.openstreetmap.org/ browse/way/23079043) SEVERE (RouteNode): E:\openmtbmap\maps\63670096.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.453887,12.236974 when routing to 338░ (http://www.openstreetmap.org/ browse/way/134104701) SEVERE (RouteNode): E:\openmtbmap\maps\63670096.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.455952,12.237370 when routing to 241░ (http://www.openstreetmap.org/ browse/way/134104701) SEVERE (RouteNode): E:\openmtbmap\maps\63670096.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.572849,12.138348 when routing to 102░ (http://www.openstreetmap.org/ browse/way/49245384) SEVERE (RouteNode): E:\openmtbmap\maps\63670096.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.111334,12.391722 when routing to 345░ (http://www.openstreetmap.org/ browse/way/23079043) SEVERE (RouteNode): E:\openmtbmap\maps\63670097.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.419061,12.106760 when routing to 18░ (http://www.openstreetmap.org/ browse/way/94916749) SEVERE (RouteNode): E:\openmtbmap\maps\63670101.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.839517,11.616697 when routing to 304░ (http://www.openstreetmap.org/ browse/way/23867528) SEVERE (RouteNode): E:\openmtbmap\maps\63670101.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.839494,11.616747 when routing to 304░ (http://www.openstreetmap.org/ browse/way/23867528) SEVERE (RouteNode): E:\openmtbmap\maps\63670101.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.840777,11.614020 when routing to 305░ (http://www.openstreetmap.org/ browse/way/23867528) SEVERE (RouteNode): E:\openmtbmap\maps\63670101.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.836746,11.619784 when routing to 203░ (http://www.openstreetmap.org/ browse/way/109082692) SEVERE (RouteNode): E:\openmtbmap\maps\63670101.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.839148,11.617493 when routing to 304░ (http://www.openstreetmap.org/ browse/way/23867528) SEVERE (RouteNode): E:\openmtbmap\maps\63670113.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.436562,10.996342 when routing to 140░ (http://www.openstreetmap.org/ browse/way/552651963) SEVERE (RouteNode): E:\openmtbmap\maps\63670114.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.869223,10.886843 when routing to 236░ (http://www.openstreetmap.org/ browse/way/225847075) SEVERE (RouteNode): E:\openmtbmap\maps\63670117.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.570251,11.935898 when routing to 109░ (http://www.openstreetmap.org/ browse/way/132914664) SEVERE (RouteNode): E:\openmtbmap\maps\63670117.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.570286,11.935696 when routing to 103░ (http://www.openstreetmap.org/ browse/way/132914664) SEVERE (RouteNode): E:\openmtbmap\maps\63670116.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.553374,11.778210 when routing to 17░ (http://www.openstreetmap.org/ browse/way/239751200)
On 15 March 2018 at 09:53, Gerd Petermann <gpetermann_muenchen@hotmail.c om> wrote:
Hi Felix,
further thoughts about this: Up to now we concentrate on problems caused by rouding errors when OSM (~32 bit) coordinates are placed on the 24 Garmin raster. What about places where OSM data already contains overlapping highways? I think there is currently no code in mkgmap to handle this properly. Don't know if we can find rules to handle this, if not we should print warning messages, as it is likely to cause trouble. Overlapping can mean : * two different OSM ways with identical sequences of 2 or more nodes, e.g. a-b-c-d and x-b-c-y * two different OSM ways with identical sequences of 2 or more nodes, but in reversed order, e.g. a-b-c-d and x--d-c-y
My understanding is that these are mapping errors, but as said before there is no code to detect this. There might be warnings, e.g. in the housenumber code.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com> Gesendet: Mittwoch, 14. März 2018 17:25:22 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix, yes, change it to a gigher value first.
Gerd
Felix Hartmann-2 wrote
Hi Gerd,
I get a huge huge list - and the ones I tried seemed to be quite alright - but the couple that I checked where simply ways that my styles inserts at least 3-4 times (usually ways with hiking/mtb route). Should I increase the counter in the patch to 5 (I guess still alright) or to 6 (I'm pretty sure I get routing errors then)?
Felix
-- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.h tml _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Felix, note that we are counting arcs here, not ways. An arc connects two routing nodes. There will always be two arcs between two nodes A and B, one from A to B and one from B to A. The node from A to B is the forward arc in A and the backward arc in B (and vice versa). Also, we have so called indirect arcs, those are added by the method addArcsToMajorRoads() in RoadNetwork.java. They help Garmins routing algo to find the next major road. So, as I said before, we have to find out what exactly causes trouble. I've attached a new version of the patch. It counts only direct forward arcs. Please check if this helps to find problematic places. Maybe comment the lines if (!arc.isForward()) continue; or if (!arc.isDirect() ) continue; so that more arcs are counted. Reg. overlapping ways: Sure, mkgmap can detect them and print a warning, but it would be much more difficult to automatically remove the overlap. Which part should be removed? This gets even more difficult when the style adds several ways for the same OSM way (no matter if routable or not). Unless both parts are equal I see no way to handle this automatically. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Dienstag, 20. März 2018 01:57:25 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Actually it's even worse, in part there are three ways on top of each other. So actually I end up with 3 + 3 + 5 ways. Maybe ways on top of each other that share the exact same nodes should be joined before put into the map? Garmin cannot route in 3D anyhow - so a supposed 2 layered highway that shares the same nodes is a problematic case no matter what we do. On 20 March 2018 at 01:37, Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> wrote: Edit, okay sorry - I think the problematic case above is actually a mapping error in OSM with two ways overlaying themselves, and both being part of the relation - hence my map ends up with 8 routable lines here. It's not mkgmap actually doing something wrong (have to check again- but seems not). Is there a way to detect such an error? On 20 March 2018 at 01:17, Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> wrote: Somehow the patch is putting out quite a bit stuff that seems fine even set to 10 - I did find one way that breaks routing on device though http://www.openstreetmap.org/browse/way/310376420 Something is really strange here - the problematic section is the bridge to the East, and with ID I cannot properly select it. Problematic tile: https://openmtbmap.org/63670040.img Routing over it on my Oregon 600 in simulation mode - it get's stuck as soon as it reaches the bridge. I have now changed my style, before if a route contained a bridge, there was supposed to be no extra routable line created for the bridge, this did not work in all cases due to the discussed bug. I changed my style to create no extra routable line for a bridge if part of a relation, but this did not work either, I'm still ending up with 8 routable lines instead of 3 for the bridge itself. Very strange. In general I think quite often it is adjoining ways that are more likely to be problematic. Not so easy what to do with all this long list as often it did not create more than 2-3 routable lines. The most were 8 (linked above). I'm now trying to see what it gives for my changed style. I did go through my style, and without this bug the style should create no more than 4 routable lines at most for a single street (yes this does not solve if there are two streets that get put on top of each other, because of super detailed mapping). However as in the above linked example that was not the case. This is a case where in OSM there is already overlapping data - I'll give it a better check tomorrow: https://www.openstreetmap.org/way/358035804#map=16/44.5885/7.8644 SEVERE (RouteNode): E:\openmtbmap\maps\63670018.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 41.099468,14.210138 when routing to 177░ (http://www.openstreetmap.org/browse/way/231702644) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.594210,7.870896 when routing to 166░ (http://www.openstreetmap.org/browse/way/268949386) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.594024,7.870959 when routing to 347░ (http://www.openstreetmap.org/browse/way/268949386) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.589474,7.868189 when routing to 230░ (http://www.openstreetmap.org/browse/way/358035804) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.595358,7.869657 when routing to 186░ (http://www.openstreetmap.org/browse/way/358035804) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.593348,7.870952 when routing to 7░ (http://www.openstreetmap.org/browse/way/268949386) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.528092<tel:528092>,7.857529 when routing to 132░ (http://www.openstreetmap.org/browse/way/310376420) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.527925<tel:527925>,7.857784 when routing to 313░ (http://www.openstreetmap.org/browse/way/310376420) SEVERE (RouteNode): E:\openmtbmap\maps\63670035.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.103926,10.499103 when routing to 12░ (http://www.openstreetmap.org/browse/way/261283126) SEVERE (RouteNode): E:\openmtbmap\maps\63670036.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.197738,9.560527 when routing to 306░ (http://www.openstreetmap.org/browse/way/216391711) SEVERE (RouteNode): E:\openmtbmap\maps\63670034.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.462818,10.589772 when routing to 260░ (http://www.openstreetmap.org/browse/way/131304170) SEVERE (RouteNode): E:\openmtbmap\maps\63670054.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.658185<tel:658185>,10.045777 when routing to 46░ (http://www.openstreetmap.org/browse/way/50847847) SEVERE (RouteNode): E:\openmtbmap\maps\63670057.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.171695,9.870816 when routing to 327░ (http://www.openstreetmap.org/browse/way/503763128) SEVERE (RouteNode): E:\openmtbmap\maps\63670059.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.690630,9.675076 when routing to 248░ (http://www.openstreetmap.org/browse/way/50730378) SEVERE (RouteNode): E:\openmtbmap\maps\63670067.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.142950,9.170384 when routing to 85░ (http://www.openstreetmap.org/browse/way/243855717) SEVERE (RouteNode): E:\openmtbmap\maps\63670066.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.488240,9.195559 when routing to 201░ (http://www.openstreetmap.org/browse/way/262420957) SEVERE (RouteNode): E:\openmtbmap\maps\63670066.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.488326,9.195591 when routing to 195░ (http://www.openstreetmap.org/browse/way/262420957) SEVERE (RouteNode): E:\openmtbmap\maps\63670070.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.586536,8.924042 when routing to 235░ (http://www.openstreetmap.org/browse/way/450869558) SEVERE (RouteNode): E:\openmtbmap\maps\63670072.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.598025,13.786274 when routing to 68░ (http://www.openstreetmap.org/browse/way/26661412) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.736224,12.736811 when routing to 94░ (http://www.openstreetmap.org/browse/way/444595723) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.736221,12.736862 when routing to 275░ (http://www.openstreetmap.org/browse/way/444595723) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.733896,12.733320 when routing to 145░ (http://www.openstreetmap.org/browse/way/166104158) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.733569,12.733668 when routing to 325░ (http://www.openstreetmap.org/browse/way/166104158) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.735211<tel:735211>,12.734411 when routing to 19░ (http://www.openstreetmap.org/browse/way/115921194) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.735631<tel:735631>,12.734614 when routing to 19░ (http://www.openstreetmap.org/browse/way/115921194) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.737543,12.738809 when routing to 348░ (http://www.openstreetmap.org/browse/way/205144591) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.991118,12.671455 when routing to 176░ (http://www.openstreetmap.org/browse/way/226058688) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.990426,12.671494 when routing to 0░ (http://www.openstreetmap.org/browse/way/226058688) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.733015,12.737255 when routing to 48░ (http://www.openstreetmap.org/browse/way/394187014) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.737876,12.738618 when routing to 155░ (http://www.openstreetmap.org/browse/way/205144591) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.735138<tel:735138>,12.735350<tel:735350> when routing to 19░ (http://www.openstreetmap.org/browse/way/524788388) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.736208,12.736964 when routing to 280░ (http://www.openstreetmap.org/browse/way/444595723) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.736087,12.737346 when routing to 306░ (http://www.openstreetmap.org/browse/way/166123198) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.735055<tel:735055>,12.734571 when routing to 289░ (http://www.openstreetmap.org/browse/way/115921194) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.735651<tel:735651>,12.736162 when routing to 307░ (http://www.openstreetmap.org/browse/way/166104131) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.737428,12.738789 when routing to 13░ (http://www.openstreetmap.org/browse/way/205144591) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.738709,12.740727 when routing to 340░ (http://www.openstreetmap.org/browse/way/205131584) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.989677,12.671807 when routing to 149░ (http://www.openstreetmap.org/browse/way/77223727) SEVERE (RouteNode): E:\openmtbmap\maps\63670076.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.930978,13.089920 when routing to 3░ (http://www.openstreetmap.org/browse/way/67628358) SEVERE (RouteNode): E:\openmtbmap\maps\63670077.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.535039<tel:535039>,12.757507 when routing to 288░ (http://www.openstreetmap.org/browse/way/62229017) SEVERE (RouteNode): E:\openmtbmap\maps\63670077.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.534998,12.757686 when routing to 288░ (http://www.openstreetmap.org/browse/way/62229017) SEVERE (RouteNode): E:\openmtbmap\maps\63670080.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.065012,13.246466 when routing to 159░ (http://www.openstreetmap.org/browse/way/526738082) SEVERE (RouteNode): E:\openmtbmap\maps\63670080.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.063818,13.247116 when routing to 160░ (http://www.openstreetmap.org/browse/way/526738082) SEVERE (RouteNode): E:\openmtbmap\maps\63670080.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.063818,13.247116 when routing to 340░ (http://www.openstreetmap.org/browse/way/526738082) SEVERE (RouteNode): E:\openmtbmap\maps\63670080.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.062397,13.247571 when routing to 352░ (http://www.openstreetmap.org/browse/way/526738082) SEVERE (RouteNode): E:\openmtbmap\maps\63670080.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.066478,13.245662 when routing to 159░ (http://www.openstreetmap.org/browse/way/526738082) SEVERE (RouteNode): E:\openmtbmap\maps\63670083.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.480502,12.573502 when routing to 57░ (http://www.openstreetmap.org/browse/way/296891396) SEVERE (RouteNode): E:\openmtbmap\maps\63670083.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.479995,12.572592 when routing to 51░ (http://www.openstreetmap.org/browse/way/296891396) SEVERE (RouteNode): E:\openmtbmap\maps\63670093.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.423061<tel:423061>,11.122175 when routing to 246░ (http://www.openstreetmap.org/browse/way/109792923) SEVERE (RouteNode): E:\openmtbmap\maps\63670090.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.576464,11.368615<tel:368615> when routing to 287░ (http://www.openstreetmap.org/browse/way/289500850) SEVERE (RouteNode): E:\openmtbmap\maps\63670093.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.423083<tel:423083>,11.122244 when routing to 246░ (http://www.openstreetmap.org/browse/way/109792923) SEVERE (RouteNode): E:\openmtbmap\maps\63670092.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.647965<tel:647965>,10.934005 when routing to 210░ (http://www.openstreetmap.org/browse/way/184765377) SEVERE (RouteNode): E:\openmtbmap\maps\63670092.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.641820<tel:641820>,10.923750 when routing to 18░ (http://www.openstreetmap.org/browse/way/184119527) SEVERE (RouteNode): E:\openmtbmap\maps\63670096.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.111527,12.391685 when routing to 318░ (http://www.openstreetmap.org/browse/way/23079043) SEVERE (RouteNode): E:\openmtbmap\maps\63670096.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.453887,12.236974 when routing to 338░ (http://www.openstreetmap.org/browse/way/134104701) SEVERE (RouteNode): E:\openmtbmap\maps\63670096.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.455952,12.237370 when routing to 241░ (http://www.openstreetmap.org/browse/way/134104701) SEVERE (RouteNode): E:\openmtbmap\maps\63670096.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.572849,12.138348 when routing to 102░ (http://www.openstreetmap.org/browse/way/49245384) SEVERE (RouteNode): E:\openmtbmap\maps\63670096.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 43.111334,12.391722 when routing to 345░ (http://www.openstreetmap.org/browse/way/23079043) SEVERE (RouteNode): E:\openmtbmap\maps\63670097.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 42.419061,12.106760 when routing to 18░ (http://www.openstreetmap.org/browse/way/94916749) SEVERE (RouteNode): E:\openmtbmap\maps\63670101.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.839517,11.616697 when routing to 304░ (http://www.openstreetmap.org/browse/way/23867528) SEVERE (RouteNode): E:\openmtbmap\maps\63670101.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.839494,11.616747 when routing to 304░ (http://www.openstreetmap.org/browse/way/23867528) SEVERE (RouteNode): E:\openmtbmap\maps\63670101.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.840777,11.614020 when routing to 305░ (http://www.openstreetmap.org/browse/way/23867528) SEVERE (RouteNode): E:\openmtbmap\maps\63670101.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.836746,11.619784 when routing to 203░ (http://www.openstreetmap.org/browse/way/109082692) SEVERE (RouteNode): E:\openmtbmap\maps\63670101.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 44.839148,11.617493 when routing to 304░ (http://www.openstreetmap.org/browse/way/23867528) SEVERE (RouteNode): E:\openmtbmap\maps\63670113.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.436562,10.996342 when routing to 140░ (http://www.openstreetmap.org/browse/way/552651963) SEVERE (RouteNode): E:\openmtbmap\maps\63670114.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.869223,10.886843 when routing to 236░ (http://www.openstreetmap.org/browse/way/225847075) SEVERE (RouteNode): E:\openmtbmap\maps\63670117.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.570251,11.935898 when routing to 109░ (http://www.openstreetmap.org/browse/way/132914664) SEVERE (RouteNode): E:\openmtbmap\maps\63670117.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 45.570286,11.935696 when routing to 103░ (http://www.openstreetmap.org/browse/way/132914664) SEVERE (RouteNode): E:\openmtbmap\maps\63670116.osm.pbf: 10 or more arcs with the same initial bearing, expect routing problems at 46.553374,11.778210 when routing to 17░ (http://www.openstreetmap.org/browse/way/239751200) On 15 March 2018 at 09:53, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, further thoughts about this: Up to now we concentrate on problems caused by rouding errors when OSM (~32 bit) coordinates are placed on the 24 Garmin raster. What about places where OSM data already contains overlapping highways? I think there is currently no code in mkgmap to handle this properly. Don't know if we can find rules to handle this, if not we should print warning messages, as it is likely to cause trouble. Overlapping can mean : * two different OSM ways with identical sequences of 2 or more nodes, e.g. a-b-c-d and x-b-c-y * two different OSM ways with identical sequences of 2 or more nodes, but in reversed order, e.g. a-b-c-d and x--d-c-y My understanding is that these are mapping errors, but as said before there is no code to detect this. There might be warnings, e.g. in the housenumber code. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> Gesendet: Mittwoch, 14. März 2018 17:25:22 An: mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, yes, change it to a gigher value first. Gerd Felix Hartmann-2 wrote
Hi Gerd,
I get a huge huge list - and the ones I tried seemed to be quite alright - but the couple that I checked where simply ways that my styles inserts at least 3-4 times (usually ways with hiking/mtb route). Should I increase the counter in the patch to 5 (I guess still alright) or to 6 (I'm pretty sure I get routing errors then)?
Felix
-- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
well I think if ways are overlapping which have identical nodes it should be possible to throw away according to say this prinicple: a) identical tags (except name which is not important) - throw away the copy/copies. I think here it is clear the copies are not needed. b) identical tags (except name) plus more tags. Eg way 1 has: key1=a key2=b way 2 has key1=a, key2=b key3=c. So throw away way1. If there is however way 1 has: key1=a key2=b key3=c way 2 has key1=a, key2=b key4=d. it is more complicated but it could still be merged to a single way consisting of key1=a, key2=b, key3=c, key4=d if way 1 has: key1=a key2=b key3=c way 2 has key1=a, key2=b key3=d we could keep both ways, or throw away one of them - but yeah then it is not clear which one so better keep. For the problems related to http://www.openstreetmap.org/b rowse/way/310376420 and the other 2 ways. Following a) removes one copy. Following rule b) would actually get rid of the second copy and now information/detail will be lost. I'll try the new patch and see if I can find out more about problems. BTW - would it not be better to just use a test map for finding the error? I'm pretty sure any 6 routable roads on top of each other (identical direction) cause routing to break on Oregon 600. As soon as some way is slightly different angle - it is fine.
Hi Felix, well, up to now I thought that you want to fix the problem in your style and just need help to find out where it happens. I still don't understand why your style adds so many routable lines, in my eyes this is an errpr on your side. But you may be right, mkgmap might be able to change the bearing values of an arc when there are too many equal ones. You never told me what exactly I should do to reproduce a problem. In previous posts you wrote about crashes, now you mention broken routing. I guess this still only happens on the device? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Dienstag, 20. März 2018 13:23:37 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. well I think if ways are overlapping which have identical nodes it should be possible to throw away according to say this prinicple: a) identical tags (except name which is not important) - throw away the copy/copies. I think here it is clear the copies are not needed. b) identical tags (except name) plus more tags. Eg way 1 has: key1=a key2=b way 2 has key1=a, key2=b key3=c. So throw away way1. If there is however way 1 has: key1=a key2=b key3=c way 2 has key1=a, key2=b key4=d. it is more complicated but it could still be merged to a single way consisting of key1=a, key2=b, key3=c, key4=d if way 1 has: key1=a key2=b key3=c way 2 has key1=a, key2=b key3=d we could keep both ways, or throw away one of them - but yeah then it is not clear which one so better keep. For the problems related to http://www.openstreetmap.org/browse/way/310376420 and the other 2 ways. Following a) removes one copy. Following rule b) would actually get rid of the second copy and now information/detail will be lost. I'll try the new patch and see if I can find out more about problems. BTW - would it not be better to just use a test map for finding the error? I'm pretty sure any 6 routable roads on top of each other (identical direction) cause routing to break on Oregon 600. As soon as some way is slightly different angle - it is fine.
Yes it only happens on device. Simulating routing via: http://www.openstreetmap.org/browse/way/310376420 will in this case not switch off the device, but just get stuck. Map moving forward/backwards slightly. Here you could reproduce it by simply doubling the routable lines - one routable line for highway=path, another one for the relation route=hiking or route=mtb. 6 Routable lines (which are not oneway) with exactly the same way on top of each other are enough to reliably cause the Oregon 600 to break routing in my experience. The arc list actually helped me to identify some common problems in my style so I could reduce some routable lines - but in my experience adding several lines on top of each other - with different road_class/road_speed helps prioritise those ways. For highways this is not needed - as they are straight. But with mountain pathes - often a road_class 4, road_speed 2 is already too high importance to be chosen for curvy pathes, so adding a road_class 3, road_speed 1, and road_class 1, road_speed 0 will help to prioritize such ways. Also adding relations as routable lines often helps in so far that at least according to gpsmapedit they have much less routable nodes than the underlying way - so maybe that helps prioritizing them too? Felix On 20 March 2018 at 17:30, Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote:
Hi Felix,
well, up to now I thought that you want to fix the problem in your style and just need help to find out where it happens. I still don't understand why your style adds so many routable lines, in my eyes this is an errpr on your side. But you may be right, mkgmap might be able to change the bearing values of an arc when there are too many equal ones. You never told me what exactly I should do to reproduce a problem. In previous posts you wrote about crashes, now you mention broken routing. I guess this still only happens on the device?
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Dienstag, 20. März 2018 13:23:37 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
well I think if ways are overlapping which have identical nodes it should be possible to throw away according to say this prinicple: a) identical tags (except name which is not important) - throw away the copy/copies. I think here it is clear the copies are not needed. b) identical tags (except name) plus more tags. Eg way 1 has: key1=a key2=b way 2 has key1=a, key2=b key3=c. So throw away way1. If there is however way 1 has: key1=a key2=b key3=c way 2 has key1=a, key2=b key4=d. it is more complicated but it could still be merged to a single way consisting of key1=a, key2=b, key3=c, key4=d if way 1 has: key1=a key2=b key3=c way 2 has key1=a, key2=b key3=d we could keep both ways, or throw away one of them - but yeah then it is not clear which one so better keep.
For the problems related to http://www.openstreetmap.org/ browse/way/310376420 and the other 2 ways. Following a) removes one copy. Following rule b) would actually get rid of the second copy and now information/detail will be lost.
I'll try the new patch and see if I can find out more about problems.
BTW - would it not be better to just use a test map for finding the error? I'm pretty sure any 6 routable roads on top of each other (identical direction) cause routing to break on Oregon 600. As soon as some way is slightly different angle - it is fine.
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
The new patch seems to work pretty well - most ways that are supposedly not routable (according to my understanding so far if there are 6 arcs or more it will break) are actually broken. Map (just unpack the lzma installer: https://openmtbmap.org/mtbitaly_test.exe All broken - in simulation routing gets stuck.: SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 8 or more arcs with the same initial bearing, expect routing problems at 44.528092,7.857529 when routing to 132░ ( http://www.openstreetmap.org/browse/way/310376420) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 7 or more arcs with the same initial bearing, expect routing problems at 44.528092,7.857529 when routing to 132░ ( http://www.openstreetmap.org/browse/way/310376420) SEVERE (RouteNode): E:\openmtbmap\maps\63670068.osm.pbf: 7 or more arcs with the same initial bearing, expect routing problems at 45.984356,9.206016 when routing to 203░ ( http://www.openstreetmap.org/browse/way/273387447) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.750019,12.707582 when routing to 189░ ( http://www.openstreetmap.org/browse/way/457631339) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.749947,12.707799 when routing to 294░ ( http://www.openstreetmap.org/browse/way/457631339) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.749966,12.707912 when routing to 258░ ( http://www.openstreetmap.org/browse/way/457631339) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746202,12.752692 when routing to 109░ ( http://www.openstreetmap.org/browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746165,12.752832 when routing to 99░ ( http://www.openstreetmap.org/browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746144,12.753007 when routing to 113░ ( http://www.openstreetmap.org/browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746083,12.753196 when routing to 117░ ( http://www.openstreetmap.org/browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746027,12.753341 when routing to 130░ ( http://www.openstreetmap.org/browse/way/303828386) Funnily this one works and routing is not broken: SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.903471,13.182355 when routing to 245░ ( http://www.openstreetmap.org/browse/way/519285722) I'll test some more tomorrow or in the upcoming days. I always tested both directions just to make sure and could not see a difference. All of them are based on OSM mapping error with (several) ways overlapping each other. If mkgmap could drop identical ways (disrespecting the name field, or even better remove ways that have the same routing profile) it would already solve all but the first problematic way. On 20 March 2018 at 20:44, Felix Hartmann <extremecarver@gmail.com> wrote:
Yes it only happens on device. Simulating routing via: http://www.openstreetmap.org/browse/way/310376420 will in this case not switch off the device, but just get stuck. Map moving forward/backwards slightly. Here you could reproduce it by simply doubling the routable lines - one routable line for highway=path, another one for the relation route=hiking or route=mtb. 6 Routable lines (which are not oneway) with exactly the same way on top of each other are enough to reliably cause the Oregon 600 to break routing in my experience.
The arc list actually helped me to identify some common problems in my style so I could reduce some routable lines - but in my experience adding several lines on top of each other - with different road_class/road_speed helps prioritise those ways. For highways this is not needed - as they are straight. But with mountain pathes - often a road_class 4, road_speed 2 is already too high importance to be chosen for curvy pathes, so adding a road_class 3, road_speed 1, and road_class 1, road_speed 0 will help to prioritize such ways. Also adding relations as routable lines often helps in so far that at least according to gpsmapedit they have much less routable nodes than the underlying way - so maybe that helps prioritizing them too?
Felix
On 20 March 2018 at 17:30, Gerd Petermann <gpetermann_muenchen@hotmail.com
wrote:
Hi Felix,
well, up to now I thought that you want to fix the problem in your style and just need help to find out where it happens. I still don't understand why your style adds so many routable lines, in my eyes this is an errpr on your side. But you may be right, mkgmap might be able to change the bearing values of an arc when there are too many equal ones. You never told me what exactly I should do to reproduce a problem. In previous posts you wrote about crashes, now you mention broken routing. I guess this still only happens on the device?
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Dienstag, 20. März 2018 13:23:37 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
well I think if ways are overlapping which have identical nodes it should be possible to throw away according to say this prinicple: a) identical tags (except name which is not important) - throw away the copy/copies. I think here it is clear the copies are not needed. b) identical tags (except name) plus more tags. Eg way 1 has: key1=a key2=b way 2 has key1=a, key2=b key3=c. So throw away way1. If there is however way 1 has: key1=a key2=b key3=c way 2 has key1=a, key2=b key4=d. it is more complicated but it could still be merged to a single way consisting of key1=a, key2=b, key3=c, key4=d if way 1 has: key1=a key2=b key3=c way 2 has key1=a, key2=b key3=d we could keep both ways, or throw away one of them - but yeah then it is not clear which one so better keep.
For the problems related to http://www.openstreetmap.org/b rowse/way/310376420 and the other 2 ways. Following a) removes one copy. Following rule b) would actually get rid of the second copy and now information/detail will be lost.
I'll try the new patch and see if I can find out more about problems.
BTW - would it not be better to just use a test map for finding the error? I'm pretty sure any 6 routable roads on top of each other (identical direction) cause routing to break on Oregon 600. As soon as some way is slightly different angle - it is fine.
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Just for testing to make it much easier - here are the routes: https://openmtbmap.org/Test_routes.gdb On 20 March 2018 at 23:19, Felix Hartmann <extremecarver@gmail.com> wrote:
The new patch seems to work pretty well - most ways that are supposedly not routable (according to my understanding so far if there are 6 arcs or more it will break) are actually broken.
Map (just unpack the lzma installer: https://openmtbmap.org/ mtbitaly_test.exe
All broken - in simulation routing gets stuck.: SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 8 or more arcs with the same initial bearing, expect routing problems at 44.528092,7.857529 when routing to 132░ (http://www.openstreetmap.org/browse/way/310376420) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 7 or more arcs with the same initial bearing, expect routing problems at 44.528092,7.857529 when routing to 132░ (http://www.openstreetmap.org/browse/way/310376420) SEVERE (RouteNode): E:\openmtbmap\maps\63670068.osm.pbf: 7 or more arcs with the same initial bearing, expect routing problems at 45.984356,9.206016 when routing to 203░ (http://www.openstreetmap.org/ browse/way/273387447) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.750019,12.707582 when routing to 189░ (http://www.openstreetmap.org/ browse/way/457631339) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.749947,12.707799 when routing to 294░ (http://www.openstreetmap.org/ browse/way/457631339) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.749966,12.707912 when routing to 258░ (http://www.openstreetmap.org/ browse/way/457631339) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746202,12.752692 when routing to 109░ (http://www.openstreetmap.org/ browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746165,12.752832 when routing to 99░ (http://www.openstreetmap.org/ browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746144,12.753007 when routing to 113░ (http://www.openstreetmap.org/ browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746083,12.753196 when routing to 117░ (http://www.openstreetmap.org/ browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746027,12.753341 when routing to 130░ (http://www.openstreetmap.org/ browse/way/303828386)
Funnily this one works and routing is not broken: SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.903471,13.182355 when routing to 245░ (http://www.openstreetmap.org/ browse/way/519285722)
I'll test some more tomorrow or in the upcoming days. I always tested both directions just to make sure and could not see a difference. All of them are based on OSM mapping error with (several) ways overlapping each other. If mkgmap could drop identical ways (disrespecting the name field, or even better remove ways that have the same routing profile) it would already solve all but the first problematic way.
On 20 March 2018 at 20:44, Felix Hartmann <extremecarver@gmail.com> wrote:
Yes it only happens on device. Simulating routing via: http://www.openstreetmap.org/browse/way/310376420 will in this case not switch off the device, but just get stuck. Map moving forward/backwards slightly. Here you could reproduce it by simply doubling the routable lines - one routable line for highway=path, another one for the relation route=hiking or route=mtb. 6 Routable lines (which are not oneway) with exactly the same way on top of each other are enough to reliably cause the Oregon 600 to break routing in my experience.
The arc list actually helped me to identify some common problems in my style so I could reduce some routable lines - but in my experience adding several lines on top of each other - with different road_class/road_speed helps prioritise those ways. For highways this is not needed - as they are straight. But with mountain pathes - often a road_class 4, road_speed 2 is already too high importance to be chosen for curvy pathes, so adding a road_class 3, road_speed 1, and road_class 1, road_speed 0 will help to prioritize such ways. Also adding relations as routable lines often helps in so far that at least according to gpsmapedit they have much less routable nodes than the underlying way - so maybe that helps prioritizing them too?
Felix
On 20 March 2018 at 17:30, Gerd Petermann <gpetermann_muenchen@hotmail.c om> wrote:
Hi Felix,
well, up to now I thought that you want to fix the problem in your style and just need help to find out where it happens. I still don't understand why your style adds so many routable lines, in my eyes this is an errpr on your side. But you may be right, mkgmap might be able to change the bearing values of an arc when there are too many equal ones. You never told me what exactly I should do to reproduce a problem. In previous posts you wrote about crashes, now you mention broken routing. I guess this still only happens on the device?
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Dienstag, 20. März 2018 13:23:37 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
well I think if ways are overlapping which have identical nodes it should be possible to throw away according to say this prinicple: a) identical tags (except name which is not important) - throw away the copy/copies. I think here it is clear the copies are not needed. b) identical tags (except name) plus more tags. Eg way 1 has: key1=a key2=b way 2 has key1=a, key2=b key3=c. So throw away way1. If there is however way 1 has: key1=a key2=b key3=c way 2 has key1=a, key2=b key4=d. it is more complicated but it could still be merged to a single way consisting of key1=a, key2=b, key3=c, key4=d if way 1 has: key1=a key2=b key3=c way 2 has key1=a, key2=b key3=d we could keep both ways, or throw away one of them - but yeah then it is not clear which one so better keep.
For the problems related to http://www.openstreetmap.org/b rowse/way/310376420 and the other 2 ways. Following a) removes one copy. Following rule b) would actually get rid of the second copy and now information/detail will be lost.
I'll try the new patch and see if I can find out more about problems.
BTW - would it not be better to just use a test map for finding the error? I'm pretty sure any 6 routable roads on top of each other (identical direction) cause routing to break on Oregon 600. As soon as some way is slightly different angle - it is fine.
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Felix, okay, I can reproduce the problem with your map and gdb file on my Oregon. If I got that right overlapping highways are likely to cause multiple identical arcs. I think it should be rather easy to detect and remove them (together with the reverse arc), so I'll try to code that first. Regarding the "funny" example that doesn't break routing: I'll have a closer look. Maybe it's also the order of the arcs that matters, maybe this one works because there are only two nodes with dulicate arcs. I think the other examples contain more. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Dienstag, 20. März 2018 23:35:06 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Just for testing to make it much easier - here are the routes: https://openmtbmap.org/Test_routes.gdb On 20 March 2018 at 23:19, Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> wrote: The new patch seems to work pretty well - most ways that are supposedly not routable (according to my understanding so far if there are 6 arcs or more it will break) are actually broken. Map (just unpack the lzma installer: https://openmtbmap.org/mtbitaly_test.exe All broken - in simulation routing gets stuck.: SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 8 or more arcs with the same initial bearing, expect routing problems at 44.528092<tel:528092>,7.857529 when routing to 132░ (http://www.openstreetmap.org/browse/way/310376420) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 7 or more arcs with the same initial bearing, expect routing problems at 44.528092<tel:528092>,7.857529 when routing to 132░ (http://www.openstreetmap.org/browse/way/310376420) SEVERE (RouteNode): E:\openmtbmap\maps\63670068.osm.pbf: 7 or more arcs with the same initial bearing, expect routing problems at 45.984356,9.206016 when routing to 203░ (http://www.openstreetmap.org/browse/way/273387447) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.750019,12.707582 when routing to 189░ (http://www.openstreetmap.org/browse/way/457631339) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.749947,12.707799 when routing to 294░ (http://www.openstreetmap.org/browse/way/457631339) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.749966,12.707912 when routing to 258░ (http://www.openstreetmap.org/browse/way/457631339) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746202,12.752692 when routing to 109░ (http://www.openstreetmap.org/browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746165,12.752832 when routing to 99░ (http://www.openstreetmap.org/browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746144,12.753007 when routing to 113░ (http://www.openstreetmap.org/browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746083,12.753196 when routing to 117░ (http://www.openstreetmap.org/browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746027,12.753341 when routing to 130░ (http://www.openstreetmap.org/browse/way/303828386) Funnily this one works and routing is not broken: SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.903471,13.182355 when routing to 245░ (http://www.openstreetmap.org/browse/way/519285722) I'll test some more tomorrow or in the upcoming days. I always tested both directions just to make sure and could not see a difference. All of them are based on OSM mapping error with (several) ways overlapping each other. If mkgmap could drop identical ways (disrespecting the name field, or even better remove ways that have the same routing profile) it would already solve all but the first problematic way. On 20 March 2018 at 20:44, Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> wrote: Yes it only happens on device. Simulating routing via: http://www.openstreetmap.org/browse/way/310376420 will in this case not switch off the device, but just get stuck. Map moving forward/backwards slightly. Here you could reproduce it by simply doubling the routable lines - one routable line for highway=path, another one for the relation route=hiking or route=mtb. 6 Routable lines (which are not oneway) with exactly the same way on top of each other are enough to reliably cause the Oregon 600 to break routing in my experience. The arc list actually helped me to identify some common problems in my style so I could reduce some routable lines - but in my experience adding several lines on top of each other - with different road_class/road_speed helps prioritise those ways. For highways this is not needed - as they are straight. But with mountain pathes - often a road_class 4, road_speed 2 is already too high importance to be chosen for curvy pathes, so adding a road_class 3, road_speed 1, and road_class 1, road_speed 0 will help to prioritize such ways. Also adding relations as routable lines often helps in so far that at least according to gpsmapedit they have much less routable nodes than the underlying way - so maybe that helps prioritizing them too? Felix On 20 March 2018 at 17:30, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, well, up to now I thought that you want to fix the problem in your style and just need help to find out where it happens. I still don't understand why your style adds so many routable lines, in my eyes this is an errpr on your side. But you may be right, mkgmap might be able to change the bearing values of an arc when there are too many equal ones. You never told me what exactly I should do to reproduce a problem. In previous posts you wrote about crashes, now you mention broken routing. I guess this still only happens on the device? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Dienstag, 20. März 2018 13:23:37 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. well I think if ways are overlapping which have identical nodes it should be possible to throw away according to say this prinicple: a) identical tags (except name which is not important) - throw away the copy/copies. I think here it is clear the copies are not needed. b) identical tags (except name) plus more tags. Eg way 1 has: key1=a key2=b way 2 has key1=a, key2=b key3=c. So throw away way1. If there is however way 1 has: key1=a key2=b key3=c way 2 has key1=a, key2=b key4=d. it is more complicated but it could still be merged to a single way consisting of key1=a, key2=b, key3=c, key4=d if way 1 has: key1=a key2=b key3=c way 2 has key1=a, key2=b key3=d we could keep both ways, or throw away one of them - but yeah then it is not clear which one so better keep. For the problems related to http://www.openstreetmap.org/browse/way/310376420 and the other 2 ways. Following a) removes one copy. Following rule b) would actually get rid of the second copy and now information/detail will be lost. I'll try the new patch and see if I can find out more about problems. BTW - would it not be better to just use a test map for finding the error? I'm pretty sure any 6 routable roads on top of each other (identical direction) cause routing to break on Oregon 600. As soon as some way is slightly different angle - it is fine. _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Okay - 5 Arcs are sometimes causing problems too - but it's like a 50/50 chance. Also if at the very beginning of a route - there are 6 Arcs - then the Oregon will somehow just skip it and get into the route. So actually some of the samples that follow work, because of that. In general even if one arc is related to oneway line, it seems that both directions are affected. 4 Arcs seems to be always safe. Tested a couple and it never failed. https://openmtbmap.org/More_Tests.gdb On 21 March 2018 at 10:23, Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote:
Hi Felix,
okay, I can reproduce the problem with your map and gdb file on my Oregon. If I got that right overlapping highways are likely to cause multiple identical arcs. I think it should be rather easy to detect and remove them (together with the reverse arc), so I'll try to code that first. Regarding the "funny" example that doesn't break routing: I'll have a closer look. Maybe it's also the order of the arcs that matters, maybe this one works because there are only two nodes with dulicate arcs. I think the other examples contain more.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Dienstag, 20. März 2018 23:35:06 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Just for testing to make it much easier - here are the routes: https://openmtbmap.org/Test_routes.gdb
On 20 March 2018 at 23:19, Felix Hartmann <extremecarver@gmail.com<mailto: extremecarver@gmail.com>> wrote: The new patch seems to work pretty well - most ways that are supposedly not routable (according to my understanding so far if there are 6 arcs or more it will break) are actually broken.
Map (just unpack the lzma installer: https://openmtbmap.org/ mtbitaly_test.exe
All broken - in simulation routing gets stuck.: SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 8 or more arcs with the same initial bearing, expect routing problems at 44.528092<tel: 528092>,7.857529 when routing to 132░ (http://www.openstreetmap.org/ browse/way/310376420) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 7 or more arcs with the same initial bearing, expect routing problems at 44.528092<tel: 528092>,7.857529 when routing to 132░ (http://www.openstreetmap.org/ browse/way/310376420) SEVERE (RouteNode): E:\openmtbmap\maps\63670068.osm.pbf: 7 or more arcs with the same initial bearing, expect routing problems at 45.984356,9.206016 when routing to 203░ (http://www.openstreetmap.org/ browse/way/273387447) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.750019,12.707582 when routing to 189░ (http://www.openstreetmap.org/ browse/way/457631339) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.749947,12.707799 when routing to 294░ (http://www.openstreetmap.org/ browse/way/457631339) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.749966,12.707912 when routing to 258░ (http://www.openstreetmap.org/ browse/way/457631339) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746202,12.752692 when routing to 109░ (http://www.openstreetmap.org/ browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746165,12.752832 when routing to 99░ (http://www.openstreetmap.org/ browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746144,12.753007 when routing to 113░ (http://www.openstreetmap.org/ browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746083,12.753196 when routing to 117░ (http://www.openstreetmap.org/ browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746027,12.753341 when routing to 130░ (http://www.openstreetmap.org/ browse/way/303828386)
Funnily this one works and routing is not broken: SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.903471,13.182355 when routing to 245░ (http://www.openstreetmap.org/ browse/way/519285722)
I'll test some more tomorrow or in the upcoming days. I always tested both directions just to make sure and could not see a difference. All of them are based on OSM mapping error with (several) ways overlapping each other. If mkgmap could drop identical ways (disrespecting the name field, or even better remove ways that have the same routing profile) it would already solve all but the first problematic way.
On 20 March 2018 at 20:44, Felix Hartmann <extremecarver@gmail.com<mailto: extremecarver@gmail.com>> wrote: Yes it only happens on device. Simulating routing via: http://www.openstreetmap.org/browse/way/310376420 will in this case not switch off the device, but just get stuck. Map moving forward/backwards slightly. Here you could reproduce it by simply doubling the routable lines - one routable line for highway=path, another one for the relation route=hiking or route=mtb. 6 Routable lines (which are not oneway) with exactly the same way on top of each other are enough to reliably cause the Oregon 600 to break routing in my experience.
The arc list actually helped me to identify some common problems in my style so I could reduce some routable lines - but in my experience adding several lines on top of each other - with different road_class/road_speed helps prioritise those ways. For highways this is not needed - as they are straight. But with mountain pathes - often a road_class 4, road_speed 2 is already too high importance to be chosen for curvy pathes, so adding a road_class 3, road_speed 1, and road_class 1, road_speed 0 will help to prioritize such ways. Also adding relations as routable lines often helps in so far that at least according to gpsmapedit they have much less routable nodes than the underlying way - so maybe that helps prioritizing them too?
Felix
On 20 March 2018 at 17:30, Gerd Petermann <gpetermann_muenchen@hotmail.com <mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix,
well, up to now I thought that you want to fix the problem in your style and just need help to find out where it happens. I still don't understand why your style adds so many routable lines, in my eyes this is an errpr on your side. But you may be right, mkgmap might be able to change the bearing values of an arc when there are too many equal ones. You never told me what exactly I should do to reproduce a problem. In previous posts you wrote about crashes, now you mention broken routing. I guess this still only happens on the device?
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann < extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Dienstag, 20. März 2018 13:23:37 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
well I think if ways are overlapping which have identical nodes it should be possible to throw away according to say this prinicple: a) identical tags (except name which is not important) - throw away the copy/copies. I think here it is clear the copies are not needed. b) identical tags (except name) plus more tags. Eg way 1 has: key1=a key2=b way 2 has key1=a, key2=b key3=c. So throw away way1. If there is however way 1 has: key1=a key2=b key3=c way 2 has key1=a, key2=b key4=d. it is more complicated but it could still be merged to a single way consisting of key1=a, key2=b, key3=c, key4=d if way 1 has: key1=a key2=b key3=c way 2 has key1=a, key2=b key3=d we could keep both ways, or throw away one of them - but yeah then it is not clear which one so better keep.
For the problems related to http://www.openstreetmap.org/ browse/way/310376420 and the other 2 ways. Following a) removes one copy. Following rule b) would actually get rid of the second copy and now information/detail will be lost.
I'll try the new patch and see if I can find out more about problems.
BTW - would it not be better to just use a test map for finding the error? I'm pretty sure any 6 routable roads on top of each other (identical direction) cause routing to break on Oregon 600. As soon as some way is slightly different angle - it is fine.
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Felix, I tried to remove duplicate arcs but that is probably not allowed. Mapsource says that there is an error in the map product when I try to route over the remaining arcs. Maybe not always but it doesn't look promising. I've noted that even with the default style you get many duplicated arcs, for example here: The oneway residential road https://www.openstreetmap.org/way/183285165 is overlapped by hw=residential + area=yes https://www.openstreetmap.org/way/393299955 Interesting is that Mapsource seems to ignore the arcs produced way 393299955 because it will not route in the wrong direction of the oneway. So, I'm back at somehow changing the heading values now. This turned out to be quite simple. We already have code in AngleChecker to modify heading values so that junctions don't show sharp angles. Please try attached patch in combination with your version of count-same-bearing-v2.patch. This patch changes groups of arcs with equal initial heading (delta < 1°) so that they are stored with slightly different heading values. You should see no more messages from the count patch and - crossing my fingers - better routing. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Mittwoch, 21. März 2018 14:01:49 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Okay - 5 Arcs are sometimes causing problems too - but it's like a 50/50 chance. Also if at the very beginning of a route - there are 6 Arcs - then the Oregon will somehow just skip it and get into the route. So actually some of the samples that follow work, because of that. In general even if one arc is related to oneway line, it seems that both directions are affected. 4 Arcs seems to be always safe. Tested a couple and it never failed. https://openmtbmap.org/More_Tests.gdb On 21 March 2018 at 10:23, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, okay, I can reproduce the problem with your map and gdb file on my Oregon. If I got that right overlapping highways are likely to cause multiple identical arcs. I think it should be rather easy to detect and remove them (together with the reverse arc), so I'll try to code that first. Regarding the "funny" example that doesn't break routing: I'll have a closer look. Maybe it's also the order of the arcs that matters, maybe this one works because there are only two nodes with dulicate arcs. I think the other examples contain more. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Dienstag, 20. März 2018 23:35:06 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Just for testing to make it much easier - here are the routes: https://openmtbmap.org/Test_routes.gdb On 20 March 2018 at 23:19, Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> wrote: The new patch seems to work pretty well - most ways that are supposedly not routable (according to my understanding so far if there are 6 arcs or more it will break) are actually broken. Map (just unpack the lzma installer: https://openmtbmap.org/mtbitaly_test.exe All broken - in simulation routing gets stuck.: SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 8 or more arcs with the same initial bearing, expect routing problems at 44.528092<tel:528092><tel:528092<tel:528092>>,7.857529 when routing to 132░ (http://www.openstreetmap.org/browse/way/310376420) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 7 or more arcs with the same initial bearing, expect routing problems at 44.528092<tel:528092><tel:528092<tel:528092>>,7.857529 when routing to 132░ (http://www.openstreetmap.org/browse/way/310376420) SEVERE (RouteNode): E:\openmtbmap\maps\63670068.osm.pbf: 7 or more arcs with the same initial bearing, expect routing problems at 45.984356,9.206016 when routing to 203░ (http://www.openstreetmap.org/browse/way/273387447) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.750019,12.707582 when routing to 189░ (http://www.openstreetmap.org/browse/way/457631339) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.749947,12.707799 when routing to 294░ (http://www.openstreetmap.org/browse/way/457631339) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.749966,12.707912 when routing to 258░ (http://www.openstreetmap.org/browse/way/457631339) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746202,12.752692 when routing to 109░ (http://www.openstreetmap.org/browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746165,12.752832 when routing to 99░ (http://www.openstreetmap.org/browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746144,12.753007 when routing to 113░ (http://www.openstreetmap.org/browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746083,12.753196 when routing to 117░ (http://www.openstreetmap.org/browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746027,12.753341 when routing to 130░ (http://www.openstreetmap.org/browse/way/303828386) Funnily this one works and routing is not broken: SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.903471,13.182355 when routing to 245░ (http://www.openstreetmap.org/browse/way/519285722) I'll test some more tomorrow or in the upcoming days. I always tested both directions just to make sure and could not see a difference. All of them are based on OSM mapping error with (several) ways overlapping each other. If mkgmap could drop identical ways (disrespecting the name field, or even better remove ways that have the same routing profile) it would already solve all but the first problematic way. On 20 March 2018 at 20:44, Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> wrote: Yes it only happens on device. Simulating routing via: http://www.openstreetmap.org/browse/way/310376420 will in this case not switch off the device, but just get stuck. Map moving forward/backwards slightly. Here you could reproduce it by simply doubling the routable lines - one routable line for highway=path, another one for the relation route=hiking or route=mtb. 6 Routable lines (which are not oneway) with exactly the same way on top of each other are enough to reliably cause the Oregon 600 to break routing in my experience. The arc list actually helped me to identify some common problems in my style so I could reduce some routable lines - but in my experience adding several lines on top of each other - with different road_class/road_speed helps prioritise those ways. For highways this is not needed - as they are straight. But with mountain pathes - often a road_class 4, road_speed 2 is already too high importance to be chosen for curvy pathes, so adding a road_class 3, road_speed 1, and road_class 1, road_speed 0 will help to prioritize such ways. Also adding relations as routable lines often helps in so far that at least according to gpsmapedit they have much less routable nodes than the underlying way - so maybe that helps prioritizing them too? Felix On 20 March 2018 at 17:30, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix, well, up to now I thought that you want to fix the problem in your style and just need help to find out where it happens. I still don't understand why your style adds so many routable lines, in my eyes this is an errpr on your side. But you may be right, mkgmap might be able to change the bearing values of an arc when there are too many equal ones. You never told me what exactly I should do to reproduce a problem. In previous posts you wrote about crashes, now you mention broken routing. I guess this still only happens on the device? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> Gesendet: Dienstag, 20. März 2018 13:23:37 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. well I think if ways are overlapping which have identical nodes it should be possible to throw away according to say this prinicple: a) identical tags (except name which is not important) - throw away the copy/copies. I think here it is clear the copies are not needed. b) identical tags (except name) plus more tags. Eg way 1 has: key1=a key2=b way 2 has key1=a, key2=b key3=c. So throw away way1. If there is however way 1 has: key1=a key2=b key3=c way 2 has key1=a, key2=b key4=d. it is more complicated but it could still be merged to a single way consisting of key1=a, key2=b, key3=c, key4=d if way 1 has: key1=a key2=b key3=c way 2 has key1=a, key2=b key3=d we could keep both ways, or throw away one of them - but yeah then it is not clear which one so better keep. For the problems related to http://www.openstreetmap.org/browse/way/310376420 and the other 2 ways. Following a) removes one copy. Following rule b) would actually get rid of the second copy and now information/detail will be lost. I'll try the new patch and see if I can find out more about problems. BTW - would it not be better to just use a test map for finding the error? I'm pretty sure any 6 routable roads on top of each other (identical direction) cause routing to break on Oregon 600. As soon as some way is slightly different angle - it is fine. _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Gerd Doesn't it cause problems at roundabouts for messages like 'leave at 3rd exit' Henning On 22 Mar 2018, 23:56, at 23:56, Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote:
Hi Felix,
I tried to remove duplicate arcs but that is probably not allowed. Mapsource says that there is an error in the map product when I try to route over the remaining arcs. Maybe not always but it doesn't look promising. I've noted that even with the default style you get many duplicated arcs, for example here: The oneway residential road https://www.openstreetmap.org/way/183285165 is overlapped by hw=residential + area=yes https://www.openstreetmap.org/way/393299955 Interesting is that Mapsource seems to ignore the arcs produced way 393299955 because it will not route in the wrong direction of the oneway.
So, I'm back at somehow changing the heading values now. This turned out to be quite simple. We already have code in AngleChecker to modify heading values so that junctions don't show sharp angles. Please try attached patch in combination with your version of count-same-bearing-v2.patch. This patch changes groups of arcs with equal initial heading (delta < 1°) so that they are stored with slightly different heading values. You should see no more messages from the count patch and - crossing my fingers - better routing.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Mittwoch, 21. März 2018 14:01:49 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Okay - 5 Arcs are sometimes causing problems too - but it's like a 50/50 chance. Also if at the very beginning of a route - there are 6 Arcs - then the Oregon will somehow just skip it and get into the route. So actually some of the samples that follow work, because of that. In general even if one arc is related to oneway line, it seems that both directions are affected.
4 Arcs seems to be always safe. Tested a couple and it never failed.
https://openmtbmap.org/More_Tests.gdb
On 21 March 2018 at 10:23, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix,
okay, I can reproduce the problem with your map and gdb file on my Oregon. If I got that right overlapping highways are likely to cause multiple identical arcs. I think it should be rather easy to detect and remove them (together with the reverse arc), so I'll try to code that first. Regarding the "funny" example that doesn't break routing: I'll have a closer look. Maybe it's also the order of the arcs that matters, maybe this one works because there are only two nodes with dulicate arcs. I think the other examples contain more.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Dienstag, 20. März 2018 23:35:06 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Just for testing to make it much easier - here are the routes: https://openmtbmap.org/Test_routes.gdb
On 20 March 2018 at 23:19, Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> wrote: The new patch seems to work pretty well - most ways that are supposedly not routable (according to my understanding so far if there are 6 arcs or more it will break) are actually broken.
Map (just unpack the lzma installer: https://openmtbmap.org/mtbitaly_test.exe
All broken - in simulation routing gets stuck.: SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 8 or more arcs with the same initial bearing, expect routing problems at 44.528092<tel:528092><tel:528092<tel:528092>>,7.857529 when routing to 132░ (http://www.openstreetmap.org/browse/way/310376420) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 7 or more arcs with the same initial bearing, expect routing problems at 44.528092<tel:528092><tel:528092<tel:528092>>,7.857529 when routing to 132░ (http://www.openstreetmap.org/browse/way/310376420) SEVERE (RouteNode): E:\openmtbmap\maps\63670068.osm.pbf: 7 or more arcs with the same initial bearing, expect routing problems at 45.984356,9.206016 when routing to 203░ (http://www.openstreetmap.org/browse/way/273387447) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.750019,12.707582 when routing to 189░ (http://www.openstreetmap.org/browse/way/457631339) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.749947,12.707799 when routing to 294░ (http://www.openstreetmap.org/browse/way/457631339) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.749966,12.707912 when routing to 258░ (http://www.openstreetmap.org/browse/way/457631339) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746202,12.752692 when routing to 109░ (http://www.openstreetmap.org/browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746165,12.752832 when routing to 99░ (http://www.openstreetmap.org/browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746144,12.753007 when routing to 113░ (http://www.openstreetmap.org/browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746083,12.753196 when routing to 117░ (http://www.openstreetmap.org/browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746027,12.753341 when routing to 130░ (http://www.openstreetmap.org/browse/way/303828386)
Funnily this one works and routing is not broken: SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.903471,13.182355 when routing to 245░ (http://www.openstreetmap.org/browse/way/519285722)
I'll test some more tomorrow or in the upcoming days. I always tested both directions just to make sure and could not see a difference. All of them are based on OSM mapping error with (several) ways overlapping each other. If mkgmap could drop identical ways (disrespecting the name field, or even better remove ways that have the same routing profile) it would already solve all but the first problematic way.
On 20 March 2018 at 20:44, Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> wrote: Yes it only happens on device. Simulating routing via: http://www.openstreetmap.org/browse/way/310376420 will in this case not switch off the device, but just get stuck. Map moving forward/backwards slightly. Here you could reproduce it by simply doubling the routable lines - one routable line for highway=path, another one for the relation route=hiking or route=mtb. 6 Routable lines (which are not oneway) with exactly the same way on top of each other are enough to reliably cause the Oregon 600 to break routing in my experience.
The arc list actually helped me to identify some common problems in my style so I could reduce some routable lines - but in my experience adding several lines on top of each other - with different road_class/road_speed helps prioritise those ways. For highways this is not needed - as they are straight. But with mountain pathes - often a road_class 4, road_speed 2 is already too high importance to be chosen for curvy pathes, so adding a road_class 3, road_speed 1, and road_class 1, road_speed 0 will help to prioritize such ways. Also adding relations as routable lines often helps in so far that at least according to gpsmapedit they have much less routable nodes than the underlying way - so maybe that helps prioritizing them too?
Felix
On 20 March 2018 at 17:30, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix,
well, up to now I thought that you want to fix the problem in your style and just need help to find out where it happens. I still don't understand why your style adds so many routable lines, in my eyes this is an errpr on your side. But you may be right, mkgmap might be able to change the bearing values of an arc when there are too many equal ones. You never told me what exactly I should do to reproduce a problem. In previous posts you wrote about crashes, now you mention broken routing. I guess this still only happens on the device?
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> Gesendet: Dienstag, 20. März 2018 13:23:37 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
well I think if ways are overlapping which have identical nodes it should be possible to throw away according to say this prinicple: a) identical tags (except name which is not important) - throw away the copy/copies. I think here it is clear the copies are not needed. b) identical tags (except name) plus more tags. Eg way 1 has: key1=a key2=b way 2 has key1=a, key2=b key3=c. So throw away way1. If there is however way 1 has: key1=a key2=b key3=c way 2 has key1=a, key2=b key4=d. it is more complicated but it could still be merged to a single way consisting of key1=a, key2=b, key3=c, key4=d if way 1 has: key1=a key2=b key3=c way 2 has key1=a, key2=b key3=d we could keep both ways, or throw away one of them - but yeah then it is not clear which one so better keep.
For the problems related to http://www.openstreetmap.org/browse/way/310376420 and the other 2 ways. Following a) removes one copy. Following rule b) would actually get rid of the second copy and now information/detail will be lost.
I'll try the new patch and see if I can find out more about problems.
BTW - would it not be better to just use a test map for finding the error? I'm pretty sure any 6 routable roads on top of each other (identical direction) cause routing to break on Oregon 600. As soon as some way is slightly different angle - it is fine.
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
------------------------------------------------------------------------
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Henning, Do you think that the patch causes problems? I'd be very surprised. Why do you think that? Do you have an example where this happens? The patch only changes the heading values, the expected effect is that the angles shown in the routing instructions differ by maybe 5° degrees. Maybe other arcs are preferred because of that, so yes, I expect effects on routing, but not a special effect at roundabouts. I've also created a test case where a roundabout is partly overlapped by a link road, still, Garmin shows the enter roundabout / leave roundabout messages. Maybe this was good luck, but my current thinking is that the Garmin algo reads the information about all available arcs and somehow prefers one without completely ignoring the others. I might still add code to print warnings for the case that (too) many arcs with the same heading are connected to one node, if you want that. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Henning Scholland <osm@hscholland.de> Gesendet: Donnerstag, 22. März 2018 17:08:27 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Gerd Doesn't it cause problems at roundabouts for messages like 'leave at 3rd exit' Henning On 22 Mar 2018, at 23:56, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, I tried to remove duplicate arcs but that is probably not allowed. Mapsource says that there is an error in the map product when I try to route over the remaining arcs. Maybe not always but it doesn't look promising. I've noted that even with the default style you get many duplicated arcs, for example here: The oneway residential road https://www.openstreetmap.org/way/183285165 is overlapped by hw=residential + area=yes https://www.openstreetmap.org/way/393299955 Interesting is that Mapsource seems to ignore the arcs produced way 393299955 because it will not route in the wrong direction of the oneway. So, I'm back at somehow changing the heading values now. This turned out to be quite simple. We already have code in AngleChecker to modify heading values so that junctions don't show sharp angles. Please try attached patch in combination with your version of count-same-bearing-v2.patch. This patch changes groups of arcs with equal initial heading (delta < 1°) so that they are stored with slightly different heading values. You should see no more messages from the count patch and - crossing my fingers - better routing. Gerd ________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Mittwoch, 21. März 2018 14:01:49 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Okay - 5 Arcs are sometimes causing problems too - but it's like a 50/50 chance. Also if at the very beginning of a route - there are 6 Arcs - then the Oregon will somehow just skip it and get into the route. So actually some of the samples that follow work, because of that. In general even if one arc is related to oneway line, it seems that both directions are affected. 4 Arcs seems to be always safe. Tested a couple and it never failed. https://openmtbmap.org/More_Tests.gdb On 21 March 2018 at 10:23, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, okay, I can reproduce the problem with your map and gdb file on my Oregon. If I got that right overlapping highways are likely to cause multiple identical arcs. I think it should be rather easy to detect and remove them (together with the reverse arc), so I'll try to code that first. Regarding the "funny" example that doesn't break routing: I'll have a closer look. Maybe it's also the order of the arcs that matters, maybe this one works because there are only two nodes with dulicate arcs. I think the other examples contain more. Gerd ________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Dienstag, 20. März 2018 23:35:06 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Just for testing to make it much easier - here are the routes: https://openmtbmap.org/Test_routes.gdb On 20 March 2018 at 23:19, Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> wrote: The new patch seems to work pretty well - most ways that are supposedly not routable (according to my understanding so far if there are 6 arcs or more it will break) are actually broken. Map (just unpack the lzma installer: https://openmtbmap.org/mtbitaly_test.exe All broken - in simulation routing gets stuck.: SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 8 or more arcs with the same initial bearing, expect routing problems at 44.528092<tel:528092><tel:528092<tel:528092>>,7.857529 when routing to 132░ (http://www.openstreetmap.org/browse/way/310376420) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 7 or more arcs with the same initial bearing, expect routing problems at 44.528092<tel:528092><tel:528092<tel:528092>>,7.857529 when routing to 132░ (http://www.openstreetmap.org/browse/way/310376420) SEVERE (RouteNode): E:\openmtbmap\maps\63670068.osm.pbf: 7 or more arcs with the same initial bearing, expect routing problems at 45.984356,9.206016 when routing to 203░ (http://www.openstreetmap.org/browse/way/273387447) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.750019,12.707582 when routing to 189░ (http://www.openstreetmap.org/browse/way/457631339) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.749947,12.707799 when routing to 294░ (http://www.openstreetmap.org/browse/way/457631339) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.749966,12.707912 when routing to 258░ (http://www.openstreetmap.org/browse/way/457631339) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746202,12.752692 when routing to 109░ (http://www.openstreetmap.org/browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746165,12.752832 when routing to 99░ (http://www.openstreetmap.org/browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746144,12.753007 when routing to 113░ (http://www.openstreetmap.org/browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746083,12.753196 when routing to 117░ (http://www.openstreetmap.org/browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746027,12.753341 when routing to 130░ (http://www.openstreetmap.org/browse/way/303828386) Funnily this one works and routing is not broken: SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.903471,13.182355 when routing to 245░ (http://www.openstreetmap.org/browse/way/519285722) I'll test some more tomorrow or in the upcoming days. I always tested both directions just to make sure and could not see a difference. All of them are based on OSM mapping error with (several) ways overlapping each other. If mkgmap could drop identical ways (disrespecting the name field, or even better remove ways that have the same routing profile) it would already solve all but the first problematic way. On 20 March 2018 at 20:44, Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> wrote: Yes it only happens on device. Simulating routing via: http://www.openstreetmap.org/browse/way/310376420 will in this case not switch off the device, but just get stuck. Map moving forward/backwards slightly. Here you could reproduce it by simply doubling the routable lines - one routable line for highway=path, another one for the relation route=hiking or route=mtb. 6 Routable lines (which are not oneway) with exactly the same way on top of each other are enough to reliably cause the Oregon 600 to break routing in my experience. The arc list actually helped me to identify some common problems in my style so I could reduce some routable lines - but in my experience adding several lines on top of each other - with different road_class/road_speed helps prioritise those ways. For highways this is not needed - as they are straight. But with mountain pathes - often a road_class 4, road_speed 2 is already too high importance to be chosen for curvy pathes, so adding a road_class 3, road_speed 1, and road_class 1, road_speed 0 will help to prioritize such ways. Also adding relations as routable lines often helps in so far that at least according to gpsmapedit they have much less routable nodes than the underlying way - so maybe that helps prioritizing them too? Felix On 20 March 2018 at 17:30, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix, well, up to now I thought that you want to fix the problem in your style and just need help to find out where it happens. I still don't understand why your style adds so many routable lines, in my eyes this is an errpr on your side. But you may be right, mkgmap might be able to change the bearing values of an arc when there are too many equal ones. You never told me what exactly I should do to reproduce a problem. In previous posts you wrote about crashes, now you mention broken routing. I guess this still only happens on the device? Gerd ________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> Gesendet: Dienstag, 20. März 2018 13:23:37 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. well I think if ways are overlapping which have identical nodes it should be possible to throw away according to say this prinicple: a) identical tags (except name which is not important) - throw away the copy/copies. I think here it is clear the copies are not needed. b) identical tags (except name) plus more tags. Eg way 1 has: key1=a key2=b way 2 has key1=a, key2=b key3=c. So throw away way1. If there is however way 1 has: key1=a key2=b key3=c way 2 has key1=a, key2=b key4=d. it is more complicated but it could still be merged to a single way consisting of key1=a, key2=b, key3=c, key4=d if way 1 has: key1=a key2=b key3=c way 2 has key1=a, key2=b key3=d we could keep both ways, or throw away one of them - but yeah then it is not clear which one so better keep. For the problems related to http://www.openstreetmap.org/browse/way/310376420 and the other 2 ways. Following a) removes one copy. Following rule b) would actually get rid of the second copy and now information/detail will be lost. I'll try the new patch and see if I can find out more about problems. BTW - would it not be better to just use a test map for finding the error? I'm pretty sure any 6 routable roads on top of each other (identical direction) cause routing to break on Oregon 600. As soon as some way is slightly different angle - it is fine. ________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich -- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich -- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd, I just was thinking about if one road is leaving the roundabout at two angles it may count on the Garmin as two roads and will lead to 'exit on 3rd exit' instead of 'exit on 2nd exit' for example. But I haven't gave it a try yet. Henning Sent from BlueMail On 23 Mar 2018, 09:07, at 09:07, Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote:
Hi Henning,
Do you think that the patch causes problems? I'd be very surprised. Why do you think that? Do you have an example where this happens? The patch only changes the heading values, the expected effect is that the angles shown in the routing instructions differ by maybe 5° degrees. Maybe other arcs are preferred because of that, so yes, I expect effects on routing, but not a special effect at roundabouts. I've also created a test case where a roundabout is partly overlapped by a link road, still, Garmin shows the enter roundabout / leave roundabout messages. Maybe this was good luck, but my current thinking is that the Garmin algo reads the information about all available arcs and somehow prefers one without completely ignoring the others.
I might still add code to print warnings for the case that (too) many arcs with the same heading are connected to one node, if you want that.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Henning Scholland <osm@hscholland.de> Gesendet: Donnerstag, 22. März 2018 17:08:27 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Gerd Doesn't it cause problems at roundabouts for messages like 'leave at 3rd exit' Henning On 22 Mar 2018, at 23:56, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote:
Hi Felix,
I tried to remove duplicate arcs but that is probably not allowed. Mapsource says that there is an error in the map product when I try to route over the remaining arcs. Maybe not always but it doesn't look promising. I've noted that even with the default style you get many duplicated arcs, for example here: The oneway residential road https://www.openstreetmap.org/way/183285165 is overlapped by hw=residential + area=yes https://www.openstreetmap.org/way/393299955 Interesting is that Mapsource seems to ignore the arcs produced way 393299955 because it will not route in the wrong direction of the oneway.
So, I'm back at somehow changing the heading values now. This turned out to be quite simple. We already have code in AngleChecker to modify heading values so that junctions don't show sharp angles. Please try attached patch in combination with your version of count-same-bearing-v2.patch. This patch changes groups of arcs with equal initial heading (delta < 1°) so that they are stored with slightly different heading values. You should see no more messages from the count patch and - crossing my fingers - better routing.
Gerd
________________________________
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Mittwoch, 21. März 2018 14:01:49 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Okay - 5 Arcs are sometimes causing problems too - but it's like a 50/50 chance. Also if at the very beginning of a route - there are 6 Arcs - then the Oregon will somehow just skip it and get into the route. So actually some of the samples that follow work, because of that. In general even if one arc is related to oneway line, it seems that both directions are affected.
4 Arcs seems to be always safe. Tested a couple and it never failed.
https://openmtbmap.org/More_Tests.gdb
On 21 March 2018 at 10:23, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix,
okay, I can reproduce the problem with your map and gdb file on my Oregon. If I got that right overlapping highways are likely to cause multiple identical arcs. I think it should be rather easy to detect and remove them (together with the reverse arc), so I'll try to code that first. Regarding the "funny" example that doesn't break routing: I'll have a closer look. Maybe it's also the order of the arcs that matters, maybe this one works because there are only two nodes with dulicate arcs. I think the other examples contain more.
Gerd
________________________________
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Dienstag, 20. März 2018 23:35:06 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Just for testing to make it much easier - here are the routes: https://openmtbmap.org/Test_routes.gdb
On 20 March 2018 at 23:19, Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> wrote: The new patch seems to work pretty well - most ways that are supposedly not routable (according to my understanding so far if there are 6 arcs or more it will break) are actually broken.
Map (just unpack the lzma installer: https://openmtbmap.org/mtbitaly_test.exe
All broken - in simulation routing gets stuck.: SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 8 or more arcs with the same initial bearing, expect routing problems at 44.528092<tel:528092><tel:528092<tel:528092>>,7.857529 when routing to 132░ (http://www.openstreetmap.org/browse/way/310376420) SEVERE (RouteNode): E:\openmtbmap\maps\63670040.osm.pbf: 7 or more arcs with the same initial bearing, expect routing problems at 44.528092<tel:528092><tel:528092<tel:528092>>,7.857529 when routing to 132░ (http://www.openstreetmap.org/browse/way/310376420) SEVERE (RouteNode): E:\openmtbmap\maps\63670068.osm.pbf: 7 or more arcs with the same initial bearing, expect routing problems at 45.984356,9.206016 when routing to 203░ (http://www.openstreetmap.org/browse/way/273387447) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.750019,12.707582 when routing to 189░ (http://www.openstreetmap.org/browse/way/457631339) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.749947,12.707799 when routing to 294░ (http://www.openstreetmap.org/browse/way/457631339) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.749966,12.707912 when routing to 258░ (http://www.openstreetmap.org/browse/way/457631339) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746202,12.752692 when routing to 109░ (http://www.openstreetmap.org/browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746165,12.752832 when routing to 99░ (http://www.openstreetmap.org/browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746144,12.753007 when routing to 113░ (http://www.openstreetmap.org/browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746083,12.753196 when routing to 117░ (http://www.openstreetmap.org/browse/way/303828386) SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.746027,12.753341 when routing to 130░ (http://www.openstreetmap.org/browse/way/303828386)
Funnily this one works and routing is not broken: SEVERE (RouteNode): E:\openmtbmap\maps\63670002.osm.pbf: 6 or more arcs with the same initial bearing, expect routing problems at 41.903471,13.182355 when routing to 245░ (http://www.openstreetmap.org/browse/way/519285722)
I'll test some more tomorrow or in the upcoming days. I always tested both directions just to make sure and could not see a difference. All of them are based on OSM mapping error with (several) ways overlapping each other. If mkgmap could drop identical ways (disrespecting the name field, or even better remove ways that have the same routing profile) it would already solve all but the first problematic way.
On 20 March 2018 at 20:44, Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> wrote: Yes it only happens on device. Simulating routing via: http://www.openstreetmap.org/browse/way/310376420 will in this case not switch off the device, but just get stuck. Map moving forward/backwards slightly. Here you could reproduce it by simply doubling the routable lines - one routable line for highway=path, another one for the relation route=hiking or route=mtb. 6 Routable lines (which are not oneway) with exactly the same way on top of each other are enough to reliably cause the Oregon 600 to break routing in my experience.
The arc list actually helped me to identify some common problems in my style so I could reduce some routable lines - but in my experience adding several lines on top of each other - with different road_class/road_speed helps prioritise those ways. For highways this is not needed - as they are straight. But with mountain pathes - often a road_class 4, road_speed 2 is already too high importance to be chosen for curvy pathes, so adding a road_class 3, road_speed 1, and road_class 1, road_speed 0 will help to prioritize such ways. Also adding relations as routable lines often helps in so far that at least according to gpsmapedit they have much less routable nodes than the underlying way - so maybe that helps prioritizing them too?
Felix
On 20 March 2018 at 17:30, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Felix,
well, up to now I thought that you want to fix the problem in your style and just need help to find out where it happens. I still don't understand why your style adds so many routable lines, in my eyes this is an errpr on your side. But you may be right, mkgmap might be able to change the bearing values of an arc when there are too many equal ones. You never told me what exactly I should do to reproduce a problem. In previous posts you wrote about crashes, now you mention broken routing. I guess this still only happens on the device?
Gerd
________________________________
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extremecarver@gmail.com>>> Gesendet: Dienstag, 20. März 2018 13:23:37 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
well I think if ways are overlapping which have identical nodes it should be possible to throw away according to say this prinicple: a) identical tags (except name which is not important) - throw away the copy/copies. I think here it is clear the copies are not needed. b) identical tags (except name) plus more tags. Eg way 1 has: key1=a key2=b way 2 has key1=a, key2=b key3=c. So throw away way1. If there is however way 1 has: key1=a key2=b key3=c way 2 has key1=a, key2=b key4=d. it is more complicated but it could still be merged to a single way consisting of key1=a, key2=b, key3=c, key4=d if way 1 has: key1=a key2=b key3=c way 2 has key1=a, key2=b key3=d we could keep both ways, or throw away one of them - but yeah then it is not clear which one so better keep.
For the problems related to http://www.openstreetmap.org/browse/way/310376420 and the other 2 ways. Following a) removes one copy. Following rule b) would actually get rid of the second copy and now information/detail will be lost.
I'll try the new patch and see if I can find out more about problems.
BTW - would it not be better to just use a test map for finding the error? I'm pretty sure any 6 routable roads on top of each other (identical direction) cause routing to break on Oregon 600. As soon as some way is slightly different angle - it is fine.
________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Henning, Henning Scholland wrote
Hi Gerd, I just was thinking about if one road is leaving the roundabout at two angles it may count on the Garmin as two roads and will lead to 'exit on 3rd exit' instead of 'exit on 2nd exit' for example.
But I haven't gave it a try yet.
ah, okay, got it. I think Garmin should calculate the number for the exit without "thinking" about the further route but who knows. I'd like to test it on my own but I found it too difficut to create a style that tries to do the same as Felix' style, and you don't get the same results when you simply add overlapping highways in JOSM. I am not aware of another style that adds multiple routable ways for one OSM way, and Felix doesn't want to share his, so testing is his work. I can only make educated guesses about the effects, and of course I'll test it with other styles before committing it. Gerd -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html
Well all the problems about problematic arcs so far came up from a combination of two things: a) my style creates two additional ways (bit different road_class/road_speed based on input) if the following is met: route relation hiking, bicycle or mtb | ( mtb:scale>0 & mtb:scale<5) | class:bicycle>1. Additionally if a road is oneway - and it's a low level road (so neither motorway,trunk,primary,secondary,tertiary) - and oneway, a low class/speed non oneway road is added as well (intention to have lower priority against the oneway than driving with the oneway direction. Also additionally if bicycle lane against the traffic flow is possible, it will create a line against the oneway. b) mistakes in OSM data where wrongly several objects lie on top of each other. Sorry my computer crashed yesterday evening, and I cannot boot it right now. Seems my Mainboard is dead. So I probably won't have possibilities for testing before Monday or Tuesday. On 23 March 2018 at 09:39, Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote:
Hi Henning,
Henning Scholland wrote
Hi Gerd, I just was thinking about if one road is leaving the roundabout at two angles it may count on the Garmin as two roads and will lead to 'exit on 3rd exit' instead of 'exit on 2nd exit' for example.
But I haven't gave it a try yet.
ah, okay, got it. I think Garmin should calculate the number for the exit without "thinking" about the further route but who knows. I'd like to test it on my own but I found it too difficut to create a style that tries to do the same as Felix' style, and you don't get the same results when you simply add overlapping highways in JOSM.
I am not aware of another style that adds multiple routable ways for one OSM way, and Felix doesn't want to share his, so testing is his work. I can only make educated guesses about the effects, and of course I'll test it with other styles before committing it.
Gerd
-- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Sorry for taking so long - needed to setup a new desktop computer with my old mainboard dead. The new patch does not really seem to improve anything. It's not dropping the route in simulation mode anymore - but getting stuck and not routing along. On 23 March 2018 at 09:50, Felix Hartmann <extremecarver@gmail.com> wrote:
Well all the problems about problematic arcs so far came up from a combination of two things: a) my style creates two additional ways (bit different road_class/road_speed based on input) if the following is met: route relation hiking, bicycle or mtb | ( mtb:scale>0 & mtb:scale<5) | class:bicycle>1. Additionally if a road is oneway - and it's a low level road (so neither motorway,trunk,primary,secondary,tertiary) - and oneway, a low class/speed non oneway road is added as well (intention to have lower priority against the oneway than driving with the oneway direction. Also additionally if bicycle lane against the traffic flow is possible, it will create a line against the oneway. b) mistakes in OSM data where wrongly several objects lie on top of each other.
Sorry my computer crashed yesterday evening, and I cannot boot it right now. Seems my Mainboard is dead. So I probably won't have possibilities for testing before Monday or Tuesday.
On 23 March 2018 at 09:39, Gerd Petermann <gpetermann_muenchen@hotmail.com
wrote:
Hi Henning,
Henning Scholland wrote
Hi Gerd, I just was thinking about if one road is leaving the roundabout at two angles it may count on the Garmin as two roads and will lead to 'exit on 3rd exit' instead of 'exit on 2nd exit' for example.
But I haven't gave it a try yet.
ah, okay, got it. I think Garmin should calculate the number for the exit without "thinking" about the further route but who knows. I'd like to test it on my own but I found it too difficut to create a style that tries to do the same as Felix' style, and you don't get the same results when you simply add overlapping highways in JOSM.
I am not aware of another style that adds multiple routable ways for one OSM way, and Felix doesn't want to share his, so testing is his work. I can only make educated guesses about the effects, and of course I'll test it with other styles before committing it.
Gerd
-- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443. html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Felix, sorry to hear. I am running out of ideas for a simple patch :-( Maybe it is not the number of arcs with the same initial bearing but the number of arcs going to the same destination node. Anyway, seems we really have to remove overlapping parts of roads much earlier to make your style work in that situation, and I think this would open a new box of worms reg. housenumbers, turn restrictions and so on, in other words, I fear we might add a lot of complex code that is rather bad for other users. So, maybe it would be better to just fix those errors in OSM? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Mittwoch, 28. März 2018 23:10:16 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Sorry for taking so long - needed to setup a new desktop computer with my old mainboard dead. The new patch does not really seem to improve anything. It's not dropping the route in simulation mode anymore - but getting stuck and not routing along. On 23 March 2018 at 09:50, Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> wrote: Well all the problems about problematic arcs so far came up from a combination of two things: a) my style creates two additional ways (bit different road_class/road_speed based on input) if the following is met: route relation hiking, bicycle or mtb | ( mtb:scale>0 & mtb:scale<5) | class:bicycle>1. Additionally if a road is oneway - and it's a low level road (so neither motorway,trunk,primary,secondary,tertiary) - and oneway, a low class/speed non oneway road is added as well (intention to have lower priority against the oneway than driving with the oneway direction. Also additionally if bicycle lane against the traffic flow is possible, it will create a line against the oneway. b) mistakes in OSM data where wrongly several objects lie on top of each other. Sorry my computer crashed yesterday evening, and I cannot boot it right now. Seems my Mainboard is dead. So I probably won't have possibilities for testing before Monday or Tuesday. On 23 March 2018 at 09:39, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Henning, Henning Scholland wrote
Hi Gerd, I just was thinking about if one road is leaving the roundabout at two angles it may count on the Garmin as two roads and will lead to 'exit on 3rd exit' instead of 'exit on 2nd exit' for example.
But I haven't gave it a try yet.
ah, okay, got it. I think Garmin should calculate the number for the exit without "thinking" about the further route but who knows. I'd like to test it on my own but I found it too difficut to create a style that tries to do the same as Felix' style, and you don't get the same results when you simply add overlapping highways in JOSM. I am not aware of another style that adds multiple routable ways for one OSM way, and Felix doesn't want to share his, so testing is his work. I can only make educated guesses about the effects, and of course I'll test it with other styles before committing it. Gerd -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Gerd, A hopefully easy solution could be to just take the first connection between two nodes and if there will be a second one, just copy name-tag for house numbers and then skip that second way. Or just report them. Can be two options like: - - duplicate-ways=remove/report Henning On 29 Mar 2018, 09:32, at 09:32, Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote:
Hi Felix,
sorry to hear. I am running out of ideas for a simple patch :-( Maybe it is not the number of arcs with the same initial bearing but the number of arcs going to the same destination node.
Anyway, seems we really have to remove overlapping parts of roads much earlier to make your style work in that situation, and I think this would open a new box of worms reg. housenumbers, turn restrictions and so on, in other words, I fear we might add a lot of complex code that is rather bad for other users. So, maybe it would be better to just fix those errors in OSM?
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Mittwoch, 28. März 2018 23:10:16 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Sorry for taking so long - needed to setup a new desktop computer with my old mainboard dead. The new patch does not really seem to improve anything. It's not dropping the route in simulation mode anymore - but getting stuck and not routing along.
On 23 March 2018 at 09:50, Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> wrote: Well all the problems about problematic arcs so far came up from a combination of two things: a) my style creates two additional ways (bit different road_class/road_speed based on input) if the following is met: route relation hiking, bicycle or mtb | ( mtb:scale>0 & mtb:scale<5) | class:bicycle>1. Additionally if a road is oneway - and it's a low level road (so neither motorway,trunk,primary,secondary,tertiary) - and oneway, a low class/speed non oneway road is added as well (intention to have lower priority against the oneway than driving with the oneway direction. Also additionally if bicycle lane against the traffic flow is possible, it will create a line against the oneway. b) mistakes in OSM data where wrongly several objects lie on top of each other.
Sorry my computer crashed yesterday evening, and I cannot boot it right now. Seems my Mainboard is dead. So I probably won't have possibilities for testing before Monday or Tuesday.
On 23 March 2018 at 09:39, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Henning,
Henning Scholland wrote
Hi Gerd, I just was thinking about if one road is leaving the roundabout at two angles it may count on the Garmin as two roads and will lead to 'exit on 3rd exit' instead of 'exit on 2nd exit' for example.
But I haven't gave it a try yet.
ah, okay, got it. I think Garmin should calculate the number for the exit without "thinking" about the further route but who knows. I'd like to test it on my own but I found it too difficut to create a style that tries to do the same as Felix' style, and you don't get the same results when you simply add overlapping highways in JOSM.
I am not aware of another style that adds multiple routable ways for one OSM way, and Felix doesn't want to share his, so testing is his work. I can only make educated guesses about the effects, and of course I'll test it with other styles before committing it.
Gerd
-- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Henning, well, I can start to code the test to detect and report overlapping highways. Maybe there is a way to fix some of them automatically, but I'd really prefer to just report them so that they are fixed in OSM. In most cases this should be easy. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Henning Scholland <osm@hscholland.de> Gesendet: Donnerstag, 29. März 2018 13:48:46 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Gerd, A hopefully easy solution could be to just take the first connection between two nodes and if there will be a second one, just copy name-tag for house numbers and then skip that second way. Or just report them. Can be two options like: - - duplicate-ways=remove/report Henning On 29 Mar 2018, at 09:32, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, sorry to hear. I am running out of ideas for a simple patch :-( Maybe it is not the number of arcs with the same initial bearing but the number of arcs going to the same destination node. Anyway, seems we really have to remove overlapping parts of roads much earlier to make your style work in that situation, and I think this would open a new box of worms reg. housenumbers, turn restrictions and so on, in other words, I fear we might add a lot of complex code that is rather bad for other users. So, maybe it would be better to just fix those errors in OSM? Gerd ________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Mittwoch, 28. März 2018 23:10:16 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Sorry for taking so long - needed to setup a new desktop computer with my old mainboard dead. The new patch does not really seem to improve anything. It's not dropping the route in simulation mode anymore - but getting stuck and not routing along. On 23 March 2018 at 09:50, Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> wrote: Well all the problems about problematic arcs so far came up from a combination of two things: a) my style creates two additional ways (bit different road_class/road_speed based on input) if the following is met: route relation hiking, bicycle or mtb | ( mtb:scale>0 & mtb:scale<5) | class:bicycle>1. Additionally if a road is oneway - and it's a low level road (so neither motorway,trunk,primary,secondary,tertiary) - and oneway, a low class/speed non oneway road is added as well (intention to have lower priority against the oneway than driving with the oneway direction. Also additionally if bicycle lane against the traffic flow is possible, it will create a line against the oneway. b) mistakes in OSM data where wrongly several objects lie on top of each other. Sorry my computer crashed yesterday evening, and I cannot boot it right now. Seems my Mainboard is dead. So I probably won't have possibilities for testing before Monday or Tuesday. On 23 March 2018 at 09:39, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Henning, Henning Scholland wrote Hi Gerd, I just was thinking about if one road is leaving the roundabout at two angles it may count on the Garmin as two roads and will lead to 'exit on 3rd exit' instead of 'exit on 2nd exit' for example. But I haven't gave it a try yet. ah, okay, got it. I think Garmin should calculate the number for the exit without "thinking" about the further route but who knows. I'd like to test it on my own but I found it too difficut to create a style that tries to do the same as Felix' style, and you don't get the same results when you simply add overlapping highways in JOSM. I am not aware of another style that adds multiple routable ways for one OSM way, and Felix doesn't want to share his, so testing is his work. I can only make educated guesses about the effects, and of course I'll test it with other styles before committing it. Gerd -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html ________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich -- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
So far I know there are already worldwide available qs tools for it. So just reporting them seems to be not necessary. After thinking about it, you are right. There will be complicated cases which are not easy to fix by code. Henning On 29 Mar 2018, 15:39, at 15:39, Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote:
Hi Henning,
well, I can start to code the test to detect and report overlapping highways. Maybe there is a way to fix some of them automatically, but I'd really prefer to just report them so that they are fixed in OSM. In most cases this should be easy.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Henning Scholland <osm@hscholland.de> Gesendet: Donnerstag, 29. März 2018 13:48:46 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Gerd, A hopefully easy solution could be to just take the first connection between two nodes and if there will be a second one, just copy name-tag for house numbers and then skip that second way. Or just report them. Can be two options like: - - duplicate-ways=remove/report
Henning On 29 Mar 2018, at 09:32, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote:
Hi Felix,
sorry to hear. I am running out of ideas for a simple patch :-( Maybe it is not the number of arcs with the same initial bearing but the number of arcs going to the same destination node.
Anyway, seems we really have to remove overlapping parts of roads much earlier to make your style work in that situation, and I think this would open a new box of worms reg. housenumbers, turn restrictions and so on, in other words, I fear we might add a lot of complex code that is rather bad for other users. So, maybe it would be better to just fix those errors in OSM?
Gerd
________________________________
Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Mittwoch, 28. März 2018 23:10:16 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Sorry for taking so long - needed to setup a new desktop computer with my old mainboard dead. The new patch does not really seem to improve anything. It's not dropping the route in simulation mode anymore - but getting stuck and not routing along.
On 23 March 2018 at 09:50, Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> wrote: Well all the problems about problematic arcs so far came up from a combination of two things: a) my style creates two additional ways (bit different road_class/road_speed based on input) if the following is met: route relation hiking, bicycle or mtb | ( mtb:scale>0 & mtb:scale<5) | class:bicycle>1. Additionally if a road is oneway - and it's a low level road (so neither motorway,trunk,primary,secondary,tertiary) - and oneway, a low class/speed non oneway road is added as well (intention to have lower priority against the oneway than driving with the oneway direction. Also additionally if bicycle lane against the traffic flow is possible, it will create a line against the oneway. b) mistakes in OSM data where wrongly several objects lie on top of each other.
Sorry my computer crashed yesterday evening, and I cannot boot it right now. Seems my Mainboard is dead. So I probably won't have possibilities for testing before Monday or Tuesday.
On 23 March 2018 at 09:39, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Henning,
Henning Scholland wrote Hi Gerd, I just was thinking about if one road is leaving the roundabout at two angles it may count on the Garmin as two roads and will lead to 'exit on 3rd exit' instead of 'exit on 2nd exit' for example.
But I haven't gave it a try yet.
ah, okay, got it. I think Garmin should calculate the number for the exit without "thinking" about the further route but who knows. I'd like to test it on my own but I found it too difficut to create a style that tries to do the same as Felix' style, and you don't get the same results when you simply add overlapping highways in JOSM.
I am not aware of another style that adds multiple routable ways for one OSM way, and Felix doesn't want to share his, so testing is his work. I can only make educated guesses about the effects, and of course I'll test it with other styles before committing it.
Gerd
-- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html ________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
-- Felix Hartman - Openmtbmap.org<http://Openmtbmap.org> & VeloMap.org<http://VeloMap.org> Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich ________________________________
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd, I haven't followed this discussion, sorry if I repeat a case or problem is already dealt with. When you use highways defined as area for routing, then area border is converted to road. Quite often there are multiple areas with common border. This common border can lead to duplicate reads. Data in OSM is correct and there is nothing to report, but it would be good if mkgmap could remove duplicate. -- Best regards, Andrzej
Well up to 3 duplicates (plus original) way there is never a problem. 4 duplicates can be problematic, 5 duplicates IS in 90% of cases problematic. I think I will rewrite my style to have maximum two duplicates, but usually no more than 1. Any solution to get rid of duplicates completely if 5 or more would be nice - but it seems Gerd cannot find a solution so be it. And yes it's not always a bug is OSM data (especially with areas) - but mostly (95% of the cases I analyzed) it was. On 29 March 2018 at 16:12, Andrzej Popowski <popej@poczta.onet.pl> wrote:
Hi Gerd,
I haven't followed this discussion, sorry if I repeat a case or problem is already dealt with.
When you use highways defined as area for routing, then area border is converted to road. Quite often there are multiple areas with common border. This common border can lead to duplicate reads. Data in OSM is correct and there is nothing to report, but it would be good if mkgmap could remove duplicate.
-- Best regards, Andrzej
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi all, when you use the default style you'll find a lot of duplicate arcs: - (multi-)polygons with highway=* & area=yes overlapping other highway=* ways - if you use option --make-opposite-cycleways you'll see a lot of duplicated arcs for all the ways created by this option. - errors where two OSM ways with highway=* and no area=yes share segments Of course the duplicate arcs often have different routing attributes, e.g. type, road_class, road_speed, oneway, restrictions etc. It seems that those duplicate arcs didn't cause problems so far, so I wonder in what situation we actually might want to avoid them? So far I found only a few cases were I would not expect side effects, e.g. 1) https://www.openstreetmap.org/way/16584103 and https://www.openstreetmap.org/way/16584160 hw=service+area=yes overlaps hw=service All attributes evaluated by mkgmap are equal, the duplicate arc is obsolete. Possible action: Split one of the two ways, remove the duplicate segment(s). 2) https://www.openstreetmap.org/way/393299955 and https://www.openstreetmap.org/way/183285165 hw=residential+area=yes+name=* overlaps hw=residential+name=* + oneway=yes The name is equal, the oneway attribute is not, other attributes are equal. Possible action: Remove the duplicated segments from the area=yes way. This would also be possible when the area=yes way doesn't have a name. If only the area=yes way had a name we might add the name to the oneway before changing the area=yes way, so that possible housenumbers are still found. Things start to get complex when the style adds multiple lines for one or both OSM ways, also when one OSM way overlaps multiple other OSM ways, e.g. https://www.openstreetmap.org/way/393299955 also overlaps https://www.openstreetmap.org/way/183212836 which has different attributes. Maybe we can find rules to handle more complex cases later, for now I try to code these actions. At least it should reduce img size. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Donnerstag, 29. März 2018 19:57:25 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Well up to 3 duplicates (plus original) way there is never a problem. 4 duplicates can be problematic, 5 duplicates IS in 90% of cases problematic. I think I will rewrite my style to have maximum two duplicates, but usually no more than 1. Any solution to get rid of duplicates completely if 5 or more would be nice - but it seems Gerd cannot find a solution so be it. And yes it's not always a bug is OSM data (especially with areas) - but mostly (95% of the cases I analyzed) it was. On 29 March 2018 at 16:12, Andrzej Popowski <popej@poczta.onet.pl<mailto:popej@poczta.onet.pl>> wrote: Hi Gerd, I haven't followed this discussion, sorry if I repeat a case or problem is already dealt with. When you use highways defined as area for routing, then area border is converted to road. Quite often there are multiple areas with common border. This common border can lead to duplicate reads. Data in OSM is correct and there is nothing to report, but it would be good if mkgmap could remove duplicate. -- Best regards, Andrzej _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Felix I assume you are asking if Mkgmap can detect the error, but for others who may find it helpful… the JOSM validator will give a warning for Overlapping highways and if you select ‘Overlapping highways’ it will highlight them. You can then zoom and select. The middle mouse button will list the ways and relations and middle mouse button +Ctrl will all enable selecting of individual ways.
On 20 Mar 2018, at 10:37 AM, Felix Hartmann <extremecarver@gmail.com> wrote:
Is there a way to detect such an error?
Hi Gerd, If we take for example that the connection between each two nodes is a separate way, with different properties which may affect routing, then any properties in the ways in the spike will have no effect on routing. Let's say that the side road in the screenshots has no access restrictions between the 1st and 2nd points, bars traffic between the 2nd and 3rd, then has no restrictions after that. With the current code, the access restriction will be in the spike and hence will not prevent routing past the end of the spike, providing the route doesn't attempt to go down the spike. Based on that, as a first stab, we would be no worse off by just deleting the spike whatever its access restrictions may be. The ideal would be that having detected that a road with no junctions has looped back to the same co-ordinate, check whether the loopback has access restrictions or highway type which are more restrictive than the ones either side. If not, just delete the spike. If the loopback is more restrictive, delete the spike and move the restrictions to one side or the other. Probably would also be useful to output a message saying a spike has been deleted; the mapper could then review the OSM data with a view to making it more mkgmap friendly, providing this can be achieved without compromising the OSM representation (I have no idea how many spikes might be detected). Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 09 March 2018 16:12 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Mike, the problem in the sample is that there are 5 ways, each with 2 nodes. So, we cannot delete any node without also deleting the corresponding way, and that would mean that we might remove important routing information. Besides that you are right, we have to detect that spike. I just think that the solution is to move all nodes to the same Garmin point, so we have two ways at that single point. Anyway, I just found a stupid bug when handling two points rounded to the same Garmin point and that bug causes some of the poor results. In line 1213 it should be if (c.getDistToDisplayedPoint() >= n.getDistToDisplayedPoint()) instead of if (c.getDistToDisplayedPoint() < n.getDistToDisplayedPoint()) I am now trying to find out what other code might be removed when this error is fixed... Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Freitag, 9. März 2018 17:01:27 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Gerd, I don't know anything about this bit of code, but the problem in the before and after pictures look to me like they are not the result of attempting to fix the angle, but look like they are the result of the second and fourth nodes in the spur both rounding to the same point, and it seems to me that the solution is to detect that the way has gone back on itself, and delete the intermediate node. If there are no junctions between two points that loop back on themselves, they should be able to be safely deleted before they are passed to WAF. Of course, I may be completely misunderstanding the intricacies of the problem, in which case I apologise for interrupting. Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 09 March 2018 08:16 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, okay, thanks. BTW: I still have no good idea how to solve the problem with the spike at node 1270407079. The attached screen shots show the problem. The coloured lines are the input. Many very short ways and all points are far from the Garmin grid points. The picture before.png shows the input to WrongAngleFixer (WAF), the after.png the output. The output is a bit better, but no improvement regarding the spike. I think WAF should collapse the two ways (111528849 and 111528851) which build the spike. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Donnerstag, 8. März 2018 20:47:39 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Thanks Gerd, I will do some tests on Saturday and then report back. Felix On 8 March 2018 at 11:46, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, attached is a patch that improves WrongAngleFixer. When both ways build a junction and both have another point close to that junction and in OSM they are different nodes mkgmap tries harder to avoid that they are rounded to the same coordinate. This is what happened with these two nodes https://www.openstreetmap.org/node/1263658804 https://www.openstreetmap.org/node/1195812701 I found similar situations at some roundabouts, sometimes a way connected to the roundabout and the roundabout way overlap. I am not sure how this patch works with your style, please try it with r4131. A few special cases to look at: https://www.openstreetmap.org/way/208976154 Coordinates: 38.4082747, 16.0787201 https://www.openstreetmap.org/way/312642720 Coordinates: 39.0259441, 8.5967561 https://www.openstreetmap.org/way/148634420 Coordinates: 41.981263, 12.4114831 Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgm ap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Samstag, 3. März 2018 19:49:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. well in general 0x16 is not avoided by any transport means (or at least it was not a couple of years ago when I checked the influence of types= - that's strange. 0x01 and 0x02 are avoided by bicycle - but in general I never use avoidances except toll and unpaved - they are pretty straight forward. I should do some checks again if something changed with activity routing over the years. If 6 ways on top of each other are routable problems are common (but do not have to occur - not sure why). (oh yeah I forgot to say to add the route=hiking to relations file, I assumed that is clear as it's a route and they are always relations). On 3 March 2018 at 15:27, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>
wrote: Hi Felix,
okay, found out again why merging before angle fixing doesn't work, but I still have no clue why this junction would cause trouble reg. routing with a normal mkgmap binary. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-b ounces@lists.mkgmap.org.uk>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>
Gesendet: Samstag, 3. März 2018 11:34:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, I just noted that I got my results reg. the modified default style with a modified StyledConverter which does the road merging before the wrong angle fixing. Something goes very wrong with this patched version. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-b ounces@lists.mkgmap.org.uk>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>
Gesendet: Samstag, 3. März 2018 11:01:42 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, no, it is just special at this juntion because the other ways have 0x8 or 0x13. On thursday I wrote that I was able to reproduce a problem at this junction but I forgot to set up routing for car (automotive) :-( I can reproduce a problem with "tour cycling", but I think that is expected with your style, because it avoids main roads by default. Maybe your users made the same error? You suggested to add route=hiking [0x13 road_class=4 road_speed=2 resolution 24 continue] to reproduce a problem. I tried that with no effect. Only after I added a rule in the relations file: type=route & route=hiking { apply { add route=hiking } } With that I see additional routable lines in the map and routing is more less broken at node 412440328 when I try to route from north to anywhere below the node , also the inverse way doesn't work. I tried different variants of the rule like other types or other road classes, always saw the same problem. I see working routing again when I remove way 130665733 from the input file and move node 1263658617 down to 412440328 and merge them (see attached file). I'll try to find out why this is so special in this situation. ciao, Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-b ounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarve r@gmail.com<mailto:extremecarver@gmail.com>>> Gesendet: Freitag, 2. März 2018 22:21:35 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Well in general 0x16 does not cause any problems. Do you think if I use another type instead (e.g.) 0x13 it won't be problematic, or do you mean that the 0x16 in itself is the problem? On 1 March 2018 at 18:55, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> <mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.c om><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmai l.com>>>> wrote: Hi Felix, okay, I think I can reproduce a routing problem on my Oregon with your map. I have a route that works from south to north but not in the reverse direction. I'll try to create a similar situation with a modified default style to find out what the problem is. My current prime suspect is the way with type 0x16. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-b ounces@lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<m ailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@list s.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarve r@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremecarver@gmail.com< mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extrem ecarver@gmail.com>>>> Gesendet: Donnerstag, 1. März 2018 18:09:02 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. routing issues is on devices only - not in Basecamp. Reported so far from Oregon and Edge - routing from North to East over that road. Well what I thought was that mkgmap should check if another road is put above. Right now it's 1 road supposed to be there, 2 and 3 roads overlapping due to that road being too short. Those overlapping somehow would need to be removed (and yes I know they are originally not the same line). My style should I think in maximum create 4 routable lines - however due to overlapping of other lines (due to the sub 4.3m line) it ends up a short stretch with more than 5 routable lines. On 1 March 2018 at 17:47, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> <mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.c om><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmai l.com>>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@h otmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenche n@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_mue nchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_ muenchen@hotmail.com>>>>> wrote: Hi Felix, Felix Hartmann-2 wrote
Okay - no-merge-lines makes no difference, also removing addArcsToMajorRoads(); function makes no difference. And I just noticed - the patch does not work. It works in it's own way - but not achieving the result that is needed. Whatever I do - I still end up with 6 routable lines.
I guess the patch checks for each road that it is not more than 4 times in the map. So I end up with 1, 2, and 3 (1 that is supposed to be in the map, 2 from the east not supposed, and 3 from the south, not supposed). (always using gpsmapedit to check results).
yes, that is what it does. Didn't you suggest something like that? You still did not tell me how I can reproduce a crash with this data, so I can only guess. I didn't see any routing issues so far with your maps, only the ugly rendering. Is this the only problem or is there really a routing issue? If yes, please let me know how to reproduce it. Gerd -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mail to:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mai lto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>>< mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> <mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org. uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org .uk>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mail to:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mai lto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
well we already have code (it's a patch still I think?) to remove roads with connection to only one side. --> set mkgmap:set_semi_connected_type=none; Maybe we could have a filter to remove all semi_connected_type lines with min length? 4-5m long roads that are only semi connected will be just adding clutter anyway. I don't think we lose any essential streets by removing them. Maybe only do not remove them if an address is attached to them (not autogenerated address - but fully entered in OSM)? And yes removing supershort roads and copying the restrictions to the adjoining ones would be best I guess. On 10 March 2018 at 18:11, Mike Baggaley <mike@tvage.co.uk> wrote:
Hi Gerd,
If we take for example that the connection between each two nodes is a separate way, with different properties which may affect routing, then any properties in the ways in the spike will have no effect on routing. Let's say that the side road in the screenshots has no access restrictions between the 1st and 2nd points, bars traffic between the 2nd and 3rd, then has no restrictions after that. With the current code, the access restriction will be in the spike and hence will not prevent routing past the end of the spike, providing the route doesn't attempt to go down the spike. Based on that, as a first stab, we would be no worse off by just deleting the spike whatever its access restrictions may be.
The ideal would be that having detected that a road with no junctions has looped back to the same co-ordinate, check whether the loopback has access restrictions or highway type which are more restrictive than the ones either side. If not, just delete the spike. If the loopback is more restrictive, delete the spike and move the restrictions to one side or the other. Probably would also be useful to output a message saying a spike has been deleted; the mapper could then review the OSM data with a view to making it more mkgmap friendly, providing this can be achieved without compromising the OSM representation (I have no idea how many spikes might be detected).
Cheers, Mike
-----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 09 March 2018 16:12 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Mike,
the problem in the sample is that there are 5 ways, each with 2 nodes. So, we cannot delete any node without also deleting the corresponding way, and that would mean that we might remove important routing information.
Besides that you are right, we have to detect that spike. I just think that the solution is to move all nodes to the same Garmin point, so we have two ways at that single point.
Anyway, I just found a stupid bug when handling two points rounded to the same Garmin point and that bug causes some of the poor results. In line 1213 it should be if (c.getDistToDisplayedPoint() >= n.getDistToDisplayedPoint()) instead of if (c.getDistToDisplayedPoint() < n.getDistToDisplayedPoint())
I am now trying to find out what other code might be removed when this error is fixed...
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Freitag, 9. März 2018 17:01:27 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Gerd, I don't know anything about this bit of code, but the problem in the before and after pictures look to me like they are not the result of attempting to fix the angle, but look like they are the result of the second and fourth nodes in the spur both rounding to the same point, and it seems to me that the solution is to detect that the way has gone back on itself, and delete the intermediate node. If there are no junctions between two points that loop back on themselves, they should be able to be safely deleted before they are passed to WAF. Of course, I may be completely misunderstanding the intricacies of the problem, in which case I apologise for interrupting.
Cheers, Mike
-----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 09 March 2018 08:16 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix,
okay, thanks. BTW: I still have no good idea how to solve the problem with the spike at node 1270407079. The attached screen shots show the problem. The coloured lines are the input. Many very short ways and all points are far from the Garmin grid points. The picture before.png shows the input to WrongAngleFixer (WAF), the after.png the output. The output is a bit better, but no improvement regarding the spike. I think WAF should collapse the two ways (111528849 and 111528851) which build the spike.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Donnerstag, 8. März 2018 20:47:39 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Thanks Gerd, I will do some tests on Saturday and then report back.
Felix
On 8 March 2018 at 11:46, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix,
attached is a patch that improves WrongAngleFixer. When both ways build a junction and both have another point close to that junction and in OSM they are different nodes mkgmap tries harder to avoid that they are rounded to the same coordinate. This is what happened with these two nodes https://www.openstreetmap.org/node/1263658804 https://www.openstreetmap.org/node/1195812701
I found similar situations at some roundabouts, sometimes a way connected to the roundabout and the roundabout way overlap. I am not sure how this patch works with your style, please try it with r4131.
A few special cases to look at: https://www.openstreetmap.org/way/208976154 Coordinates: 38.4082747, 16.0787201 https://www.openstreetmap.org/way/312642720 Coordinates: 39.0259441, 8.5967561 https://www.openstreetmap.org/way/148634420 Coordinates: 41.981263, 12.4114831
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgm ap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Samstag, 3. März 2018 19:49:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
well in general 0x16 is not avoided by any transport means (or at least it was not a couple of years ago when I checked the influence of types= - that's strange. 0x01 and 0x02 are avoided by bicycle - but in general I never use avoidances except toll and unpaved - they are pretty straight forward. I should do some checks again if something changed with activity routing over the years. If 6 ways on top of each other are routable problems are common (but do not have to occur - not sure why).
(oh yeah I forgot to say to add the route=hiking to relations file, I assumed that is clear as it's a route and they are always relations).
On 3 March 2018 at 15:27, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
<mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
wrote: Hi Felix,
okay, found out again why merging before angle fixing doesn't work, but I still have no clue why this junction would cause trouble reg. routing with a normal mkgmap binary.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-b ounces@lists.mkgmap.org.uk>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
<mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
Gesendet: Samstag, 3. März 2018 11:34:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix,
I just noted that I got my results reg. the modified default style with a modified StyledConverter which does the road merging before the wrong angle fixing. Something goes very wrong with this patched version.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-b ounces@lists.mkgmap.org.uk>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
<mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
Gesendet: Samstag, 3. März 2018 11:01:42 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Hi Felix,
no, it is just special at this juntion because the other ways have 0x8 or 0x13. On thursday I wrote that I was able to reproduce a problem at this junction but I forgot to set up routing for car (automotive) :-( I can reproduce a problem with "tour cycling", but I think that is expected with your style, because it avoids main roads by default. Maybe your users made the same error?
You suggested to add route=hiking [0x13 road_class=4 road_speed=2 resolution 24 continue] to reproduce a problem. I tried that with no effect. Only after I added a rule in the relations file: type=route & route=hiking { apply { add route=hiking } } With that I see additional routable lines in the map and routing is more less broken at node 412440328 when I try to route from north to anywhere below the node , also the inverse way doesn't work. I tried different variants of the rule like other types or other road classes, always saw the same problem. I see working routing again when I remove way 130665733 from the input file and move node 1263658617 down to 412440328 and merge them (see attached file). I'll try to find out why this is so special in this situation.
ciao, Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-b ounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto: extremecarve r@gmail.com<mailto:extremecarver@gmail.com>>> Gesendet: Freitag, 2. März 2018 22:21:35 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
Well in general 0x16 does not cause any problems. Do you think if I use another type instead (e.g.) 0x13 it won't be problematic, or do you mean that the 0x16 in itself is the problem?
On 1 March 2018 at 18:55, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
<mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
<mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_ muenchen@hotmail.c om><mailto:gpetermann_muenchen@hotmail.com<mailto:gp etermann_muenchen@hotmai l.com>>>> wrote: Hi Felix,
okay, I think I can reproduce a routing problem on my Oregon with your map. I have a route that works from south to north but not in the reverse direction. I'll try to create a similar situation with a modified default style to find out what the problem is. My current prime suspect is the way with type 0x16.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap- dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-b ounces@lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk <m ailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mk gmap-dev-bounces@list s.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto: extremecarve r@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremec arver@gmail.com< mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto: extrem ecarver@gmail.com>>>> Gesendet: Donnerstag, 1. März 2018 18:09:02 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads.
routing issues is on devices only - not in Basecamp. Reported so far from Oregon and Edge - routing from North to East over that road.
Well what I thought was that mkgmap should check if another road is put above. Right now it's 1 road supposed to be there, 2 and 3 roads overlapping due to that road being too short. Those overlapping somehow would need to be removed (and yes I know they are originally not the same line). My style should I think in maximum create 4 routable lines - however due to overlapping of other lines (due to the sub 4.3m line) it ends up a short stretch with more than 5 routable lines.
On 1 March 2018 at 17:47, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
<mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com
<mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_ muenchen@hotmail.c om><mailto:gpetermann_muenchen@hotmail.com<mailto:gp etermann_muenchen@hotmai l.com>>><mailto:gpetermann_muenchen@hotmail.com<mailto:gp etermann_muenchen@h otmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gp etermann_muenche n@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto: gpetermann_mue nchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto: gpetermann_ muenchen@hotmail.com>>>>> wrote: Hi Felix,
Felix Hartmann-2 wrote
Okay - no-merge-lines makes no difference, also removing addArcsToMajorRoads(); function makes no difference. And I just noticed - the patch does not work. It works in it's own way - but not achieving the result that is needed. Whatever I do - I still end up with 6 routable lines.
I guess the patch checks for each road that it is not more than 4 times in the map. So I end up with 1, 2, and 3 (1 that is supposed to be in the map, 2 from the east not supposed, and 3 from the south, not supposed). (always using gpsmapedit to check results).
yes, that is what it does. Didn't you suggest something like that?
You still did not tell me how I can reproduce a crash with this data, so I can only guess. I didn't see any routing issues so far with your maps, only the ugly rendering. Is this the only problem or is there really a routing issue? If yes, please let me know how to reproduce it.
Gerd
-- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mail to:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk <mai lto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
< mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap- dev@lists.mkgmap.org.uk> <mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap- dev@lists.mkgmap.org.uk <mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap- dev@lists.mkgmap.org. uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap- dev@lists.mkgmap.org .uk>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mail to:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk <mai lto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich
Hi Mike, you seem to assume that there is a shortcut but this is not the case. The spike is just a rendering issue, the routing info in NOD "knows" there is no shortcut. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com> Gesendet: Freitag, 9. März 2018 17:12:12 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Mike, the problem in the sample is that there are 5 ways, each with 2 nodes. So, we cannot delete any node without also deleting the corresponding way, and that would mean that we might remove important routing information. Besides that you are right, we have to detect that spike. I just think that the solution is to move all nodes to the same Garmin point, so we have two ways at that single point. Anyway, I just found a stupid bug when handling two points rounded to the same Garmin point and that bug causes some of the poor results. In line 1213 it should be if (c.getDistToDisplayedPoint() >= n.getDistToDisplayedPoint()) instead of if (c.getDistToDisplayedPoint() < n.getDistToDisplayedPoint()) I am now trying to find out what other code might be removed when this error is fixed... Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Freitag, 9. März 2018 17:01:27 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Gerd, I don't know anything about this bit of code, but the problem in the before and after pictures look to me like they are not the result of attempting to fix the angle, but look like they are the result of the second and fourth nodes in the spur both rounding to the same point, and it seems to me that the solution is to detect that the way has gone back on itself, and delete the intermediate node. If there are no junctions between two points that loop back on themselves, they should be able to be safely deleted before they are passed to WAF. Of course, I may be completely misunderstanding the intricacies of the problem, in which case I apologise for interrupting. Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 09 March 2018 08:16 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, okay, thanks. BTW: I still have no good idea how to solve the problem with the spike at node 1270407079. The attached screen shots show the problem. The coloured lines are the input. Many very short ways and all points are far from the Garmin grid points. The picture before.png shows the input to WrongAngleFixer (WAF), the after.png the output. The output is a bit better, but no improvement regarding the spike. I think WAF should collapse the two ways (111528849 and 111528851) which build the spike. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Donnerstag, 8. März 2018 20:47:39 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Thanks Gerd, I will do some tests on Saturday and then report back. Felix On 8 March 2018 at 11:46, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, attached is a patch that improves WrongAngleFixer. When both ways build a junction and both have another point close to that junction and in OSM they are different nodes mkgmap tries harder to avoid that they are rounded to the same coordinate. This is what happened with these two nodes https://www.openstreetmap.org/node/1263658804 https://www.openstreetmap.org/node/1195812701 I found similar situations at some roundabouts, sometimes a way connected to the roundabout and the roundabout way overlap. I am not sure how this patch works with your style, please try it with r4131. A few special cases to look at: https://www.openstreetmap.org/way/208976154 Coordinates: 38.4082747, 16.0787201 https://www.openstreetmap.org/way/312642720 Coordinates: 39.0259441, 8.5967561 https://www.openstreetmap.org/way/148634420 Coordinates: 41.981263, 12.4114831 Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgm ap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Samstag, 3. März 2018 19:49:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. well in general 0x16 is not avoided by any transport means (or at least it was not a couple of years ago when I checked the influence of types= - that's strange. 0x01 and 0x02 are avoided by bicycle - but in general I never use avoidances except toll and unpaved - they are pretty straight forward. I should do some checks again if something changed with activity routing over the years. If 6 ways on top of each other are routable problems are common (but do not have to occur - not sure why). (oh yeah I forgot to say to add the route=hiking to relations file, I assumed that is clear as it's a route and they are always relations). On 3 March 2018 at 15:27, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>
wrote: Hi Felix,
okay, found out again why merging before angle fixing doesn't work, but I still have no clue why this junction would cause trouble reg. routing with a normal mkgmap binary. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-b ounces@lists.mkgmap.org.uk>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>
Gesendet: Samstag, 3. März 2018 11:34:24 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, I just noted that I got my results reg. the modified default style with a modified StyledConverter which does the road merging before the wrong angle fixing. Something goes very wrong with this patched version. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-b ounces@lists.mkgmap.org.uk>>> im Auftrag von Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>
Gesendet: Samstag, 3. März 2018 11:01:42 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Hi Felix, no, it is just special at this juntion because the other ways have 0x8 or 0x13. On thursday I wrote that I was able to reproduce a problem at this junction but I forgot to set up routing for car (automotive) :-( I can reproduce a problem with "tour cycling", but I think that is expected with your style, because it avoids main roads by default. Maybe your users made the same error? You suggested to add route=hiking [0x13 road_class=4 road_speed=2 resolution 24 continue] to reproduce a problem. I tried that with no effect. Only after I added a rule in the relations file: type=route & route=hiking { apply { add route=hiking } } With that I see additional routable lines in the map and routing is more less broken at node 412440328 when I try to route from north to anywhere below the node , also the inverse way doesn't work. I tried different variants of the rule like other types or other road classes, always saw the same problem. I see working routing again when I remove way 130665733 from the input file and move node 1263658617 down to 412440328 and merge them (see attached file). I'll try to find out why this is so special in this situation. ciao, Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-b ounces@lists.mkgmap.org.uk>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarve r@gmail.com<mailto:extremecarver@gmail.com>>> Gesendet: Freitag, 2. März 2018 22:21:35 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. Well in general 0x16 does not cause any problems. Do you think if I use another type instead (e.g.) 0x13 it won't be problematic, or do you mean that the 0x16 in itself is the problem? On 1 March 2018 at 18:55, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> <mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.c om><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmai l.com>>>> wrote: Hi Felix, okay, I think I can reproduce a routing problem on my Oregon with your map. I have a route that works from south to north but not in the reverse direction. I'll try to create a similar situation with a modified default style to find out what the problem is. My current prime suspect is the way with type 0x16. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgm ap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-b ounces@lists.mkgmap.org.uk>><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<m ailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@list s.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com><mailto:extremecarve r@gmail.com<mailto:extremecarver@gmail.com>><mailto:extremecarver@gmail.com< mailto:extremecarver@gmail.com><mailto:extremecarver@gmail.com<mailto:extrem ecarver@gmail.com>>>> Gesendet: Donnerstag, 1. März 2018 18:09:02 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Bug in Road Merging - actually doubling roads. routing issues is on devices only - not in Basecamp. Reported so far from Oregon and Edge - routing from North to East over that road. Well what I thought was that mkgmap should check if another road is put above. Right now it's 1 road supposed to be there, 2 and 3 roads overlapping due to that road being too short. Those overlapping somehow would need to be removed (and yes I know they are originally not the same line). My style should I think in maximum create 4 routable lines - however due to overlapping of other lines (due to the sub 4.3m line) it ends up a short stretch with more than 5 routable lines. On 1 March 2018 at 17:47, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mai lto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> <mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.c om><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmai l.com>>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@h otmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenche n@hotmail.com>><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_mue nchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_ muenchen@hotmail.com>>>>> wrote: Hi Felix, Felix Hartmann-2 wrote
Okay - no-merge-lines makes no difference, also removing addArcsToMajorRoads(); function makes no difference. And I just noticed - the patch does not work. It works in it's own way - but not achieving the result that is needed. Whatever I do - I still end up with 6 routable lines.
I guess the patch checks for each road that it is not more than 4 times in the map. So I end up with 1, 2, and 3 (1 that is supposed to be in the map, 2 from the east not supposed, and 3 from the south, not supposed). (always using gpsmapedit to check results).
yes, that is what it does. Didn't you suggest something like that? You still did not tell me how I can reproduce a crash with this data, so I can only guess. I didn't see any routing issues so far with your maps, only the ugly rendering. Is this the only problem or is there really a routing issue? If yes, please let me know how to reproduce it. Gerd -- Sent from: http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mail to:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mai lto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>>< mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> <mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk
<mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org. uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org .uk>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>><mail to:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mai lto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto :mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Schusterbergweg 32/8 6020 Innsbruck Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
participants (6)
-
Andrzej Popowski -
Felix Hartmann -
Gerd Petermann -
Henning Scholland -
Mike Baggaley -
nwastra