[PATCH v1] - Route centre tweaks

Thanks to those who have tried yesterday's table A patch. Seems like it hasn't caused any problems (so far). Today's offering includes the table A tweak but it also increases one of the limits that determine when a route centre needs to be sub-divided. As far as I can tell, the limit was somewhat smaller than it should have been. So with this patch, fewer routing centres should be required (obviously depends on the map data). So please test this patch (it replaces the previous patch) and let me know if their are any issues. You must enable assertions, otherwise if the data structures overflow you won't know until mapsource/gps barfs. Cheers, Mark BTW - if you are not interested in routing over footpaths, changing them to a non-routable type will simplify the routing data further.

Mark Burton wrote:
Thanks to those who have tried yesterday's table A patch. Seems like it hasn't caused any problems (so far).
After playing around a bit on my Vista HCx I did notice slightly different routing too. The maximum distance that it manages without "route calculation error" did not change however.
Today's offering includes the table A tweak but it also increases one of the limits that determine when a route centre needs to be sub-divided. As far as I can tell, the limit was somewhat smaller than it should have been. So with this patch, fewer routing centres should be required (obviously depends on the map data). Routing in Mapsource is now different too. So far I have found one route that does not calculate with the old version, but with the new. The difference is however 2-3 more turns, so no drastical improvement. Maybe some routes also degrade?
So please test this patch (it replaces the previous patch) and let me know if their are any issues.
You must enable assertions, otherwise if the data structures overflow you won't know until mapsource/gps barfs.
Cheers,
Mark
BTW - if you are not interested in routing over footpaths, changing them to a non-routable type will simplify the routing data further.
------------------------------------------------------------------------
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Felix,
After playing around a bit on my Vista HCx I did notice slightly different routing too. The maximum distance that it manages without "route calculation error" did not change however.
On the HCx, I just tried an 800Km route from where I live to Thurso and it took quite a while (stuck on 100% for a minute or two) but it did eventually calculate a sensible route.
Today's offering includes the table A tweak but it also increases one of the limits that determine when a route centre needs to be sub-divided. As far as I can tell, the limit was somewhat smaller than it should have been. So with this patch, fewer routing centres should be required (obviously depends on the map data). Routing in Mapsource is now different too. So far I have found one route that does not calculate with the old version, but with the new. The difference is however 2-3 more turns, so no drastical improvement. Maybe some routes also degrade?
I guess that is possible but I would hope that the overall effect is beneficial. I'm (optimistically) working on the theory that increasing the size of the route centres makes the route calculation easier/quicker. That could, of course, be complete rubbish. With the current patch, my GB map is around 172 MB compared to 180 without so the space saving is worth having if not dramatic. Cheers, Mark

Mark Burton wrote:
Felix,
After playing around a bit on my Vista HCx I did notice slightly different routing too. The maximum distance that it manages without "route calculation error" did not change however.
On the HCx, I just tried an 800Km route from where I live to Thurso and it took quite a while (stuck on 100% for a minute or two) but it did eventually calculate a sensible route.
Well that's taking big streets. With my maps I'm happy when it routes 10-40km on the Vista HCx (or max about 50 turns), and 40-150km in Mapsource (or max about 150turns). The only way to really improve this is in my opinion to remove sharp turns on intersections - what we talked about last week. Then Mapsource will route on for long, long distances and the Vista HCx will go up to 100 turns (or say 20-40km in really densely mapped areas). Vista HCx cannot route over more than 100 turns without Via Points from what is my knowledge, so that boundary cannot be removed.
Today's offering includes the table A tweak but it also increases one of the limits that determine when a route centre needs to be sub-divided. As far as I can tell, the limit was somewhat smaller than it should have been. So with this patch, fewer routing centres should be required (obviously depends on the map data).
Routing in Mapsource is now different too. So far I have found one route that does not calculate with the old version, but with the new. The difference is however 2-3 more turns, so no drastical improvement. Maybe some routes also degrade?
I guess that is possible but I would hope that the overall effect is beneficial. I'm (optimistically) working on the theory that increasing the size of the route centres makes the route calculation easier/quicker. That could, of course, be complete rubbish.
I think this is correct, but will not help much for non car centric maps (car centric in the way that motorways have few intersections, and have no sharp turns on intersections). For car centric maps the patches might help more, because here you route over many tiles and therefore the more efficient the underlying data, the better.
With the current patch, my GB map is around 172 MB compared to 180 without so the space saving is worth having if not dramatic.
Cheers,
Mark
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Mark Burton schreef:
Today's offering includes the table A tweak but it also increases one of the limits that determine when a route centre needs to be sub-divided.[...] So please test this patch (it replaces the previous patch) and let me know if their are any issues.
No issues found with just simple tests. By the way, Mark, please try the following route and be surprised: http://www.yournavigation.org/?flat=52.445382&flon=4.80525&tlat=52.404858&tl... Mapsource sends me through Oostzaan but has a sensible route. It's a bit longer than what Yournavigation makes of it, but it's understandable, given the turning penalties Garmin seems to have. But the Nuvi does really really strange things: it routes me through Krommenie http://osm.org/go/0E5sYyYM--?layers=0B00FTF, then Purmerend http://osm.org/go/0E7Ea66?layers=0B00FTF ... and only then to Amsterdam. Is this reproducable in your brand new Nuvi? Best regards, Valentijn

Valentijn Sessink wrote:
Valentijn Sessink schreef:
given the turning penalties Garmin seems to have. But the Nuvi does really really strange things: it routes me through
... by bicycle (I forgot to mention that.).
forget bicycle mode. Only car / taxi and similar modes work well. Bicycle and Pedestrian are crap anyhow. They drop all road_speed down to 1, and more or less inverse the road_class. With this base for deciding which way to route, all results are obliged to be pure crap! The speed for the arrival time calculation is 18km/h or if road_speed=0 then 7-10km/h depending on unit/mapsource. The only maps that kinda work with bicycle / pedestrian mode are the dutch "onroute" maps. I think that knowing the above facts, they simply created maps with road_speed=1 for ways that are supposed to be chosen, and road_speed=0 for those that are not supposed to be chosen. If you want to have good bicycle routing, you are obliged to reprogram the maps by fooling the GPS with reprogramming the maps so that cycleways have attributes like motorways, and so on - only then routing will work well - of course suffering from the big problem of penalty time at intersections which are too long for bicylce/pedestrian mode. This could be solved by adding additional ways at intersections however.
V. _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

On Tue, Sep 22, 2009 at 01:00:24PM +0100, Mark Burton wrote:
Thanks to those who have tried yesterday's table A patch. Seems like it hasn't caused any problems (so far).
Today's offering includes the table A tweak but it also increases one of the limits that determine when a route centre needs to be sub-divided. As far as I can tell, the limit was somewhat smaller than it should have been. So with this patch, fewer routing centres should be required (obviously depends on the map data).
I generated the same map with the only difference being this patch. The file was a little smaller: -rw-r--r-- 1 marko marko 36888576 22.9. 09:01 gmapsuppa.img -rw-r--r-- 1 marko marko 36510720 23.9. 14:06 gmapsupp.img
So please test this patch (it replaces the previous patch) and let me know if their are any issues.
Routing seems to be unaffected. I tested the same route, both bicycle (253 km) and car (204 km).
You must enable assertions, otherwise if the data structures overflow you won't know until mapsource/gps barfs.
There are a few differences between the generated gmapsupp.img if I enable assertions. The files are of the same size, though. Come to think of it, the differences could be attributed to --max-jobs. But the diff of hexdump is only 64 lines, or 16 differing 16-byte blocks. Marko

Hi Marko, Thanks for the report.
I generated the same map with the only difference being this patch. The file was a little smaller:
-rw-r--r-- 1 marko marko 36888576 22.9. 09:01 gmapsuppa.img -rw-r--r-- 1 marko marko 36510720 23.9. 14:06 gmapsupp.img
So please test this patch (it replaces the previous patch) and let me know if their are any issues.
Routing seems to be unaffected. I tested the same route, both bicycle (253 km) and car (204 km).
Good.
You must enable assertions, otherwise if the data structures overflow you won't know until mapsource/gps barfs.
There are a few differences between the generated gmapsupp.img if I enable assertions. The files are of the same size, though. Come to think of it, the differences could be attributed to --max-jobs. But the diff of hexdump is only 64 lines, or 16 differing 16-byte blocks.
I think the differences will just be the time stamps. Enabling assertions really should not make the output change otherwise. That's a least 3 positive reports so I think this patch is probably OK to commit. Cheers, Mark

Mark Burton wrote:
Thanks to those who have tried yesterday's table A patch. Seems like it hasn't caused any problems (so far).
Today's offering includes the table A tweak but it also increases one of the limits that determine when a route centre needs to be sub-divided. As far as I can tell, the limit was somewhat smaller than it should have been. So with this patch, fewer routing centres should be required (obviously depends on the map data).
So please test this patch (it replaces the previous patch) and let me know if their are any issues.
I've applied this as well and con confirm what you saw. My UK map is about 7.5MB smaller. From what I can see routing is unaffected with me being able to find sensible routes to both Lands End and John O'Groats. In my "very limited" testing there seems to be nothing detrimental Cheers Paul
participants (5)
-
Felix Hartmann
-
Mark Burton
-
Marko Mäkelä
-
Paul
-
Valentijn Sessink