- mkgmap-dev - The mkgmap lists

NPE with mkgmap 3320
by UliBaer 07 Nov '14

07 Nov '14

With the latest versions (tried, back until 3316) of mkgmap i'm getting a NPE with a new setup on an older 32Bit XP Machine: java.lang.NullPointerException at uk.me.parabola.imgfmt.app.net.RoadDef.compareTo(RoadDef.java:700) at uk.me.parabola.imgfmt.app.net.RoadDef.compareTo(RoadDef.java:56) at java.util.HashMap.compareComparables(Unknown Source) at java.util.HashMap$TreeNode.treeify(Unknown Source) at java.util.HashMap.treeifyBin(Unknown Source) at java.util.HashMap.putVal(Unknown Source) at java.util.HashMap.put(Unknown Source) at uk.me.parabola.imgfmt.app.net.TableA.addArc(TableA.java:93) at uk.me.parabola.imgfmt.app.net.NOD1Part.addNode(NOD1Part.java:229) at uk.me.parabola.imgfmt.app.net.RoadNetwork.splitCenters(RoadNetwork.ja va:239) at uk.me.parabola.imgfmt.app.net.RoadNetwork.getCenters(RoadNetwork.java :250) at uk.me.parabola.mkgmap.build.MapBuilder.makeMap(MapBuilder.java:231) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:120) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:82) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:253) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:249) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) Exiting - if you want to carry on regardless, use the --keep-going option Number of ExitExceptions: 1 It is in this code segment: public int compareTo(RoadDef other) { // sort by city name - this is used to group together // roads that have been split into segments if(other == this) return 0; // TODO: look at what this is doing... if(city != null && other.city != null) return city.getName().compareTo(other.city.getName()); <--- Here happens the NPE if (hashCode() == other.hashCode()) return 0; else if (hashCode() < other.hashCode()) return -1; else return 0; } *This happens when running with "--max-jobs=2" (it is a core2duo machine) but when running with "--max-jobs=1" the error does NOT occur... :?* Best regards, Uli -- View this message in context: http://gis.19327.n5.nabble.com/NPE-with-mkgmap-3320-tp5813472.html Sent from the Mkgmap Development mailing list archive at Nabble.com.

4 13

RoadDef patch
by Brian Egge 06 Nov '14

06 Nov '14

I’m not sure what the concurrency issue is related to this class, but it seems to have some problems around equality. First, it’s being used in a HashMap, which means both equals and hashCode need to be implemented. Second, the compareTo was using an unimplemented hashCode, which results in random sorting and inability to find two identical objects. I’m not sure I understand all the details of what RoadDef does, but I’ve fixed up the basic methods in the class to be consistent and added a test case around those methods. Brian

2 5

Commit: r3345: - remove compareTo() method from RoadDef and the Comparable attribute.
by svn commit 06 Nov '14

06 Nov '14

Version mkgmap-r3345 was committed by gerd on Thu, 06 Nov 2014 - remove compareTo() method from RoadDef and the Comparable attribute. The sorting of RoadDef instances is done with a more complex method in NETFile.sortRoads(). This might also prevent an NPE that occurs with JRE 8.

1 0

FW: mkgmap in NYC
by Gerd Petermann 05 Nov '14

05 Nov '14

Just noticed that I sent this to Greg only... Gerd From: gpetermann_muenchen(a)hotmail.com To: gdt(a)ir.bbn.com Subject: RE: [mkgmap-dev] mkgmap in NYC Date: Tue, 21 Oct 2014 09:25:45 +0200 Hi Greg, I thought about this. The precompiled bounds contain the needed info, it is the LocationHook that fills the tags like mkgmap:admin_level6. The LocationHook uses the --name-tag-list option to decide which value is used. It would be possible to fill an additional set of tags like mkgmap:admin_level-alt-2 .. mkgmap:admin_level-alt-11, but I don't see much use in this. If I got it right, all we need for New York are a five rules like this: mkgmap:country=USA & mkgmap:city!=* & mkgmap:admin_level5=New York City & mkgmap:admin_level6=New York County { set mkgmap:city=Manhattan } mkgmap:country=USA & mkgmap:city!=* & mkgmap:admin_level5=New York City & mkgmap:admin_level6=Kings County { set mkgmap:city=Brooklyn } ... With the additional alt_name values it would be one rule like this: mkgmap:country=USA & mkgmap:city!=* & mkgmap:admin_level5=New York City {set mkgmap:city='${mkgmap:admin_level-alt-6}' } (note that the rule doesn't check if the alt-name is filled) Are there more places where this could be used? Gerd > From: gdt(a)ir.bbn.com > To: gpetermann_muenchen(a)hotmail.com > CC: mkgmap-dev(a)lists.mkgmap.org.uk > Subject: Re: [mkgmap-dev] mkgmap in NYC > Date: Mon, 20 Oct 2014 08:37:36 -0400 > > > Gerd Petermann <gpetermann_muenchen(a)hotmail.com> writes: > > > [1] This is because we use so called "precompiled boundaries", and changing them like that would > > require hard coded rules in the source. > > That might be the right place to fix this. Unfortunately New York > really is a weird case (I don't know of any other such case in the US), > but arguably it's important because a lot of people live there :-)

5 12

Splitter
by Lambertus 03 Nov '14

03 Nov '14

There is a ~20MB o5m file that needs to be split. But Splitter returns: "Cannot find a good split with exactly 2 areas" I hope a (the) dev can have a look at this? Thanks! The tile is here: http://osm.pleiades.uni-wuppertal.de/garmin/20140703/63240007.o5m See for more info and a link to the o5m file: http://forum.openstreetmap.org/viewtopic.php?pid=434024#p434024

4 7

Commit: r3344: In OSM-Poland we recently changes administrative boundary classification - we don't use level10 anymore.
by svn commit 02 Nov '14

02 Nov '14

Version mkgmap-r3344 was committed by steve on Sun, 02 Nov 2014 In OSM-Poland we recently changes administrative boundary classification - we don't use level10 anymore. - basement-labs (via github)

1 0

difference
by Steve Sgalowski 02 Nov '14

02 Nov '14

what is the difference between osm2garmin from frank, and the scripting from mkgmap dev crew , as the osm2garmin is not rebooting my garmin nuvi 1450lmt but the map of australia is rebooting my nuvi any ideas @echo off rem -------------------------------------------------- rem --- CreateIMG.bat - By Marco Certelli - Beta07 --- rem -------------------------------------------------- rem **** Define your default country **** set country=australia-latest rem ************************************* rem Available styles: drivemap, kleineisel, masterstyle, default, marine, noname, test set style=drivemap rem Available TYPfiles: DRIVEMAP.TYP, KLEINEISEL.TYP, MASTER.TYP, TEDDY.TYP, DOM.TYP set typfile=here201530.TYP rem Put AddTypToIMG=yes to add TYPfile to gmapsupp.img (so it is active in garmin too) set AddTypToIMG=yes rem MapSource Family-ID: must be a unique (in mapsource) 3 digit number (000 to 999) set FID=923 rem MSDir shall contain the "existing" directory where mapsource installs maps rem Next usually results in MSDir=C:\\Garmin set MSDir=%systemdrive%\\Garmin rem Next usually results in MSDir=C:\\Program Files\\Garmin rem set MSDir=%ProgramFiles% rem set MSDir=%MSDir:\=\\% rem set MSDir=%MSDir%\\Garmin rem Available continents: europe, africa, asia, north-america, south-america set continent= rem Just leave debug=no for production & to delete intermediate temporary files. set debug=no echo. echo ****************************************************** echo * This script downloads (if needed) and compiles the * echo * OSM map data to generate a Garmin IMG routable map * echo ****************************************************** echo. rem Override default country if a name is given to the batch as parameter if "%1" NEQ "" set country=%1 rem Ask user for a country name if no default and no parameter is set if "%country%" NEQ "" goto :Search4Map set /P country="Enter the country to build: " echo. :Search4Map if NOT EXIST OSM-Data mkdir OSM-Data cd OSM-Data rem 1) search for xxx.osm file rem set osmfile=%country%.osm rem if EXIST %osmfile% echo File OSM-Data\%osmfile% found (no download required) rem if EXIST %osmfile% GOTO :SplitMap rem 2) search for xxx.osm.bz2 file rem set osmfile=%country%.osm.bz2 rem if EXIST %osmfile% echo File OSM-Data\%osmfile% found: delete it for a new download rem if EXIST %osmfile% GOTO :SplitMap rem 3) search for xxx.osm.pbf file set osmfile=%country%.osm.pbf if EXIST %osmfile% echo File OSM-Data\%osmfile% found: delete it for a new download if EXIST %osmfile% GOTO :SplitMap echo. echo Downloading OSM data for %country% echo. ..\bin\wget http://download.geofabrik.de/openstreetmap/%continent%/%osmfile% if EXIST %osmfile% goto :SplitMap echo. echo ************************************************************* echo *** SORRY: download of /%continent%/%osmfile% has FAILED!!! echo *** Check at http://download.geofabrik.de/osm/%continent%/ echo *** and manually download %osmfile% echo ************************************************************* echo. goto :END :SplitMap echo. echo Start converting %country% OSM data into IMG Map... if NOT EXIST ..\IMG-OSM-%country% mkdir ..\IMG-OSM-%country% cd ..\IMG-OSM-%country% if EXIST template.args goto :Compile echo. echo Splitting OSM-Data\%osmfile%. Please wait echo. rem start /low /b /wait java -enableassertions -Xmx1000m -jar ..\bin\splitter.jar --mapid=66%FID%001 --max-nodes=1000000 ..\OSM-Data\%osmfile% rem start /low /b /wait java -enableassertions -Xmx1250m -jar ..\bin\splitter.jar --mapid=66%FID%001 --output=xml ..\OSM-Data\%osmfile% start /low /b /wait java -enableassertions -Xmx900m -jar ..\bin\splitter.jar --mapid=66%FID%001 ..\OSM-Data\%osmfile% --output=xml --max-nodes=300000 --problem-report --keep-complete=true --status-freq=120 :Compile echo. echo Compiling OSM-Data\%osmfile% into IMG, FID=%FID%. Please wait echo. set TypFileToAdd= if "%AddTypToIMG%" NEQ "yes" goto :NoTypToAdd copy "..\bin\typ\%typfile%" style.typ 2>nul 1>nul ..\bin\TYPtool %FID% 1 style.typ >nul set TypFileToAdd=style.typ :NoTypToAdd rem start /low /b /wait java -enableassertions -Xmx1000m -jar ..\bin\mkgmap.jar --country-name="%country%" --family-id=%FID% --mapname=66%FID%001 --overview-mapname=66%FID%000 --series-name="OSM-%country%" --family-name="OpenStreetMap: %country%" --style-file=..\bin\styles\ --style=%style% --description="%country%" -c ..\bin\template_basic.args -c template.args %TypFileToAdd% rem start /low /b /wait java -enableassertions -Xmx600m -jar ..\bin\mkgmap.jar --transparent --check-roundabouts --link-pois-to-ways --make-poi-index --reduce-point-density=2.6 --reduce-point-density-polygon=8 --index --levels=0:24,1:22,2:20,3:18,4:16,5:14 --make-poi-index --route --verbose --country-name="%country%" --family-id=%FID% --mapname=66%FID%001 --overview-mapname=66%FID%000 --series-name="OSM-%country%" --family-name="OpenStreetMap: %country%" --style-file=..\bin\styles\ --style=%style% --description="%country%" -c ..\bin\template_basic.args -c template.args %TypFileToAdd% rem start /low /b /wait java -enableassertions -Xmx700m -jar ..\bin\mkgmap.jar --process-destination --add-pois-to-areas --pois-to-areas-placement=tagelist --add-pois-to-lines --tdbfile --transparent --make-poi-index --reduce-point-density=2.6 --reduce-point-density-polygon=4 --index --levels=0:24,1:22,2:20,3:18,4:16,5:14 --make-poi-index --verbose --route --country-name="%country%" --family-id=%FID% --mapname=66%FID%001 --overview-mapname=66%FID%000 --series-name="OSM-%country%" --family-name="OpenStreetMap: %country%" --style-file=..\bin\styles\ --style=%style% --description="%country%" -c ..\bin\template_basic.args -c template.args %TypFileToAdd% start /low /b /wait java -enableassertions -Xmx800m -jar ..\bin\mkgmap.jar --bounds=..\boundary\ --housenumbers --overview-levels --link-pois-to-ways --polygon-size-limits="24:12, 18:10, 16:8, 14:4, 12:2, 11:0" --process-exits --merge-lines --add-pois-to-areas --style=default --pois-to-areas-placement=tagelist --add-pois-to-lines --tdbfile --transparent --reduce-point-density=2.6 --reduce-point-density-polygon=4 --index --levels=0:24,1:22,2:20,3:18,4:16,5:14 --verbose --route --country-name="%country%" --family-id=%FID% --mapname=66%FID%001 --overview-mapname=66%FID%000 --series-name="OSM-%country%" --family-name="OpenStreetMap: %country%" --style-file=..\bin\styles\ --style=%style% --description="%country%" -c ..\bin\template_basic.args -c template.args %TypFileToAdd% if EXIST 66%FID%001.img goto :Cleanup echo. echo *********************************************** echo *** SORRY: IMG compiling task has FAILED!!! *** echo *********************************************** echo. goto :END :Cleanup if "%debug%" NEQ "no" goto :MSPrepare del *.gz 2>nul del *.pbf 2>nul del areas.list 2>nul del template.args 2>nul if EXIST %MSDir% goto :MSPrepare echo. echo MapSource Install files not prepared ("%MSDir%" not existing) goto :END :MSPrepare echo. echo Preparing MapSource Install (.reg) echo. copy ..\bin\typ\%typfile% style.typ 2>nul 1>nul rem preparing MapSource installer registry echo Windows Registry Editor Version 5.00 > IMG-OSM-%country%_MSInstall.reg echo. >> IMG-OSM-%country%_MSInstall.reg echo [HKEY_LOCAL_MACHINE\SOFTWARE\Garmin\Mapsource\Families\IMG-OSM-%country%] >> IMG-OSM-%country%_MSInstall.reg rem TYPtool <family_id> <product_id> <stylefile> ..\bin\TYPtool %FID% 1 style.typ >> IMG-OSM-%country%_MSInstall.reg if EXIST style.typ echo "TYP"="%MSDir%\\IMG-OSM-%country%\\style.typ" >> IMG-OSM-%country%_MSInstall.reg echo. >> IMG-OSM-%country%_MSInstall.reg echo [HKEY_LOCAL_MACHINE\SOFTWARE\Garmin\Mapsource\Families\IMG-OSM-%country%\1] >> IMG-OSM-%country%_MSInstall.reg echo "BMAP"="%MSDir%\\IMG-OSM-%country%\\66%FID%000.img" >> IMG-OSM-%country%_MSInstall.reg echo "LOC"="%MSDir%\\IMG-OSM-%country%" >> IMG-OSM-%country%_MSInstall.reg echo "TDB"="%MSDir%\\IMG-OSM-%country%\\66%FID%000.tdb" >> IMG-OSM-%country%_MSInstall.reg rem preparing un-installer registry echo Windows Registry Editor Version 5.00 > IMG-OSM-%country%_MSUnInstall.reg echo. >> IMG-OSM-%country%_MSUnInstall.reg echo [-HKEY_LOCAL_MACHINE\SOFTWARE\Garmin\Mapsource\Families\IMG-OSM-%country%] >> IMG-OSM-%country%_MSUnInstall.reg :END cd.. echo. echo ******************************************** echo *** CreateIMG Script End - Press any key *** echo ******************************************** if "%1" EQU "" pause >nul stephen galowski

2 1

Commit: r3343: Merge the bounds branch.
by svn commit 02 Nov '14

02 Nov '14

Version mkgmap-r3343 was committed by gerd on Sun, 02 Nov 2014 Merge the bounds branch.

1 0

Building northeast map
by Brian Egge 31 Oct '14

31 Oct '14

I've built my own gmappsup for the US Northeast and loaded it into my Garmin. My script for doing so is roughly as follows: [[ us-northeast-latest.osm.bz2 -nt northeast.om5 ]] && bzcat us-northeast-latest.osm.bz2 | ../osmconvert/osmconvert - -o=northeast.om5 [[ northeast.om5 -nt northeast-boundaries.o5m ]] && ../osmfilter/osmfilter northeast.om5 --keep-nodes= --keep-ways-relations="boundary=administrative =postal_code postal_code=" -o=northeast-boundaries.o5m java -cp ../mkgmap/dist/mkgmap.jar uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryPreprocessor northeast-boundaries.o5m bounds/ java -jar ../mkgmap/dist/mkgmap.jar \ --gmapsupp \ --mapname=20355490 \ --description="Northeast United States" \ --country-name="United States" \ --country-abbr=US \ --region-name="Northeast" \ --region-abbr=NE \ --index \ --location-autofill=nearest \ --housenumbers \ --route \ --add-pois-to-areas \ --bounds=bounds \ --add-pois-to-areas \ --process-destination \ --process-exits \ *.osm.pbf I've loaded the result onto my Garmin Nuvi. When I attempt to do an address search, it first asks me for the City, but the cities I'm looking for don't show up in the search. Oddly, when it shows the closest cities I can see some of them, but when I do a text search it shows distant oddballs. For example, with 'New York', I see: New York, FL New York, TX New York Mills, MN None of these are the New York I'm looking for. I don't even think they are in my input file, but are perhaps coming from the internal memory on my GPS. It does appear the NYC addresses are working better - I can see the Bronx Zoo is in The Bronx and Carnegie Hall is in New York, however, I can't key in an address to see if it works because of the address search issue. Another thing which has me puzzled is why some POIs are not showing the city/state. For example Desert Moon Grille <http://www.openstreetmap.org/node/3139391561> is in Danbury <http://www.openstreetmap.org/way/33271879>, Connecticut. I can find it doing a Food POI search. That works fine. But, when I select it, it shows "Not_set, Fairfield County". Nomination gets the address perfect: Desert Moon Fresh Mexican Grille, 113, Mill Plain Road, Danbury, Fairfield County, Connecticut, United States of America <http://www.openstreetmap.org/node/3139391561> . I'm compiling my own bounds file, so I'm surprised it hasn't worked. Brian

3 10

Convert filter improvements
by Steve Ratcliffe 31 Oct '14

31 Oct '14

Hi I wrote this during the summer after a conversation on the list with Felix. Currently the convert filter will only convert from meters to feet as it was for compatibility with some hard wired rule back before the style system. It also didn't work if the original value had a unit. Eg: '${ele|"m=>ft"}' The patch allows for length conversions between m, km, mi, ft and speed conversions of km/h (kmh, kmph), mph, knots. New ones can easily be added. It will also take into account any unit that already exists. So for example if you have ${val|m=>ft} Then val will be assumed to be in meters if there is no unit. val=10 --> 33 if a unit is given, then it converts from that, so if already in feet the value will be unchanged. val=10ft --> 10 val=10km --> 32,808 If it can't work out what to do then the value is unchanged. ..Steve

1 0