- mkgmap-dev - The mkgmap lists

Optimizing MapSplitter
by Gerd Petermann 15 Nov '14

15 Nov '14

Hi all, I started to rewrite the MapSplitter class so that it produces smaller overlaps. This should improve the redraw speed in the GPS devices because fewer sub divisions have to be rendered. Now I wonder what threshold values to use and if there is an existing tool that allows to display the overlaps. Any ideas? @Andrzej: You posted this idea here: http://gis.19327.n5.nabble.com/question-regarding-MapRoad-tp5781633p5800741… How did you measure ? Gerd

4 27

Problematic tile
by Carlos Dávila 14 Nov '14

14 Nov '14

I'm trying to build a map of Asia, but one tile fails to compile, giving an OutOfMemoryError. Input file is a custom Asia excerpt obtained with the following poly [1]. Problematic tile can be obtained from [2]. It's bbox from splitter is 51700183: 3043328,5879808 to 3856384,8388608 (65.302734,126.166992 to 82.749023,180.000000). It fails with my own style but also with default. My commands: splitter: java -Xmx4000M -jar splitter.jar --keep-complete --geonames-file=geonames/cities15000.zip --max-nodes=1400000 --no-trim --precomp-sea --mapid=51700002 --output=o5m asia-right.o5m mkgmap: java -Xmx6G -enableassertions -Dlog.config=logging.properties -jar mkgmap.jar --output-dir=./tmp --max-jobs --bounds=bounds.zip --precomp-sea=sea --route --latin1 --code-page=1252 --area-name=Asia --family-name="OpenStreetMap Asia" --family-id=170 --product-id=1 --series-name="OSM-Asia" --overview-mapname=ASI-170 --overview-mapnumber=51700000 --name-tag-list=int_name,name:en,name:fr,name --index --process-destination --process-exits --housenumbers --reduce-point-density=4 --reduce-point-density-polygon=8 --polygon-size-limits="24:12, 18:10, 16:0" --add-pois-to-areas --adjust-turn-headings --report-similar-arcs --link-pois-to-ways --location-autofill=is_in,nearest --drive-on-right --check-roundabouts --check-roundabout-flares --license-file=license_ODbL.txt --copyright-message="OpenStreetMap contributors, ODbL. See: http://www.openstreetmap.org/copyright" 51700183.o5m It seems as if it goes into some kind of loop until it exceeds available heap. Any idea why it could happen? [1] http://mapas.alternativaslibres.es/asia-right.poly [2] http://mapas.alternativaslibres.es/51700183.o5m

2 3

Commit: r3350: fix OutOfMemoryError caused by special case:
by svn commit 14 Nov '14

14 Nov '14

Version mkgmap-r3350 was committed by gerd on Fri, 14 Nov 2014 fix OutOfMemoryError caused by special case: A very long line going from 65.866041/180.0 to 66.640599/180.0 . The makeBetweenPoint() routine calculated a point with longitude -180 instead of 180.

1 0

Error not detected
by Stéphane MARTIN 11 Nov '14

11 Nov '14

Hi, Occurring with mkgmap-r3345 & mkgmap-r3346. I made a mistake in the "lines" file. I wrote "ighway=secondary & bridge=yes" Mkgmap didn't detect the error : ----- Found one style in ../styles/default/ Warning: Resolution values <= 10 may confuse MapSource: 5:14, 6:12, 7:10 finished check-styles Number of MapFailedExceptions: 0 Number of ExitExceptions: 0 Time finished: Mon Nov 10 18:48:58 GFT 2014 Total time taken: 13771ms ----- I didn't test with previous versions of mkgmap. The test was right a couple of weeks ago... Do you think it's because of the warning "Resolution values <= 10 may confuse MapSource: 5:14, 6:12, 7:10" ? Regards. Steph

4 4

Commit: r3349: Change logging level to debug in RuleFileReader.saveRule()
by svn commit 11 Nov '14

11 Nov '14

Version mkgmap-r3349 was committed by steve on Tue, 11 Nov 2014 Change logging level to debug in RuleFileReader.saveRule()

1 0

patches
by Brian Egge 11 Nov '14

11 Nov '14

Thanks Ben for the hints with the boundary files. It looks like they are published weekly on the site you linked to. I modify my build script to download them when they change: wget -N --user-agent="www.theeggeadventure.com" http://osm2.pleiades.uni-wuppertal.de/sea/latest/sea.zip wget -N --user-agent="www.theeggeadventure.com" http://osm2.pleiades.uni-wuppertal.de/bounds/latest/bounds.zip <http://osm2.pleiades.uni-wuppertal.de/bounds/latest/bounds.zip> The NYC addresses are working well. I have a minor correction as follows: Index: resources/styles/default/inc/address =================================================================== --- resources/styles/default/inc/address (revision 3342) +++ resources/styles/default/inc/address (working copy) @@ -66,8 +66,11 @@ # New York City has different admin levels than the rest of the US. # https://wiki.openstreetmap.org/wiki/United_States_admin_level mkgmap:country=USA & mkgmap:city!=* & mkgmap:admin_level5='New York City' & mkgmap:admin_level6='New York County' { set mkgmap:city='New York' } -mkgmap:country=USA & mkgmap:city!=* & mkgmap:admin_level5='New York City' & mkgmap:admin_level6='Bronx County' { set mkgmap:city='The Bronx' } +mkgmap:country=USA & mkgmap:city!=* & mkgmap:admin_level5='New York City' & mkgmap:admin_level6='Bronx County' { set mkgmap:city='Bronx' } mkgmap:country=USA & mkgmap:city!=* & mkgmap:admin_level5='New York City' & mkgmap:admin_level6='Kings County' { set mkgmap:city='Brooklyn' } +# Queens uses neighborhoods for city in postal addresses +# http://en.wikipedia.org/wiki/List_of_Queens_neighborhoods +mkgmap:country=USA & mkgmap:city!=* & mkgmap:admin_level5='New York City' & mkgmap:admin_level6='Queens County' & mkgmap:admin_level8=* { set mkgmap:city='${mkgmap:admin_level8}' } mkgmap:country=USA & mkgmap:city!=* & mkgmap:admin_level5='New York City' & mkgmap:admin_level6='Queens County' { set mkgmap:city='Queens' } mkgmap:country=USA & mkgmap:city!=* & mkgmap:admin_level5='New York City' & mkgmap:admin_level6='Richmond County' { set mkgmap:city='Staten Island' } mkgmap:country=USA & mkgmap:city!=* & mkgmap:admin_level8=* { set mkgmap:city='${mkgmap:admin_level8|subst:City of }’ } One always says ‘The Bronx’, but in addresses is it’s simply Bronx. For Queens, the neighborhood is used in mailing addresses, though sometimes people will use ‘Queens’ instead. If you look up "40-01 43 AVENUE” www.usps.com <http://www.usps.com/>, it says the standardized address is: 4001 43RD AVE SUNNYSIDE NY 11104-3205 But, the school board <http://schools.nyc.gov/SchoolPortals/30/Q150/default.htm> lists it’s address as: 40-01 43 AVENUE QUEENS, NY11104 While the school itself <https://sites.google.com/site/ps150queens/> says it’s address is: 40-01 43 Avenue Sunnyside, NY 11104 If I’m given an address, most likely it will have the neighborhood in it, and not ‘Queens’. Here’s an alternative patch to pick up place_name: Index: src/uk/me/parabola/mkgmap/build/LocatorUtil.java =================================================================== --- src/uk/me/parabola/mkgmap/build/LocatorUtil.java (revision 3342) +++ src/uk/me/parabola/mkgmap/build/LocatorUtil.java (working copy) @@ -28,7 +28,7 @@ .compile("[,\\s]+"); public static List<String> getNameTags(Properties props) { - String nameTagProp = props.getProperty("name-tag-list", "name"); + String nameTagProp = props.getProperty("name-tag-list", "name,place_name"); return Arrays.asList(COMMA_OR_SPACE_PATTERN.split(nameTagProp)); } Can we reduce the logging from the RuleFileReader by default? It produces a huge amount of output which probably isn’t useful unless you are debugging the rule reader. Index: src/uk/me/parabola/mkgmap/osmstyle/RuleFileReader.java =================================================================== --- src/uk/me/parabola/mkgmap/osmstyle/RuleFileReader.java (revision 3342) +++ src/uk/me/parabola/mkgmap/osmstyle/RuleFileReader.java (working copy) @@ -243,7 +243,7 @@ * from the expression. */ private void saveRule(TokenScanner scanner, Op op, ActionList actions, GType gt) { - log.info("EXP", op, ", type=", gt); + log.debug("EXP", op, ", type=", gt); // check if the type definition is allowed if (inFinalizeSection && gt != null) Here’s a bit friendlier documentation: Index: src/uk/me/parabola/mkgmap/osmstyle/StyledConverter.java =================================================================== --- src/uk/me/parabola/mkgmap/osmstyle/StyledConverter.java (revision 3342) +++ src/uk/me/parabola/mkgmap/osmstyle/StyledConverter.java (working copy) @@ -926,7 +926,10 @@ } else { mp = new MapPoint(); - log.warn("Motorway exit", node.getName(), "(" + node.getLocation().toOSMURL() + ") has no motorway! (either make the exit share a node with the motorway or specify the motorway ref with a", Exit.TAG_ROAD_REF, "tag)"); + // This may be caused by a motorway node connecting to two motorway links and no motorway + log.warn("Motorway exit", node.getName(), "(" , node.toBrowseURL(), + ") has no motorway! (either make the exit share a node with the motorway or specify the motorway ref with a", + Exit.TAG_ROAD_REF, "tag)"); } } else { Note - it an enhancement would be to see if the motorway_link is connected to another motorway_link, and attempt to follow the links back the motorway. Standardize the URL: Index: src/uk/me/parabola/mkgmap/reader/osm/Element.java =================================================================== --- src/uk/me/parabola/mkgmap/reader/osm/Element.java (revision 3342) +++ src/uk/me/parabola/mkgmap/reader/osm/Element.java (working copy) @@ -251,7 +251,7 @@ } public String toBrowseURL() { - return "http://www.openstreetmap.org/browse/" + kind() + "/" + id; + return "http://www.openstreetmap.org/" + kind() + "/" + id; } public Element copy() { Brian

5 5

Commit: r3348: improve logging
by svn commit 11 Nov '14

11 Nov '14

Version mkgmap-r3348 was committed by gerd on Tue, 11 Nov 2014 improve logging .Brian Egge

1 0

Commit: r3347: improve the New York address search.
by svn commit 11 Nov '14

11 Nov '14

Version mkgmap-r3347 was committed by gerd on Tue, 11 Nov 2014 improve the New York address search. -Brian Egge

1 0

Commit: r3346: Add get access to subdivision width and height and fix read values.
by svn commit 10 Nov '14

10 Nov '14

Version mkgmap-r3346 was committed by steve on Mon, 10 Nov 2014 Add get access to subdivision width and height and fix read values. The width and height are stored as half width and height, so multiply by 2 when reading in.

1 0

Unknown points on decompiled map
by Andrzej Popowski 09 Nov '14

09 Nov '14

Hi, I have decompiled some tiles of my map with GPSMapEdit. I have found some points, that shouldn't be there. Points have types, that I never have used, like for example 0x16401 and some are placed outside of tile area. This could be an error in mkgmap or GPSMapEdit, I can't tell. I think points appear on tiles, which contains sea. See this example: http://files.mkgmap.org.uk/download/222/29626450.7z One of these points (type 0x10e00) is placed at N5.256958 W8.848844. Best regards, Andrzej

3 3