February 2013 - mkgmap-dev - The mkgmap lists

Question reg. LayerFilterChain.addElement
by GerdP 05 Feb '13

05 Feb '13

Hi, maybe I found an error, maybe my understanding is wrong... I thought that all filters in the chain are executed before any element is finally passed to eg. the MapBuilder.LineAddFilter.LineAddFilter But if eg. the LineSplitterFilter calls addElement() instead of doFilter() all following filters are skipped and MapBuilder.LineAddFilter.LineAddFilter is called directly. If this is intended, where should a filter that checks for equal coordinates be placed? I wanted to add it after RemoveEmpty(), but then some invalid lines are passed to the map.addMapObject() method. ciao, Gerd -- View this message in context: http://gis.19327.n5.nabble.com/Question-reg-LayerFilterChain-addElement-tp5… Sent from the Mkgmap Development mailing list archive at Nabble.com.

2 4

Question reg. LinePreparer
by GerdP 05 Feb '13

05 Feb '13

Hi, I simply copied it to the LinePreparerFilter, but what is the idea behind this code in LinePreparer? // compute normalized differences // -2^(shift-1) <= dx, dy < 2^(shift-1) // XXX: relies on the fact that java integers are 32 bit signed final int offset = 8+shift; int dx = (lon - lastLong) << offset >> offset; int dy = (lat - lastLat) << offset >> offset; I don't understand the comment. Why are the values shifted left and right? While debugging I did not see a case where this changed the result. Gerd -- View this message in context: http://gis.19327.n5.nabble.com/Question-reg-LinePreparer-tp5748142.html Sent from the Mkgmap Development mailing list archive at Nabble.com.

2 2

Commit: r2474: Fix typo: supportsNode --> supportsRelation
by svn commit 04 Feb '13

04 Feb '13

Version 2474 was committed by steve on Mon, 04 Feb 2013 Fix typo: supportsNode --> supportsRelation

1 0

Patch for routing problems in r2448 and higher
by GerdP 04 Feb '13

04 Feb '13

Hi, with r2448 the removeShortArcs routine was no longer applied to non-routable ways. This increased the possibility that an invalid line passes all filters but finally is not written to the RGN file while still increasing the subdivision lineNumber. This breaks routing in some case. Attached patch adds a check to the final filter to avoid that. fix_routing_v1.patch <http://gis.19327.n5.nabble.com/file/n5747979/fix_routing_v1.patch> @Steve: It would also be possible to create a new filter for that, but this would mean that we duplicate most of the code in LinePreparer. I don't know if this would be better. Ciao, Gerd -- View this message in context: http://gis.19327.n5.nabble.com/Patch-for-routing-problems-in-r2448-and-high… Sent from the Mkgmap Development mailing list archive at Nabble.com.

4 16

Re: [mkgmap-dev] Regression: Revision 2448 breaking routing in some cases
by Felix Hartmann 04 Feb '13

04 Feb '13

Oh okay, well then let's put this on the list. I know the remove-short-arcs function is not touching it, but it's 2448 that breaks it. There must be something else touched on the routing side of it. And I would say it's very likely not only happening here, but probably happening in quite a few cases - it just popped up there. On 30.01.2013 22:19, Gerd Petermann wrote: > Hi Felix, > > sorry, I have no idea what goes wrong. With r2466, the > remove-short-arcs function doesn't touch the way 38693214 or 83196110. > I think this is something Steve must look at. > > Gerd > P.S. I don't know why my answer to your first mail did not go to the > list. This was not intended. > > > ------------------------------------------------------------------------ > Date: Wed, 30 Jan 2013 17:47:44 +0100 > From: extremecarver(a)gmail.com > To: gpetermann_muenchen(a)hotmail.com > Subject: Re: [mkgmap-dev] Regression: Revision 2448 breaking routing > in some cases > > okay great, well I think there is some routing information missing on > the road. Just see what happens when you try to click on it for a > route with Basecamp or Mapsource - it puts the routing node somewhere > completly else (a little bit, like what happens with merge-lines, just > much further away). > On 30.01.2013 17:39, Gerd Petermann wrote: > > Hi Felix, > > okay, I see if I can find anything special in this file. We > already know that the algorithm is not 100 % correct, and I hope > Steve will find a better solution,but > maybe I can improve the existing algo first. > > Gerd > > ------------------------------------------------------------------------ > Date: Wed, 30 Jan 2013 17:22:30 +0100 > From: extremecarver(a)gmail.com <mailto:extremecarver@gmail.com> > To: gpetermann_muenchen(a)hotmail.com > <mailto:gpetermann_muenchen@hotmail.com> > Subject: Re: [mkgmap-dev] Regression: Revision 2448 breaking > routing in some cases > > > On 30.01.2013 16:23, Gerd Petermann wrote: > > Hi Felix, > > I want to find the special case in this. Please provide the > osm data (66570017.osm.pbf ) > > it's here now: http://openmtbmap.org/65250017.osm.pbf > > Are you able to reproduce the problem with the default style? > > No, I'm really lost on the style issue. I can cut down the style > quite far, and it's still broken. But even if I change routable > lines, that are created after the breaking road (further down in > the lines file), it can suddenly work again. > On the other hand, there seems to be nothing special about the osm > data there at all. > > > Gerd > > > Date: Wed, 30 Jan 2013 11:46:24 +0100 > > From: extremecarver(a)gmail.com <mailto:extremecarver@gmail.com> > > To: mkgmap-dev(a)lists.mkgmap.org.uk > <mailto:mkgmap-dev@lists.mkgmap.org.uk> > > Subject: [mkgmap-dev] Regression: Revision 2448 breaking > routing in some cases > > > > Well, I got notified that there is a routing problem in one > of my maps, > > and after trying around a long time, I tracked it down to > release 2448 > > that breaks routing under certain occasions. Here is a > screenshot of the > > the routing failing: > > > > http://openmtbmap.org/broken_routing.jpg > > > > So for a very short distance, the routing will actually > route over the > > broken road (the section where the route is missing). > > However for longer sections on that road, or route that > actually has a > > routepoint manually set on it, Mapsource/Basecamp/GPS will > fail to > > calculate a route at all. (e.g. if you try to route from the > North point > > of the route in the picture, South to the Bergkirchen place > POI/node). > > > > > > It is dependant on the the style - but I played with > deleting lots of > > stuff from the style, and it seems to be quite random. > > So here are the downloads (all .exe are lzma packed, just > unpack them if > > not on windows): > > > > http://openmtbmap.org/velonordrhein-westfalen_working_2447.exe > > http://openmtbmap.org/velonordrhein-westfalen_broken_2448.exe > > > > Search for Bergkirchen, it is in the tile 66570017 > > > > > > Maps are compiled with: > > c:\OpenMTBMap\maps>start /low /b /wait java -jar -Xms4000M > -Xmx10400M > > c:\openmtbmap\mkgmap.jar --max-jobs=8 --generate-sea --latin1 > > --precomp-sea=c:\openmtbmap\maps\sea > > "--style-file=c:\openmtbmap\velomap_style" --nsis --index > --transparent > > --adjust-turn-headings --add-pois-to-areas --ignore-maxspeeds > > --reduce-point-density=3 --x-reduce-point-density-polygon=6 > > --link-pois-to-ways --ignore-turn-restrictions > --remove-short-arcs=5.4 > > --min-size-polygon=18 --description=velomap_dnw > --show-profiles=1 > > --location-autofill=bounds,is_in,nearest > > --bounds=c:\openmtbmap\maps\bounds --route --country-abbr=dnw > > --country-name=nordrhein-westfalen --mapname=66570000 > --family-id=6657 > > --product-id=1 > --series-name=velomap_nordrhein-westfalen_30.01.2013 > > --family-name=velomap_dnw_30.01.2013 --tdbfile > > --overview-mapname=mapsetc --keep-going > > --area-name="nordrhein-westfalen_30.01.2013_velomap.org" -c > > c:\openmtbmap\maps\template.nordrhein-westfalen 7*.img 1>NUL > > > > --remove-short-arcs == resulting road will be broken > > --remove-short-arcs=5.4 == resulting road will be broken > > without remove-short-arcs == resulting road will be broken > > > > So it doesn't directly have to do with the > --remove-short-arcs function. > > > > > > (also Compiled with --remove-short-arcs=5.4 ) > > http://openmtbmap.org/velonordrhein-westfalen_broken_2466.exe > > > > then Uncommented the following lines in my style-file, which > shouldn't > > affect routing at all, but it does as the mistake is gone: > > # power=line [0x29 resolution 22 continue] > > # power=minor_line | powerline=yes | power_line=yes | > powerline=true | > > power_line=true [0x29 resolution 24 continue] > > http://openmtbmap.org/velonordrhein-westfalen_nopower_2466.exe > > > > However I can also leave that line in the style-file, and > delete some > > other lines, and routing will work again. There seems to be > no clear > > pattern (except that the bug go introduced with rev 2448). I > use the > > same line in my openmtbmap, and there the routing error > doesn't happen. > > > > > > -- > > keep on biking and discovering new trails > > > > Felix > > openmtbmap.org & www.velomap.org <http://www.velomap.org> > > > > _______________________________________________ > > mkgmap-dev mailing list > > mkgmap-dev(a)lists.mkgmap.org.uk > <mailto:mkgmap-dev@lists.mkgmap.org.uk> > > http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > > > -- > keep on biking and discovering new trails > > Felix > openmtbmap.org &www.velomap.org <http://www.velomap.org> > > > -- > keep on biking and discovering new trails > > Felix > openmtbmap.org &www.velomap.org <http://www.velomap.org> -- keep on biking and discovering new trails Felix openmtbmap.org & www.velomap.org

4 10

removeShortArcs_v4.patch for regression in r2448
by GerdP 03 Feb '13

03 Feb '13

Hi, I still have no idea what exactly goes wrong, but it seems that we have to apply short arc removal to all ways that are not shapes. Since r2448 this was no longer done, which broke routing. Attached patch for r2473 changes the code so that removeShortArcs is again done for roads and other lines. removeShortArcs_v4.patch <http://gis.19327.n5.nabble.com/file/n5747776/removeShortArcs_v4.patch> Gerd -- View this message in context: http://gis.19327.n5.nabble.com/removeShortArcs-v4-patch-for-regression-in-r… Sent from the Mkgmap Development mailing list archive at Nabble.com.

4 10