February 2013 - mkgmap-dev - The mkgmap lists

Commit: r2477: Avoid that multipolygon cutting algorithm creates very small polygons
by svn commit 07 Feb '13

07 Feb '13

Version 2477 was committed by wanmil on Wed, 06 Feb 2013 Avoid that multipolygon cutting algorithm creates very small polygons The algorithm has been changed so that cuts with a high aspect ratio are preferred to those that cut multiple inner polygons. This avoids that the cut algorithm creates narrow but wide polygons that are filtered out when zoomed out. This avoids white stripes in sea areas.

3 8

poiDispFlag="0xc" in locatorconfig.xml
by Felix Hartmann 07 Feb '13

07 Feb '13

Just a quick question. I couldn't find anywhere documentation what it does exactly. Why is it added for some countries? And what does regionOffset="number" do? -- keep on biking and discovering new trails Felix openmtbmap.org & www.velomap.org

6 10

mkgmap 2470 breakage
by Felix Hartmann 07 Feb '13

07 Feb '13

As of 2470 I run into the following error. If I downgrade to 2468 my map compiles fine again without this error. (I first thought this is due to the remove_short_arcs_v4.patch, but actually I run into it with any mkgmap version >=2470) java.lang.UnsupportedOperationException at uk.me.parabola.mkgmap.osmstyle.eval.AbstractOp.value(AbstractOp.java:110) at uk.me.parabola.mkgmap.osmstyle.eval.EqualsOp.eval(EqualsOp.java:44) at uk.me.parabola.mkgmap.osmstyle.eval.AndOp.eval(AndOp.java:34) at uk.me.parabola.mkgmap.osmstyle.eval.AndOp.eval(AndOp.java:34) at uk.me.parabola.mkgmap.osmstyle.eval.AndOp.eval(AndOp.java:34) at uk.me.parabola.mkgmap.osmstyle.eval.AndOp.eval(AndOp.java:34) at uk.me.parabola.mkgmap.osmstyle.eval.AndOp.eval(AndOp.java:34) at uk.me.parabola.mkgmap.osmstyle.eval.AndOp.eval(AndOp.java:34) at uk.me.parabola.mkgmap.osmstyle.eval.AndOp.eval(AndOp.java:34) at uk.me.parabola.mkgmap.osmstyle.ActionRule.resolveType(ActionRule.java:59) at uk.me.parabola.mkgmap.osmstyle.RuleSet.resolveType(RuleSet.java:68) at uk.me.parabola.mkgmap.osmstyle.StyledConverter.convertWay(StyledConverter.java:216) at uk.me.parabola.mkgmap.reader.osm.ElementSaver.convert(ElementSaver.java:237) at uk.me.parabola.mkgmap.reader.osm.bin.OsmBinMapDataSource.load(OsmBinMapDataSource.java:75) at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:144) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:56) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:201) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:198) at java.util.concurrent.FutureTask$Sync.innerRun(Unknown Source) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source)

3 4

Commit: r2479: Replace poiDispFlag attribute in LocatorConfig.xml with streetBeforeHousenumber and postalcodeBeforeCity
by svn commit 06 Feb '13

06 Feb '13

Version 2479 was committed by wanmil on Wed, 06 Feb 2013 Replace poiDispFlag attribute in LocatorConfig.xml with streetBeforeHousenumber and postalcodeBeforeCity The poiDispFlag value sometimes did overwrite flags that were set at other places (e.g. the transparent flag). In the LocatorConfig.xml only the two flags streetBeforeHousenumber and postalcodeBeforeCity can be set. So it is better to use two separate flags instead a bit coded value with only two relevant bits. This might fix a problem where maps were not transparent in some countries also the --transparent option was set.

1 0

filters for shapes
by GerdP 06 Feb '13

06 Feb '13

Hi, the current filter chain for shapes is a bit confusing for me: - We start with PreserveHorizontalAndVerticalLinesFilter which uses the original coords (in map units) to preserve endpoints of vertical and horizontal lines. - Next we use the RoundCoordsFilter which rounds the coords according to the desired resolution For low resolutions, many small shapes are rounded to a single point. Only when the remaining line has at least two points we continue either with the SizeFilter or with the DouglasPeuckerFilter (if they are not disabled) Only the DouglasPeuckerFilter cares about the preserved flag, so I think the PreserveHorizontalAndVerticalLinesFilter should be moved directly before it so that it checks only the rounded coords. I also wonder why we use the PreserveHorizontalAndVerticalLinesFilter for lines that are not shapes. The filter was added with a comment regarding polygons only. Ciao, Gerd -- View this message in context: http://gis.19327.n5.nabble.com/filters-for-shapes-tp5748328.html Sent from the Mkgmap Development mailing list archive at Nabble.com.

1 0

[PATCH v1] Improve aspect ratio of cuttings in multipolygon algorithm
by WanMil 06 Feb '13

06 Feb '13

The patch improves the existing multipolygon cut algorithm. It prefers cuttings with a higher aspect ratio. This avoids very long and small width cuts. That lead to white lines in the precompiled sea areas. With the new algorithm I only saw very few of the white lines but small islands tends to grow when zooming out. The patch fixes precompiling sea and common multipolygons. You have to reprecompile the sea with the patch applied to see a difference. WanMil

2 1

Commit: r2476: Correct and simplify map filter chain: Replaced obsolete LayerFilterChain.addElement() by LayerFilterChain.doFilter() and made sure that all following filters are executed (not only the last)
by svn commit 06 Feb '13

06 Feb '13

Version 2476 was committed by gerd on Wed, 06 Feb 2013 Correct and simplify map filter chain: Replaced obsolete LayerFilterChain.addElement() by LayerFilterChain.doFilter() and made sure that all following filters are executed (not only the last) This error did not cause any harm until r2474.

1 0

Commit: r2475: Fix routing problems introduced with r2448.
by svn commit 06 Feb '13

06 Feb '13

Version 2475 was committed by gerd on Wed, 06 Feb 2013 Fix routing problems introduced with r2448. 1) StyledConverter: try to avoid adding consecutive equal coordinates 2) LinePreparerFilter: do the same calculations as LinePreparer and reject lines that would be rejected later by LinePreparer 3) LineSplitterFilter: don't create small final part which is likely to be discarded

1 0

Patch v2 for routing problems in r2448 and higher
by GerdP 05 Feb '13

05 Feb '13

Hi, attached is a patch that adds a new filter and a simple check to avoid the routine problems. 1) StyledConverter: try to avoid adding consecutive equal coords 2) LinePreparerFilter: do the same calcs as LinePreparer and reject lines that would be rejected later by LinePreparer 3) LineSplitterFilter: don't create small final part which is likely to be discarded fix_routing_v2.patch <http://gis.19327.n5.nabble.com/file/n5748091/fix_routing_v2.patch> It solved the problems reported by NetCheck with my test data but it is still possible that invalid lines are passed to MapBuilder.ShapeAddFilter due to the bogus addElement function. I am not 100% sure if these invalid shapes can cause routing errors, but I doubt it. Ciao, Gerd -- View this message in context: http://gis.19327.n5.nabble.com/Patch-v2-for-routing-problems-in-r2448-and-h… Sent from the Mkgmap Development mailing list archive at Nabble.com.

3 14

[PATCH v1] Ensure that only 0xc bits can be configured with poiDispFlags in LocatorConfig.xml
by WanMil 05 Feb '13

05 Feb '13

The patch ensures that only bits 0x02 and 0x04 are taken from poiDispFlag attribute in the LocatorConfig. Does no longer overwrite the poiDispFlag in the TREHeader but performs an OR with the existing flags. WanMil

1 0