June 2009 - mkgmap-dev - The mkgmap lists

overview, tdb, detail files naming
by Anton Todorov 21 Jun '09

21 Jun '09

Hi, I am new to the list but would like to share some thoughts about naming the files. Detail maps: the files has name of 8 digits. The internal subfiles are with the same digits or combination of 'I'+7digits. TDB: there is relation that is always digits(4byte field) to map names.(section 0x42 for overview and 0x4c for detail) Overview map: in mkgmap the map name is 8 digits too. But mapsource permit the use of text for overview and tdb file. So I think for overview map we should think that there are two definitions: mapname and mapnumber than can be different. for example the overview map and tdb files can have name Country.img and Country.tdb, the detail map with file name 12345678.img. The only thing that need to be added is the internal map number in Country.img and this number to be described in Country.tdb (section 0x42 and 0x4c). I attached patch for this change in my previous mail but maybe it is lost. So here is the patch inline: Best Regards, Anton Todorov Index: doc/mkgmap-man.txt =================================================================== --- doc/mkgmap-man.txt (revision 1067) +++ doc/mkgmap-man.txt (working copy) @@ -28,4 +28,9 @@ displayed in the chosen character set into unaccented characters. --overview-mapname=''name'' - This gives the name of the overview map. + If --tdbfile is enabled, this gives the name of the overview .img and .tdb files. + The default map name is OSM_map. + +--overview-mapnumber=''8 digit number'' + If --tdbfile is enabled, this gives the internal 8 digit number used in overview map and + tdb file. The default number is 63240000. Index: resources/help/en/options =================================================================== --- resources/help/en/options (revision 1067) +++ resources/help/en/options (working copy) @@ -98,7 +98,14 @@ --series-name --family-name --area-name ---overview-mapname +--overview-mapname=name + If --tdbfile is enabled, this gives the name of the overview .img and .tdb files. + The default map name is OSM_map. + +--overview-mapnumber=8 digit number + If --tdbfile is enabled, this gives the internal 8 digit number used in overview map and + tdb file. The default number is 63240000. + Misc options: --max-jobs[=number] Index: src/uk/me/parabola/mkgmap/CommandArgsReader.java =================================================================== --- src/uk/me/parabola/mkgmap/CommandArgsReader.java (revision 1067) +++ src/uk/me/parabola/mkgmap/CommandArgsReader.java (working copy) @@ -56,7 +56,8 @@ // line before any user supplied options. add(new CommandOption("mapname", "63240001")); add(new CommandOption("description", "OSM street map")); - add(new CommandOption("overview-mapname", "63240000")); + add(new CommandOption("overview-mapname", "OSM_map")); + add(new CommandOption("overview-mapnumber", "63240000")); } public CommandArgsReader(ArgumentProcessor proc) { Index: src/uk/me/parabola/mkgmap/combiners/TdbBuilder.java =================================================================== --- src/uk/me/parabola/mkgmap/combiners/TdbBuilder.java (revision 1067) +++ src/uk/me/parabola/mkgmap/combiners/TdbBuilder.java (working copy) @@ -48,6 +48,7 @@ private int parent = 63240000; private String overviewMapname; + private String overviewMapnumber; private String overviewDescription; private int tdbVersion; @@ -59,11 +60,12 @@ * In otherwords if the same argument appears more than once, then it will */ public void init(CommandArgs args) { - overviewMapname = args.get("overview-mapname", "63240000"); + overviewMapname = args.get("overview-mapname", "OSM_map"); + overviewMapnumber = args.get("overview-mapnumber", "63240000"); try { - parent = Integer.parseInt(overviewMapname); + parent = Integer.parseInt(overviewMapnumber); } catch (NumberFormatException e) { - log.debug("overview map name not an integer", overviewMapname); + log.debug("overview map number not an integer", overviewMapnumber); } overviewDescription = args.get("overview-description", "Overview Map"); @@ -113,7 +115,7 @@ String mapname = finfo.getMapname(); String mapdesc = finfo.getDescription(); - detail.setMapName(mapname); + detail.setMapName(mapname, mapname); String desc = mapdesc + " (" + mapname + ')'; detail.setDescription(desc); @@ -123,7 +125,8 @@ detail.setNetDataSize(finfo.getNetsize()); detail.setNodDataSize(finfo.getNodsize()); - log.info("overview-mapname", parent); + log.info("overview-mapname", overviewMapname); + log.info("overview-mapnumber", parent); detail.setParentMapNumber(parent); tdb.addDetail(detail); @@ -216,7 +219,7 @@ // We can set the overall bounds easily as it was calcualted as part of // the overview map. - tdb.setOverview(overviewMapname, overviewSource.getBounds()); + tdb.setOverview(overviewMapname, overviewSource.getBounds(), overviewMapnumber); writeTdbFile(); writeOverviewMap(); @@ -234,7 +237,7 @@ params.setMapDescription(overviewDescription); try { - Map map = Map.createMap(overviewMapname, params); + Map map = Map.createMap(overviewMapname, params, overviewMapnumber); mb.makeMap(map, overviewSource); map.close(); } catch (FileExistsException e) { Index: src/uk/me/parabola/mkgmap/main/MapMaker.java =================================================================== --- src/uk/me/parabola/mkgmap/main/MapMaker.java (revision 1067) +++ src/uk/me/parabola/mkgmap/main/MapMaker.java (working copy) @@ -86,7 +86,7 @@ log.info("Started making", args.getMapname(), "(" + args.getDescription() + ")"); try { - Map map = Map.createMap(args.getMapname(), params); + Map map = Map.createMap(args.getMapname(), params, args.getMapname()); setOptions(map, args); MapBuilder builder = new MapBuilder(); Index: src/uk/me/parabola/mkgmap/main/AbstractTestMap.java =================================================================== --- src/uk/me/parabola/mkgmap/main/AbstractTestMap.java (revision 1067) +++ src/uk/me/parabola/mkgmap/main/AbstractTestMap.java (working copy) @@ -54,7 +54,7 @@ Map map; try { - map = Map.createMap("32860003", params); + map = Map.createMap("32860003", params, "32860003"); } catch (FileExistsException e) { throw new ExitException("File exists already", e); } catch (FileNotWritableException e) { Index: src/uk/me/parabola/tdbfmt/TdbFile.java =================================================================== --- src/uk/me/parabola/tdbfmt/TdbFile.java (revision 1067) +++ src/uk/me/parabola/tdbfmt/TdbFile.java (working copy) @@ -118,10 +118,10 @@ * @param name The overview map name. * @param bounds The bounds for the map. */ - public void setOverview(String name, Area bounds) { + public void setOverview(String name, Area bounds, String number) { overviewMapBlock = new OverviewMapBlock(); overviewMapBlock.setArea(bounds); - overviewMapBlock.setMapName(name); + overviewMapBlock.setMapName(name, number); overviewMapBlock.setDescription(overviewDescription); } Index: src/uk/me/parabola/tdbfmt/OverviewMapBlock.java =================================================================== --- src/uk/me/parabola/tdbfmt/OverviewMapBlock.java (revision 1067) +++ src/uk/me/parabola/tdbfmt/OverviewMapBlock.java (working copy) @@ -107,10 +107,10 @@ this.description = description; } - public void setMapName(String mapName) { + public void setMapName(String mapName, String mapNumber) { this.mapName = mapName; try { - this.mapNumber = Integer.parseInt(mapName); + this.mapNumber = Integer.parseInt(mapNumber); } catch (NumberFormatException e) { this.mapNumber = 0; } Index: src/uk/me/parabola/imgfmt/app/map/Map.java =================================================================== --- src/uk/me/parabola/imgfmt/app/map/Map.java (revision 1067) +++ src/uk/me/parabola/imgfmt/app/map/Map.java (working copy) @@ -81,7 +81,7 @@ * @throws FileNotWritableException If the file cannot * be opened for write. */ - public static Map createMap(String mapname, FileSystemParam params) + public static Map createMap(String mapname, FileSystemParam params, String mapnumber) throws FileExistsException, FileNotWritableException { Map m = new Map(); @@ -92,13 +92,13 @@ m.filename = outFilename; m.fileSystem = fs; - m.rgnFile = new RGNFile(m.fileSystem.create(mapname + ".RGN")); - m.treFile = new TREFile(m.fileSystem.create(mapname + ".TRE"), true); - m.lblFile = new LBLFile(m.fileSystem.create(mapname + ".LBL")); + m.rgnFile = new RGNFile(m.fileSystem.create(mapnumber + ".RGN")); + m.treFile = new TREFile(m.fileSystem.create(mapnumber + ".TRE"), true); + m.lblFile = new LBLFile(m.fileSystem.create(mapnumber + ".LBL")); int mapid; try { - mapid = Integer.parseInt(mapname); + mapid = Integer.parseInt(mapnumber); } catch (NumberFormatException e) { mapid = 0; }

1 0

A free MapSource installer for Windows
by Ævar Arnfjörð Bjarmason 21 Jun '09

21 Jun '09

On Tue, May 26, 2009 at 12:05 PM, maning sambale<emmanuel.sambale(a)gmail.com> wrote: > Somewhat off-topic with mkgmap but closely related, I have been > receiving numerous reports of mapsource install error of my OSM-PH > garmin maps > I create mapsource installer using winrar's sfx version, for details: > http://epsg4253.wordpress.com/2009/04/13/diy-garmin-routable-map-from-opens… Apologies for the blogspam but I'm working on a free MapSource installer for Windows: http://www.openstreetmap.org/user/%C3%86var%20Arnfj%C3%B6r%C3%B0%20Bjarmaso… It would be useful to get input on the full range of registry keys MapSource supports and how that relates to mkgmap command line options. I don't have any non-free maps installed so I only have the previous thread on this list to refer to.

1 0

[patch] Ant-Task for mkgmap
by Christian Gawron 20 Jun '09

20 Jun '09

Hi, I've written an ant task for mkgmap which can be used like this: <target name="mkgmap"> <taskdef name="mkgmap" classname="uk.me.parabola.mkgmap.ant.MKGMapTask" classpath="/home/cgawron/mkgmap/dist/mkgmap.jar:."/> <mkgmap options="mkgmap.cfg"> <path> <fileset dir="." includes="input_sauerland.osm" /> </path> </mkgmap> </target> The task supports an options file and nested filesets with osm files. Since it reuses most of mkgmap's argument processing, I had to make some protected methods of Option.java and CommandArgsReader.java public (see attached patch). Best wishes Christian /* * Copyright (C) 2009 Christian Gawron * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * * Author: Christian Gawron * Create date: 19-Jun-2009 */ package uk.me.parabola.mkgmap.ant; import org.apache.tools.ant.Task; import org.apache.tools.ant.BuildException; import org.apache.tools.ant.types.Path; import java.io.*; import java.util.*; import uk.me.parabola.mkgmap.main.Main; import uk.me.parabola.mkgmap.ArgumentProcessor; import uk.me.parabola.mkgmap.CommandArgs; import uk.me.parabola.mkgmap.CommandArgsReader; /** * This class provides an ant task for mkgmap */ public class MKGMapTask extends Task { private ArgumentProcessor proc = null; CommandArgsReader argsReader = null; private Vector<Path> paths = new Vector<Path>(); public void init() { proc = new Main(); argsReader = new CommandArgsReader(proc); } public void addPath(Path path) { paths.add(path); } public void setOptions(String configFile) { argsReader.readConfigFile(configFile); } public void execute() { try { proc.startOptions(); for (Path path : paths) { String[] includedFiles = path.list(); for (int i=0; i<includedFiles.length; i++) { String filename = includedFiles[i]; log("processing " + filename); argsReader.addOption("input-file", filename); } } for (CommandArgsReader.ArgType a : argsReader.getArgList()) { a.processArg(); } proc.endOptions(new CommandArgs(argsReader.getArgs())); } catch (Exception ex) { log(ex, 1); ex.printStackTrace(); throw new BuildException(ex); } } } Index: src/uk/me/parabola/mkgmap/Option.java =================================================================== --- src/uk/me/parabola/mkgmap/Option.java (Revision 1067) +++ src/uk/me/parabola/mkgmap/Option.java (Arbeitskopie) @@ -34,7 +34,7 @@ } } - protected Option(String option, String value) { + public Option(String option, String value) { this.option = option; this.value = value; } Index: src/uk/me/parabola/mkgmap/CommandArgsReader.java =================================================================== --- src/uk/me/parabola/mkgmap/CommandArgsReader.java (Revision 1067) +++ src/uk/me/parabola/mkgmap/CommandArgsReader.java (Arbeitskopie) @@ -129,7 +129,7 @@ * @param option The option name. * @param value Its value. */ - private void addOption(String option, String value) { + public void addOption(String option, String value) { CommandOption opt = new CommandOption(option, value); addOption(opt); } @@ -181,13 +181,21 @@ return arglist.iterator(); } + public ArgList getArgList() { + return arglist; + } + + public EnhancedProperties getArgs() { + return args; + } + /** * Read a config file that contains more options. When the number of * options becomes large it is more convenient to place them in a file. * * @param filename The filename to obtain options from. */ - private void readConfigFile(String filename) { + public void readConfigFile(String filename) { Options opts = new Options(new OptionProcessor() { public void processOption(Option opt) { log.debug("incoming opt", opt.getOption(), opt.getValue()); @@ -206,14 +214,14 @@ * the argument to be processed in order. Options can be intersperced with * filenames. The options take effect where they appear. */ - interface ArgType { + public interface ArgType { public abstract void processArg(); } /** * A filename. */ - class Filename implements ArgType { + public class Filename implements ArgType { private final String name; private boolean useFilenameAsMapname = true; @@ -270,7 +278,7 @@ /** * An option argument. A key value pair. */ - class CommandOption implements ArgType { + public class CommandOption implements ArgType { private final Option option; private CommandOption(Option option) { @@ -297,7 +305,7 @@ /** * The arguments are held in this list. */ - class ArgList implements Iterable<CommandArgsReader.ArgType> { + public class ArgList implements Iterable<CommandArgsReader.ArgType> { private final List<ArgType> alist; private int filenameCount;

1 0

make pot to areas searcheable
by maning sambale 20 Jun '09

20 Jun '09

--add-pois-to-areas switch gives names to areas but not searcheable. Can a workaround like the --road-name-pois incorporated here to search areas? -- cheers, maning ------------------------------------------------------ "Freedom is still the most radical idea of all" -N.Branden wiki: http://esambale.wikispaces.com/ blog: http://epsg4253.wordpress.com/ ------------------------------------------------------

1 0

improving city search
by maning sambale 20 Jun '09

20 Jun '09

Currently the city search gives an output like this: Manila, PHI (City,Country) In the Philippines, city search should be City, Province, Country How should we improve the data to incorporate the Province? We already have polygon/relation for Provincial boundaries. I think that's my last report for now. Thank you to all the devs! -- cheers, maning ------------------------------------------------------ "Freedom is still the most radical idea of all" -N.Branden wiki: http://esambale.wikispaces.com/ blog: http://epsg4253.wordpress.com/ ------------------------------------------------------

1 0

some behavior of --road-name-pois
by maning sambale 20 Jun '09

20 Jun '09

I am assuming the --road-name-pois uses the nearest place tag, generally the street/place hits the mark. But in some cases, it gives a wrong place label especially when the street is equidistant to two places label. -- cheers, maning ------------------------------------------------------ "Freedom is still the most radical idea of all" -N.Branden wiki: http://esambale.wikispaces.com/ blog: http://epsg4253.wordpress.com/ ------------------------------------------------------

1 0

Re: [mkgmap-dev] creating a fool-proof mapsource installer across different versions
by Marco Certelli 19 Jun '09

19 Jun '09

Well, try before enjoing. Actually I take a slighly different approach to mapsoruce install. I use mkgmap with something like: --overview-mapname=40000000 --mapname=40000001 and then in the registry ... "BMAP"="C:\\OSM\\40000000.img" "TDB"="C:\\OSM\\40000000.tdb" ... Try it also. Have a nice day, Marco. --- Mer 27/5/09, maning sambale <emmanuel.sambale(a)gmail.com> ha scritto: > Da: maning sambale <emmanuel.sambale(a)gmail.com> > Oggetto: Re: [mkgmap-dev] creating a fool-proof mapsource installer across different versions > A: "Development list for mkgmap" <mkgmap-dev(a)lists.mkgmap.org.uk> > Data: Mercoledì 27 maggio 2009, 10:28 > Marko, > > You made my day! Will test this tonight. Thanks > thanks! > > On Wed, May 27, 2009 at 3:57 PM, Marco Certelli <marco_certelli(a)yahoo.it> > wrote: > > > > No, just keep the --family-id=639 and eliminate only > the --product-id=xxx (elmiminating the product-id, the > default is 1) > > > > Then the .reg would be: > > > > REGEDIT4 > > > > > [HKEY_LOCAL_MACHINE\SOFTWARE\Garmin\MapSource\Families\OSM_PHIL] > > "ID"=hex:7f,02 > > > > > [HKEY_LOCAL_MACHINE\SOFTWARE\Garmin\MapSource\Families\OSM_PHIL\1] > > "LOC"="C:\\OSM\\" > > "BMAP"="C:\\OSM\\40000001.img" > > "TDB"="C:\\OSM\\40000001.tdb" > > > > Should work. > > > > If you want to add a personal typ file, you must put > the family-id,product-id in the typ file (for you, it would > be 639,1). see http://ati.land.cz/gps/typdecomp/editor.cgi > > > > Remember you cannot contemporary have 2 maps installed > with the same family-id or product-id. > > > > Ciao. > > > > > > --- Mer 27/5/09, maning sambale <emmanuel.sambale(a)gmail.com> > ha scritto: > > > >> Da: maning sambale <emmanuel.sambale(a)gmail.com> > >> Oggetto: Re: [mkgmap-dev] creating a fool-proof > mapsource installer across different versions > >> A: "Development list for mkgmap" <mkgmap-dev(a)lists.mkgmap.org.uk> > >> Data: Mercoledì 27 maggio 2009, 05:21 > >> So it should be: > >> mkgmap syntax: > >> java -Xmx512m -jar dist/mkgmap.jar > >> --code-page=1252 --tdbfile \ > >> --gmapsupp --latin1 --country-abbr=PHI > >> --country-name=PHILIPPINES \ > >> --road-name-pois --add-pois-to-areas > >> --no-poi-address --family-name="OSM_PHIL" > >> --overview-mapname=40000001 \ > >> --route --description="OSM_PHILIPPINES" > >> /path/to/your/osm/file/philippines.osm > >> > >> omitting family-id and product-id > >> > >> registry key should be: > >> REGEDIT4 > >> > >> > [HKEY_LOCAL_MACHINE\SOFTWARE\Garmin\MapSource\Families\40000001] > >> "ID"=hex:7f,02 > >> > >> > [HKEY_LOCAL_MACHINE\SOFTWARE\Garmin\MapSource\Families\OSM_PHIL] > >> > [HKEY_LOCAL_MACHINE\SOFTWARE\Garmin\MapSource\Families\OSM_PHIL\1] > >> "LOC"="C:\\OSM\\" > >> "BMAP"="C:\\OSM\\40000001.img" > >> "TDB"="C:\\OSM\\40000001.tdb" > >> > >> I'm a bit perplexed with the > >> > [HKEY_LOCAL_MACHINE\SOFTWARE\Garmin\MapSource\Families\40000001] > >> "ID"=hex:7f,02 > >> > >> > >> > >> On Tue, May 26, 2009 at 9:36 PM, Marco Certelli > <marco_certelli(a)yahoo.it> > >> wrote: > >> > > >> > It might be: > >> > > >> > --family-name="OSM_PHIL" > >> > > >> > then > >> > > >> > > >> > [HKEY_LOCAL_MACHINE\SOFTWARE\Garmin\MapSource\Families\OSM_PHIL] > >> > > >> > [HKEY_LOCAL_MACHINE\SOFTWARE\Garmin\MapSource\Families\OSM_PHIL\1] > >> > > >> > Ciao. > >> > > >> > > >> > --- Mar 26/5/09, Lambertus <osm(a)na1400.info> > >> ha scritto: > >> > > >> >> Da: Lambertus <osm(a)na1400.info> > >> >> Oggetto: Re: [mkgmap-dev] creating a > fool-proof > >> mapsource installer across different versions > >> >> A: "Development list for mkgmap" <mkgmap-dev(a)lists.mkgmap.org.uk> > >> >> Data: Martedì 26 maggio 2009, 15:25 > >> >> Strange, I have about 200 people > >> >> downloading maps per day. Most of them > will use > >> the > >> >> MapSource installer which uses the > product-id to > >> register > >> >> the map and I never receive complaints > about > >> MapSource > >> >> crashes. > >> >> > >> >> Apollinaris Schoell wrote: > >> >> > Don't use --product-id > >> >> > this let's Mapsource crash most of > the time > >> or you > >> >> can't even start a map after install > >> >> > > >> >> > > >> >> > On 26 May 2009, at 14:05 , maning > sambale > >> wrote: > >> >> > > >> >> >> Hi, > >> >> >> > >> >> >> Somewhat off-topic with mkgmap > but > >> closely > >> >> related, I have been > >> >> >> receiving numerous reports of > mapsource > >> install > >> >> error of my OSM-PH > >> >> >> garmin maps > >> >> >> I create mapsource installer > using > >> winrar's sfx > >> >> version, for details: > >> >> >> http://epsg4253.wordpress.com/2009/04/13/diy-garmin-routable-map-from-opens… > >> >> > >> >> >> > >> >> >> My mapsource version 6.11 and > it > >> installs > >> >> OK. Problems persist on > >> >> >> other versions like 6.13 and > mostly > >> 6.15.6. > >> >> >> > >> >> >> Any advice in creating > fool-proof install > >> for > >> >> MapSource? > >> >> >> > >> >> >> > >> >> >> My registry key is like this: > >> >> >> REGEDIT4 > >> >> >> > >> >> > >> > [HKEY_LOCAL_MACHINE\SOFTWARE\Garmin\MapSource\Families\40000001] > >> >> >> "ID"=hex:7f,02 > >> >> >> > >> >> > >> > [HKEY_LOCAL_MACHINE\SOFTWARE\Garmin\MapSource\Families\40000001\678] > >> >> >> "LOC"="C:\\OSM\\" > >> >> >> "BMAP"="C:\\OSM\\40000001.img" > >> >> >> "TDB"="C:\\OSM\\40000001.tdb" > >> >> >> > >> >> >> mkgmap syntax: > >> >> >> java -Xmx512m -jar > dist/mkgmap.jar > >> >> --code-page=1252 --tdbfile \ > >> >> >> --gmapsupp --latin1 > --country-abbr=PHI > >> >> --country-name=PHILIPPINES \ > >> >> >> --road-name-pois > --add-pois-to-areas > >> >> --no-poi-address --family-id=639 \ > >> >> >> --family-name="OSM_PHIL" > >> --product-id=678 > >> >> --overview-mapname=40000001 \ > >> >> >> --route > --description="OSM_PHILIPPINES" > >> >> /path/to/your/osm/file/philippines.osm > >> >> >> - > >> >> >> - > >> >> >> cheers, > >> >> >> maning > >> >> >> > >> >> > >> > ------------------------------------------------------ > >> >> >> "Freedom is still the most > radical idea > >> of all" > >> >> -N.Branden > >> >> >> wiki: http://esambale.wikispaces.com/ > >> >> >> blog: http://epsg4253.wordpress.com/ > >> >> >> > >> >> > >> > ------------------------------------------------------ > >> >> >> > >> _______________________________________________ > >> >> >> mkgmap-dev mailing list > >> >> >> mkgmap-dev(a)lists.mkgmap.org.uk > >> >> >> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > >> >> > > >> >> > > >> _______________________________________________ > >> >> > mkgmap-dev mailing list > >> >> > mkgmap-dev(a)lists.mkgmap.org.uk > >> >> > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > >> >> > >> >> > _______________________________________________ > >> >> mkgmap-dev mailing list > >> >> mkgmap-dev(a)lists.mkgmap.org.uk > >> >> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > >> >> > >> > > >> > > >> > > >> > > _______________________________________________ > >> > mkgmap-dev mailing list > >> > mkgmap-dev(a)lists.mkgmap.org.uk > >> > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > >> > > >> > >> > >> > >> -- > >> cheers, > >> maning > >> > ------------------------------------------------------ > >> "Freedom is still the most radical idea of all" > -N.Branden > >> wiki: http://esambale.wikispaces.com/ > >> blog: http://epsg4253.wordpress.com/ > >> > ------------------------------------------------------ > >> _______________________________________________ > >> mkgmap-dev mailing list > >> mkgmap-dev(a)lists.mkgmap.org.uk > >> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > >> > > > > > > > > _______________________________________________ > > mkgmap-dev mailing list > > mkgmap-dev(a)lists.mkgmap.org.uk > > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev > > > > > > -- > cheers, > maning > ------------------------------------------------------ > "Freedom is still the most radical idea of all" -N.Branden > wiki: http://esambale.wikispaces.com/ > blog: http://epsg4253.wordpress.com/ > ------------------------------------------------------ > _______________________________________________ > mkgmap-dev mailing list > mkgmap-dev(a)lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev >

3 2

Commit: r1067: Disable line cleaning filters for overview map
by svn commit 17 Jun '09

17 Jun '09

Version 1067 was commited by elrond on 2009-06-17 20:56:33 +0100 (Wed, 17 Jun 2009) Disable line cleaning filters for overview map Our current overview map contains one polygon for each map, that is part of the map set. This polygon is a rectangle, which is explicitly generated from the boundaries of the corresponding map. Sometimes, for very small maps, the polygon can get dropped by the SizeFilter or get distorted by the DouglasPeuckerFilter. So we disable those cleaning filters for the overview map for now. Notes: 1) The distortion by the DouglasPeuckerFilter might be a bug in that filter. Current discussion topic. 2) To be future safe, we should replace this global disabling by a per polygon disabling. As discussed on the ML. See: http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2009q2/002385.html

1 0

Commit: r1066: Minor bug fix - remove extra decrement of loop variable.
by svn commit 17 Jun '09

17 Jun '09

Version 1066 was commited by markb on 2009-06-17 20:43:05 +0100 (Wed, 17 Jun 2009) Minor bug fix - remove extra decrement of loop variable. The extra decrement provided a small speed optimisation but it could also lead to a CoordNode being discarded erroneously. Also, removed a comment that isn't true (although a similar comment elsewhere in this file is true).

1 0

Re: [mkgmap-dev] Overview map: tiny patch/review series
by Marco Certelli 17 Jun '09

17 Jun '09

--- Mar 16/6/09, Mark Burton <markb(a)ordern.com> ha scritto: > Da: Mark Burton <markb(a)ordern.com> > Oggetto: Re: [mkgmap-dev] Overview map: tiny patch/review series > A: mkgmap-dev(a)lists.mkgmap.org.uk > Data: Martedì 16 giugno 2009, 18:19 > > Hi Thilo, > > > > At the distances we're (mostly) interested in, > the curvature of the > > > earth's surface has a tiny effect (much less than > the effect of > > > hills & > > > valleys) so I guess (hope) that leaving out that > factor is OK. > > > > The curvature may have a tiny effect, but nonetheless > you should > > consider the coordinate system you are using. > Interpreting lat and lon > > as cartesian coordinates (don't know whether you are > really doing > > that) will give large errors at high latitudes. > > I have to admit that I'm not much of a mathematician so I > am quite > happy to take advice as to the soundness of the current > algorithm. I > did test it against what we were using before and for the > latitudes I > was using, it appeared to work OK. > > > > I know that this isn't your code but it's as good > a place as any > > > to comment about it: looking at the DP code (for > the first time), I > > > immediately see that the loop that finds the max > distance is > > > (potentially) doing many more sqrts and divisions > than it needs to. So > > > even if the code is correct, it could be somewhat > faster which would > > > be > > > worthwhile given that it gets called for every > line. Eg, it could be > > > changed to look like this: > > > > > > // Find > point with highest distance. > > > // Loop > runs downwards, as the list length gets modified while > > > > running > > > for(int i = > endIndex-1; i > startIndex; i--) { > > > > Coord p = points.get(i); > > > > double ap = p.distance(a); > > > > double bp = p.distance(b); > > > > double abpa = (ab+ap+bp)/2; > > > > double dd = abpa * (abpa-ab) * (abpa-ap) > * (abpa-bp); > > > > if (dd > maxDistance) { > > > > maxDistance = dd; > > > > maxIndex = i; > > > > } > > > } > > > maxDistance > = 2 * Math.sqrt(maxDistance) / ab; > > > > > > Also - you get a division by zero if ab is 0, > perhaps adding a test > > > for that before the loop would be advisable. > > > > Do you understand that formula for the distance > calculation? If so > > could you explain it for me? I don't get it. > > Sorry, no. > Just speculation: I've a and b that defines a line. I look for the distance between a point p and the line. Given the triangle p-a-b where p is the vertex and a-b is the "base", the area of the triangle can be calculated from the lenght of its 3 sides (pa, pb, ab). After that, since the area is also base x height / 2 we can calculate the height = area / base * 2 well, the height is exactly the distance of the point p from the line a-b Maybe... > > > > > Another minor nit - the comment is inaccurate as > the list length > > > doesn't change in this loop. > > > > It is accurate, because the list length does get > changed by the way > > the recursion works. It is not obvious, therefore this > comment is > > really needed! > > The loop I mention does not contain any recursion. The loop > in > doFilter() does (it is adorned with a similar comment). > > > Another question, just out of curiosity: Does it > really mattern in > > Java how many sqrts or sin or cos I do? Doesn't that > kind of > > difference get swamped by all that interpretation and > memory > > allocation things etc. going on? With modern FPUs that > kind of > > operation isn't that expensive (if it is done > native). > > You're quite possibly right but some maths ops are > hideously slow (i.e. > acos which is used in the original distance() method). In > the example > above, I would argue that taking the sqrt and division > outside of the > loop doesn't make the code harder to understand and may > yield some > speedup. > > > I would start working on the DP code if it makes > sense. If somebody > > understands that distance formula and could explain it > it would be > > very much appreciated. Otherwise I will have to make > up my own formula > > (sigh...) > > Well, I think Johann wrote the code so maybe he will > enlighten you! > > Cheers, > > Mark > _______________________________________________ > mkgmap-dev mailing list > mkgmap-dev(a)lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev >

4 3