February 2009 - mkgmap-dev - The mkgmap lists

[PATCH] reverse dead-end ways (to avoid routing problem?)
by Mark Burton 14 Feb '09

14 Feb '09

Perhaps, the attached patch would help the problem of routing to the wrong end of the dead-end way?

3 6

Commit: r882: Output changed slightly due to previous fix.
by svn commit 14 Feb '09

14 Feb '09

Version 882 was commited by steve on 2009-02-14 13:44:57 +0000 (Sat, 14 Feb 2009) Output changed slightly due to previous fix. Test given correct number.

1 0

[PATCH] looped way patch for nod branch
by Bernhard Heibler 14 Feb '09

14 Feb '09

Hi, it looks like the looped way check doesn't find all self intersection ways. It just checks if some waypoint is the same like the last way point. It misses loops somewhere in the middle of the way. This results in route calculation hangups on the nuvi. Here comes a patch for the nod branch that fixes the problem. The new function should also work with multiple loops in a way. The check for the two point loops needs a closer look. For now we only check if there are more then 2 points in the way. I have tried a alternate way by checking the distance between the intersection points to be greater the 1 (j-pIdx>1). This will produce some more loop warnings. In one case I was not able to see the reason for the warning so I commented the alternate check out for now. Berni. Index: src/uk/me/parabola/mkgmap/osmstyle/StyledConverter.java =================================================================== --- src/uk/me/parabola/mkgmap/osmstyle/StyledConverter.java (revision 881) +++ src/uk/me/parabola/mkgmap/osmstyle/StyledConverter.java (working copy) @@ -261,36 +261,42 @@ } } - boolean looped = false; - List<Coord> wayPoints = way.getPoints(); - int numPointsInWay = wayPoints.size(); + int numPointsInWay; + int pIdx; + boolean tinyLoop = false; - if(numPointsInWay > 1) { - // check if the last point in the way is the same as - // any other point in the way - if it is, there's a loop - Coord wayEndCoord = wayPoints.get(numPointsInWay - 1); - for(int i = 0; !looped && i < numPointsInWay - 1; ++i) { - if(wayPoints.get(i) == wayEndCoord) - looped = true; + do + { + List<Coord> wayPoints = way.getPoints(); + numPointsInWay = wayPoints.size(); + boolean looped = false; + + // check if the way contains a loop or self intersection + for(pIdx = 0; !looped && pIdx < (numPointsInWay - 1); pIdx++) { + for(int j = pIdx+1; !looped && j < numPointsInWay; j++) { + if(wayPoints.get(pIdx) == wayPoints.get(j)) + { + if(numPointsInWay > 2) // (j-pIdx > 1) will find more ugly stuff + { + Way loopTail = splitWayAt(way, pIdx + 1); + addRoadWithoutLoops(way, gt); + way = loopTail; // the rest + looped = true; + } + else + { + System.err.println("Ignoring looped way with only 2 points located at " + wayPoints.get(0).toDegreeString()); + looped = true; + tinyLoop = true; + } + } + } } - } - - if(looped) { - if(numPointsInWay > 2) { - // create a new way to replace the last segment - Way loopTail = splitWayAt(way, numPointsInWay - 2); - // make roads from the un-looped ways - addRoadWithoutLoops(way, gt); - addRoadWithoutLoops(loopTail, gt); - } - else { - System.err.println("Ignoring looped way with only 2 points located at " + wayPoints.get(0).toDegreeString()); - } - } - else { - // make a road from the way (it wasn't looped) + } while(pIdx < numPointsInWay -1 && !tinyLoop); // until we are at the end of the way + + if(!tinyLoop) addRoadWithoutLoops(way, gt); - } + } void addRoadWithoutLoops(Way way, GType gt) {

2 3

Multiple bounds entries in osm file
by Johann Gail 14 Feb '09

14 Feb '09

Hi, while playing with the mkgmap-nod branch, I've found a small unexpected error. When I download multiple segments with the josm editor and save them in a single osm file then the file contains multiple 'bound' tags. When I process this file with mkgmap then only the last bound entry is considered. Wouldn't it be more reasonable that all bounds entries are considered? Or is there a reason, that the generated img has to be of rectangular outline?

2 2

Commit: r881: Add option to frig roundabouts.
by svn commit 13 Feb '09

13 Feb '09

Version 881 was commited by robert on 2009-02-13 20:00:00 +0000 (Fri, 13 Feb 2009) Add option to frig roundabouts. Add option to "frig" roundabouts by adding an extra point between each pair of adjacent nodes. The extra points are positioned "outside" of the line joining the two nodes. The effect is to make roundabouts "rounder". Unfortunately, it also makes them ugly as the frigging is being done by a dumb computer with little aesthetic capability. It is not enabled by default, you need to specify the --frig-roundabouts option. By default the "frig factor" (influences how far the new points are away from the centre of the roundabout) is set to 0.25. You can specify a different value as the option value: --frig-roundabouts=0.1 Large values tend to make the roundabout uglier so it would be worth experimenting to see what the minimum frig factor is that will stop the gps from reporting the wrong exit. You can also enable frigging for an individual roundabout by tagging the OSM XML with the "mkgmap:frig_roundabout" tag which can either be set to a valid (floating point) number to specify the frig factor or just some other string that will make it use the default frig factor. This patch also avoids putting in new points if the new point would be less than 5 or more than 100 metres from the adjacent points. - Mark Burton

1 0

[PATCH] improve handling of access restrictions in osm routing
by Mark Burton 13 Feb '09

13 Feb '09

Hi, The attached patch improves the handling of access restriction tags so that you can now restrict on a vehicle class basis i.e. hgv=no Not all of the OSM tags are supported as the Garmin doesn't seem to recognise the existence of horses or motorcycles or taxis. This should apply to the current nod SVN trunk. The earlier patch to frig roundabouts is also to the same file but they should not conflict. Feedback, etc. Cheers, Mark

5 11

Commit: r880: Normalize deltas in LinePreparer.
by svn commit 13 Feb '09

13 Feb '09

Version 880 was commited by robert on 2009-02-13 17:53:23 +0000 (Fri, 13 Feb 2009) Normalize deltas in LinePreparer.

1 0

Commit: r879: Improved support for access restrictions (Mark Burton)
by svn commit 13 Feb '09

13 Feb '09

Version 879 was commited by robert on 2009-02-13 17:47:19 +0000 (Fri, 13 Feb 2009) Improved support for access restrictions (Mark Burton)

1 0

some reports on the recent svn-nod mkgmap
by maning sambale 13 Feb '09

13 Feb '09

Hi, I've recently used the the nod branch using the native OSM file as input, and here are some comments on my brief use: tested on my garmin etrex legend cx and mapsource 1. routing is fine for short routes of a 100KM but not so for very long routes about 1200KM (yeah maybe too much). Mapsource reports an error "Error Code:3" and my etrex just hangs to 99% when calculating the route. I also have another map from another source and Mapsource doesn't reports error code:3 2. roads and cities are now searchable! But islands names are not. (My previous using osm2mp can search islands) 3. ferry routes are not routing I also added contours and the looks are excellent! However, when panning and zooming for long periods on my etrex, the whole map just disappear. Is this a a problem with unit and not the data? Hope this helps the dev team. -- cheers, maning ------------------------------------------------------ "Freedom is still the most radical idea of all" -N.Branden wiki: http://esambale.wikispaces.com/ blog: http://epsg4253.wordpress.com/ ------------------------------------------------------

3 8

Re: [mkgmap-dev] Commit: r868: Implement routing for .osm input files
by stefan＠binaervarianz.de 13 Feb '09

13 Feb '09

Sorry for the quick post some minutes ago. I had to leave for work and was in a hurry. The downloaded OSM data seams big enough to contain the region I asked for with all ways and stuff. mkgmap doesn't display any error messages regarding the files size. I compiled a map about 70% of this size some days ago (with the snapshot version), which came out as just one file after usage of splitter. So I though this map wouldn't need to be chopped in pieces either. Maybe I was wrong? As posted before, if I try to use splitter on the osm file now, it produces an error. I'm running this on a Mac (privious test were on a Win-PC), but that should make any differences, right? I can upload the .osm file to anyone who likes to test it. Even if it is corrupt, maybe someone can find a way to detect this and make mkgmap output a meaningfull error message? (please allow 8-9h until I return from work) If you say my command lines were right, I don't know what else to do other then to download the OSM data again. ----- Ende der weitergeleiteten Nachricht -----

2 1