Commit: r759: Hack MapSplitter/MapArea to not put at most 0x100 lines in a div.
Version 759 was commited by robert on 2008-12-02 22:39:22 +0000 (Tue, 02 Dec 2008) Hack MapSplitter/MapArea to not put at most 0x100 lines in a div. It appears to work as intended, but could use review.
On Dec 2, 2008, at 23:39, svn commit wrote:
Hack MapSplitter/MapArea to not put at most 0x100 lines in a div.
It now compiles my big test map successfully, and routing "sort of" works. (I.e., it tries to route, but not really always along roads; there's obviously some bugs left.) Interestingly, I now reliably get the road name popups. Perhaps that's to do with cutting down the area sizes? Cheers Robert
You speak about the Nod branch, don't you? That's the only branch were for me the tooltip shows on the right place when using --net option. However if you watch carefully it's not perfect yet. At those places where before (or with trunk branch), it showed right it continues to show right. However were it was wrong, it is now in the right place but the little black dot locking to the object is not shown. Maybe that explains why routing is not allways alongside a rode! (or maybe give you an indication on which places it works and on which it doesn't work). Felix Robert Vollmert wrote: On Dec 2, 2008, at 23:39, svn commit wrote:
Hack MapSplitter/MapArea to not put at most 0x100 lines in a div.
It now compiles my big test map successfully, and routing "sort of" works. (I.e., it tries to route, but not really always along roads; there's obviously some bugs left.) Interestingly, I now reliably get the road name popups. Perhaps that's to do with cutting down the area sizes? Cheers Robert _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ________________________________ Diese Nachricht erhalten Sie von einem Studierenden der IMC Fachhochschule Krems. Für Übermittlungsfehler oder sonstige Irrtümer bei Übermittlung besteht keine Haftung seitens der IMC Fachhochschule Krems. This message is being transmitted by an IMC student. The sender does not accept liability for any errors or omissions as a result of the transmission.
Sorry my wrong, tooltip is now allways on right place including the little black snapbox. f.hartmann wrote: You speak about the Nod branch, don't you? That's the only branch were for me the tooltip shows on the right place when using --net option. However if you watch carefully it's not perfect yet. At those places where before (or with trunk branch), it showed right it continues to show right. However were it was wrong, it is now in the right place but the little black dot locking to the object is not shown. Maybe that explains why routing is not allways alongside a rode! (or maybe give you an indication on which places it works and on which it doesn't work). Felix Robert Vollmert wrote: On Dec 2, 2008, at 23:39, svn commit wrote:
Hack MapSplitter/MapArea to not put at most 0x100 lines in a div.
It now compiles my big test map successfully, and routing "sort of" works. (I.e., it tries to route, but not really always along roads; there's obviously some bugs left.) Interestingly, I now reliably get the road name popups. Perhaps that's to do with cutting down the area sizes? Cheers Robert _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ________________________________ Diese Nachricht erhalten Sie von einem Studierenden der IMC Fachhochschule Krems. Für Übermittlungsfehler oder sonstige Irrtümer bei Übermittlung besteht keine Haftung seitens der IMC Fachhochschule Krems. This message is being transmitted by an IMC student. The sender does not accept liability for any errors or omissions as a result of the transmission. ________________________________ Diese Nachricht erhalten Sie von einem Studierenden der IMC Fachhochschule Krems. Für Übermittlungsfehler oder sonstige Irrtümer bei Übermittlung besteht keine Haftung seitens der IMC Fachhochschule Krems. This message is being transmitted by an IMC student. The sender does not accept liability for any errors or omissions as a result of the transmission.
Steve, On Dec 2, 2008, at 23:39, svn commit wrote:
Version 759 was commited by robert on 2008-12-02 22:39:22 +0000 (Tue, 02 Dec 2008)
Hack MapSplitter/MapArea to not put at most 0x100 lines in a div.
It appears to work as intended, but could use review.
there's an assert in RoadIndex.write asserting that the associated polyline is among the 256 first polylines in a subdivision (so its index fits in a byte). I was running into this, and thought I'd fixed it by the above change, but sletuffe ran into the error (see below). I'm not really familiar with the MapBuilder/MapSplitter/trergn stuff, so could you perhaps have a look at this on occasion? Cheers Robert Here's the bug report, copied from wiki. unexpected crash, looks like the above I ran this : java -jar osmosis.jar --read-xml france.osm --bounding-box left=4.92 right=6.92 top=46.57 bottom=44.57 --write-xml test-2x2.osm perl osm2mp.pl test-2x2.osm > test-2x2.mp java -enableassertions -Xmx1512M - jar ./mkgmap-nod/mkgmap.jar --route --gmapsupp test-2x2.mp And mkgmap fails with : Exception in thread "main" java.lang.AssertionError at uk.me.parabola.imgfmt.app.net.RoadIndex.write(RoadIndex.java:45) at uk.me.parabola.imgfmt.app.net.RoadDef.writeLevelDivs(RoadDef.java:158) at uk.me.parabola.imgfmt.app.net.RoadDef.writeNet1(RoadDef.java:114) at uk.me.parabola.imgfmt.app.net.NETFile.write(NETFile.java:61) at uk.me.parabola.mkgmap.build.MapBuilder.makeMap(MapBuilder.java:119) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:76) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:45) at uk.me.parabola.mkgmap.main.Main.processFilename(Main.java:148) at uk.me.parabola.mkgmap.CommandArgs$Filename.processArg(CommandArgs.java: 355) at uk.me.parabola.mkgmap.CommandArgs.readArgs(CommandArgs.java: 114) at uk.me.parabola.mkgmap.main.Main.main(Main.java:90) I'm using the last svn version of... now the test mp file is located here (My sand box is here with files) I have no problem with the same center and a 1°x1° square, so something looks wrong somewhere around Sletuffe 20:12, 8 December 2008 (UTC) http://beta.letuffe.org/garmin/test-2x2.mp http://beta.letuffe.org/garmin/
The case where n is exactly equal to 256 isn't covered if I'm seeing it right. But I'd also reduce the MAX_NUM_LINE by a couple too, I've not seen any cases where it is higher than 254. ..Steve
participants (4)
-
f.hartmann -
Robert Vollmert -
Steve Ratcliffe -
svn commit