r 2839 in high-prec-coord branch
Hi all, it took a while to analyse many special cases, but today I've committed r2839. Compared to trunk you should see: - better routing results because bearing values are calculated using the high precision values of coordinates. - fewer optical errors caused by rounding, e.g. ugly roundabouts or havy zig-zagging lines in the img when OSM data shows an almost straight line - smaller img file size because many obsolete points are removed - slightly higher peak memory usage, else not much difference in throughput Wrong angles are corrected by either moving the displayed points a little bit or by removing them. In some cases, points are merged as in the old short-arc-removal process, but with improvements: - if a way has only two points, the algo tries to keep that way in favor to a wrong angle in the img (else routing would be changed in favor to optic) - very close exit points on a roundabout are kept if possible (to avoid wrong "leave roundabout at" messages Up to now the changes are calculated for routable ways. In a second step, non-routable ways (not shapes) sharing modified points are modified as well. This is useful for those users who create styles for biking. The code needs a bit of review, but I think the result is very good now. Next on my todo list: 1) Change the implementation of the --link-pois-to-ways feature. Current implementation is too complex. Maybe it doesn't work at all now. @WanMil: Or do you already work on it? 2) Implement the merge-shape feature. Gerd
Next on my todo list: 1) Change the implementation of the --link-pois-to-ways feature. Current implementation is too complex. Maybe it doesn't work at all now. @WanMil: Or do you already work on it?
Not really. At the moment I am making the last fine tuning on the mergeroads branch. I know the --link-pois-to-ways feature is broken on the mergeroads branch but up to now I didn't have a look on it. I would be happy if you can help! Maybe we could also merge both branches and use that to reimplement the --link-pois-to-ways? What do you think?
2) Implement the merge-shape feature. Hooo. You are really crazy! :-) I am curious if you find a performant solution.
WanMil wrote
Not really. At the moment I am making the last fine tuning on the mergeroads branch. I know the --link-pois-to-ways feature is broken on the mergeroads branch but up to now I didn't have a look on it. I would be happy if you can help! Maybe we could also merge both branches and use that to reimplement the --link-pois-to-ways? What do you think?
I think the solution doesn't depend on high-prec-coords, so maybe I can create the patch for the mergeroads branch as well. Gerd -- View this message in context: http://gis.19327.n5.nabble.com/r-2839-in-high-prec-coord-branch-tp5787771p57... Sent from the Mkgmap Development mailing list archive at Nabble.com.
WanMil wrote
Not really. At the moment I am making the last fine tuning on the mergeroads branch. I know the --link-pois-to-ways feature is broken on the mergeroads branch but up to now I didn't have a look on it. I would be happy if you can help! Maybe we could also merge both branches and use that to reimplement the --link-pois-to-ways? What do you think?
I think the solution doesn't depend on high-prec-coords, so maybe I can create the patch for the mergeroads branch as well.
Gerd
That's great! I think you can also merge back to trunk the high-prec-coord branch if you wanto to. I just fear to get problems to merge your changes to the mergeroads branch. But if you keep an eye on it I am completely happy with that :-) You might also commit any changes directly to the mergeroads branch. WanMil
Hi WanMil, I found a rather simple fix for the high-prec-coords branch. I did not notice before how different the StyledConverter is now, so I will probably try to merge it with mergeroads next. Gerd
Date: Fri, 29 Nov 2013 21:35:15 +0100 From: wmgcnfg@web.de To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] r 2839 in high-prec-coord branch
WanMil wrote
Not really. At the moment I am making the last fine tuning on the mergeroads branch. I know the --link-pois-to-ways feature is broken on the mergeroads branch but up to now I didn't have a look on it. I would be happy if you can help! Maybe we could also merge both branches and use that to reimplement the --link-pois-to-ways? What do you think?
I think the solution doesn't depend on high-prec-coords, so maybe I can create the patch for the mergeroads branch as well.
Gerd
That's great! I think you can also merge back to trunk the high-prec-coord branch if you wanto to. I just fear to get problems to merge your changes to the mergeroads branch. But if you keep an eye on it I am completely happy with that :-)
You might also commit any changes directly to the mergeroads branch.
WanMil
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
participants (3)
-
Gerd Petermann -
GerdP
-
WanMil