[PATCH v2] Move maxspeed calculations to style file
The patch moves the road speed calculations based on the maxspeed tag to the style file. It uses the new maxspeedkmh function to calculate the new internal tag mkgmap:road-speed-class. This makes the ignore-maxspeeds option superfluous. Anyhow I have kept it to ignore the evaluation of the new tag mkgmap:road-speed-class. The second advantage is that maxspeed can be removed from the builtin-tag-list which meaans the maxspeed tag is not loaded if not referenced in the style file. WanMil
Hi WanMil
The patch moves the road speed calculations based on the maxspeed tag to the style file. It uses the new maxspeedkmh function to calculate the new internal tag mkgmap:road-speed-class.
Have only glanced at the code, but I heartily approve of removing as many hard-wired tags from StyledConverter as possible. Thanks! ..Steve
Just to confirm - this affects only the *max* speed, correct? So if my defaults for single-track unclassified roads suggest 40mph, but tags say we're allowed to do up to 60mph (both quite reasonable here in Scotland, where the National Speed Limit is unattainable on many roads), then the map won't try to take me down the narrow roads just because the allowed maximum is higher? Or will I need to reformulate my speed rules to avoid increasing speed class? (And, if so, does such a reformulation need to be in the default rules?) P.S. Please would you post patches in a text/* MIME-type (ideally text/x-patch)? application/x-download isn't really appropriate for diffs, as it doesn't imply any charset or line-end conversions, and is harder to display inline.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Toby, the patch shouldn't change that much. If you actually use - --ignore-maxspeed, then you havn't to change anything. If you actually don't use --ignore-maxspeed, then you'll need to add a rule like maxspeed=* { set mkgmap:maxspeed = maxspeedkmh() } If mkgmap:maxspeed-tag is found, then mkgmap will override your given road_speed. Maybe you could describe your situation a little bit more detailed. Then it would be more easy to tell you, what you'll have to change. Henning Am 30.08.2013 06:44, schrieb Toby Speight:
Just to confirm - this affects only the *max* speed, correct? So if my defaults for single-track unclassified roads suggest 40mph, but tags say we're allowed to do up to 60mph (both quite reasonable here in Scotland, where the National Speed Limit is unattainable on many roads), then the map won't try to take me down the narrow roads just because the allowed maximum is higher?
Or will I need to reformulate my speed rules to avoid increasing speed class? (And, if so, does such a reformulation need to be in the default rules?)
P.S. Please would you post patches in a text/* MIME-type (ideally text/x-patch)? application/x-download isn't really appropriate for diffs, as it doesn't imply any charset or line-end conversions, and is harder to display inline. _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (MingW32) iQEcBAEBAgAGBQJSIDT/AAoJEPFgsWC7jOeTrccH/R22lcmt/pPPVtbWzay9MhbB IYJGMqZ3plF3lo6RugKEO5UPUS5xW2OhDdCks7rSgt7gpAHUL4QUTg2WBmH1qaeY myAG3wHNzjZnvRMoQ/oKtFNdhoVqEzE1b6EG1db1vgnT6v6gA+a208cCN6WGlSNF Lnuo18r9GGV3LEu8ZvxE1Zf6wUlK8awqdiHmmS87yBpEop0X2zFiPZS2okxg04hu GvVes5uQSvTTkZul7Iuu/K26QMFsDANaFTDZjJHJusROC2ViXowyWGlXcfC2FvBf sZprSGg8FjXbDxv0vbZ9gpSWEeJZcWjPxY0bHRxSqfrlo6zhpCg+tSXZc593eHc= =FeVD -----END PGP SIGNATURE-----
0> In article <522034FF.6060405@aighes.de>, 0> Henning Scholland <URL:mailto:osm@aighes.de> ("Henning") wrote: Henning> the patch shouldn't change that much. If you actually Henning> use --ignore-maxspeed, then you havn't to change anything. If Henning> you actually don't use --ignore-maxspeed, then you'll need to Henning> add a rule like Henning> maxspeed=* { set mkgmap:maxspeed = maxspeedkmh() } No, I don't use --ignore-maxspeed. But the above looks quite different from your roadspeed style, where you set mkgmap:road-speed-class rather than mkgmap:maxspeed - is that wrong? Henning> If mkgmap:maxspeed-tag is found, then mkgmap will override your Henning> given road_speed. But only downwards, right? I never want maxspeed to increase the estimated actual speed. Henning> Maybe you could describe your situation a little bit more Henning> detailed. Then it would be more easy to tell you, what you'll Henning> have to change. My routing rules go something like this extract: /-------- | highway=primary & oneway=yes [0x03 road_class=3 road_speed=5 resolution 17] | highway=primary [0x03 road_class=3 road_speed=4 resolution 17] | highway=primary_link [0x0b road_class=3 road_speed=3 resolution 19] | highway=secondary & oneway=yes [0x04 road_class=2 road_speed=4 resolution 18] | highway=secondary [0x04 road_class=2 road_speed=3 resolution 18] | highway=secondary_link [0x04 road_class=2 road_speed=2 resolution 22] | highway=tertiary [0x05 road_class=1 road_speed=3 resolution 20] | highway=tertiary_link [0x05 road_class=1 road_speed=1 resolution 20] \-------- My region of interest is Scotland; speed limits are mapped over most of the west Highlands: <URL: http://www.itoworld.com/map/5?lon=-4.95077&lat=57.10531 > I don't want my 60mph-limit secondary roads to have their speeds increased to road_speed=6. But I do want 30mph-limit secondary roads to have their speeds reduced to road_speed=3. So I want you to confirm that the new maxspeed code will act only as a limit, not a target (as driving instructors love to say). I really want to avoid routing along minor roads in preference to slightly longer roads where the speed limit is the same: <URL: http://osrm.at/4Rl > A final thought: some ways have a maxspeed:practical=* tag; if maxspeedkmh() didn't hard-code which tag to read, we'd be able to use that in our style files, too.
only downwards, is what everyone expects, but not what mkgmap did so far. I critisized this quite often in the past.... Now you can make rules to actually only use maxspeed to decrease the road-speed.... The actual importance of maxspeed only downwards was in practice better then in theory, as (for the old way of doing luckily) stuff like highway=track, or highway=unclassified usually had no maxspeed tag at all. So the case of roadspeed=5 or 6 being set for a residential/track/unclassified was very rare. So "what you really want to avoid" is what was hapenning, now you can set it yourself... So the default should rather be: maxspeed=* & maxspeedkmh() > 110 & highway=motorway { set mkgmap:road-speed-class = 7 } maxspeed=* & mkgmap:road-speed-class!=* maxspeedkmh() > 80 & ( highway=motorway | highway=trunk ) { set mkgmap:road-speed-class = 6 } maxspeed=* & mkgmap:road-speed-class!=* maxspeedkmh() > 60 & ( highway=motorway | highway=trunk | highway=motorway_link | highway=trunk_link | highway=primary ) { set mkgmap:road-speed-class = 5 } maxspeed=* & mkgmap:road-speed-class!=* maxspeedkmh() > 40 & ( highway=motorway | highway=trunk | highway=motorway_link | highway=trunk_link | highway=primary | highway=primary_link | highway=secondary ) { set mkgmap:road-speed-class = 4 } ... maybe a special rule for maxspeed()>80 and tertiary.... .... and continue including highways lower down... ... Do the same for maxspeedmph() This way is actually much much better than the old way which was IMHO crap because it would also increase road-speed... (and meaning if you created a cyclemap, you always needed ignore-maxspeed command else primaries would be road-speed=5 very often, and far to high priority...). On 30.08.2013 09:45, Toby Speight wrote:
0> In article <522034FF.6060405@aighes.de>, 0> Henning Scholland <URL:mailto:osm@aighes.de> ("Henning") wrote:
Henning> the patch shouldn't change that much. If you actually Henning> use --ignore-maxspeed, then you havn't to change anything. If Henning> you actually don't use --ignore-maxspeed, then you'll need to Henning> add a rule like Henning> maxspeed=* { set mkgmap:maxspeed = maxspeedkmh() }
No, I don't use --ignore-maxspeed. But the above looks quite different from your roadspeed style, where you set mkgmap:road-speed-class rather than mkgmap:maxspeed - is that wrong?
Henning> If mkgmap:maxspeed-tag is found, then mkgmap will override your Henning> given road_speed.
But only downwards, right? I never want maxspeed to increase the estimated actual speed.
Henning> Maybe you could describe your situation a little bit more Henning> detailed. Then it would be more easy to tell you, what you'll Henning> have to change.
My routing rules go something like this extract:
/-------- | highway=primary & oneway=yes [0x03 road_class=3 road_speed=5 resolution 17] | highway=primary [0x03 road_class=3 road_speed=4 resolution 17] | highway=primary_link [0x0b road_class=3 road_speed=3 resolution 19] | highway=secondary & oneway=yes [0x04 road_class=2 road_speed=4 resolution 18] | highway=secondary [0x04 road_class=2 road_speed=3 resolution 18] | highway=secondary_link [0x04 road_class=2 road_speed=2 resolution 22] | highway=tertiary [0x05 road_class=1 road_speed=3 resolution 20] | highway=tertiary_link [0x05 road_class=1 road_speed=1 resolution 20] \--------
My region of interest is Scotland; speed limits are mapped over most of the west Highlands:
<URL: http://www.itoworld.com/map/5?lon=-4.95077&lat=57.10531 >
I don't want my 60mph-limit secondary roads to have their speeds increased to road_speed=6. But I do want 30mph-limit secondary roads to have their speeds reduced to road_speed=3. So I want you to confirm that the new maxspeed code will act only as a limit, not a target (as driving instructors love to say).
I really want to avoid routing along minor roads in preference to slightly longer roads where the speed limit is the same:
<URL: http://osrm.at/4Rl >
A final thought: some ways have a maxspeed:practical=* tag; if maxspeedkmh() didn't hard-code which tag to read, we'd be able to use that in our style files, too. _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- keep on biking and discovering new trails Felix openmtbmap.org & www.velomap.org
0> In article <522050A9.5010304@gmail.com>, 0> Felix Hartmann <URL:mailto:extremecarver@gmail.com> ("Felix") wrote: Felix> only downwards, is what everyone expects, but not what mkgmap did Felix> so far. I critisized this quite often in the past.... Thanks Felix - that's what I wanted to know. I obviously overlooked your previous complaints! The style rules you present do look quite unwieldy - perhaps it's possible to simplify by setting initial defaults, and using those to allow revising downwards: /-------- | highway=motorway { add mkgmap:road-speed-class = 7 } | highway=trunk { add mkgmap:road-speed-class = 6 } | ... | | maxspeed:practical=* { set maxspeed=${maxspeed:practical} } | | maxspeed=* & mkgmap:road-speed-class > 1 & maxspeedkmh() <= 5 | { set mkgmap:road-speed-class = 1 } | maxspeed=* & mkgmap:road-speed-class > 2 & maxspeedkmh() <= 20 | { set mkgmap:road-speed-class = 2 } | ... \-------- Is there any reason why that wouldn't work?
Felix> only downwards, is what everyone expects, but not what mkgmap did Felix> so far. I critisized this quite often in the past....
Thanks Felix - that's what I wanted to know. I obviously overlooked your previous complaints!
The style rules you present do look quite unwieldy - perhaps it's possible to simplify by setting initial defaults, and using those to allow revising downwards:
/-------- | highway=motorway { add mkgmap:road-speed-class = 7 } | highway=trunk { add mkgmap:road-speed-class = 6 } | ... | | maxspeed:practical=* { set maxspeed=${maxspeed:practical} } | | maxspeed=* & mkgmap:road-speed-class > 1 & maxspeedkmh() <= 5 | { set mkgmap:road-speed-class = 1 } | maxspeed=* & mkgmap:road-speed-class > 2 & maxspeedkmh() <= 20 | { set mkgmap:road-speed-class = 2 } | ... \--------
Is there any reason why that wouldn't work?
Should work. As I answered Felix I will come back later on to improve the default maxspeed rules. WanMil
"Manfred Brenneisen" <Manfred.Brenneisen@gmx.net> writes:
Thinking about maxspeed:practical, which can be used to initialize maxspeed in some cases, I thought about rural areas, which do not have any maxspeed, or maxspeed:practical information included in OSM data:
I think we do need tags for maximum speed that tends to be reasoable typical speed one can go
The new curviness() function (useful for ways).
Such a function could e.g. return the sum of direction change at every point, divided by the way's length.
This could give an estimation for the maximum practical speed.
This could be useful to drop the speed absent tags, but I would worry that it would be very sensitive to how well the road is represented. As a completely alternative approach, one could process tracks to obtain maxspeed:typical values for ways. A related concern is if some ways (the more commmonly-used ones) are tagged, then the untagged, even scarier roads will be preferred by routing.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Am 01.09.2013 23:29, schrieb Manfred Brenneisen:
You do a great job, and I really appreciate your work Thinking about maxspeed:practical, which can be used to initialize maxspeed in some cases, I thought about rural areas, which do not have any maxspeed, or maxspeed:practical information included in OSM data: The new curviness() function (useful for ways).
Do you mean the practical speed (maxspeed seems to be wrong in my opinion) in rush hour, rush hour in public holiday, offpeak, inbound or outbound... ;) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQEcBAEBAgAGBQJSJNasAAoJEPFgsWC7jOeTIuwH/jcersqE7VretthTPPUFddyP 7Uo5B0/bje48Pv7mGG/SJ7LmLDQvWoZMcDvvokt2sKnyDj+GJ0ant/3VXqfyfl91 3DcA0dRWHorlIM9G64n4ysq2zKcoXU6tLIrK7pxnQ9PBrdaOCxDE4Cf4Xd4MfNqD Tc7hRLwcJSPDXgV4sDV9t8Le2QVJfo0Ds2/eeKwqkAJ+ZGDASUB3kfzg/4BXgOqi /nJu9ppdHa5gZcYP/NM+1XfoEzbWS75Y8KyAF+uNLAbhQvsVjK+UtY/zcnDjoVDL Jwqpy9t7HnjDWQZx9bCwHot9ALH7G7kpdpwZ6Asx8YQuH7rCulQa3hwWtLwKWcw= =p+NG -----END PGP SIGNATURE-----
Hi, Am 01.09.2013 23:29, schrieb Manfred Brenneisen:
You do a great job, and I really appreciate your work Thinking about maxspeed:practical, which can be used to initialize maxspeed in some cases, I thought about rural areas, which do not have any maxspeed, or maxspeed:practical information included in OSM data: The new curviness() function (useful for ways).
Do you mean the practical speed (maxspeed seems to be wrong in my opinion) in rush hour, rush hour in public holiday, offpeak, inbound or outbound... ;) You are right, maxspeed:practical is only useful for one type of vehicle at a certain time, and weather condition. That is why it is not in common use, and not approved: http://wiki.openstreetmap.org/wiki/Key%3Amaxspeed%3Apractical But, today in mkgmap, you don't have a possibility to create your personal maxspeed:practical (or, better call it estimated_speed) from the physical shape of the road. That's why I think about such a function. maxspeed!=* & maxspeed:practical!=* & curviness()<0.3 { set estimated_speed=120 } ... maxspeed:practical!=* {set maxspeed=${estimated_speed} } ... (continue with maxspeed evaluation and way rules) You are even free to ignore maxspeed:practical, if you don't trust it or don't like it. The curviness() function itself would not compute a speed value, but a (virtual) numerical value which is made of the physical road shape. And, you are free to let other tags, like surface and width, decrease estimated_speed further.
Hi Manfred, thanks for your proposal. I think there are a lot of reasons why the new curviness() function might be a bad idea (it depends on how well a way is mapped; its value is unreliable due to the mapping to the garmin coordinates; etc.). Anyhow I think it's worthy to play a little bit with it :-) I will try to add a first implementation of this function so anybody can test it. If it does not get enough supporters we can throw it away later on. WanMil
Hi all, moving away from fixed built-in, to a flexible, configurable mkgmap can give a great progress to the quality of maps. You do a great job, and I really appreciate your work Thinking about maxspeed:practical, which can be used to initialize maxspeed in some cases, I thought about rural areas, which do not have any maxspeed, or maxspeed:practical information included in OSM data: The new curviness() function (useful for ways). Such a function could e.g. return the sum of direction change at every point, divided by the way's length. This could give an estimation for the maximum practical speed. /-------------------------------------------------------- | ... | maxspeed!=* & maxspeed:practical!=* & curviness()<0.3 {set maxspeed:practical=120} | maxspeed!=* & maxspeed:practical!=* & curviness()<0.5 {set maxspeed:practical=100} | maxspeed!=* & maxspeed:practical!=* & curviness()<0.8 {set maxspeed:practical=80} | ... | maxspeed:practical=* {set maxspeed=${maxspeed:practical} } | ... \------------------------------------------------------------ However, the values are only fictional values, and does not include a physical background. But anyway, it might help improve routing quality, especially in poor mapped areas It also could help to improve maps for motorbikers, who tend to prefer curvy roads. Could you imagine that such a function would make sense? Cheers Manfred *Gesendet:* Freitag, 30. August 2013 um 22:19 Uhr *Von:* WanMil <wmgcnfg@web.de> *An:* "Development list for mkgmap" <mkgmap-dev@lists.mkgmap.org.uk> *Betreff:* Re: [mkgmap-dev] [PATCH v2] Move maxspeed calculations to style file
Felix> only downwards, is what everyone expects, but not what mkgmap did Felix> so far. I critisized this quite often in the past....
Thanks Felix - that's what I wanted to know. I obviously overlooked your previous complaints!
The style rules you present do look quite unwieldy - perhaps it's possible to simplify by setting initial defaults, and using those to allow revising downwards:
/-------- | highway=motorway { add mkgmap:road-speed-class = 7 } | highway=trunk { add mkgmap:road-speed-class = 6 } | ... | | maxspeed:practical=* { set maxspeed=${maxspeed:practical} } | | maxspeed=* & mkgmap:road-speed-class > 1 & maxspeedkmh() <= 5 | { set mkgmap:road-speed-class = 1 } | maxspeed=* & mkgmap:road-speed-class > 2 & maxspeedkmh() <= 20 | { set mkgmap:road-speed-class = 2 } | ... \--------
Is there any reason why that wouldn't work?
Should work. As I answered Felix I will come back later on to improve the default maxspeed rules.
WanMil
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
So "what you really want to avoid" is what was hapenning, now you can set it yourself...
So the default should rather be: maxspeed=* & maxspeedkmh() > 110 & highway=motorway { set mkgmap:road-speed-class = 7 } maxspeed=* & mkgmap:road-speed-class!=* maxspeedkmh() > 80 & ( highway=motorway | highway=trunk ) { set mkgmap:road-speed-class = 6 } maxspeed=* & mkgmap:road-speed-class!=* maxspeedkmh() > 60 & ( highway=motorway | highway=trunk | highway=motorway_link | highway=trunk_link | highway=primary ) { set mkgmap:road-speed-class = 5 } maxspeed=* & mkgmap:road-speed-class!=* maxspeedkmh() > 40 & ( highway=motorway | highway=trunk | highway=motorway_link | highway=trunk_link | highway=primary | highway=primary_link | highway=secondary ) { set mkgmap:road-speed-class = 4 } ... maybe a special rule for maxspeed()>80 and tertiary.... .... and continue including highways lower down...
Ok, looks good to me. Anyhow I will not yet commit them to the branch. First I want to remove more code from the StyledConverter to reduce the usage of hardcoded tags. Maybe at a later stage of the branch I will come back to discuss resonable rules and then we can put them into the default style. Thanks! WanMil
Just to confirm - this affects only the *max* speed, correct? So if my defaults for single-track unclassified roads suggest 40mph, but tags say we're allowed to do up to 60mph (both quite reasonable here in Scotland, where the National Speed Limit is unattainable on many roads), then the map won't try to take me down the narrow roads just because the allowed maximum is higher?
Or will I need to reformulate my speed rules to avoid increasing speed class? (And, if so, does such a reformulation need to be in the default rules?)
Yes, I think other guys have explained. With the patch you can write your own speed rules. If don't consider maxspeed in your style the maxspeed tag is not taken into account. At the moment the default style uses an include file with the old hardcoded rules.
P.S. Please would you post patches in a text/* MIME-type (ideally text/x-patch)? application/x-download isn't really appropriate for diffs, as it doesn't imply any charset or line-end conversions, and is harder to display inline.
Mmh, my mailtool identifies the patches correctly. I think the webinterface changes the MIME-type (?). Anyhow I do not post any patches for this case any more because all changes are directly commited to the branch now.
couldn't the int_ref, nat_ref, exit:to and junction also be moved to the style-file? oneway seems to me the only thing, that cannot be moved to the style-file - or better would need some additional mkgmap:oneway command and be a bit more complicated (values like -1 or reverse, or 1....) On 29.08.2013 21:22, WanMil wrote:
The patch moves the road speed calculations based on the maxspeed tag to the style file. It uses the new maxspeedkmh function to calculate the new internal tag mkgmap:road-speed-class.
This makes the ignore-maxspeeds option superfluous. Anyhow I have kept it to ignore the evaluation of the new tag mkgmap:road-speed-class.
The second advantage is that maxspeed can be removed from the builtin-tag-list which meaans the maxspeed tag is not loaded if not referenced in the style file.
WanMil
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- keep on biking and discovering new trails Felix openmtbmap.org & www.velomap.org
ref, int_ref, nat_ref and ref_ref is already moved to the style file in the branch. They are composed to mkgmap:ref. exit:facility, exit:road_ref and exit:to might also be removed by assigning new tags mkgmap:exit_facility, mkgmap:exit_road_ref and mkgmap:exit_to. But the question is: are these tags used by anyone? The tags are not or very rarely used in OSM (see http://taginfo.openstreetmap.org). The values that can be used with exit:facility are not really documented (apart from the mailing list post: http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2009q1/001317.html). So I guess this is a dead function. junction is used to detect roundabouts. We could map that to mkgmap:junction but I am not sure if that really helps? WanMil
couldn't the int_ref, nat_ref, exit:to and junction also be moved to the style-file?
oneway seems to me the only thing, that cannot be moved to the style-file - or better would need some additional mkgmap:oneway command and be a bit more complicated (values like -1 or reverse, or 1....) On 29.08.2013 21:22, WanMil wrote:
The patch moves the road speed calculations based on the maxspeed tag to the style file. It uses the new maxspeedkmh function to calculate the new internal tag mkgmap:road-speed-class.
This makes the ignore-maxspeeds option superfluous. Anyhow I have kept it to ignore the evaluation of the new tag mkgmap:road-speed-class.
The second advantage is that maxspeed can be removed from the builtin-tag-list which meaans the maxspeed tag is not loaded if not referenced in the style file.
WanMil
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- keep on biking and discovering new trails
Felix openmtbmap.org &www.velomap.org
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Am 04.09.2013 20:16, schrieb WanMil:
junction is used to detect roundabouts. We could map that to mkgmap:junction but I am not sure if that really helps?
Maybe it would help in the point, that mkgmap internally only handels tags with mkgmap:*. So it's easyer to understand. Do you know if remapping eg. oneway=* to mkgmap:oneway=* costs more runtime? Henning -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQEcBAEBAgAGBQJSJ4ktAAoJEPFgsWC7jOeTWusH+wWeqlY5DiMaLhHnlvwriFDI 34l1iJ7SUWh96dXGxn7G1qGJVxtbv8iyHC6H0QXj8zSq7tDaDFrdrx98tcDssN8H AQ39aK0aGY4jg1fG0AxjgxRXqoPheeN+ovZMBXp23Ol5MMFRA5oEofbu0V7OY+J2 h7M7cTCp8Hf5PBpux7OOdZHr2G8xFaZ0sBOg6LgJXp5VNEKC8Am1lYO0j0NlMttm LkH5kFA+U/jx6D+KOSyxv5wimtIUm+LYdMCa//Dy8+8B4RFYpYtyhcveml8g8mtQ Gc3zkhWLG15wF1FWw6M+R3Db1tFd9DguMKhK4p2Gq6wu5fvENXL7lu2XQyF4tIE= =I/Bl -----END PGP SIGNATURE-----
Will this patch be part of the regular release? RocketMan ----- Original Message ----- From: "WanMil" <wmgcnfg@web.de> To: "Development list for mkgmap" <mkgmap-dev@lists.mkgmap.org.uk> Sent: Thursday, August 29, 2013 9:22 PM Subject: [mkgmap-dev] [PATCH v2] Move maxspeed calculations to style file
The patch moves the road speed calculations based on the maxspeed tag to the style file. It uses the new maxspeedkmh function to calculate the new internal tag mkgmap:road-speed-class.
This makes the ignore-maxspeeds option superfluous. Anyhow I have kept it to ignore the evaluation of the new tag mkgmap:road-speed-class.
The second advantage is that maxspeed can be removed from the builtin-tag-list which meaans the maxspeed tag is not loaded if not referenced in the style file.
WanMil
participants (9)
-
Felix Hartmann -
Greg Troxel -
Henning Scholland -
Manfred Brenneisen -
Manfred Brenneisen -
RocketMan -
Steve Ratcliffe -
Toby Speight -
WanMil