April 2021 - mkgmap-dev - The mkgmap lists

logging help patch
by Mike Baggaley 14 Apr '21

14 Apr '21

Hi Gerd, Attached is a patch that provides additional information about logging. Cheers, Mike

1 0

remainder of logging changes
by Mike Baggaley 13 Apr '21

13 Apr '21

Hi Gerd, Please find attached a patch with the remainder of the logging changes (apart from CommandArgs). There are changes to the main program so that the dates and times are only output if mkgmap is processing one or more files. The patch includes an update to the unit test. Note that this now takes a little longer to run, because of having to create new processes to run some of the tests. BTW, were you expecting a change to diagnosticmessages.patch, or is it OK as it stands? (I've attached a copy in case it got lost amongst all the others.) Cheers, Mike

4 9

Commit r4656: (modified) mainlogging.patch by Mike Baggaley
by svn commit 13 Apr '21

13 Apr '21

Version mkgmap-r4656 was committed by gerd on Tue, 13 Apr 2021 (modified) mainlogging.patch by Mike Baggaley - changed runAsProcess() to work on unix like systems and without dist - changed wait to 1 MILLISECONDS Original comment by Mike: "Please find attached a patch with the remainder of the logging changes (apart from CommandArgs). There are changes to the main program so that the dates and times are only output if mkgmap is processing one or more files. The patch includes an update to the unit test. Note that this now takes a little longer to run, because of having to create new processes to run some of the tests." http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4656

1 0

Commit r4655: Use https for test file downloads
by svn commit 12 Apr '21

12 Apr '21

Version mkgmap-r4655 was committed by steve on Mon, 12 Apr 2021 Use https for test file downloads http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4655

1 0

Commit r4654: stillmorelogging.patch by Mike Baggaley
by svn commit 12 Apr '21

12 Apr '21

Version mkgmap-r4654 was committed by gerd on Mon, 12 Apr 2021 stillmorelogging.patch by Mike Baggaley "In the attached patch there are a few improvements to messages as well as some more use of logging: In ImgFS, the message from the FileNotWritableException was displaying the filename twice, so I have fixed that. In TdbBuilder, I have removed an unnecessary log.error In StyledConverter, I have added the synchronisation code for the removal of duplicate messages In O5mBinHandler, I have changed a thrown exception from IOException to FormatException so that it gets handled by its callers" http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4654

1 0

logging
by Mike Baggaley 12 Apr '21

12 Apr '21

Hi Gerd, In the attached patch there are a few improvements to messages as well as some more use of logging: In ImgFS, the message from the FileNotWritableException was displaying the filename twice, so I have fixed that. In TdbBuilder, I have removed an unnecessary log.error In StyledConverter, I have added the synchronisation code for the removal of duplicate messages In O5mBinHandler, I have changed a thrown exception from IOException to FormatException so that it gets handled by its callers Cheers, Mike

2 1

Commit r4653: yetmorelogging.v2.patch by Mike Baggaley
by svn commit 12 Apr '21

12 Apr '21

Version mkgmap-r4653 was committed by gerd on Mon, 12 Apr 2021 yetmorelogging.v2.patch by Mike Baggaley - move more messages from writing to stdout/err to using logging http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4653

1 0

Yet More Logging
by Mike Baggaley 12 Apr '21

12 Apr '21

Hi Gerd, Here's the next patch. Hopefully should only need a couple more patches to package up the remainder of the changes. Cheers, Mike

2 2

r4649 reports many messenges
by Arndt Röhrig 12 Apr '21

12 Apr '21

2 11

Commit r4652: slightly modified morelogging.patch by Mike Baggaley
by svn commit 11 Apr '21

11 Apr '21

Version mkgmap-r4652 was committed by gerd on Sun, 11 Apr 2021 slightly modified morelogging.patch by Mike Baggaley "This one moves a number of messages from writing to stdout/err to using logging. There are several files changed, but most have only very small changes." http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4652

1 0