June 2020 - mkgmap-dev - The mkgmap lists

New style function is_drive_on_left()
by Dave Jackman 09 Jun '20

09 Jun '20

Hi Gerd, Have done a quick test and the new function seems to work fine, I will compile a map covering both Zambia and DRC to fully test it. But I have received an error message: Error in style Error: (lines:395) : Error: No function with name 'length()' So it seems the length() function may no longer work. Dave >

4 4

Re: [mkgmap-dev] Nearby POIs
by Mike Baggaley 09 Jun '20

09 Jun '20

Hi Gerd, The solution gets rid of the unexpected error message, however, it does not delete POIs that were originally coincident. Perhaps a better solution would be not use the set of locations for testing uniqueness in removeSimpleDuplicates, instead using a list and trawl the list using high precision comparison to determine whether the coordinate matches another. It could even compare both in high precision and displayed precision so that POIs which have been moved to be coincident are also removed. As the list will only contain a few coordinates it shouldn't be expensive. To help minimise enumerations, the list could be ordered by longitude or latitude if necessary. Another option would be to derive a class with different iterator comparator which might be useful elsewhere. Regards, Mike >I added options --route --link-pois-to-ways and finally could reproduce the problem with the small file. >Should be fixed with r4523. The high-prec-stuff makes many things better but it is also is a constant source for problems like these

2 1

Commit r4525: nearby-poi: compare high prec locations in removeSimpleDuplicates() to handle duplicate POI which were moved to different places by WrongAngleFixer.
by svn commit 09 Jun '20

09 Jun '20

Version mkgmap-r4525 was committed by gerd on Tue, 09 Jun 2020 nearby-poi: compare high prec locations in removeSimpleDuplicates() to handle duplicate POI which were moved to different places by WrongAngleFixer. http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4525

1 0

default style points enhancements
by Ticker Berkin 09 Jun '20

09 Jun '20

Hi Gerd and followers of the default style Here are some enhancements to default style "points" - patch attached. I've been building up a list of changes to the default style for a while, and, with the current discussion about multiple POI for a single OSM object and the benefit of benches (I've just added this), it seemed like a good time to put forward these changes. Some of these derive from: http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2019q4/030097.html Some from other comments in this forum and the rest are from when I've noticed something wrong or that could be improved. Summary of changes: - for amenity={atm/bar/cafe} allow additional POI from other tags, eg shop=bakery or any others: leisure/tourism/sport/...=... - create POI 0x6605 for bench (Geographic>Land>Bench) - don't create POI for private parking - create parking POI for parking_entrance - if parking unnamed, use access tag if exists, giving names like "Customer parking", "Permissive parking"... - explicit shelter_type=basic_hut rather that trying to exclude bus shelters etc for Find>Lodgings - marina code from 0x4300 to 0x2f09; searchable as "Others" - POI for nature_reserve, even if not named - don't create POI for pitch if no name or sport - don't create POI for private swimming pools - don't create POI for unnamed cliff - add POI 0x6503 for named bay (Geographic>Water>Bay) - for platforms, just 1 POI when --add-pois-to-lines - name unnamed shops as category, regardless of category being matched - add, commented out, extra shop categories supported by some devices - add POI for shop=outdoor - for {camp/caravan}_site have BOTH 0x2b03 AND 0x2b05; 03 not shown on modern devices, 05 not shown on old devices - have both Food & Lodging POI for same point if appropriate - landuse=basin code from 0x650f (Geographic>Water>Reservoir) to 0x6603 (Geographic>Land>Basin) - water=reservoir as well as landuse=reservoir - add POI 0x650d for named water=lake/pond (Geograhic>Water>Lake) I'm happy to explain any of these change in more detail and, if anyone considers a particular change incorrect, provide a revised patch. Ticker

3 6

Commit r4524: Improve default style points: defaultStylePoints5.patch by Ticker Berkin
by svn commit 09 Jun '20

09 Jun '20

Version mkgmap-r4524 was committed by gerd on Tue, 09 Jun 2020 Improve default style points: defaultStylePoints5.patch by Ticker Berkin Summary of changes: - for amenity={atm/bar/cafe} allow additional POI from other tags, eg shop=bakery or any others: leisure/tourism/sport/...=... - create POI 0x6605 for bench (Geographic>Land>Bench) - don't create POI for private parking - create parking POI for parking_entrance - if parking unnamed, use access tag if exists, giving names like "Customer parking", "Permissive parking"... - explicit shelter_type=basic_hut rather that trying to exclude bus shelters etc for Find>Lodgings - marina code from 0x4300 to 0x2f09; searchable as "Others" - POI for nature_reserve, even if not named - don't create POI for pitch if no name or sport - don't create POI for private swimming pools - don't create POI for unnamed cliff - add POI 0x6503 for named bay (Geographic>Water>Bay) - for platforms, just 1 POI when --add-pois-to-lines - name unnamed shops as category, regardless of category being matched - add, commented out, extra shop categories supported by some devices - add POI for shop=outdoor - for {camp/caravan}_site have BOTH 0x2b03 AND 0x2b05; 03 not shown on modern devices, 05 not shown on old devices - have both Food & Lodging POI for same point if appropriate - landuse=basin code from 0x650f (Geographic>Water>Reservoir) to 0x6603 (Geographic>Land>Basin) - water=reservoir as well as landuse=reservoir - add POI 0x650d for named water=lake/pond (Geograhic>Water>Lake) http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4524

1 0

Nearby POIs
by Mike Baggaley 08 Jun '20

08 Jun '20

Just a small note about the distance calculation - I get the following message which suggests the message is slightly incorrect: Removed nearby (<0 m) POI with type 0x013009 "" for element http://www.openstreetmap.org/node/4073250218 at http://www.openstreetmap.org/?mlat=53.068619&mlon=-2.110307&zoom=17 Cheers, Mike

2 4

Commit r4523: nearby POI: fix nonsense message "Removed nearby (<0 m) POI with ..."
by svn commit 08 Jun '20

08 Jun '20

Version mkgmap-r4523 was committed by gerd on Mon, 08 Jun 2020 nearby POI: fix nonsense message "Removed nearby (<0 m) POI with ..." - use getDisplayedCoord() when calculating the distance used in log messages - use string <= in the log messages There is still a glitch in the calculation of the nearby POIs as KdTree also ignores the possible distance between the displayed point and the point returned by getLocation(). Have to think about that again. http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4523

1 0

Commit r4522: fix position of documentation for is_drive_on_left() style function
by svn commit 07 Jun '20

07 Jun '20

Version mkgmap-r4522 was committed by gerd on Sun, 07 Jun 2020 fix position of documentation for is_drive_on_left() style function http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4522

1 0

Commit r4521: fix stupid typo lenght -> length to make length() style function work again
by svn commit 07 Jun '20

07 Jun '20

Version mkgmap-r4521 was committed by gerd on Sun, 07 Jun 2020 fix stupid typo lenght -> length to make length() style function work again Error was introduced with r4520. http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4521

1 0

Commit r4520: Implement new style function is_drive_on_left()
by svn commit 07 Jun '20

07 Jun '20

Version mkgmap-r4520 was committed by gerd on Sun, 07 Jun 2020 Implement new style function is_drive_on_left() The function can be used in points, lines and polygons. The function returns "true" or "false". The return code depends on the information stored in the LocatorConfig.xml and on the iso code in the tag mkgmap:admin_level2. If the latter is not set the function tries the value in mkgmap:country. If both are not set the function returns false. If the iso code is not found in LocatorConfig.xml the function returns false. If the iso code is found and the driveOnLeft attribute is not set in LocatorConfig.xml the function returns false. If (and only if) the iso code is found and the driveOnLeft attribute is set in LocatorConfig.xml the function returns true. http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4520

1 0