April 2014 - mkgmap-dev - The mkgmap lists

Commit: r3181: adapt expected TRE size in unit test
by svn commit 11 Apr '14

11 Apr '14

Version mkgmap-r3181 was committed by gerd on Fri, 11 Apr 2014 adapt expected TRE size in unit test

1 0

Commit: r3180: - don't merge via nodes with boundary nodes in WrongAngleFixer
by svn commit 11 Apr '14

11 Apr '14

Version mkgmap-r3180 was committed by gerd on Fri, 11 Apr 2014 - don't merge via nodes with boundary nodes in WrongAngleFixer - don't merge end points of a way if way has only two points, even if they have highPrecEqual() coordinates. These ways may be created by the LinkDestinationHook. - print error message if a way that is referenced in a restriction is outside of bbox, but was (partly) inside before WrongAngleFixer was executed.

1 0

Commit: r3179: add check to make sure that all ways that are referenced in
by svn commit 11 Apr '14

11 Apr '14

Version mkgmap-r3179 was committed by gerd on Fri, 11 Apr 2014 add check to make sure that all ways that are referenced in a restriction relation have at least two points and that first and last point are not identical. Print warning if the check fails and ignore the restriction.

1 0

r3177 and open question
by Gerd Petermann 10 Apr '14

10 Apr '14

Hi all, r3177 should fix the reported crashes. It still prints error messages for restriction relations, e.g. Schwerwiegend (RestrictionRelation): e:\osm_out_work\germany\20140205_071837\63240003.o5m: Turn restriction (only_right_turn) http://www.openstreetmap.org/browse/relation/2456606 (at http://www.openstreetmap.org/?mlat=51.296499&mlon=6.925914&zoom=17) way http://www.openstreetmap.org/browse/way/184456457 doesn't have required node or Schwerwiegend (RestrictionRelation): e:\osm_out_work\germany\20140205_071837\63240054.o5m: Turn restriction (only_straight_on) http://www.openstreetmap.org/browse/relation/3310817 (at http://www.openstreetmap.org/?mlat=51.480335&mlon=12.018367&zoom=17) via node is not a routing node I am not sure what to do in these cases. The typical reason is that the restriction is valid, but one of the ways is not a road (style doesn't assign road_speed or road_class). I guess I should change the level to warning in such a case? The alternative would be to add a tag like highway=unclassified to the ways used in restriction relations if they don't have a highway=* tag. Gerd

3 2

r3178
by Gerd Petermann 10 Apr '14

10 Apr '14

Hi all, with mkgmap r3178 and splitter r321 you should not see any Turn restriction ... doesn't have required node error messages. If you see them, please report details. Gerd

1 0

Commit: r3178: - fix error: if the 'to' way of a restriction relation was merged to a
by svn commit 10 Apr '14

10 Apr '14

Version mkgmap-r3178 was committed by gerd on Thu, 10 Apr 2014 - fix error: if the 'to' way of a restriction relation was merged to a p-shaped way with the via node appearing twice, make sure that splitWayAt() tells the restriction relation to use the correct part after splitting. - don't print error message "way ... doesn't have required node" for restrictions when referenced ways are not routable, instead print warning "restriction ... is ignored because referenced way ... is not routable" or "restriction ... is ignored because referenced way ... is ignored" in case the way has less than 2 points or no tags.

1 0

Commit: r3176: add copyright info, no functional change
by svn commit 10 Apr '14

10 Apr '14

Version mkgmap-r3176 was committed by gerd on Thu, 10 Apr 2014 add copyright info, no functional change

4 7

Commit: r3177: - fix possible NPE for invalid restriction relation
by svn commit 10 Apr '14

10 Apr '14

Version mkgmap-r3177 was committed by gerd on Thu, 10 Apr 2014 - fix possible NPE for invalid restriction relation - fix possible assertion that is not an error

1 0

Commit: r3175: merge from via_ways branch
by svn commit 10 Apr '14

10 Apr '14

Version mkgmap-r3175 was committed by gerd on Thu, 10 Apr 2014 merge from via_ways branch adds support for restriction relations with - via way - restriction no_entry or no_exit - specific vehicle type, e.g. type=restriction:motorcar or restriction:motorcar=no_u_turn - fixes possible error if different roads connect the same nodes (old code possibly saved the restriction for the wrong road) - detects obsolete restrictions, e.g. when a oneway doesn't allow to enter the road or when the restiction applies to motor_vehicles only and the road is a cycleway. - if the style creates multiple routable ways for one OSM way, the restriction is added for all needed combinations

4 3

make-cycleways and make-opposite-cycleways
by Gerd Petermann 10 Apr '14

10 Apr '14

Hi all, Mario Hantschke pointed out that these tags are not yet evaluated in the --make-opposite-cycleway option: cycleway:left=* and cycleway:right=* http://taginfo.openstreetmap.org/keys/cycleway:left?filter=ways#values While looking at the code I noticed that (for a oneway) the tags bicycle:oneway=no and oneway:bicycle=no are only evaluated if the way also has the tag cycleway=* , which was not intended and is an error. I think all agreed that it only makes sense to add a cycleway if the way is a oneway, so the options --make-cycleways and --make-all-cycleways are obsolete and should be ignored. This leaves option --make-opposite-cycleways which only applies to oneways which do not already have a highway=cycleway tag. My understanding is now that mkgmap should add an additional cycleway if a oneway also has oneway:bicycle=no | bicycle:oneway=no | cycleway=opposite |cycleway=opposite_lane | cycleway=opposite_track | cycleway:left=opposite_lane | cycleway:right=opposite_lane | cycleway:left=opposite_track | cycleway:right=opposite_track Attached is a patch that implements these changes. If I hear no complains I'll commit it on sunday. I'd still prefer to remove also the --make-opposite-cycleways option and change the default style, but I don't know how to change the lines file so that the additional cycleway is added after(!) the normal highway and bicycle traffic is forbidden on that normal highway :-( Gerd

1 0