April 2014 - mkgmap-dev - The mkgmap lists

Commit: r3199: Revert r3198
by svn commit 18 Apr '14

18 Apr '14

Version mkgmap-r3199 was committed by steve on Fri, 18 Apr 2014 Revert r3198

1 0

[PATCH v1] Rework of inc/access
by WanMil 18 Apr '14

18 Apr '14

Hi, attached is a reworked inc/access file. It now uses a 1:1 assignment between OSM tag and mkgmap access tag: foot=* { set mkgmap:foot='${foot}' } bicycle=* { set mkgmap:bicycle='${bicycle}' } motorcar=* { set mkgmap:car='${motorcar}' } goods=* { set mkgmap:delivery='${goods}' } hgv=* { set mkgmap:truck='${hgv}' } bus=* { set mkgmap:bus='${bus}' } taxi=* { set mkgmap:taxi='${taxi}' } emergency=* { set mkgmap:emergency='${emergency}' } motorcycle is no longer used. There is no clean solution when motorcycle != motorcar. The default style supports motorcars. Users that want to use the cards especially for motorcycling should modify their inc/access file appropriately. delivery is no longer used. It is not an access key. The wiki notes: The key delivery is mostly used with the value yes to indicate that the restaurant offers delivery of your meal. More access keys are used. They are taken into account obeying the rules of vehicle subclasses (set motorcar=no if motor_vehicle=no or vehicle=no etc.). The old rule highway=path { add foot=yes; add access=no } did not work for the way [highway=path; access=no]. This way should not be used by foot anyway but the rule above errorneously allowed foot. This is fixed now. carpool handling is now disabled. It does not work (as far as I know) so the rules are not useful. Many thanks to Mario Hantschke who worked out some problems of the old access file and provided some good ideas for the new rules. Please check the new rules. If you are unhappy with some assignements please post an tagging example of a way and how you think the access rules should be assigned. Have fun! WanMil

6 16

Commit: r3198: prepare refactoring of access evaluation:
by svn commit 18 Apr '14

18 Apr '14

Version mkgmap-r3198 was committed by gerd on Fri, 18 Apr 2014 prepare refactoring of access evaluation: move RoadNetwork from package uk.me.parabola.mkgmap.general to uk.me.parabola.imgfmt.app.net Note that you may have to adapt your logging.properties file!

2 1

Commit: r3197: code cleanup to reduce number of problems reported by FindBugs and eclipse,
by svn commit 18 Apr '14

18 Apr '14

Version mkgmap-r3197 was committed by gerd on Fri, 18 Apr 2014 code cleanup to reduce number of problems reported by FindBugs and eclipse, no change in output expected

1 0

Commit: r3196: calm down FindBugs: don't use Math.ceil() on int values
by svn commit 18 Apr '14

18 Apr '14

Version mkgmap-r3196 was committed by gerd on Fri, 18 Apr 2014 calm down FindBugs: don't use Math.ceil() on int values no change in output expected

1 0

Commit: r3195: restrictons2-v4.patch:
by svn commit 18 Apr '14

18 Apr '14

Version mkgmap-r3195 was committed by gerd on Fri, 18 Apr 2014 restrictons2-v4.patch: Compared to r3194 it fixes some errors and adds new checks: 1) only these well documented restrictions are evaluated: no_right_turn, no_left_turn, no_u_turn, no_straight_on, only_right_turn, only_left_turn, only_straight_on, no_entry, no_exit 2) to-ways that build a loop so that first and last point end at the via node are now supported if the restriction contains a direction info (left, right,...). 3) Further plausibility checks are performed to find restrictions where the angle of the from and to way don't match the direction info, for example when a no_right_turn looks more like a no_left_turn. If the angle doesn't match, a warning is written and the restriction is ignored 4) Restrictions with multiple via ways are now supported as well as via ways with additional nodes. The new limit is given by the img format: it allows to specify a "path" with up to 8 routing nodes.

1 0

Commit: r3194: improve LineMergeFilter: Don't merge lines for higher levels
by svn commit 17 Apr '14

17 Apr '14

Version mkgmap-r3194 was committed by gerd on Thu, 17 Apr 2014 improve LineMergeFilter: Don't merge lines for higher levels LineMerger is called with a list that contains all lines, also those which are not written at current resolution. The old versions merged all of them where possible, but only the ones with the right resolution were written to the img file. The new version skips the merge for all lines which are not written at the current resolution. This has different effects: 1) better performance (a few % faster), because the work is not done multiple times, and numbers of lines to merge are much smaller on lower resolutions (e.g. 25 instead of 250.000 at resolution 14) 2) the merging of lines for resolution > x preserved some points for resolution x which are now not preserved. This has a significant impact on output, many shapes and some lines look different. Hard to say if the new result is better. 3) the img size is a bit smaller (maybe only a few bytes)

1 0

Bug in LineMergeFilter
by Gerd Petermann 17 Apr '14

17 Apr '14

Hi all, today I noticed a bug in LineMergeFilter. I am not yet sure how to fix it. I has at least a bad impact on performance, maybe it also causes redundant data in the map. It merges for each resolution also the lines of all higher resolutions, which are later simply dropped. The bug is that it modifies the original line objects instead of copies, so I assume that some lines are saved multiple times, once as part of a merged line, once as single line. No need to wait for a fix, afaik maps are okay. Gerd

1 0

Commit: r3193: copy all tags with keys containing the string "name".
by svn commit 17 Apr '14

17 Apr '14

Version mkgmap-r3193 was committed by gerd on Thu, 17 Apr 2014 copy all tags with keys containing the string "name". Old code copied only "name" and keys ending with ":name", so tags like "name:en" got lost

2 1

Commit: r3192: performance improvement: use two-tier-structure in RuleIndex
by svn commit 17 Apr '14

17 Apr '14

Version mkgmap-r3192 was committed by gerd on Thu, 17 Apr 2014 performance improvement: use two-tier-structure in RuleIndex The advantages: - The lookup routine doesn't have to concatenate tag key and value to a key=value string for each tag of each element. This reduces the number of temp. StringBuilder instances drastically. - if no rule exists for the key, only one HashMap.get() is needed. - the index has a smaller memory footprint, because it keeps only references to already existing string objects Depending on the style and options, this reduces run time by up to 10% No change in output expected.

1 0