August 2013 - mkgmap-dev - The mkgmap lists

Commit: r2679: With output-dir does not exist can result in error.
by svn commit 29 Aug '13

29 Aug '13

Version 2679 was committed by steve on Thu, 29 Aug 2013 With output-dir does not exist can result in error. If more than one thread then there is a race between testing the existence of the directory and creating it. Creating it results in an error if it already exists and the original code would fallback to the default directory on seeing this error. The correct logic is to attempt to create the directory and ignore errors (which is what mkdirs() does anyway), then make sure that the directory exists afterwards.

1 0

[PATCH v1] maxspeedkmh style function
by WanMil 29 Aug '13

29 Aug '13

The patch adds a new style function maxspeedkmh() that returns the maxspeed tag in km/h. Don't know if that's useful for anyone but it's also a kind of preparation to move the maxspeed handling from Java source code in StyledConverter to the style files. It might be used later on to set the roadspeed. WanMil

2 2

Strange occurence in Mapsource/Basecamp
by Geoff Sherlock 25 Aug '13

25 Aug '13

This is not a problem with mkgmap, just a curious thing with Mapsource/Basecamp. Recently I decided to increase the symbol size I used for my maps for POI from a base 16x16 to 24x24. After finding a site where I could download all the PNG files for Mapnik style OSM sysmbols from sizes 12x12 to 64x64 I got to work losing a good couple of weekends in the process; converting the PNGs to be used in my TYP file editor, and tidying up the symbols. Once done I was delighted with the results, but then scrolling around the map I found parts of it were no longer being displayed in Mapsource or Basecamp. I tried the map on my Dakota 20 and could not find the same problem there. One common thing with the missing map parts was it always seemed to be where power lines started to come together, I had changed the image for power towers from a 7x7 pixel image (TYP: 0x6417) to a 22x19 pixel image (TYP: 0x640E). Playing with the detail level in Mapsource I found that viewing on Medium detail level; where the power towers were visible, created a hole in the map where nothing in the rectangle was shown. But changing to the Low detail level when the power towers were lost the map was fine again. It does not seem to be the number of POIs either as the centre of St Albans was shown fine with many POIs. Although these were many different POIs not the same. I am at a loss why large POIs (or at least power power ones) are causing these “holes” in the map, but simply changing the power tower level from 1 to 0 in the style file has fixed the problem as far a I have seen. I have attached two JPEGs showing the difference between the two detail level settings when the power tower was still defined at level 1 in the points file. If anyone has any thoughts I would like to hear them. Regards, Geoff

2 1

possible problem if output dir doesn't exist
by GerdP 25 Aug '13

25 Aug '13

Hi programmers, I've just noted for the first time that mkgmap may fail if the output directory doesn't exist and -max-jobs is used. I saw these messages: Output directory not found. Creating directory '.\map_rrk' Output directory not found. Creating directory '.\map_rrk' and one ovm*.img file was not written to the output dir. I don't expect this to happen often, but I guess this has to be fixed with a threadlocal variable? Gerd -- View this message in context: http://gis.19327.n5.nabble.com/possible-problem-if-output-dir-doesn-t-exist… Sent from the Mkgmap Development mailing list archive at Nabble.com.

2 2

Phone number normalisation with style functions
by Colin Smale 24 Aug '13

24 Aug '13

Hi, Following a discussion on talk-gb about ways of formatting a phone number I decided to see how far I could get with the current style functions in mkgmap. I was very pleasantly surprised! The recent additions of subst with a regex and the part function have allowed me to get an almost perfect result with the countries I have looked at. I thought I would share my experiences in case others also find it useful. The goal is to normalise all POI phone numbers to international format so starting with a + followed by the country code etc. without any punctuation or extraneous information. I put the following code in "inc/phone" and used the include function to invoke that from "inc/address", instead of the existing two lines which derive mkgmap:phone. ========== start of script # reformat phone numbers # get the number to use phone=* | contact:phone=* | addr:phone=* {set cs:phone='${phone}' | '${contact:phone}' | '${addr:phone}'} # only use the first number if there is a list cs:phone=* {set cs:phone='${cs:phone|part:}'} # country-specific rules cs:phone=* & (mkgmap:country=GBR | mkgmap:country=IMN) {set cs:phone='${cs:phone|subst:(0)=>|subst:^00~>+|subst:[()]~>|subst:^0~>+44|subst:^+440~>+44}'} cs:phone=* & mkgmap:country=LUX {set cs:phone='${cs:phone|subst:^00~>+}'} cs:phone=* & mkgmap:country=IRL {set cs:phone='${cs:phone|subst:^00~>+|subst:[- ()]~>|subst:^0~>+353|subst:^+3530~>+353}'} cs:phone=* & mkgmap:country=NLD {set cs:phone='${cs:phone|subst:^00~>+|subst:[- ()]~>|subst:^0~>+31|subst:^+310~>+31}'} cs:phone=* & mkgmap:country=BEL {set cs:phone='${cs:phone|subst:^00~>+|subst:[- ()]~>|subst:^0~>+32|subst:^+320~>+32}'} cs:phone=* & mkgmap:country=FRA {set cs:phone='${cs:phone|subst:^00~>+|subst:^0~>+33}'} cs:phone=* & mkgmap:country=DEU {set cs:phone='${cs:phone|subst:^00~>+|subst:[- ()]~>|subst:^0~>+49|subst:^+490~>+49}'} # lose all non-digits (except for +) cs:phone=* {set cs:phone='${cs:phone|subst:[^0-9+]~>}'} # wrap up cs:phone=* {echo '(${mkgmap:country}) Phone number ${phone} reformatted to ${cs:phone}' } cs:phone=* {add mkgmap:phone='${cs:phone}'; set phone='${cs:phone}'; delete contact:phone; delete addr:phone;} ========== end of script A couple of things I missed: 1) the ability to do variable substitution within the old/new parameters to subst, e.g. subst:${old}~>${new} 2) the ability to use backreferences to parts of the pattern, e.g. subst:(abc)def~>{1} to delete occurrences of "def" when they are preceded by "abc" If these functions were to exist, many of the country-specific stuff could actually be collapsed into one or two rules, with variables for the country code and the trunk prefix (usually a 0 in Europe). Best regards, Colin

3 2

Enhancement on SubstitutionFilter.java to handle regexp (filter "subst:")
by Enrico Liboni 19 Aug '13

19 Aug '13

I updated the SubstitutionFilter.java class in order to allow regexp on the subst filters by using the operator "~>" to state the first argument is a regexp. The default behavior is maintained if no operator (i.e. remove string) or "=>" is used This is convenient for mass corrections or in case we'll have some tweaks to apply on street address names to facilitate search, for example the style entry below (Carlos!) highway=* & name ~ '[Aa]venida [Dd]e [Ee]l .*' { add streettype:movend='${name|subst:Avenida De El |subst:Avenida De el |subst:Avenida de El |subst:Avenida de el |subst:avenida De El |subst:avenida De el |subst:avenida de El |subst:avenida de el }'} will become highway=* & name ~ '[Aa]venida [Dd]e [Ee]l .*' { add streettype:movedend='${name|subst:[Aa]venida [Dd]e [Ee]l ~>}'} Technically, the change is minimal, it is just checking the filter operator (=> or ~>) and using replaceAll() instead of replace() if "~>" is used. Attached the updated class - I really hope it will be included and be useful! Cheers, Enrico

5 11

Commit: r2673: Documentation update for Substitution and Part filters.
by svn commit 19 Aug '13

19 Aug '13

Version 2673 was committed by steve on Mon, 19 Aug 2013 Documentation update for Substitution and Part filters. - Enrico Liboni

1 0

Commit: r2672: Disable drive-on-left/right handling also if coastlinefile option is set
by svn commit 19 Aug '13

19 Aug '13

Version 2672 was committed by wanmil on Mon, 19 Aug 2013 Disable drive-on-left/right handling also if coastlinefile option is set

1 0

Commit: r2671: Do not always set drive-on-left flag to false if option precomp-sea is set
by svn commit 18 Aug '13

18 Aug '13

Version 2671 was committed by wanmil on Sun, 18 Aug 2013 Do not always set drive-on-left flag to false if option precomp-sea is set In case a tile has mixed sea/land content and uses the precomp-sea option the precompiled sea tiles are loaded by an OsmMapDataSources instance. This creates a an option less StyledConverter which sets the drive-on-left flag to false. This overrides the drive-on-left/right option of the config file. This change adds an internal option "ignore-drive-on-left" which does not initialize the drive-on-left flag in the StyleConverter. This option is only set by the SeaGenerator when loading precompiled sea tiles.

1 0

Commit: r2670: Ensure thread safe handling for the drive-on-left/right flag
by svn commit 18 Aug '13

18 Aug '13

Version 2670 was committed by wanmil on Sun, 18 Aug 2013 Ensure thread safe handling for the drive-on-left/right flag The drive on left flag is set via a static method. This was not thread safe when using more than one thread. The flag is now stored as ThreadLocal variable which ensures that the value is used only in the current thread.

1 0