January 2013 - mkgmap-dev - The mkgmap lists

SeaGenerator patch v1
by GerdP 12 Jan '13

12 Jan '13

Hi, the index for the precomp-sea method stores 131072 * 2 = 262.144 Strings with String.intern() in a HashMap (one instance for each job). Attached is a patch that changes the index to use a byte[512][256] array > 131072 bytes. It reduces run time and memory needs in mkgmap (when --precomp-sea is used) One problem: The unpatched version would allow to have different formats (*.o5m, *.osm.pbf, .osm.gz) in one sea directory. The patched version assumes that all files have the same prefix and extension. So, if you want to update a precompiled sea tile you have to make sure that you keep the name and format. I hope this small limit is no problem? Gerd seaGen_v1.patch <http://gis.19327.n5.nabble.com/file/n5743972/seaGen_v1.patch> -- View this message in context: http://gis.19327.n5.nabble.com/SeaGenerator-patch-v1-tp5743972.html Sent from the Mkgmap Development mailing list archive at Nabble.com.

3 3

Commit: r2445: Reduce memory consumption when using precompiled sea
by svn commit 12 Jan '13

12 Jan '13

Version 2445 was committed by wanmil on Sat, 12 Jan 2013 Reduce memory consumption when using precompiled sea The index of the precompiled sea tiles is now a byte[][] with 512*256 = 131072 entries instead of a HashMap<String,String> with 131072 entries.

1 0

reduce_peak_mem_v1.patch
by GerdP 12 Jan '13

12 Jan '13

Hi, attached is another patch to reduce peak memory usage in mkgmap. - reduce initial size of typically ArrayList instances which typically contain few entries - free way after it was converted in ElementSaver - free the precomp-sea index in SeaGenerator after usage (the related HashMap requires ~17Mb) for each job. I do not yet understand why this is index is a ThreadLocal. I guess it was planned to have a single thread just for the index? I think that would be good, but I don't want to change that part now because it will probably be changed in the mp_cut branch. Ciao, Gerd -- View this message in context: http://gis.19327.n5.nabble.com/reduce-peak-mem-v1-patch-tp5743803.html Sent from the Mkgmap Development mailing list archive at Nabble.com.

5 6

installer/license_template.txt should be revised
by Franco Bez 11 Jan '13

11 Jan '13

Hi everybody, I noticed that with every img I create there is a *_license.txt file generated that reads: Map data (c) OpenStreetMap and contributors http://www.openstreetmap.org/ Map data licenced under Creative Commons Attribution ShareAlike 2.0 See http://creativecommons.org/licenses/by-sa/2.0/ Map created with mkgmap-r2426 You know since quite some time the OSM Data is no longer licensed under Creative Commons Attribution ShareAlike 2.0, but there was a switch to Open Data Commons Open Database Lizenz <http://opendatacommons.org/licenses/odbl/> (ODbL) http://opendatacommons.org/licenses/odbl/ Ciao, Franco

3 4

Commit: r2444: Link the copyright page of OSM in the license text
by svn commit 11 Jan '13

11 Jan '13

Version 2444 was committed by wanmil on Fri, 11 Jan 2013 Link the copyright page of OSM in the license text

1 0

[PATCH v1] Always use US locale for number formatting in ExtTypeAttributes
by WanMil 10 Jan '13

10 Jan '13

The ExtTypeAttributes which are used for marine maps should have a problem if the locale of the system does not use english number formatting (e.g. german uses "," as decimal separator). Attached patch fixes that. I cannot test it because the code is only executed with polish input files using the attribute "HeightAboveFoundation". Please test if you are able to reproduce. WanMil

1 0

Optimization for ExtTypeAttributes
by GerdP 10 Jan '13

10 Jan '13

Hi, I noticed that each ExtTypeAttributes instance allocates a DecimalFormat instance. This requires ~700 Bytes, but it seems that it is only used in rare cases. With the style that I am using for testing, I see > 200.000 instances of the ExtTypeAttributes class, so 140Mb are probably wasted. Attached small patch allocates the instance only when needed. Any objections? Gerd ExtTypeAttributes.patch <http://gis.19327.n5.nabble.com/file/n5743637/ExtTypeAttributes.patch> -- View this message in context: http://gis.19327.n5.nabble.com/Optimization-for-ExtTypeAttributes-tp5743637… Sent from the Mkgmap Development mailing list archive at Nabble.com.

4 8

FakeIdGenerator
by GerdP 10 Jan '13

10 Jan '13

Hi Steve, WanMil, I think the FakeIdGenerator should be changed. As Rogert Calvert pointed out, other tools like SRTM2OSM generate OSM data with IDs like "9223372036854775807" These ids may be treated as fake ids by the FakeIdGenerator.isFakeId() method which is too simple. Possible solutions: - the reader should stop with an error message if an OSM id is found that is higher than FakeIdGenerator.START_ID or - the FakeIdGenerator should be changed to allow a parameter which gives a start value (or maybe a range ) What do you think? Gerd -- View this message in context: http://gis.19327.n5.nabble.com/FakeIdGenerator-tp5743379.html Sent from the Mkgmap Development mailing list archive at Nabble.com.

5 10

Wiki: Remove translated pages
by WanMil 10 Jan '13

10 Jan '13

Hi, there are quite a few pages in the wiki with translations. I fear most of them (I don't understand all languages ;-) are not up to date and sometimes contain old and/or wrong information. Some examples with date of last change: http://wiki.openstreetmap.org/wiki/DE:Mkgmap Jan 2012 http://wiki.openstreetmap.org/wiki/FR:Mkgmap Nov 2010 http://wiki.openstreetmap.org/wiki/JA:Mkgmap Jan 2010 http://wiki.openstreetmap.org/wiki/NL:Mkgmap Jan 2010 http://wiki.openstreetmap.org/wiki/RU:Mkgmap Aug 2011 http://wiki.openstreetmap.org/wiki/Zh-hans:Mkgmap Apr 2011 I would like to remove them all to avoid misinformation. Any objections or idea how to avoid the problem of unmaintained localized pages? WanMil

3 2

removeShortArcs_v2.patch
by GerdP 10 Jan '13

10 Jan '13

Hi, this is the corrected version of the patch to use removeShortArcs only for roads. removeShortArcs_v2.patch <http://gis.19327.n5.nabble.com/file/n5743266/removeShortArcs_v2.patch> It makes processing a bit faster and reduces the size of those tiles that contain a lot of coastline ways (e.g. around norway). Gerd -- View this message in context: http://gis.19327.n5.nabble.com/removeShortArcs-v2-patch-tp5743266.html Sent from the Mkgmap Development mailing list archive at Nabble.com.

2 1