January 2012 - mkgmap-dev - The mkgmap lists

Commit: r2169: When building mdr20 take account of the map number and the city
by svn commit 15 Jan '12

15 Jan '12

Version 2169 was commited by steve on 2012-01-15 22:36:15 +0000 (Sun, 15 Jan 2012) When building mdr20 take account of the map number and the city when deciding if a street is the same or not. Also set again a flag that was accidentally not set after the change to add gmapsupp indexes in mdr5.

1 0

mkgmap command-line argument parsing bugs
by Richard Hansen 14 Jan '12

14 Jan '12

Hi all, I have stumbled across a couple of mkgmap command-line argument parsing bugs: 1. (all?) command-line arguments after '-c template.args' are ignored 2. '--generate-sea' produces the following error message (I have to use '--generate-sea=multipolygon' even though multipolygon is supposedly the default): Unknown sea generation option '' Known sea generation options are: multipolygon use a multipolygon (default) polygons | no-mp use polygons rather than a multipolygon no-sea-sectors disable use of "sea sectors" extend-sea-sectors extend coastline to reach border land-tag=TAG=VAL tag to use for land polygons (default natural=land) close-gaps=NUM close gaps in coastline that are less than this distance (metres) floodblocker enable the floodblocker (for multipolgon only) fbgap=NUM points closer to the coastline are ignored for flood blocking (default 40) fbthres=NUM min points contained in a polygon to be flood blocked (default 20) fbratio=NUM min ratio (points/area size) for flood blocking (default 0.5) I'll see what I can do to provide patches to fix these, but it'll take me a while (the argument parsing code does not look trivial). Thanks, Richard

5 7

Configurable region/city mapping in address search?
by Marko Mäkelä 14 Jan '12

14 Jan '12

It occurred to me that the definition of a region should probably depend on the area of the map that is being built. For a map that comprises most of Europe, a meaningful region could be the country. A map of a single country or closely related countries, such as the BeNeLux or the Baltic countries might use state or province for the regions. A map of a federal republic such as Germany or the USA could use the state for the region. A map of a single state might use city as the region and suburb or village (German: Ortsteil) as the city. Is the mapping of regions and cities configurable? How? I guess that one would get most flexibility with a location bounds file. Marko

3 3

Stackoverflow while loading style files
by Lambertus 14 Jan '12

14 Jan '12

Hopefully someone can shed some light on what I'm doing wrong? java -Xmx1000M -ea -jar ~/garmin/utils/mkgmap/mkgmap.jar --style-file=/home/lambertus/garmin/world/styles/default/ --input-file=63240001.osm.gz java.lang.StackOverflowError at sun.nio.cs.UTF_8.updatePositions(UTF_8.java:58) at sun.nio.cs.UTF_8$Encoder.encodeArrayLoop(UTF_8.java:392) at sun.nio.cs.UTF_8$Encoder.encodeLoop(UTF_8.java:447) at java.nio.charset.CharsetEncoder.encode(CharsetEncoder.java:544) at java.lang.StringCoding$StringEncoder.encode(StringCoding.java:240) at java.lang.StringCoding.encode(StringCoding.java:272) at java.lang.String.getBytes(String.java:946) at java.io.UnixFileSystem.getBooleanAttributes0(Native Method) at java.io.UnixFileSystem.getBooleanAttributes(UnixFileSystem.java:228) at java.io.File.isDirectory(File.java:754) at uk.me.parabola.mkgmap.osmstyle.DirectoryFileLoader.<init>(DirectoryFileLoader.java:47) at uk.me.parabola.mkgmap.osmstyle.StyleFileLoader.createStyleLoader(StyleFileLoader.java:64) at uk.me.parabola.mkgmap.osmstyle.StyleImpl.<init>(StyleImpl.java:132) at uk.me.parabola.mkgmap.osmstyle.StyleImpl.readBaseStyle(StyleImpl.java:518) at uk.me.parabola.mkgmap.osmstyle.StyleImpl.<init>(StyleImpl.java:140) at uk.me.parabola.mkgmap.osmstyle.StyleImpl.readBaseStyle(StyleImpl.java:518) at uk.me.parabola.mkgmap.osmstyle.StyleImpl.<init>(StyleImpl.java:140) at uk.me.parabola.mkgmap.osmstyle.StyleImpl.readBaseStyle(StyleImpl.java:518) (Lot's of the same errors like the last 6 lines snipped) The styles directory is an svn export of the styles section in the Mkgmap SVN repository, svn info reports version 2160. Mkgmap version is r2162.

2 2

trouble routing across extracts
by Richard Hansen 14 Jan '12

14 Jan '12

Hi all, Using splitter on the US state extracts from Geofabrik, I am unable to route across state boundaries. On my Oregon 450 I get "route calculation error" after it sits at 80% for a while. If I combine the extracts before splitting, then routing works. Is this a known limitation? Would it be feasible to teach splitter how to combine the extracts internally before splitting? If not, what would it take to get mkgmap's routing to work across split extracts? DETAILS: The following produces a gmapsupp.img that does not support routing across state boundaries: STATES="massachusetts connecticut" for s in ${STATES}; do wget http://download.geofabrik.de/osm/north-america/us/${s}.osm.pbf done java -jar splitter.jar --no-trim *.osm.pbf java -jar mkgmap.jar --gmapsupp --route -c template.args The following produces a gmapsupp.img that works as expected: combine() { unset args for f in "$@"; do case ${f} in *.osm.pbf) r="--rb";; *) r="--rx";; esac args="${args} ${r} ${f} --sort${args+ --merge}" done osmosis ${args} --wb combined.osm.pbf } rm -f combined.osm.pbf combine *.osm.pbf java -jar splitter.jar --no-trim combined.osm.pbf java -jar mkgmap.jar --gmapsupp --route -c template.args Thanks, Richard

4 5

Generating location bounds info from shape file?
by Marko Mäkelä 13 Jan '12

13 Jan '12

This may be a dumb question, because I do not know any GIS file formats (apart from *.osm). But, would it be possible to create the bounds information from a shape file that defines administrative boundaries? This would allow experimentation before importing hundreds of municipality boundaries (1000s of ways and 100s of relations) into OSM. Marko

6 7

Commit: r2168: Minor bugfixing in Java2DConverter
by svn commit 12 Jan '12

12 Jan '12

Version 2168 was commited by wanmil on 2012-01-12 22:20:54 +0000 (Thu, 12 Jan 2012) Minor bugfixing in Java2DConverter When converting an java.awt.geom.Area to List<Coord> using the singularAreaToPoints(Area area) method the closing point was always duplicated due to a wrong check. Starting with a test class for the Java2DConverter to avoid such problems in future :-)

1 0

Possible optimization of StyledConverter
by GerdP 12 Jan '12

12 Jan '12

Steve, WanMil, the discussion about a prepro for styles inspired me to think about a compiler/optimizer for style rules. The point that I have in mind is this: Style files typically have many different rules starting with e.g. highway=* & ... The current iplementation in RuleSet.java and RuleIndex.java will first create a set of all rules that might match for the existing tags of a given element. Next, it processes each rule until the element is done. Let's assume an element that has tag "highway" and maybe 4 other tags If we have twenty rules with highway=* and none of them matches, we'll call getTag("highway") twenty times, always with the same result. Although getTag() is not very complex, it still means a lookup in a hash table. I see two possible optimizations here: 1) Combine rules that start with the same expression, e.g. highway=*, so that we don't evaluate tags again and again. In the past I used parser generator tools like lexx+yacc. I have the feeling that the rule interpretation is also something that could be done by a table driven parser. 2) A bit off-topic: Use a short instead of a String for the keys of Tags. I think even complex styles will not use more than a few hundred different tag keys. If all used tag keys are stored in an array, we can refer to the position in that array. Some weeks ago I coded that and it turned out to save some CPU cycles because Tags.keyPos() is simpler, but it also required changes in many sources and I found other patches providing more improvement with smaller changes. What do you think about this? Gerd P.S. A storm kept me awake all night long, so maybe I am writing nonsense :-O -- View this message in context: http://gis.638310.n2.nabble.com/Possible-optimization-of-StyledConverter-tp… Sent from the Mkgmap Development mailing list archive at Nabble.com.

3 6

[Patch v1] LocationHook with new Quadtree
by GerdP 12 Jan '12

12 Jan '12

Hi, attached is a patch that implements LocationHook with a new Quadtree. With my test data, it makes mkgmap about 10% faster. Remarks: - Some Nodes and ways are not found. I think that's because they lie exactly on boundaries. The same problem occurs with mkgmap from trunk. As a work around I suggest to search those nodes again with coords decreased by 1. - More time may be saved if we manage to save the preprocessed boundary data in a format that can be directly loaded into the quadtree. http://gis.638310.n2.nabble.com/file/n7181376/locationHook_speedup.patch locationHook_speedup.patch ciao, Gerd -- View this message in context: http://gis.638310.n2.nabble.com/Patch-v1-LocationHook-with-new-Quadtree-tp7… Sent from the Mkgmap Development mailing list archive at Nabble.com.

3 7

Commit: r2167: Remove getUsedTags() from LocationHook
by svn commit 12 Jan '12

12 Jan '12

Version 2167 was commited by wanmil on 2012-01-12 20:22:55 +0000 (Thu, 12 Jan 2012) Remove getUsedTags() from LocationHook The used tags give the tags the hook requires to workout the OSM elements. The LocationHook does not need any of them. They are required only for the preprocessed boundaries. This method seems to have survived from the very very early days of the LocationHook.

1 0