May 2011 - mkgmap-dev - The mkgmap lists

[PATCH v1] Remove LineClipper artefacts to avoid flooding
by WanMil 25 May '11

25 May '11

The patch removes artefacts from the LineClipper that might cause floodings. WanMil

3 8

Convert.java bug fix
by Alin Năstac 25 May '11

25 May '11

Ahoy there, I've found a bug in function parseDouble. In short, the function is unable to parse float numbers such as ".12" or "12.". This simple patch fixes the issue: --- Convert.java.old 2011-05-24 21:37:52.000000000 +0200 +++ Convert.java 2011-05-24 21:38:31.000000000 +0200 @@ -180,7 +180,7 @@ if (isNegative) decimal = -decimal; - if (decimalPoint > 0) + if (decimalPoint >= 0 && decimalPoint < i - 1) return decimal / PowersOfTen[i - decimalPoint - 2]; else return decimal; Cheers, Alin

2 1

Commit: r1954: Let LineSplitter return at most connected ways
by svn commit 24 May '11

24 May '11

Version 1954 was commited by wanmil on 2011-05-24 17:23:46 +0100 (Tue, 24 May 2011) Let LineSplitter return at most connected ways Ways are no longer split when two subsequent coordinates are equal. In case a way is closed the clipped ways are no longer splitted at its start/end point Slightly improved clip algorithm that now performs the most common check first if both points are within the clipping area As a result from these fixed the SeaGenerator no longer needs to join the clipped ways.

1 0

mkgmap locking up on Iceland. All files and instructions to recreate the problem linked
by Felix Hartmann 24 May '11

24 May '11

Get the cutted maps and areas.list file (in order to use -c option) for recreating the problem here: 1. _/http://openmtbmap.org/beta/iceland_osm.gz.zip/_ (11MB): Style-file here: 2. /_http://openmtbmap.org/beta/style-file.zip_/ If i either remove my style-file OR remove --route, then it compiles without problems: java -ea -jar -Xmx6500M c:\openmtbmap\mkgmap.jar --max-jobs=1 %style-file% --route -c c:\openmtbmap\maps\template.%country% Seems that just one more time, my extensive style- triggers an error, that otherwise maybe never shows up (or very rarely). Error only happens when using locator branch. (does not matter if I use my patched locator trunk, or latest from mkgmap.org.uk ). I have no clue how to get the stack trace of mkgmap locking up.

2 2

Slowness processing specific tile
by Francisco Moraes 23 May '11

23 May '11

I noticed a big hang/delay processing one tile in NC. Here's the generated IMG files for each tile: 05/19/2011 09:33 AM 4,230,144 63240001.img 05/19/2011 09:33 AM 2,450,432 63240002.img 05/19/2011 09:33 AM 2,893,824 63240003.img 05/19/2011 09:33 AM 2,170,880 63240004.img 05/19/2011 09:33 AM 2,173,952 63240005.img 05/19/2011 09:34 AM 2,518,016 63240006.img 05/19/2011 09:34 AM 2,553,856 63240007.img 05/19/2011 09:34 AM 1,730,560 63240008.img 05/19/2011 09:34 AM 2,041,856 63240009.img 05/19/2011 09:34 AM 3,491,328 63240010.img 05/19/2011 09:34 AM 6,999,552 63240011.img 05/19/2011 09:35 AM 4,713,984 63240012.img 05/19/2011 09:35 AM 2,435,072 63240013.img 05/19/2011 09:35 AM 3,771,392 63240014.img 05/19/2011 09:35 AM 6,385,152 63240015.img 05/19/2011 09:35 AM 3,237,376 63240016.img 05/19/2011 09:35 AM 3,420,160 63240017.img 05/19/2011 09:35 AM 2,976,768 63240018.img 05/19/2011 09:35 AM 3,629,056 63240019.img 05/19/2011 09:36 AM 3,863,552 63240020.img 05/19/2011 09:36 AM 3,583,488 63240021.img 05/19/2011 09:36 AM 1,553,408 63240022.img 05/19/2011 09:36 AM 3,411,456 63240023.img 05/19/2011 09:36 AM 3,038,208 63240024.img 05/19/2011 09:36 AM 7,901,696 63240025.img 05/19/2011 09:36 AM 3,146,752 63240026.img 05/19/2011 09:36 AM 4,070,400 63240027.img 05/19/2011 09:37 AM 2,481,664 63240028.img 05/19/2011 09:37 AM 3,462,656 63240029.img 05/19/2011 09:37 AM 4,033,536 63240030.img 05/19/2011 09:47 AM 8,536,576 63240031.img 05/19/2011 09:47 AM 1,745,408 63240032.img 05/19/2011 09:47 AM 4,779,008 63240033.img 05/19/2011 09:47 AM 3,905,024 63240034.img 05/19/2011 09:47 AM 5,238,272 63240035.img 05/19/2011 09:47 AM 3,605,504 63240036.img You can see that tile 31 took about 10 minutes to be generated while the rest was much quicker. Anyone seen anything similar? Here's the tile boundaries from the splitter output: 63240031: 1576960,-3932160 to 1597440,-3891200 # : 33.837891,-84.375000 to 34.277344,-83.496094 Just curious. Not a big deal but I thought I had caused it somehow with the PBF patch. Francisco

5 15

Commit: r1953: Multipolygons: Joining unconnected ways out of the bounding box
by svn commit 23 May '11

23 May '11

Version 1953 was commited by wanmil on 2011-05-23 19:06:49 +0100 (Mon, 23 May 2011) Multipolygons: Joining unconnected ways out of the bounding box Unclosed ways with endpoints out of the bounding box are now connected. Connections with smallest distance are preferred. This fixes problems with very large multipolygons that are larger than the bounding box.

1 0

Re: [mkgmap-dev] Splitter PBF support patch
by Francisco Moraes 23 May '11

23 May '11

On 5/22/2011 4:35 PM, mkgmap-dev-request(a)lists.mkgmap.org.uk wrote: > I've downloaded the splitter from trunk, but how can I splitt the files into pbf-format. --pbf or output=pbf didn't work. > And does the locator-branch already can handle pbf-files? The code has not been committed to SVN yet. You need to apply the patch on top of the trunk code. The patch currently uses --pbf option to enable PBF output. I will change it to --output=pbf as suggested on the next patch once I hear confirmation about the unreferenced node issues that have been reported as I think that also happens on the XML output path. Francisco

3 2

generate-sea is broken from rev 1760
by Apollinaris Schoell 22 May '11

22 May '11

Hi, the code below was added to SeaGenerater.java in revision 1760. Since then the some flooding happens in a few tiles. before that all sea rendering was correct. I tried also the floodblocker but then part of the sea is not blue anymore. It jsut blocks sea in some places but doesn't prevent the creation of bad polygons. I have checked all of the coastline and it is definitely correct and extends in all places beyond the bounds of the tile. If someone want's to debug I can also provide the coastline only for the area. Just too big for this list and can upload or send to a private email I am using generate-sea=multipolygon,extend-sea-sectors,close-gaps=10 area for splitter is 18900004: 1687552,-5750784 to 1761280,-5685248 # : 36.210938,-123.398438 to 37.792969,-121.992188 This is the code difference in SeaGenerator.java if (clipped.size() > 0) { // the LineClipper sometimes returns unjoined clips // need to rejoin them here log.info(clipped.size(),"clippings. Try to join them."); List<Way> clippedWays = new ArrayList<Way>(clipped.size()); for (List<Coord> clippedPoints : clipped) { clippedWays.add(new Way(FakeIdGenerator.makeFakeId(), clippedPoints)); } clippedWays = joinWays(clippedWays); if (clippedWays.size() != clipped.size()) { clipped = new ArrayList<List<Coord>>(clippedWays.size()); for (Way w : clippedWays) { clipped.add(w.getPoints()); } } log.info(clipped.size(),"joined clippings."); }

3 8

Re: [mkgmap-dev] Splitter PBF support patch
by Francisco Moraes 22 May '11

22 May '11

On 5/20/2011 3:59 AM, mkgmap-dev-request(a)lists.mkgmap.org.uk wrote: > I am checking that now, but with today's dump instead of yesterday's. > The splitting time is 199s for osm.gz vs 102s for osm.pbf. > > The XML path seems to be unaffected by your patch. My filter only > passed two errors, which I will soon correct (so that they should not > be in tomorrow's finland.osm.pbf). I compared the splitter output from both the XML and PBF with your script. I took one of the missing node messages (node 1217412566 referenced from way 105721933 and compared the XML and PBF splitter outputs. As far as I can tell, the node is not present on the tile 63240006 in either the XML or PBF output. It is present on tile 63240007 though and that matches the areas.list you are using. Is this a case of the PBF parser in mkgmap being more chatty than the XML parser? I also noticed that the splitter outputs XML at version 0.5. That probably should be fixed. Finally, I don't know if this is an issue, but my PBF patch doesn't output any metadata as I didn't see that in the data structure used in the splitter. Let me know if I am off base, but that's seems to be what I found so far. I won't be able to look at it again until next week now. Francisco

3 2

How do I get a blue sea?
by Roger Calvert 22 May '11

22 May '11

I'm using mkgmap to install OSM on my Garmin GPS. Lakes and rivers come out in blue on both Mapsource and the GPS, but the sea comes out white. The shoreline appears as a single thin line. I am using pbf files of England, Scotland and Wales downloaded from geofabrik Download-Bereich. I have the option '--generate-sea=polygons,extend-sea-sectors,close-gaps=1000' in the mkgmap command line. The 'polygons' file contains 'natural=sea [0x32 resolution 18]'. Any suggestions as to how I might get a blue sea? Many thanks! Roger -- ------------------------------------------------------------------------ Roger Calvert ------------------------------------------------------------------------

4 6