mkgmap-dev

mkgmap-dev@lists.mkgmap.org.uk

October 2009

50 participants
192 discussions

Suppressing or fixing zero-length arc warnings
by Marko Mäkelä 01 Oct '09

01 Oct '09

I have fixed some zero length arc warnings in the Finland extract. The count has gone down from 334 to 289. Most warnings are now for unnamed roads. Some of them are badly mapped cycleways or footways, but some are genuine zero-length arcs that I think should be silently dropped or merged by mkgmap. There are some cases that I am having trouble with: (1) steps and short ramps or paths around them, e.g., http://www.openstreetmap.org/browse/way/31345355 at http://www.openstreetmap.org/?lat=60.15495&lon=24.86515&zoom=17 Perhaps mkgmap should merge the highway=steps to highway=footway? Could this be done at the style-file level somehow? (2) short highways that end at some region boundary, such as this one: http://www.openstreetmap.org/browse/way/31359067 http://www.openstreetmap.org/?lat=60.15515&lon=24.88084&zoom=17 Could we introduce a tag for short arcs, similar to noname=*? It could be in the mkgmap namespace and renamed by a style file. For example, to suppress warnings about short steps, just add a rule like this: highway=steps { add mkgmap:zerolength=yes } (3) crossings on narrow city streets where the footway has been split into tiny segments due to a tram line crossing: http://www.openstreetmap.org/browse/way/28842855 http://www.openstreetmap.org/?lat=60.16600&lon=24.94182&zoom=17 See the Bulevardi/Yrjönkatu crossing. What to do about this? The same work-around as above? Marko

2 7

Issue with exits ref and possible patch
by Nakor 01 Oct '09

01 Oct '09

Hello, I have noticed that in case an exit node is linked to several highways (maybe this is bad mapping practice but it exists) and one of them does not have a ref tag, mkgmap issues a warning that the exit was not assigned a ref (see nodes 62152165 and 61852851 for an example). Below is an patch that tries to fix this: Index: src/uk/me/parabola/mkgmap/reader/osm/xml/Osm5XmlHandler.java =================================================================== --- src/uk/me/parabola/mkgmap/reader/osm/xml/Osm5XmlHandler.java (revision 1246) +++ src/uk/me/parabola/mkgmap/reader/osm/xml/Osm5XmlHandler.java (working copy) @@ -432,19 +432,21 @@ for (Node e : exits) { String refTag = Exit.TAG_ROAD_REF; if(e.getTag(refTag) == null) { + String ref = null; for (Way w : motorways) { - String ref = w.getTag("ref"); if (w.getPoints().contains(e.getLocation())) { - if(ref != null) { - log.info("Adding " + refTag + "=" + ref + " to exit" + e.getTag("ref")); - e.addTag(refTag, ref); - } - else { - log.warn("Motorway exit is positioned on a motorway that doesn't have a 'ref' tag"); - } - break; + ref = w.getTag("ref"); + if(ref != null) + break; } } + if(ref != null) { + log.info("Adding " + refTag + "=" + ref + " to exit" + e.getTag("ref")); + e.addTag(refTag, ref); + } + else { + log.warn("Motorway exit is positioned on a motorway that doesn't have a 'ref' tag"); + } } } Thanks, N.

2 2

Jump to page: