Defer relations does not work with PBF
Marko, you have commited the defer relation lookup feature (r1466). It is not implemented for the PBF loader. Do you still use this feature? Can you give an example where this feature is useful? I have the feeling that it might not be used because otherwise someone should have complained that it is not working for pbf files?!? WanMil
Hi WanMil, Sorry, I have been a little busy due to a business trip last week. I still have not fully recovered from the jet lag.
you have commited the defer relation lookup feature (r1466). It is not implemented for the PBF loader.
Do you still use this feature? Can you give an example where this feature is useful?
I tested it on this ferry route relation a long time ago: http://www.openstreetmap.org/browse/relation/155054 The relation contains two stops that are type=site relations, containing the highway=bus_stop node in role=passengers and a node on the route way http://www.openstreetmap.org/browse/way/123403659 in role=vehicle. I saw a suggestion in the wiki that bus route relations should be mapped in this way. I guess that the idea is to enable better routing, or to better resolve the bus stops when a bus goes through some 270° ramps below and above a bridge. I just checked, and the two highway=bus_stop endpoints of this ferry route do not inherit any ref or name information from the ferry route relation. So, it is indeed broken for PBF input. How hard would it be to implement the deferred relation lookup in PBF? I feel that it is needed for anything that uses subrelations. Best regards, Marko
Hi WanMil,
Sorry, I have been a little busy due to a business trip last week. I still have not fully recovered from the jet lag.
you have commited the defer relation lookup feature (r1466). It is not implemented for the PBF loader.
Do you still use this feature? Can you give an example where this feature is useful?
I tested it on this ferry route relation a long time ago:
http://www.openstreetmap.org/browse/relation/155054
The relation contains two stops that are type=site relations, containing the highway=bus_stop node in role=passengers and a node on the route way http://www.openstreetmap.org/browse/way/123403659 in role=vehicle.
I saw a suggestion in the wiki that bus route relations should be mapped in this way. I guess that the idea is to enable better routing, or to better resolve the bus stops when a bus goes through some 270° ramps below and above a bridge.
I just checked, and the two highway=bus_stop endpoints of this ferry route do not inherit any ref or name information from the ferry route relation. So, it is indeed broken for PBF input.
How hard would it be to implement the deferred relation lookup in PBF? I feel that it is needed for anything that uses subrelations.
Hi Marko, I think it's quite easy. I just wondered if it does anything because nobody complained. And of course I need a testcase to implement the feature. Can you send me the style files where it has an effect? I will try to fix that within the next days. Have fun! WanMil
Best regards,
Marko _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
On Fri, Oct 21, 2011 at 06:22:29PM +0200, WanMil wrote:
I think it's quite easy. I just wondered if it does anything because nobody complained. And of course I need a testcase to implement the feature. Can you send me the style files where it has an effect?
It should work with the default style. Let me try now. josm * hit ctrl-shift-o * download relation 155054 * download the bounding box minlat='60.146908999999994' minlon='24.9462708' maxlat='60.169635799999995' maxlon='24.9937026' * or just download the above bounding box straight away * save to file test.osm java -jar mkgmap.jar --gmapsupp --latin1 test.osm strings gmapsupp.img |grep 009 KAUPPATORI 0099(SUOMENLINNAN LAUTTA) SUOMENLINNA 0098(SUOMENLINNAN LAUTTA)+ The same thing with osm.pbf should omit the name of the ferry route relation from the "bus stop" labels: strings gmapsupp.img |grep 009 KAUPPATORI 0099 SUOMENLINNA 0098+ Strangely, I failed to convert the test.osm to test.osm.pbf: osmosis --rx test.osm --wb test.osm.pbf osmosis --rx test.osm --wb omitmetadata=true test.osm.pbf java -jar mkgmap.jar --gmapsupp --latin1 test.osm.pbf This would produce an empty gmapsupp.img for me (10k or 8k instead of the 92K). I have no idea what goes wrong. Maybe my Osmosis 0.39 is too old? This is the first time I have asked it to write osm.pbf. XML output and PBF and XML input have worked. Best regards, Marko
participants (2)
-
Marko Mäkelä -
WanMil