[PATCH v1] Weird routing failure + possible fix
Hi, Someone has pointed out that the routing doesn't work in this little map. http://www.openstreetmap.org/?lat=30.918&lon=35.112&zoom=9 I have been testing using mapsource, not a gps. If you try and route across road 227, it misses a chunk out on the left hand side. Road 227 contains quite a few points so I tried splitting the road into more than one segment to see if it made a difference using the attached patch. I experimented with different values of MAX_POINTS_IN_WAY and discovered that when using values of approx 250 or more, the gap in the routing appears. As I don't really know what's causing the problem here and what the limit is, I suggest we limit roads to no more than, say, 200 points to avoid this problem. Any thoughts? Cheers, Mark
2009/3/23 Mark Burton <markb@ordern.com>:
I experimented with different values of MAX_POINTS_IN_WAY and discovered that when using values of approx 250 or more, the gap in the routing appears. As I don't really know what's causing the problem here and what the limit is, I suggest we limit roads to no more than, say, 200 points to avoid this problem.
I applied this patch, and also noted at least one weird routing error, similar to the one you describe, disappeared. I have not yet had a chance to do more extensive testing, but I did not notice any other side effects from the patch. Therefore it is most likely safe to assume that this patch can be incorporated into the trunk. Thanks!
Hi Clinton,
I applied this patch, and also noted at least one weird routing error, similar to the one you describe, disappeared.
I have not yet had a chance to do more extensive testing, but I did not notice any other side effects from the patch. Therefore it is most likely safe to assume that this patch can be incorporated into the trunk.
Many thanks for trying that out. The percentage of ways that have more than 200 points must surely be quite low so I don't think there will be a big overhead if we incorporate this patch. Like, it's not going to double the number of ways in our maps. If I get no negative feedback in the next 24H I shall commit it. Cheers, Mark
participants (2)
-
Clinton Gladstone -
Mark Burton