Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch)
Version mkgmap-r4703 was committed by gerd on Tue, 11 May 2021 improve RoadMerger (based on merge-roads-reversed-v6.patch) This has two effects: - it allows RoadMerger to merge roads which build a sharp angle, if that is done an info message is logged - it allows RoadMerger to merge roads with different directions be reversing the order of points if special criteria are met - implement new special tag mkgmap:has-direction=true which tells mkgmap that the direction of the way is important and should not be reversed. The routing tags oneway=yes or oneway=-1 have the same effect, but they also effect routing. Use this tag if you have a TYP file which renders lines different (e.g. cycleway on the right or on the left side) to prevent a reverse merge - implements new experimental option --x-force-reverse-merge Merging with reverse produces smaller maps, esp. smaller NET and NOD files, it may have an influence on routing. Reversing of roads is disabled unless mkgmap detects that the style has at least one rule which adds mkgmap:has-direction=true in rule file lines or option --x-force-reverse-merge is used. The program checks if any line that was added for a given OSM way has the tag mkgmap:has-direction=true. If one is found the tag is propagated to the road(s) for that OSM way so no reversing happens. Roads with different direction attributes are not merged. The option --x-force-reverse-merge is meant for those who don't use a TYP file or don't render left/right attributes with different types. All others should not use the option and adapt the style instead. http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4703
Hi Gerd, I may be misunderstanding this, but the explanation of when it is enabled seems illogical. It seems to me that reversing should be the default except on ways that have mkgmap:has-direction=true unless a switch is given to disable it. Or it could be off by default and a switch enables it, except for ways that have mkgmap:has-direction=true. Cheers, Mike -----Original Message----- From: svn commit [mailto:svn@mkgmap.org.uk] Sent: 11 May 2021 11:22 To: mkgmap-svn@lists.mkgmap.org.uk; mkgmap-dev@lists.mkgmap.org.uk Subject: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch) Version mkgmap-r4703 was committed by gerd on Tue, 11 May 2021 improve RoadMerger (based on merge-roads-reversed-v6.patch) This has two effects: - it allows RoadMerger to merge roads which build a sharp angle, if that is done an info message is logged - it allows RoadMerger to merge roads with different directions be reversing the order of points if special criteria are met - implement new special tag mkgmap:has-direction=true which tells mkgmap that the direction of the way is important and should not be reversed. The routing tags oneway=yes or oneway=-1 have the same effect, but they also effect routing. Use this tag if you have a TYP file which renders lines different (e.g. cycleway on the right or on the left side) to prevent a reverse merge - implements new experimental option --x-force-reverse-merge Merging with reverse produces smaller maps, esp. smaller NET and NOD files, it may have an influence on routing. Reversing of roads is disabled unless mkgmap detects that the style has at least one rule which adds mkgmap:has-direction=true in rule file lines or option --x-force-reverse-merge is used. The program checks if any line that was added for a given OSM way has the tag mkgmap:has-direction=true. If one is found the tag is propagated to the road(s) for that OSM way so no reversing happens. Roads with different direction attributes are not merged. The option --x-force-reverse-merge is meant for those who don't use a TYP file or don't render left/right attributes with different types. All others should not use the option and adapt the style instead. http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4703
Hi Mike, it is off by default because it will cause trouble with some styles / TYP files which rely on the direction but don't set that the new special tag (yet). Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Dienstag, 11. Mai 2021 13:15 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch) Hi Gerd, I may be misunderstanding this, but the explanation of when it is enabled seems illogical. It seems to me that reversing should be the default except on ways that have mkgmap:has-direction=true unless a switch is given to disable it. Or it could be off by default and a switch enables it, except for ways that have mkgmap:has-direction=true. Cheers, Mike -----Original Message----- From: svn commit [mailto:svn@mkgmap.org.uk] Sent: 11 May 2021 11:22 To: mkgmap-svn@lists.mkgmap.org.uk; mkgmap-dev@lists.mkgmap.org.uk Subject: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch) Version mkgmap-r4703 was committed by gerd on Tue, 11 May 2021 improve RoadMerger (based on merge-roads-reversed-v6.patch) This has two effects: - it allows RoadMerger to merge roads which build a sharp angle, if that is done an info message is logged - it allows RoadMerger to merge roads with different directions be reversing the order of points if special criteria are met - implement new special tag mkgmap:has-direction=true which tells mkgmap that the direction of the way is important and should not be reversed. The routing tags oneway=yes or oneway=-1 have the same effect, but they also effect routing. Use this tag if you have a TYP file which renders lines different (e.g. cycleway on the right or on the left side) to prevent a reverse merge - implements new experimental option --x-force-reverse-merge Merging with reverse produces smaller maps, esp. smaller NET and NOD files, it may have an influence on routing. Reversing of roads is disabled unless mkgmap detects that the style has at least one rule which adds mkgmap:has-direction=true in rule file lines or option --x-force-reverse-merge is used. The program checks if any line that was added for a given OSM way has the tag mkgmap:has-direction=true. If one is found the tag is propagated to the road(s) for that OSM way so no reversing happens. Roads with different direction attributes are not merged. The option --x-force-reverse-merge is meant for those who don't use a TYP file or don't render left/right attributes with different types. All others should not use the option and adapt the style instead. http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4703 _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Actually besides rivers all lines can be reversed from level1 onwards - Is that possible or can ways not be reversed if the direction may not be changed in level 0? Also it would be good if adding {add mkgmap:has-direction=true} is only relevant for future lines if continue with_actions is used, but not if continue is used. E.g. if a road has cycleway = lane:left I display it only at resolution 24, however the road itself can be reversed. Just not the cycleway line that is a second line to the left side of the road. The road also is later in my style vs the cycleway. That way maybe some additional lines can be reversed. In general for Austria or Germany this gives pretty nice improvements in map size. For less developed countries the differences are smaller... On Tue, 11 May 2021 at 19:21, Gerd Petermann < gpetermann_muenchen@hotmail.com> wrote:
Hi Mike,
it is off by default because it will cause trouble with some styles / TYP files which rely on the direction but don't set that the new special tag (yet).
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Dienstag, 11. Mai 2021 13:15 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch)
Hi Gerd,
I may be misunderstanding this, but the explanation of when it is enabled seems illogical.
It seems to me that reversing should be the default except on ways that have mkgmap:has-direction=true unless a switch is given to disable it.
Or it could be off by default and a switch enables it, except for ways that have mkgmap:has-direction=true.
Cheers, Mike
-----Original Message----- From: svn commit [mailto:svn@mkgmap.org.uk] Sent: 11 May 2021 11:22 To: mkgmap-svn@lists.mkgmap.org.uk; mkgmap-dev@lists.mkgmap.org.uk Subject: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch)
Version mkgmap-r4703 was committed by gerd on Tue, 11 May 2021
improve RoadMerger (based on merge-roads-reversed-v6.patch) This has two effects: - it allows RoadMerger to merge roads which build a sharp angle, if that is done an info message is logged - it allows RoadMerger to merge roads with different directions be reversing the order of points if special criteria are met - implement new special tag mkgmap:has-direction=true which tells mkgmap that the direction of the way is important and should not be reversed. The routing tags oneway=yes or oneway=-1 have the same effect, but they also effect routing. Use this tag if you have a TYP file which renders lines different (e.g. cycleway on the right or on the left side) to prevent a reverse merge - implements new experimental option --x-force-reverse-merge
Merging with reverse produces smaller maps, esp. smaller NET and NOD files, it may have an influence on routing. Reversing of roads is disabled unless mkgmap detects that the style has at least one rule which adds mkgmap:has-direction=true in rule file lines or option --x-force-reverse-merge is used. The program checks if any line that was added for a given OSM way has the tag mkgmap:has-direction=true. If one is found the tag is propagated to the road(s) for that OSM way so no reversing happens. Roads with different direction attributes are not merged.
The option --x-force-reverse-merge is meant for those who don't use a TYP file or don't render left/right attributes with different types. All others should not use the option and adapt the style instead.
http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4703
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org
Regarding Autorouting - for me the recent changes improved autotourouting a lot. Very often before the route would leave the bicycle route relation and then later go back onto it. Now it follows the routes much better. Aroung 8.5 out of 10 places where routing changed, it changed for the better. Just very few times it chose a sharp angle and a worse way instead. However long distance routes still follow more or less always the same way - but they stick to that way much better. Really great improvment. On Wed, 12 May 2021 at 21:08, Felix Hartmann <extremecarver@gmail.com> wrote:
Actually besides rivers all lines can be reversed from level1 onwards - Is that possible or can ways not be reversed if the direction may not be changed in level 0?
Also it would be good if adding {add mkgmap:has-direction=true} is only relevant for future lines if continue with_actions is used, but not if continue is used. E.g. if a road has cycleway = lane:left I display it only at resolution 24, however the road itself can be reversed. Just not the cycleway line that is a second line to the left side of the road. The road also is later in my style vs the cycleway. That way maybe some additional lines can be reversed.
In general for Austria or Germany this gives pretty nice improvements in map size. For less developed countries the differences are smaller...
On Tue, 11 May 2021 at 19:21, Gerd Petermann < gpetermann_muenchen@hotmail.com> wrote:
Hi Mike,
it is off by default because it will cause trouble with some styles / TYP files which rely on the direction but don't set that the new special tag (yet).
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Dienstag, 11. Mai 2021 13:15 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch)
Hi Gerd,
I may be misunderstanding this, but the explanation of when it is enabled seems illogical.
It seems to me that reversing should be the default except on ways that have mkgmap:has-direction=true unless a switch is given to disable it.
Or it could be off by default and a switch enables it, except for ways that have mkgmap:has-direction=true.
Cheers, Mike
-----Original Message----- From: svn commit [mailto:svn@mkgmap.org.uk] Sent: 11 May 2021 11:22 To: mkgmap-svn@lists.mkgmap.org.uk; mkgmap-dev@lists.mkgmap.org.uk Subject: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch)
Version mkgmap-r4703 was committed by gerd on Tue, 11 May 2021
improve RoadMerger (based on merge-roads-reversed-v6.patch) This has two effects: - it allows RoadMerger to merge roads which build a sharp angle, if that is done an info message is logged - it allows RoadMerger to merge roads with different directions be reversing the order of points if special criteria are met - implement new special tag mkgmap:has-direction=true which tells mkgmap that the direction of the way is important and should not be reversed. The routing tags oneway=yes or oneway=-1 have the same effect, but they also effect routing. Use this tag if you have a TYP file which renders lines different (e.g. cycleway on the right or on the left side) to prevent a reverse merge - implements new experimental option --x-force-reverse-merge
Merging with reverse produces smaller maps, esp. smaller NET and NOD files, it may have an influence on routing. Reversing of roads is disabled unless mkgmap detects that the style has at least one rule which adds mkgmap:has-direction=true in rule file lines or option --x-force-reverse-merge is used. The program checks if any line that was added for a given OSM way has the tag mkgmap:has-direction=true. If one is found the tag is propagated to the road(s) for that OSM way so no reversing happens. Roads with different direction attributes are not merged.
The option --x-force-reverse-merge is meant for those who don't use a TYP file or don't render left/right attributes with different types. All others should not use the option and adapt the style instead.
http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4703
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org
-- Felix Hartman - Openmtbmap.org & VeloMap.org
Hi Felix, I don't understand why you think that the direction is only important at level 0. Doesn't that depend on the TYP file and the style? Still, you are probably right that mkgmap could ignore the direction if that doesn't produce visible differences. We just have to find out if there is a fixed limit or if we need more options or special tags. What I try to avoid is the situation that the road is merged and therefore possibly reduced to a straight line while overlay lines are not merged and possibly zig-zagging along the road. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Mittwoch, 12. Mai 2021 15:08 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch) Actually besides rivers all lines can be reversed from level1 onwards - Is that possible or can ways not be reversed if the direction may not be changed in level 0? Also it would be good if adding {add mkgmap:has-direction=true} is only relevant for future lines if continue with_actions is used, but not if continue is used. E.g. if a road has cycleway = lane:left I display it only at resolution 24, however the road itself can be reversed. Just not the cycleway line that is a second line to the left side of the road. The road also is later in my style vs the cycleway. That way maybe some additional lines can be reversed. In general for Austria or Germany this gives pretty nice improvements in map size. For less developed countries the differences are smaller... On Tue, 11 May 2021 at 19:21, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Mike, it is off by default because it will cause trouble with some styles / TYP files which rely on the direction but don't set that the new special tag (yet). Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Mike Baggaley <mike@tvage.co.uk<mailto:mike@tvage.co.uk>> Gesendet: Dienstag, 11. Mai 2021 13:15 An: mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> Betreff: Re: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch) Hi Gerd, I may be misunderstanding this, but the explanation of when it is enabled seems illogical. It seems to me that reversing should be the default except on ways that have mkgmap:has-direction=true unless a switch is given to disable it. Or it could be off by default and a switch enables it, except for ways that have mkgmap:has-direction=true. Cheers, Mike -----Original Message----- From: svn commit [mailto:svn@mkgmap.org.uk<mailto:svn@mkgmap.org.uk>] Sent: 11 May 2021 11:22 To: mkgmap-svn@lists.mkgmap.org.uk<mailto:mkgmap-svn@lists.mkgmap.org.uk>; mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> Subject: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch) Version mkgmap-r4703 was committed by gerd on Tue, 11 May 2021 improve RoadMerger (based on merge-roads-reversed-v6.patch) This has two effects: - it allows RoadMerger to merge roads which build a sharp angle, if that is done an info message is logged - it allows RoadMerger to merge roads with different directions be reversing the order of points if special criteria are met - implement new special tag mkgmap:has-direction=true which tells mkgmap that the direction of the way is important and should not be reversed. The routing tags oneway=yes or oneway=-1 have the same effect, but they also effect routing. Use this tag if you have a TYP file which renders lines different (e.g. cycleway on the right or on the left side) to prevent a reverse merge - implements new experimental option --x-force-reverse-merge Merging with reverse produces smaller maps, esp. smaller NET and NOD files, it may have an influence on routing. Reversing of roads is disabled unless mkgmap detects that the style has at least one rule which adds mkgmap:has-direction=true in rule file lines or option --x-force-reverse-merge is used. The program checks if any line that was added for a given OSM way has the tag mkgmap:has-direction=true. If one is found the tag is propagated to the road(s) for that OSM way so no reversing happens. Roads with different direction attributes are not merged. The option --x-force-reverse-merge is meant for those who don't use a TYP file or don't render left/right attributes with different types. All others should not use the option and adapt the style instead. http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4703 _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org
Ah true, if the dp filter changes differently it would not be good. I think the key could include the max level for no direction change. Just on add the smaller resolution would need to be considered. However with level 0 dp filter being invisible in changes anyhow, it's really only important for level 1 or higher if direction for continue ways can be merged or not. Also oneway street could be reversed at level 1 or higher. On Wed, 12 May 2021, 22:37 Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote:
Hi Felix,
I don't understand why you think that the direction is only important at level 0. Doesn't that depend on the TYP file and the style? Still, you are probably right that mkgmap could ignore the direction if that doesn't produce visible differences. We just have to find out if there is a fixed limit or if we need more options or special tags. What I try to avoid is the situation that the road is merged and therefore possibly reduced to a straight line while overlay lines are not merged and possibly zig-zagging along the road.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Mittwoch, 12. Mai 2021 15:08 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch)
Actually besides rivers all lines can be reversed from level1 onwards - Is that possible or can ways not be reversed if the direction may not be changed in level 0?
Also it would be good if adding {add mkgmap:has-direction=true} is only relevant for future lines if continue with_actions is used, but not if continue is used. E.g. if a road has cycleway = lane:left I display it only at resolution 24, however the road itself can be reversed. Just not the cycleway line that is a second line to the left side of the road. The road also is later in my style vs the cycleway. That way maybe some additional lines can be reversed.
In general for Austria or Germany this gives pretty nice improvements in map size. For less developed countries the differences are smaller...
On Tue, 11 May 2021 at 19:21, Gerd Petermann < gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Mike,
it is off by default because it will cause trouble with some styles / TYP files which rely on the direction but don't set that the new special tag (yet).
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto: mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Mike Baggaley < mike@tvage.co.uk<mailto:mike@tvage.co.uk>> Gesendet: Dienstag, 11. Mai 2021 13:15 An: mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> Betreff: Re: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch)
Hi Gerd,
I may be misunderstanding this, but the explanation of when it is enabled seems illogical.
It seems to me that reversing should be the default except on ways that have mkgmap:has-direction=true unless a switch is given to disable it.
Or it could be off by default and a switch enables it, except for ways that have mkgmap:has-direction=true.
Cheers, Mike
-----Original Message----- From: svn commit [mailto:svn@mkgmap.org.uk<mailto:svn@mkgmap.org.uk>] Sent: 11 May 2021 11:22 To: mkgmap-svn@lists.mkgmap.org.uk<mailto:mkgmap-svn@lists.mkgmap.org.uk>; mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> Subject: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch)
Version mkgmap-r4703 was committed by gerd on Tue, 11 May 2021
improve RoadMerger (based on merge-roads-reversed-v6.patch) This has two effects: - it allows RoadMerger to merge roads which build a sharp angle, if that is done an info message is logged - it allows RoadMerger to merge roads with different directions be reversing the order of points if special criteria are met - implement new special tag mkgmap:has-direction=true which tells mkgmap that the direction of the way is important and should not be reversed. The routing tags oneway=yes or oneway=-1 have the same effect, but they also effect routing. Use this tag if you have a TYP file which renders lines different (e.g. cycleway on the right or on the left side) to prevent a reverse merge - implements new experimental option --x-force-reverse-merge
Merging with reverse produces smaller maps, esp. smaller NET and NOD files, it may have an influence on routing. Reversing of roads is disabled unless mkgmap detects that the style has at least one rule which adds mkgmap:has-direction=true in rule file lines or option --x-force-reverse-merge is used. The program checks if any line that was added for a given OSM way has the tag mkgmap:has-direction=true. If one is found the tag is propagated to the road(s) for that OSM way so no reversing happens. Roads with different direction attributes are not merged.
The option --x-force-reverse-merge is meant for those who don't use a TYP file or don't render left/right attributes with different types. All others should not use the option and adapt the style instead.
http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4703
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Felix, see https://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4711 I think I see a way to really improve rendering of dual carriage ways. Needs some more experimenting. At the moment only size is reduced in RemoveObsoletePointsFilter, but the new code seems to be able detect dual carriage ways. Work in progress... Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Felix Hartmann <extremecarver@gmail.com> Gesendet: Mittwoch, 12. Mai 2021 16:58 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch) Ah true, if the dp filter changes differently it would not be good. I think the key could include the max level for no direction change. Just on add the smaller resolution would need to be considered. However with level 0 dp filter being invisible in changes anyhow, it's really only important for level 1 or higher if direction for continue ways can be merged or not. Also oneway street could be reversed at level 1 or higher. On Wed, 12 May 2021, 22:37 Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>> wrote: Hi Felix, I don't understand why you think that the direction is only important at level 0. Doesn't that depend on the TYP file and the style? Still, you are probably right that mkgmap could ignore the direction if that doesn't produce visible differences. We just have to find out if there is a fixed limit or if we need more options or special tags. What I try to avoid is the situation that the road is merged and therefore possibly reduced to a straight line while overlay lines are not merged and possibly zig-zagging along the road. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>> im Auftrag von Felix Hartmann <extremecarver@gmail.com<mailto:extremecarver@gmail.com>> Gesendet: Mittwoch, 12. Mai 2021 15:08 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch) Actually besides rivers all lines can be reversed from level1 onwards - Is that possible or can ways not be reversed if the direction may not be changed in level 0? Also it would be good if adding {add mkgmap:has-direction=true} is only relevant for future lines if continue with_actions is used, but not if continue is used. E.g. if a road has cycleway = lane:left I display it only at resolution 24, however the road itself can be reversed. Just not the cycleway line that is a second line to the left side of the road. The road also is later in my style vs the cycleway. That way maybe some additional lines can be reversed. In general for Austria or Germany this gives pretty nice improvements in map size. For less developed countries the differences are smaller... On Tue, 11 May 2021 at 19:21, Gerd Petermann <gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com><mailto:gpetermann_muenchen@hotmail.com<mailto:gpetermann_muenchen@hotmail.com>>> wrote: Hi Mike, it is off by default because it will cause trouble with some styles / TYP files which rely on the direction but don't set that the new special tag (yet). Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk><mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk<mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk>>> im Auftrag von Mike Baggaley <mike@tvage.co.uk<mailto:mike@tvage.co.uk><mailto:mike@tvage.co.uk<mailto:mike@tvage.co.uk>>> Gesendet: Dienstag, 11. Mai 2021 13:15 An: mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> Betreff: Re: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch) Hi Gerd, I may be misunderstanding this, but the explanation of when it is enabled seems illogical. It seems to me that reversing should be the default except on ways that have mkgmap:has-direction=true unless a switch is given to disable it. Or it could be off by default and a switch enables it, except for ways that have mkgmap:has-direction=true. Cheers, Mike -----Original Message----- From: svn commit [mailto:svn@mkgmap.org.uk<mailto:svn@mkgmap.org.uk><mailto:svn@mkgmap.org.uk<mailto:svn@mkgmap.org.uk>>] Sent: 11 May 2021 11:22 To: mkgmap-svn@lists.mkgmap.org.uk<mailto:mkgmap-svn@lists.mkgmap.org.uk><mailto:mkgmap-svn@lists.mkgmap.org.uk<mailto:mkgmap-svn@lists.mkgmap.org.uk>>; mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> Subject: [mkgmap-dev] Commit r4703: improve RoadMerger (based on merge-roads-reversed-v6.patch) Version mkgmap-r4703 was committed by gerd on Tue, 11 May 2021 improve RoadMerger (based on merge-roads-reversed-v6.patch) This has two effects: - it allows RoadMerger to merge roads which build a sharp angle, if that is done an info message is logged - it allows RoadMerger to merge roads with different directions be reversing the order of points if special criteria are met - implement new special tag mkgmap:has-direction=true which tells mkgmap that the direction of the way is important and should not be reversed. The routing tags oneway=yes or oneway=-1 have the same effect, but they also effect routing. Use this tag if you have a TYP file which renders lines different (e.g. cycleway on the right or on the left side) to prevent a reverse merge - implements new experimental option --x-force-reverse-merge Merging with reverse produces smaller maps, esp. smaller NET and NOD files, it may have an influence on routing. Reversing of roads is disabled unless mkgmap detects that the style has at least one rule which adds mkgmap:has-direction=true in rule file lines or option --x-force-reverse-merge is used. The program checks if any line that was added for a given OSM way has the tag mkgmap:has-direction=true. If one is found the tag is propagated to the road(s) for that OSM way so no reversing happens. Roads with different direction attributes are not merged. The option --x-force-reverse-merge is meant for those who don't use a TYP file or don't render left/right attributes with different types. All others should not use the option and adapt the style instead. http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4703 _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk><mailto:mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk>> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk<mailto:mkgmap-dev@lists.mkgmap.org.uk> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
participants (4)
-
Felix Hartmann -
Gerd Petermann -
Mike Baggaley -
svn commit