Commit: r1877: Allow different smoothing parameters for polygons and lines.
Version 1877 was commited by steve on 2011-03-02 11:17:38 +0000 (Wed, 02 Mar 2011) Allow different smoothing parameters for polygons and lines. It applies the DP filter against polygons with a different agressiveness than for lines. This is really useful because strong DP filter against lines looks really bad, while for polygons the visual quality is degraded less. Implements a new option --reduce-point-density-polygon - Johann Gail Documentation added to the help file - Felix Hartmann
On 02.03.2011 14:11, Minko wrote:
Where can I find the help file? help/en/options
or showing it on commandline (see mkgmap on osm wiki).
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Ok, couldnt find help/en/options in the tar.gz, had to look in the src.tar.gz version, thanks.
I've now tested r1877 but noticed almost all the forests in the Netherlands are completely gone at resolution 18 :-( I've tried it with and without --reduce-point-density-polygon but it seems to have no effect. Is there a way to set this parameter off?
On 03.03.2011 12:57, Minko wrote:
I've now tested r1877 but noticed almost all the forests in the Netherlands are completely gone at resolution 18 :-( I've tried it with and without --reduce-point-density-polygon but it seems to have no effect. Is there a way to set this parameter off?
This has nothing to do with this patch. It is related to "drop small polygons" ( as introduced in rev. 1875). You can make the values smaller (so 2 or 3 instead of 8). Look at the changes. The netherlands are the only country with such problems, as contrary to everywhere you're forests are not placed into big multipolygons but consists of small patches. Reduce-point-density-polygon is a completly different affair. It allows you to set different dp-filter strength against lines vs polygons.
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Felix, You have recently introduced so many changes I can't figure out anymore what is causing what. How can I change the settings of "drop small polygons"? It's not described in the help files.
On 03.03.2011 14:54, Minko wrote:
Felix, You have recently introduced so many changes I can't figure out anymore what is causing what. How can I change the settings of "drop small polygons"? It's not described in the help files.
Read rev 1875, and change the 8 to a smaller value. You have to do it in source and compile mkgmap yourself of course.
Hi Felix, Could you please be more specific. I never had to compile mkgmap before. Is it possible to use an option --drop small polygons for this? The rendering is now far from ideal for the Dutch folks, I would like to turn this option "drop small polygons" off without having to compile mkgmap. Thanks, Minko Felix wrote: Read rev 1875, and change the 8 to a smaller value. You have to do it in source and compile mkgmap yourself of course.
I Hope there is a way to turn it off. I like forests and national parks, etc coming in at zoom 16 so I can get the big picture on what's around. I think it should be the style file that sets when things should be displayed. -----Original Message----- From: mkgmap-dev-bounces@lists.mkgmap.org.uk [mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk] On Behalf Of Minko Sent: Thursday, 3 March 2011 10:27 PM To: Development list for mkgmap Subject: Re: [mkgmap-dev] Commit: r1877: Allow different smoothing parameters for polygons and lines. I've now tested r1877 but noticed almost all the forests in the Netherlands are completely gone at resolution 18 :-( I've tried it with and without --reduce-point-density-polygon but it seems to have no effect. Is there a way to set this parameter off? _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Am 03.03.2011 13:35, schrieb Markus_g:
I Hope there is a way to turn it off. I like forests and national parks, etc coming in at zoom 16 so I can get the big picture on what's around. I think it should be the style file that sets when things should be displayed.
At the moment there is no possibility to turn it of. I am working on a patch for it.
Am 03.03.2011 20:11, schrieb Johann Gail:
Am 03.03.2011 13:35, schrieb Markus_g:
I Hope there is a way to turn it off. I like forests and national parks, etc coming in at zoom 16 so I can get the big picture on what's around. I think it should be the style file that sets when things should be displayed.
At the moment there is no possibility to turn it of. I am working on a patch for it.
Here follows the patch. Im not sure of the name of the option. I have called it --min-size-polygon=NUM. Maybe a better name would be --remove-small-polygons=NUM. Any suggestions for it? If no option is set, then the default is zero, which means the same behaviour as before the 'small polygon patch' Feel free to check it in into the trunk. Regards, Johann
Thankyou. I like it that if no option is set that it will behave as before the small polygon patch. It is good also that we can play around with the setting. Regards, Markus_g -----Original Message----- From: mkgmap-dev-bounces@lists.mkgmap.org.uk [mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk] On Behalf Of Johann Gail Sent: Friday, 4 March 2011 7:08 AM To: Development list for mkgmap Subject: Re: [mkgmap-dev] Commit: r1877: Allow different smoothing parameters for polygons and lines. Am 03.03.2011 20:11, schrieb Johann Gail:
Am 03.03.2011 13:35, schrieb Markus_g:
I Hope there is a way to turn it off. I like forests and national parks, etc coming in at zoom 16 so I can get the big picture on what's around. I think it should be the style file that sets when things should be displayed.
At the moment there is no possibility to turn it of. I am working on a patch for it.
Here follows the patch. Im not sure of the name of the option. I have called it --min-size-polygon=NUM. Maybe a better name would be --remove-small-polygons=NUM. Any suggestions for it? If no option is set, then the default is zero, which means the same behaviour as before the 'small polygon patch' Feel free to check it in into the trunk. Regards, Johann
Am 03.03.2011 21:38, schrieb Johann Gail:
Am 03.03.2011 20:11, schrieb Johann Gail:
Am 03.03.2011 13:35, schrieb Markus_g:
I Hope there is a way to turn it off. I like forests and national parks, etc coming in at zoom 16 so I can get the big picture on what's around. I think it should be the style file that sets when things should be displayed.
At the moment there is no possibility to turn it of. I am working on a patch for it.
Here follows the patch. Im not sure of the name of the option. I have called it --min-size-polygon=NUM. Maybe a better name would be --remove-small-polygons=NUM. Any suggestions for it?
If no option is set, then the default is zero, which means the same behaviour as before the 'small polygon patch'
Feel free to check it in into the trunk.
Regards, Johann
Hi Steve or Wanmil, (or any other with write access) could you please check in this patch to the repository? So the default behaviour is the same as before. Regards, Johann
could you please check in this patch to the repository? So the default behaviour is the same as before.
Regards, Johann _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Sure, I'd prefer that the default be a value that creates a better map in most cases rather than the previous behaviour. ..Steve
participants (6)
-
Felix Hartmann -
Johann Gail -
Markus_g -
Minko -
Steve Ratcliffe -
svn commit