Hi, I just stumbled over this special case in the test data mkgmap\test\resources\in\mp\test1.mp : ; WayID = 23809417 ; building=yes ; ERROR: WayID=23809417 area is not closed [POLYGON] Type=0x13 Data0=(51.5270965,-0.1008803), (51.5271606,-0.100537), (51.5272514,-0.1005885), (51.527198,-0.1008803), (51.5271179,-0.1008803) [END] As the comment says, this polygon is not closed. The trunk version ignores this error and creates a shape. Is this intended? Gerd
Hi Gerd,
As the comment says, this polygon is not closed. The trunk version ignores this error and creates a shape. Is this intended?
Yes, this is standard for polish format. Cgpsmapper would probably complain if you close a polygon. I think there are still some basic problems with mkgmap regarding polish format. For example: [POLYLINE] .... Data0=.... Data0=.... [END] This object should create 2 separate lines, I think mkgmap connects them, which is wrong. [POLYGON] .... Data0=.... Data0=.... [END] First "Data" should be treated as outer polygon, second and following as inner (hole). I'm not sure, what is doing mkgmap but i remember that something is wrong with polygons too, there are wrong shapes on map. -- Best regards, Andrzej
Hi Andrzej,
As the comment says, this polygon is not closed. The trunk version ignores this error and creates a shape. Is this intended?
Yes, this is standard for polish format. Cgpsmapper would probably complain if you close a polygon.
okay, that should work now in branch r2993.
I think there are still some basic problems with mkgmap regarding polish format. For example:
[POLYLINE] .... Data0=.... Data0=.... [END]
This object should create 2 separate lines, I think mkgmap connects them, which is wrong.
yes, it connects them and writes an error message. Can you give an example ? I did not find a hint in the version 2.5 docu for cgpsmapper.
[POLYGON] .... Data0=.... Data0=.... [END]
First "Data" should be treated as outer polygon, second and following as inner (hole). I'm not sure, what is doing mkgmap but i remember that something is wrong with polygons too, there are wrong shapes on map.
Probably, because mkgmap simply adds all points to one list of points. I assume we would need a procedure like that for mp relations. Maybe I'll have a look at that later. Gerd
Hi Gerd,
This object should create 2 separate lines, I think mkgmap connects them, which is wrong. yes, it connects them and writes an error message. Can you give an example ? I did not find a hint in the version 2.5 docu for cgpsmapper.
Neither I can find. This could be unintended feature but this kind of data creates GPSMapEdit, when splitting or cropping a map. Note, that cgpsmapper doesn't allow for multiple Data0 in routable polylines. For this case there is option in GPSMapEdit "Split Multi-Element Routable Roads". There is no tool for splitting non-routable polylines, probably because cgpsmapper can cope with them. It would be useful, if mkgmap could replicate cgpsmapper behavior here. Actually standard feature for cgpsmapper is to have multiple Data statements for different levels, like this: Data0=... Data1=... Data2=... I think that support for Data statements could be the same, regardless of level number in Data. Only exception would be Data0 for routable polyline. -- Best regards, Andrzej
participants (2)
-
Andrzej Popowski -
Gerd Petermann