On http://forum.openstreetmap.org/viewtopic.php?id=13257&p=3 a few suggestions were posted to improve the routing: Maybe Marko can have a look at this to see if this can be added to the default style? * highway=construction Be careful with construction=minor. http://wiki.openstreetmap.org/wiki/Key:construction "Additionally construction=minor can be used for existing highways which will be modified or repaired without being closed. In this case we don't set highway=construction but leave it at its default value. " So you will brake routing. I think that highway=construction | (highway=* & construction=* & construction!=minor & construction!=no) {add access = no; add bicycle = yes; add foot = yes; add mkgmap:dead-end-check = false } [0x16 road_class=0 road_speed=1 resolution 23] will fix it. * motor_vehicle / vehicle One thing I really miss in the default mkgmap style as well as "world" style, which I've added my own style, is the ability to obey the motor_vehicle and vehicle tags when routing. The two lines below is the one I use, you might certainly have a more effective way to get the work done. highway=* & (motor_vehicle=no | motor_vehicle=destination | motor_vehicle=agricultural | motor_vehicle=private) { add motorcar=no } highway=* & (vehicle=no | vehicle=destination | vehicle=agricultural | vehicle=private) { add motorcar=no }
Thanks Minko, the suggestions look reasonable to me. I responded to the thread, advertising the TYP compiler branch too, hoping to attract other testers for it. I had to fix some coastline issues this weekend, and could not proceed with splitting the default style yet. I will implement the routing improvement suggestions first. Best regards, Marko
Perhaps we should also reduce roadspeed for construction = minor highway=* & construction=minor [0x16 road_speed=3 resolution 22] ? http://forum.openstreetmap.org/viewtopic.php?pid=202133#p202133
On Mon, Nov 14, 2011 at 02:11:37AM +0100, flabot@googlemail.com wrote:
Perhaps we should also reduce roadspeed for construction = minor
highway=* & construction=minor [0x16 road_speed=3 resolution 22] ?
What about construction=minor on a tertiary or lesser road? That should not increase the road_speed, but decrease it. I think that the construction=minor needs more thought. I would say that road_speed=1 is a bearable compromise, as long as we do not break routing. Even with minor construction, one of the lanes could be closed, slowing the effective speed. Marko
On Sun, Nov 13, 2011 at 06:37:53PM +0100, Minko wrote:
* highway=construction
I would suggest this, which would not grant or forbid access, but only lower the road_class and road_speed: -# Treat ways under construction as highway=path -highway=construction | highway=* & construction=* {add access = no; add bicycle = yes; add foot = yes; add mkgmap:dead-end-check = false } [0x16 road_class=0 road_speed=1 resolution 23] +# Treat ways under construction specially +highway=construction { add mkgmap:dead-end-check = false } [0x16 road_class=0 road_speed=0 resolution 23] +highway=* & construction=* [0x16 road_class=1 road_speed=1 resolution 23]
* motor_vehicle / vehicle
One thing I really miss in the default mkgmap style as well as "world" style, which I've added my own style, is the ability to obey the motor_vehicle and vehicle tags when routing. The two lines below is the one I use, you might certainly have a more effective way to get the work done.
In the mkgmap or Garmin context, a vehicle can be a motor_vehicle (motorcar) or a bicycle. I would suggest the following: Index: resources/styles/default/lines =================================================================== --- resources/styles/default/lines (revision 2091) +++ resources/styles/default/lines (working copy) @@ -98,6 +98,10 @@ contour=elevation | contour_ext=elevatio # Remove access=yes from highways. highway=* & access=yes { delete access } +# Translate motor_vehicle and vehicle access rules. +highway=* & motor_vehicle=* { add motorcar='${motor_vehicle}' } +highway=* & vehicle=* { add motorcar='${vehicle}'; add bicycle='${vehicle}' } + # By default, ways are accessible by the highest allowed mode of # transportation, and thus access=yes should be redundant. # However, sometimes cycleways may be tagged access=destination or # similar, Can you try these out? I will post this also to the forum. Best regards, Marko
El 15/11/11 22:19, Marko Mäkelä escribió:
On Sun, Nov 13, 2011 at 06:37:53PM +0100, Minko wrote:
* highway=construction
I would suggest this, which would not grant or forbid access, but only lower the road_class and road_speed:
-# Treat ways under construction as highway=path -highway=construction | highway=*& construction=* {add access = no; add bicycle = yes; add foot = yes; add mkgmap:dead-end-check = false } [0x16 road_class=0 road_speed=1 resolution 23] +# Treat ways under construction specially +highway=construction { add mkgmap:dead-end-check = false } [0x16 road_class=0 road_speed=0 resolution 23] +highway=*& construction=* [0x16 road_class=1 road_speed=1 resolution 23]
Perhaps mkgmap:road-speed could be a good option: highway=* & construction=* { add mkgmap:road-speed = '-1'; add mkgmap:road-speed-min = '1' }
* motor_vehicle / vehicle
One thing I really miss in the default mkgmap style as well as "world" style, which I've added my own style, is the ability to obey the motor_vehicle and vehicle tags when routing. The two lines below is the one I use, you might certainly have a more effective way to get the work done.
In the mkgmap or Garmin context, a vehicle can be a motor_vehicle (motorcar) or a bicycle. I would suggest the following:
Index: resources/styles/default/lines =================================================================== --- resources/styles/default/lines (revision 2091) +++ resources/styles/default/lines (working copy) @@ -98,6 +98,10 @@ contour=elevation | contour_ext=elevatio
# Remove access=yes from highways. highway=*& access=yes { delete access } +# Translate motor_vehicle and vehicle access rules. +highway=*& motor_vehicle=* { add motorcar='${motor_vehicle}' } +highway=*& vehicle=* { add motorcar='${vehicle}'; add bicycle='${vehicle}' } + # By default, ways are accessible by the highest allowed mode of # transportation, and thus access=yes should be redundant. # However, sometimes cycleways may be tagged access=destination or # similar,
Can you try these out? I will post this also to the forum.
Best regards,
Marko _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Por favor, no me envíe documentos con extensiones .doc, .docx, .xls, .xlsx, .ppt, .pptx, .mdb, mdbx Instale LibreOffice desde http://es.libreoffice.org/descarga/ LibreOffice es libre: se puede copiar, modificar y redistribuir libremente. Gratis y totalmente legal. LibreOffice está en continuo desarrollo y no tendrá que pagar por las nuevas versiones.
I read http://wiki.openstreetmap.org/wiki/Key:construction construction=minor means that a road can be driven but at lower speed. construction=yes mean that a road with the roadtype highway=* will be build, and you cant drive it at the moment with an car. Thats the way i unterstand the wiki. I think we could set roadspeed to zero for every thing exact construction=yes, and construction=yes should lower the roadspeed. Dirk
On Tue, Nov 15, 2011 at 11:38:45PM +0100, flabot@googlemail.com wrote:
I read http://wiki.openstreetmap.org/wiki/Key:construction
construction=minor means that a road can be driven but at lower speed. construction=yes mean that a road with the roadtype highway=* will be build, and you cant drive it at the moment with an car.
Isn't highway=proposed for this? I replied on the forum in more detail: http://forum.openstreetmap.org/viewtopic.php?id=13257
I think we could set roadspeed to zero for every thing exact construction=yes, and construction=yes should lower the roadspeed.
How does lowering the roadspeed work? Carlos Dávila suggested the same:
Perhaps mkgmap:road-speed could be a good option: highway=* & construction=* { add mkgmap:road-speed = '-1'; add mkgmap:road-speed-min = '1' }
How does this work? I did not follow the discussions when this was implemented, because my personal itch has always been bicycle routing. Marko
El 16/11/11 09:26, Marko Mäkelä escribió:
On Tue, Nov 15, 2011 at 11:38:45PM +0100, flabot@googlemail.com wrote:
I read http://wiki.openstreetmap.org/wiki/Key:construction
construction=minor means that a road can be driven but at lower speed. construction=yes mean that a road with the roadtype highway=* will be build, and you cant drive it at the moment with an car.
Isn't highway=proposed for this? I replied on the forum in more detail: http://forum.openstreetmap.org/viewtopic.php?id=13257
I think we could set roadspeed to zero for every thing exact construction=yes, and construction=yes should lower the roadspeed.
How does lowering the roadspeed work? Carlos Dávila suggested the same:
Perhaps mkgmap:road-speed could be a good option: highway=*& construction=* { add mkgmap:road-speed = '-1'; add mkgmap:road-speed-min = '1' }
How does this work? I did not follow the discussions when this was implemented, because my personal itch has always been bicycle routing. From Mark Burton email dated on 14/10/2009:
v2 - you can now have mkgmap:road-class-min and mkgmap:road-class-max tags (and the same for the road speed) that will limit the final value used. These can either be added to the POI (from whence they will be transferred to the way by mkgmap) or directly to the way. --------------------- V1 - This is something that was briefly discussed not too long ago and the idea is that a road's speed or class can be modified by the presence of a POI that defines new values for either/both of them. This, hopefully, will make ways that have stuff like traffic signals and crossings, etc. less attractive to route over. The values are specified using mkgmap:road-speed and mkgmap:road-class tags added to the POI. These tags expect an integer value, optionally preceded by a + or - which make the adjustment relative to the original value. For example, mkgmap:road-speed=3 sets the speed to 3 and mkgmap:road-speed=-1 reduces the speed by 1 from whatever value it had before. Here's some possible rules for the points file: highway=traffic_signals { add mkgmap:road-speed = '-1' } highway=crossing { add mkgmap:road-speed = '-1' } highway=mini_roundabout { add mkgmap:road-speed = '1' } The region of the way that has its speed/class modified is limited to the closest points either side of the POI. Not sure if that's the right thing to do yet. Needs playing with. You need to specify the --link-pois-to-ways option to enable this functionality. It was commited as rev 1278 (use svn log -r 1278 for more info).
Marko, I've tested the rules for (motor_)vehicle, seems to work well in Mapsource. It does not work in Basecamp but that is another issue. The fact that bicycles are also a vehicle is not widely known, so this changed routing will cause some confusion.
Hi Minko,
I've tested the rules for (motor_)vehicle, seems to work well in Mapsource. It does not work in Basecamp but that is another issue.
Thank you, I will commit it then. When it comes to the highway=construction or construction=*, I will wait for some feedback first.
The fact that bicycles are also a vehicle is not widely known, so this changed routing will cause some confusion.
I thought that it was common knowledge. It is also mentioned in the wiki: http://wiki.openstreetmap.org/wiki/Key:access Anyway, I guess that bicyclists need to improvise from time to time. Cycleways are not always drawn on the map, or they are just short sections that do no good for long journeys. When there is a cycleway roughly parallel to a bigger road, you usually need to look ahead in the map if it is worth using (unless your legislation and law enforcement says that it must be used, no matter what). I have done up to 180km day trips by bicycle. Marko
participants (4)
-
Carlos Dávila -
flabot＠googlemail.com -
Marko Mäkelä -
Minko