[Patch v4] sharp angles
Hi all, attached is v4 of the patch. Changes: 1) The option --x--fix-sharp-angles is gone. 2) A new option --x-ignore-sharp-angles can be used to disable the code that enlarges sharp angles 3) The option --cylcle-map is now documented (not in detail, as I still work them out). Please try if the option improves routing in cycle maps. It allows changes up to 112° instead of only 45°. 4) known errors were fixed: - use sum of speeds - take into account that values maybe rounded when calculating the new heading(s) A binary is here: http://files.mkgmap.org.uk/download/282/mkgmap.jar Gerd
El 07/09/15 a las 17:42, Gerd Petermann escribió:
Hi all,
attached is v4 of the patch. Changes: 1) The option --x--fix-sharp-angles is gone. 2) A new option --x-ignore-sharp-angles can be used to disable the code that enlarges sharp angles 3) The option --cylcle-map is now documented (not in detail, as I still work them out). Please try if the option improves routing in cycle maps. It allows changes up to 112° instead of only 45°. 4) known errors were fixed: - use sum of speeds - take into account that values maybe rounded when calculating the new heading(s)
A binary is here: |http://files.mkgmap.org.uk/download/282/mkgmap.jar| Trying to build mkgmap with patch I get the following errors: Compiling 496 source files to /home/carlos/Paquetes/mkgmap/build/classes [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:422: error: class, interface, or enum expected [javac] package uk.me.parabola.imgfmt.app.net; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:424: error: class, interface, or enum expected [javac] import java.util.ArrayList; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:425: error: class, interface, or enum expected [javac] import java.util.Collections; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:426: error: class, interface, or enum expected [javac] import java.util.Comparator; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:427: error: class, interface, or enum expected [javac] import java.util.HashSet; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:428: error: class, interface, or enum expected [javac] import java.util.Iterator; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:429: error: class, interface, or enum expected [javac] import java.util.List; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:430: error: class, interface, or enum expected [javac] import java.util.Map; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:432: error: class, interface, or enum expected [javac] import uk.me.parabola.log.Logger; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:433: error: class, interface, or enum expected [javac] import uk.me.parabola.util.EnhancedProperties;
Hi Carlos, I've no access to my dev machine. Please use a clean checkout and check if the patch is applied without error messages. If that is okay, use ant clean dist to do a clean build. Gerd Carlos Dávila-2 wrote
El 07/09/15 a las 17:42, Gerd Petermann escribió:
Hi all,
attached is v4 of the patch. Changes: 1) The option --x--fix-sharp-angles is gone. 2) A new option --x-ignore-sharp-angles can be used to disable the code that enlarges sharp angles 3) The option --cylcle-map is now documented (not in detail, as I still work them out). Please try if the option improves routing in cycle maps. It allows changes up to 112° instead of only 45°. 4) known errors were fixed: - use sum of speeds - take into account that values maybe rounded when calculating the new heading(s)
A binary is here: |http://files.mkgmap.org.uk/download/282/mkgmap.jar| Trying to build mkgmap with patch I get the following errors: Compiling 496 source files to /home/carlos/Paquetes/mkgmap/build/classes [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:422: error: class, interface, or enum expected [javac] package uk.me.parabola.imgfmt.app.net; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:424: error: class, interface, or enum expected [javac] import java.util.ArrayList; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:425: error: class, interface, or enum expected [javac] import java.util.Collections; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:426: error: class, interface, or enum expected [javac] import java.util.Comparator; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:427: error: class, interface, or enum expected [javac] import java.util.HashSet; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:428: error: class, interface, or enum expected [javac] import java.util.Iterator; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:429: error: class, interface, or enum expected [javac] import java.util.List; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:430: error: class, interface, or enum expected [javac] import java.util.Map; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:432: error: class, interface, or enum expected [javac] import uk.me.parabola.log.Logger; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:433: error: class, interface, or enum expected [javac] import uk.me.parabola.util.EnhancedProperties;
mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context: http://gis.19327.n5.nabble.com/Patch-v4-sharp-angles-tp5854127p5854828.html Sent from the Mkgmap Development mailing list archive at Nabble.com.
I had already done an ant clean dist build, but it didn't work. It seems some "not clean" file remains with that method, as using a clean checkout did solve the problem. El 16/09/15 a las 08:15, GerdP escribió:
Hi Carlos,
I've no access to my dev machine. Please use a clean checkout and check if the patch is applied without error messages. If that is okay, use ant clean dist to do a clean build.
Gerd
Carlos Dávila-2 wrote
El 07/09/15 a las 17:42, Gerd Petermann escribió:
Hi all,
attached is v4 of the patch. Changes: 1) The option --x--fix-sharp-angles is gone. 2) A new option --x-ignore-sharp-angles can be used to disable the code that enlarges sharp angles 3) The option --cylcle-map is now documented (not in detail, as I still work them out). Please try if the option improves routing in cycle maps. It allows changes up to 112° instead of only 45°. 4) known errors were fixed: - use sum of speeds - take into account that values maybe rounded when calculating the new heading(s)
A binary is here: |http://files.mkgmap.org.uk/download/282/mkgmap.jar| Trying to build mkgmap with patch I get the following errors: Compiling 496 source files to /home/carlos/Paquetes/mkgmap/build/classes [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:422: error: class, interface, or enum expected [javac] package uk.me.parabola.imgfmt.app.net; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:424: error: class, interface, or enum expected [javac] import java.util.ArrayList; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:425: error: class, interface, or enum expected [javac] import java.util.Collections; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:426: error: class, interface, or enum expected [javac] import java.util.Comparator; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:427: error: class, interface, or enum expected [javac] import java.util.HashSet; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:428: error: class, interface, or enum expected [javac] import java.util.Iterator; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:429: error: class, interface, or enum expected [javac] import java.util.List; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:430: error: class, interface, or enum expected [javac] import java.util.Map; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:432: error: class, interface, or enum expected [javac] import uk.me.parabola.log.Logger; [javac] ^ [javac] /home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:433: error: class, interface, or enum expected [javac] import uk.me.parabola.util.EnhancedProperties;
For me the patch worked without problems. @Carlos - best do a clean checkout of the whole mkgmap SVN. (my way to apply patches is the following - copy my clean directory - then apply the patch on the copy. If a newer version comes out - delete the patched directory - and copy the clean directory again). My clean directory only has some patches that I use all the time (basically some copyright patch because I was too lazy still to change the copyright txt file, and some display priority patch so that maps have priority 31 by default not 25). It's a bit tedious but I would not know how to remove a patch quickly and safe. On 16 September 2015 at 09:58, Carlos Dávila <cdavilam@orangecorreo.es> wrote:
I had already done an ant clean dist build, but it didn't work. It seems some "not clean" file remains with that method, as using a clean checkout did solve the problem.
El 16/09/15 a las 08:15, GerdP escribió:
Hi Carlos,
I've no access to my dev machine. Please use a clean checkout and check if the patch is applied without error messages. If that is okay, use ant clean dist to do a clean build.
Gerd
Carlos Dávila-2 wrote
El 07/09/15 a las 17:42, Gerd Petermann escribió:
Hi all,
attached is v4 of the patch. Changes: 1) The option --x--fix-sharp-angles is gone. 2) A new option --x-ignore-sharp-angles can be used to disable the code that enlarges sharp angles 3) The option --cylcle-map is now documented (not in detail, as I still work them out). Please try if the option improves routing in cycle maps. It allows changes up to 112° instead of only 45°. 4) known errors were fixed: - use sum of speeds - take into account that values maybe rounded when calculating the new heading(s)
A binary is here: |http://files.mkgmap.org.uk/download/282/mkgmap.jar|
Trying to build mkgmap with patch I get the following errors: Compiling 496 source files to /home/carlos/Paquetes/mkgmap/build/classes [javac]
/home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:422: error: class, interface, or enum expected [javac] package uk.me.parabola.imgfmt.app.net; [javac] ^ [javac]
/home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:424: error: class, interface, or enum expected [javac] import java.util.ArrayList; [javac] ^ [javac]
/home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:425: error: class, interface, or enum expected [javac] import java.util.Collections; [javac] ^ [javac]
/home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:426: error: class, interface, or enum expected [javac] import java.util.Comparator; [javac] ^ [javac]
/home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:427: error: class, interface, or enum expected [javac] import java.util.HashSet; [javac] ^ [javac]
/home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:428: error: class, interface, or enum expected [javac] import java.util.Iterator; [javac] ^ [javac]
/home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:429: error: class, interface, or enum expected [javac] import java.util.List; [javac] ^ [javac]
/home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:430: error: class, interface, or enum expected [javac] import java.util.Map; [javac] ^ [javac]
/home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:432: error: class, interface, or enum expected [javac] import uk.me.parabola.log.Logger; [javac] ^ [javac]
/home/carlos/Paquetes/mkgmap/src/uk/me/parabola/imgfmt/app/net/AngleChecker.java:433: error: class, interface, or enum expected [javac] import uk.me.parabola.util.EnhancedProperties;
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Floragasse 9/11 1040 Wien Austria - Österreich
El 07/09/15 a las 17:42, Gerd Petermann escribió:
Hi all,
attached is v4 of the patch. Changes: 1) The option --x--fix-sharp-angles is gone. 2) A new option --x-ignore-sharp-angles can be used to disable the code that enlarges sharp angles 3) The option --cylcle-map is now documented (not in detail, as I still work them out). Please try if the option improves routing in cycle maps. It allows changes up to 112° instead of only 45°. 4) known errors were fixed: - use sum of speeds - take into account that values maybe rounded when calculating the new heading(s) I have tested the patch and I find it doesn't avoid the "spurious instructions to "keep right/left" when the road doesn't actually fork". My test case is a route from SW to NE along A-471 (http://www.openstreetmap.org/#map=12/36.8685/-6.1225&layers=T) where I get several unnecessary keep right/left instructions at crossings with sharp angle links leaving A-471, such as the one at http://www.openstreetmap.org/#map=18/36.77762/-6.27642&layers=T The number of these unnecessary instructions is lower than without the patch (6 vs 9). The map is produced with a general purpose style, not a cyclist one.
okay - I tested around a bit more. Using v4 patch and cycle-map option - there was again rather no improvment. I did test out v4 patch without cycle map - and at least for my maps that seems to turn out better routing results (not always better streets, but on the same streets faster arrival times). So I guess v4 and no --cycle-map is what I'm going to use. On 16 September 2015 at 12:15, Carlos Dávila <cdavilam@orangecorreo.es> wrote:
El 07/09/15 a las 17:42, Gerd Petermann escribió:
Hi all,
attached is v4 of the patch. Changes: 1) The option --x--fix-sharp-angles is gone. 2) A new option --x-ignore-sharp-angles can be used to disable the code that enlarges sharp angles 3) The option --cylcle-map is now documented (not in detail, as I still work them out). Please try if the option improves routing in cycle maps. It allows changes up to 112° instead of only 45°. 4) known errors were fixed: - use sum of speeds - take into account that values maybe rounded when calculating the new heading(s)
I have tested the patch and I find it doesn't avoid the "spurious instructions to "keep right/left" when the road doesn't actually fork". My test case is a route from SW to NE along A-471 ( http://www.openstreetmap.org/#map=12/36.8685/-6.1225&layers=T) where I get several unnecessary keep right/left instructions at crossings with sharp angle links leaving A-471, such as the one at http://www.openstreetmap.org/#map=18/36.77762/-6.27642&layers=T The number of these unnecessary instructions is lower than without the patch (6 vs 9). The map is produced with a general purpose style, not a cyclist one.
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-- Felix Hartman - Openmtbmap.org & VeloMap.org Floragasse 9/11 1040 Wien Austria - Österreich
Hi Felix, thanks for testing. Please post a sample where --cycle-map is worse compared to no-cycle-map. Gerd Date: Wed, 16 Sep 2015 14:12:42 +0200 From: extremecarver@gmail.com To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] [Patch v4] sharp angles okay - I tested around a bit more. Using v4 patch and cycle-map option - there was again rather no improvment. I did test out v4 patch without cycle map - and at least for my maps that seems to turn out better routing results (not always better streets, but on the same streets faster arrival times). So I guess v4 and no --cycle-map is what I'm going to use. On 16 September 2015 at 12:15, Carlos Dávila <cdavilam@orangecorreo.es> wrote: El 07/09/15 a las 17:42, Gerd Petermann escribió: Hi all, attached is v4 of the patch. Changes: 1) The option --x--fix-sharp-angles is gone. 2) A new option --x-ignore-sharp-angles can be used to disable the code that enlarges sharp angles 3) The option --cylcle-map is now documented (not in detail, as I still work them out). Please try if the option improves routing in cycle maps. It allows changes up to 112° instead of only 45°. 4) known errors were fixed: - use sum of speeds - take into account that values maybe rounded when calculating the new heading(s) I have tested the patch and I find it doesn't avoid the "spurious instructions to "keep right/left" when the road doesn't actually fork". My test case is a route from SW to NE along A-471 (http://www.openstreetmap.org/#map=12/36.8685/-6.1225&layers=T) where I get several unnecessary keep right/left instructions at crossings with sharp angle links leaving A-471, such as the one at http://www.openstreetmap.org/#map=18/36.77762/-6.27642&layers=T The number of these unnecessary instructions is lower than without the patch (6 vs 9). The map is produced with a general purpose style, not a cyclist one. _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -- Felix Hartman - Openmtbmap.org & VeloMap.org Floragasse 9/11 1040 Wien Austria - Österreich _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
participants (4)
-
Carlos Dávila -
Felix Hartmann -
Gerd Petermann -
GerdP