Commit: r1059: New approach to the too many nodes in region problem - carry on regardless.
Version 1059 was commited by markb on 2009-06-03 17:34:08 +0100 (Wed, 03 Jun 2009) New approach to the too many nodes in region problem - carry on regardless. Now, instead of croaking when too many nodes are in a region, it throws them away and tries to continue the best it can. The routing will be broken in that region but it would have been wacky anyway even if the nodes had been processed normally.
Let's see how this does - I have tried it out on 63660006.osm and the resulting map loads into mapsource OK and is generally fine. Trying to route through the broken region does cause mapsource to either draw a straight line or pop up the "your map's broken" dialog. A real gps would probably hang or crash if it tried to route through the region. The fix is not very pleasing but if it allows the map to build with minimal damage to the routing then I guess it will do for now as an interim solution. Cheers, Mark
On Wed, Jun 3, 2009 at 5:41 PM, Mark Burton <markb@ordern.com> wrote:
Let's see how this does - I have tried it out on 63660006.osm and the resulting map loads into mapsource OK and is generally fine. Trying to route through the broken region does cause mapsource to either draw a straight line or pop up the "your map's broken" dialog. A real gps would probably hang or crash if it tried to route through the region.
Thanks! I'll try this out as soon as possible. I've noticed on my eTrex, when I encounter such broken areas, I usually simply get a "Routing Error" popup, but the device has not yet (recently) hung. Cheers.
On Wed, Jun 3, 2009 at 5:41 PM, Mark Burton <markb@ordern.com> wrote:
Let's see how this does - I have tried it out on 63660006.osm and the resulting map loads into mapsource OK and is generally fine.
I have also tested this, and it worked fine (with the exception of the broken routing in the damaged area, but that is to be expected). Thanks very much for this fix! I also apologise, because I thought that r1054 introduced the "croaking" feature. But if I now understand it correctly, the commit simply made the croaking more elegant. Previously mkgmap would "spew" error messages and then croak. Cheers.
Hi Clinton,
On Wed, Jun 3, 2009 at 5:41 PM, Mark Burton <markb@ordern.com> wrote:
Let's see how this does - I have tried it out on 63660006.osm and the resulting map loads into mapsource OK and is generally fine.
I have also tested this, and it worked fine (with the exception of the broken routing in the damaged area, but that is to be expected).
Thanks very much for this fix!
Well, as we know, it's a hack but if it allows the map to build and be mostly usable, it's a worthwhile hack.
I also apologise, because I thought that r1054 introduced the "croaking" feature. But if I now understand it correctly, the commit simply made the croaking more elegant. Previously mkgmap would "spew" error messages and then croak.
No need to apologise, I understood your unhappiness with how it was. But yes, it would have bombed anyway, I just made it a little more useful by reporting the bbox and then exiting without spewing out more garbage. Cheers, Mark
participants (3)
-
Clinton Gladstone -
Mark Burton -
svn commit