[PATCH v2] - yet more turn heading adjustment fixes
v2 - further fixes Carlos, this still gives you an extra "turn left onto Calle Osa Mayor" and I know what's happening there but can't fix it - how about the other problems you were seeing? better/worse? -------- Hopefully, these changes will fix the bad routing directions we have been seeing recently - please test and report success/failure.
Mark Burton escribió:
v2 - further fixes
Carlos, this still gives you an extra "turn left onto Calle Osa Mayor" and I know what's happening there but can't fix it Will it break other things? - how about the other problems you were seeing? better/worse?
Better, "keep right at Avenida de las Delicias" has changed to "turn right..." (step 3 of my explanation). Turn right at 4 is still happening.
--------
Hopefully, these changes will fix the bad routing directions we have been seeing recently - please test and report success/failure.
Hi Carlos,
Carlos, this still gives you an extra "turn left onto Calle Osa Mayor" and I know what's happening there but can't fix it Will it break other things?
It's a problem - if I change it so that it doesn't give you that extra turn left, then when the route is reversed, it won't tell you to turn right from Calle Osa Mayor (rather than continue on round the left bend). So is it worse to have the turn left direction when, in fact, the road carries straight on, or is it worse for the turn right direction to be missing when coming the other way? Actually, I don't yet totally understand why the turn left is happening so it could possibly be that I can make it do the correct thing when routing in either direction. More work required..
- how about the other problems you were seeing? better/worse?
Better, "keep right at Avenida de las Delicias" has changed to "turn right..." (step 3 of my explanation). Turn right at 4 is still happening.
--------
Well, better is better (if not perfect)! Given that it was broken, I think I should commit some/all of this patch so that at least it's less broken than it was. Thanks for the feedback. Mark
Mark Burton escribió:
Hi Carlos,
Carlos, this still gives you an extra "turn left onto Calle Osa Mayor" and I know what's happening there but can't fix it
Will it break other things?
It's a problem - if I change it so that it doesn't give you that extra turn left, then when the route is reversed, it won't tell you to turn right from Calle Osa Mayor (rather than continue on round the left bend). So is it worse to have the turn left direction when, in fact, the road carries straight on, or is it worse for the turn right direction to be missing when coming the other way?
Calle Osa Mayor is oneway, so no reverse route is possible.
Actually, I don't yet totally understand why the turn left is happening so it could possibly be that I can make it do the correct thing when routing in either direction. More work required..
- how about the other problems you were seeing? better/worse?
Better, "keep right at Avenida de las Delicias" has changed to "turn right..." (step 3 of my explanation). Turn right at 4 is still happening.
--------
Well, better is better (if not perfect)!
Given that it was broken, I think I should commit some/all of this patch so that at least it's less broken than it was.
Thanks for the feedback.
Yes, I also think some improvement is better than nothing. I wonder if nobody else have seen these kind of anomalous turn instructions. More cases could help guessing what is happening.
Mark Burton escribió:
Hi Carlos,
Calle Osa Mayor is oneway, so no reverse route is possible.
Some of it is oneway, the part I am talking about is not oneway.
It seems you know my city better than me ;-) . It's not tagged as oneway, but it is a de facto oneway, as it connects with two oneway streets pointing in the opposite direction. Anyway, it's a bit estrange, so I'll try to check it on the place tomorrow.
On Feb 28, 2010, at 21:24, Carlos Dávila wrote:
Yes, I also think some improvement is better than nothing. I wonder if nobody else have seen these kind of anomalous turn instructions. More cases could help guessing what is happening.
I also have been seeing such turn instructions. Patch v2 seems to have solved the problem though, in my particular test case. Sorry, I have not had time to properly test and report on this though. I'll keep an eye out for similar incorrect turn instructions. Cheers.
participants (3)
-
Carlos Dávila -
Clinton Gladstone -
Mark Burton