Commit: r1429: Cosmetic changes to the default style: Add comments and do not sort
Version 1429 was commited by marko on 2009-12-09 22:11:45 +0000 (Wed, 09 Dec 2009) Cosmetic changes to the default style: Add comments and do not sort the highway=* alphabetically but by descending order of class, i.e., motorway, trunk, primary, secondary, tertiary, etc.
Version 1429 was commited by marko on 2009-12-09 22:11:45 +0000 (Wed, 09 Dec 2009) Cosmetic changes to the default style: Add comments and do not sort the highway=* alphabetically but by descending order of class, i.e., motorway, trunk, primary, secondary, tertiary, etc. I'm glad to see this. I have thought that there should be something almost like a 'design document' for the style that explains the grand plan, although with individual comments that becomes more or less not needed. (sorry I haven't been more useful lately; my osm cycles are limited and have been filled up with trail mapping and trying to keep building garmin maps as I watch the flurry of improvements)
Greg Troxel wrote:
Version 1429 was commited by marko on 2009-12-09 22:11:45 +0000 (Wed, 09 Dec 2009)
Cosmetic changes to the default style: Add comments and do not sort the highway=* alphabetically but by descending order of class, i.e., motorway, trunk, primary, secondary, tertiary, etc.
I'm glad to see this. I have thought that there should be something almost like a 'design document' for the style that explains the grand plan, although with individual comments that becomes more or less not needed.
Building on this, each style file could have a standard 'header' of comments that explain to the user what's going on. Here's an example: # ------------------------------------------------------------------- # points style file (default) # ------------------------------------------------------------------- # This is the default mkgmap style file for converting OSM data # into Garmin POIs # Any line prefaced with # is a comment and will not be applied # Each line is a rule, of the generalised format: # OSM_tag(s)_to_match [Garmin_type_code resolution] # See http://wiki.openstreetmap.org/wiki/Mkgmap/help/style_rules # and http://wiki.openstreetmap.org/wiki/Mkgmap/help/Custom_styles # for more information -- Charlie
On Wed, Dec 09, 2009 at 06:05:33PM -0500, Greg Troxel wrote:
Version 1429 was commited by marko on 2009-12-09 22:11:45 +0000 (Wed, 09 Dec 2009)
Cosmetic changes to the default style: Add comments and do not sort the highway=* alphabetically but by descending order of class, i.e., motorway, trunk, primary, secondary, tertiary, etc.
I'm glad to see this. I have thought that there should be something almost like a 'design document' for the style that explains the grand plan, although with individual comments that becomes more or less not needed.
Actually, it was Felix (extremecarver) who suggested this in his resolution/road_speed patch. I sorted the lines first in a separate commit, so that the "real" diff (committed today) would be easier to follow.
(sorry I haven't been more useful lately; my osm cycles are limited and have been filled up with trail mapping and trying to keep building garmin maps as I watch the flurry of improvements)
I think that I will reduce my cycles soonish. OSM has been my primary hobby for almost a year now, and I have been neglecting other hobbies. Besides, it is not fun to map in the dark and wet "winter" period. Marko
participants (4)
-
Charlie Ferrero -
Greg Troxel -
Marko Mäkelä -
svn commit