merge-roads branch verry bugged...

I needed to revert to version 2715. ...2716 is the version which really breaks on my styles. There are for sure quite a lot serious bugs in 2716 and later... I'm sorry that I cannot relly help on tracking down the bugs - I'm currently in China, and haven't got much time, nor anything that we would consider usable internet in Europe (cannot reach my own SVN for example and lots of other things blocked - VPNs working unrealiably for productive tasks, and speed is max 256Kbit up, 2-3Mbit down) -- on the up to date - merge-roads rev 2722 many of my maps fail to compile - the usual is like countless errors due to identical road id (and rev 2721 really made this much worse. With 2717 I only get like 20 for Switzerland instead of uncountable), then (not for all countries) java.lang.assertionError: SEVERE (StyledConverter): c:\openmtbmap\maps\63710216.osm.pbf: Road with identical id: 238840783 ..... uncountable amount of, then: java.lang.AssertionError at uk.me.parabola.mkgmap.osmstyle.housenumber.HousenumberGenerator.match(HousenumberGenerator.java:322) at uk.me.parabola.mkgmap.osmstyle.housenumber.HousenumberGenerator.generate(HousenumberGenerator.java:195) at uk.me.parabola.mkgmap.osmstyle.StyledConverter.end(StyledConverter.java:389) at uk.me.parabola.mkgmap.reader.osm.ElementSaver.convert(ElementSaver.java:244) at uk.me.parabola.mkgmap.reader.osm.bin.OsmBinMapDataSource.load(OsmBinMapDataSource.java:67) at uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMapDataSource.java:127) at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:167) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:63) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:243) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:239) at java.util.concurrent.FutureTask$Sync.innerRun(Unknown Source) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) java.lang.AssertionError at uk.me.parabola.mkgmap.osmstyle.housenumber.HousenumberGenerator.match(HousenumberGenerator.java:322) at uk.me.parabola.mkgmap.osmstyle.housenumber.HousenumberGenerator.generate(HousenumberGenerator.java:195) at uk.me.parabola.mkgmap.osmstyle.StyledConverter.end(StyledConverter.java:389) at uk.me.parabola.mkgmap.reader.osm.ElementSaver.convert(ElementSaver.java:244) at uk.me.parabola.mkgmap.reader.osm.bin.OsmBinMapDataSource.load(OsmBinMapDataSource.java:67) at uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMapDataSource.java:127) at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:167) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:63) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:243) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:239) at java.util.concurrent.FutureTask$Sync.innerRun(Unknown Source) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) java.lang.AssertionError at uk.me.parabola.mkgmap.osmstyle.housenumber.HousenumberGenerator.match(HousenumberGenerator.java:322) at uk.me.parabola.mkgmap.osmstyle.housenumber.HousenumberGenerator.generate(HousenumberGenerator.java:195) at uk.me.parabola.mkgmap.osmstyle.StyledConverter.end(StyledConverter.java:389) at uk.me.parabola.mkgmap.reader.osm.ElementSaver.convert(ElementSaver.java:244) at uk.me.parabola.mkgmap.reader.osm.bin.OsmBinMapDataSource.load(OsmBinMapDataSource.java:67) at uk.me.parabola.mkgmap.reader.osm.OsmMapDataSource.load(OsmMapDataSource.java:127) at uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:167) at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:63) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:243) at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:239) at java.util.concurrent.FutureTask$Sync.innerRun(Unknown Source) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source)

Hi Felix,
SEVERE (StyledConverter): c:\openmtbmap\maps\63710216.osm.pbf: Road with identical id: 238840783
this looks like you have rules which add the same OSM way at least two times to the road network, maybe with different types, maybe not. Is this intended? If yes: What is the idea behind that? Gerd

yes - many rules. All intended! Some are to circumvent the high penalties on corners on higher speed roads, others are to have different speed for each direction of a way (slower against oneway, faster with oneway direction) and some others... So far this has never been a problem (actually the continue command (or better it's precursor) was created exactly for this originally upon a feature request by me...). On 26.09.2013 10:19, Gerd Petermann wrote:
Hi Felix,
SEVERE (StyledConverter): c:\openmtbmap\maps\63710216.osm.pbf: Road with identical id: 238840783
this looks like you have rules which add the same OSM way at least two times to the road network, maybe with different types, maybe not. Is this intended? If yes: What is the idea behind that?
Gerd
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Hi WanMil, in the branch you added a test to flag this as an error. I guess the RoadMerger has a problem with that? Gerd Felix Hartmann-2 wrote
yes - many rules. All intended!
Some are to circumvent the high penalties on corners on higher speed roads, others are to have different speed for each direction of a way (slower against oneway, faster with oneway direction) and some others...
So far this has never been a problem (actually the continue command (or better it's precursor) was created exactly for this originally upon a feature request by me...).
On 26.09.2013 10:19, Gerd Petermann wrote:
Hi Felix,
SEVERE (StyledConverter): c:\openmtbmap\maps\63710216.osm.pbf: Road with identical id: 238840783
this looks like you have rules which add the same OSM way at least two times to the road network, maybe with different types, maybe not. Is this intended? If yes: What is the idea behind that?
Gerd
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context: http://gis.19327.n5.nabble.com/merge-roads-branch-verry-bugged-tp5779013p577... Sent from the Mkgmap Development mailing list archive at Nabble.com.

Hi Gerd, it was just intended as debug message but I forgot to change the level before commiting. I've changed that. The RoadMerger should not have a problem with that. WanMil
Hi WanMil,
in the branch you added a test to flag this as an error. I guess the RoadMerger has a problem with that?
Gerd
Felix Hartmann-2 wrote
yes - many rules. All intended!
Some are to circumvent the high penalties on corners on higher speed roads, others are to have different speed for each direction of a way (slower against oneway, faster with oneway direction) and some others...
So far this has never been a problem (actually the continue command (or better it's precursor) was created exactly for this originally upon a feature request by me...).
On 26.09.2013 10:19, Gerd Petermann wrote:
Hi Felix,
SEVERE (StyledConverter): c:\openmtbmap\maps\63710216.osm.pbf: Road with identical id: 238840783
this looks like you have rules which add the same OSM way at least two times to the road network, maybe with different types, maybe not. Is this intended? If yes: What is the idea behind that?
Gerd
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context: http://gis.19327.n5.nabble.com/merge-roads-branch-verry-bugged-tp5779013p577... Sent from the Mkgmap Development mailing list archive at Nabble.com. _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
participants (4)
-
Felix Hartmann
-
Gerd Petermann
-
GerdP
-
WanMil