[Patch v2] route restrictions
Here is version 2 of the patch, it fixes a rare issue with via ways that are split by the LinkDestinationHook (used with option --process-destinations). For now, these ways are ignored by the hook so that the restriction works. A compiled binary is here: http://files.mkgmap.org.uk/download/200/mkgmap.jar Gerd
Le 15/04/2014 09:22, Gerd Petermann a écrit :
Here is version 2 of the patch, it fixes a rare issue with via ways that are split by the LinkDestinationHook (used with option --process-destinations).
For now, these ways are ignored by the hook so that the restriction works. A compiled binary is here: |http://files.mkgmap.org.uk/download/200/mkgmap.jar|
No problem compiling gmapsupp for a French region (Auvergne) with --process-destinations option.
This version runs smoothly with the Germany extract - thanks! -- View this message in context: http://gis.19327.n5.nabble.com/Patch-v2-route-restrictions-tp5803296p5803316... Sent from the Mkgmap Development mailing list archive at Nabble.com.
Hi Uli, thanks for the quick feedback :-) Gerd
Date: Tue, 15 Apr 2014 06:14:27 -0700 From: ulibaer@gmail.com To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] [Patch v2] route restrictions
This version runs smoothly with the Germany extract - thanks!
-- View this message in context: http://gis.19327.n5.nabble.com/Patch-v2-route-restrictions-tp5803296p5803316... Sent from the Mkgmap Development mailing list archive at Nabble.com. _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd, I have compiled whole Europe getting warnings for only one restriction: SEVERE (StyledConverter): pbf\europe-w\29468056.osm.pbf: restriction http://www.openstreetmap.org/browse/relation/2852823 is ignored because referenced way http://www.openstreetmap.org/browse/way/52119376 lies outside of bbox SEVERE (StyledConverter): pbf\europe-w\29468075.osm.pbf: restriction http://www.openstreetmap.org/browse/relation/2852823 is ignored because referenced way http://www.openstreetmap.org/browse/way/214641575 lies outside of bbox I guess that via node is exactly at tile border. I have tested some restrictions near my place and they are obeyed correctly. -- Best regards, Andrzej
Hi Andrzej, my goal is to have the restriction in one of the two tiles and no error message. Please post a link to the two files. Gerd popej wrote
Hi Gerd,
I have compiled whole Europe getting warnings for only one restriction:
SEVERE (StyledConverter): pbf\europe-w\29468056.osm.pbf: restriction http://www.openstreetmap.org/browse/relation/2852823 is ignored because referenced way http://www.openstreetmap.org/browse/way/52119376 lies outside of bbox SEVERE (StyledConverter): pbf\europe-w\29468075.osm.pbf: restriction http://www.openstreetmap.org/browse/relation/2852823 is ignored because referenced way http://www.openstreetmap.org/browse/way/214641575 lies outside of bbox
I guess that via node is exactly at tile border.
I have tested some restrictions near my place and they are obeyed correctly.
-- Best regards, Andrzej _______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context: http://gis.19327.n5.nabble.com/Patch-v2-route-restrictions-tp5803296p5803344... Sent from the Mkgmap Development mailing list archive at Nabble.com.
Hi Andrzej, maybe the explanation is that after clipping the way has two different, but highPrecEqual() points. If you like, please try to comment lines 83-85 in LineClipper: if (pair[0].highPrecEquals(pair[1])) { continue; } Gerd popej wrote
Hi Gerd,
I have compiled whole Europe getting warnings for only one restriction:
SEVERE (StyledConverter): pbf\europe-w\29468056.osm.pbf: restriction http://www.openstreetmap.org/browse/relation/2852823 is ignored because referenced way http://www.openstreetmap.org/browse/way/52119376 lies outside of bbox SEVERE (StyledConverter): pbf\europe-w\29468075.osm.pbf: restriction http://www.openstreetmap.org/browse/relation/2852823 is ignored because referenced way http://www.openstreetmap.org/browse/way/214641575 lies outside of bbox
I guess that via node is exactly at tile border.
I have tested some restrictions near my place and they are obeyed correctly.
-- Best regards, Andrzej _______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context: http://gis.19327.n5.nabble.com/Patch-v2-route-restrictions-tp5803296p5803346... Sent from the Mkgmap Development mailing list archive at Nabble.com.
Hi Gerd,
If you like, please try to comment lines 83-85 in LineClipper:
These were lines 80-82 for me, I don't know why there is a difference. I have compiled sources 3189 with your patch v2. Removing these lines hasn't helped. Here are my files: http://files.mkgmap.org.uk/download/201/test.7z The via node of restriction is really exactly on tile border. I think you would have to bend the border to get restriction working. -- Best regards, Andrzej
Hi Andrzej, thanks for the test data, I was able to reproduce the problem now. It is at a different place in LineClipper. The problem is: Even if I fix that error, the restriction doesn't work. Don't know yet why, I guess Garmin is not able to connect the right boundary nodes when it finds two or more with the same coordinates. On the other hand, I see similar cases in original maps. I'll post version 3 soon. Gerd popej wrote
Hi Gerd,
If you like, please try to comment lines 83-85 in LineClipper:
These were lines 80-82 for me, I don't know why there is a difference. I have compiled sources 3189 with your patch v2.
Removing these lines hasn't helped.
Here are my files: http://files.mkgmap.org.uk/download/201/test.7z
The via node of restriction is really exactly on tile border. I think you would have to bend the border to get restriction working.
-- Best regards, Andrzej _______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context: http://gis.19327.n5.nabble.com/Patch-v2-route-restrictions-tp5803296p5803368... Sent from the Mkgmap Development mailing list archive at Nabble.com.
participants (5)
-
Andrzej Popowski -
Gerd Petermann -
GerdP
-
Stéphane MARTIN -
UliBaer