Exits / Service areas improvement

Hi I've made some improvements to "Exits" handling. The existing logic looked for tags: exit:road_ref - the highway the exit/services is on exit:to - the destination for the exit exit:facilities - what is available at the services These don't exist in OSM data. There is some processing in mkgmap to set exit:road_ref in simple circumstances. Without this being set, Exits don't work. Changes in this patch: - set exit:road_ref for highway=rest_area as well as motorway_junction and services. - do the above for motorroad, trunk and primary highways as well as motorways. - for services and rest_area, if option --link-pois-to-ways is set, handle "Ways" in a similar manner to "Nodes". - allow the point/area in above to be slightly off the road. - improve the efficiency of the setting of exit:road_ref for motorway_junction. - Change the typCode of motorway junction from 0x2100 (Exit with Services) to 0x2000 (Exit without Services) and only do if exit:road_ref is set. Also attempt to set exit:to from standard OSM tags exit_to or destination. - Change the typCode of services from 0x210f (see above) to 0x230f (Exit Service Area), do even of generated from polygon, set some facilities and show at a lower resolution. - correct the allowable ranges of the different POI subtypes. My eTrex HCx supports "Find > Exits" and shows the facility details. However the "Select Map" option for this defaults to "Use Best Maps" and this always chooses the inbuilt Basemap, even when disabled. Selecting the mkgmap generated map shows the junctions and services along the major road that the cursor is nearest. Stupidly, the map selection lists the tiles rather than the complete map, naming each tile as the --series-name, which is the same for all of them! There are stupidities with most aspect of Exits definitions and device handling of it and I can see why support seems to have been dropped on more modern devices, but maybe it works better on other devices, specifically car navigation systems. Ticker

Hi Ticker, did not try it yet. I wonder why the code for the --process-exits (LinkDestinationHook) is not changed by your patch. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap@jagit.co.uk> Gesendet: Donnerstag, 11. Juni 2020 14:27 An: mkgmap development Betreff: [mkgmap-dev] Exits / Service areas improvement Hi I've made some improvements to "Exits" handling. The existing logic looked for tags: exit:road_ref - the highway the exit/services is on exit:to - the destination for the exit exit:facilities - what is available at the services These don't exist in OSM data. There is some processing in mkgmap to set exit:road_ref in simple circumstances. Without this being set, Exits don't work. Changes in this patch: - set exit:road_ref for highway=rest_area as well as motorway_junction and services. - do the above for motorroad, trunk and primary highways as well as motorways. - for services and rest_area, if option --link-pois-to-ways is set, handle "Ways" in a similar manner to "Nodes". - allow the point/area in above to be slightly off the road. - improve the efficiency of the setting of exit:road_ref for motorway_junction. - Change the typCode of motorway junction from 0x2100 (Exit with Services) to 0x2000 (Exit without Services) and only do if exit:road_ref is set. Also attempt to set exit:to from standard OSM tags exit_to or destination. - Change the typCode of services from 0x210f (see above) to 0x230f (Exit Service Area), do even of generated from polygon, set some facilities and show at a lower resolution. - correct the allowable ranges of the different POI subtypes. My eTrex HCx supports "Find > Exits" and shows the facility details. However the "Select Map" option for this defaults to "Use Best Maps" and this always chooses the inbuilt Basemap, even when disabled. Selecting the mkgmap generated map shows the junctions and services along the major road that the cursor is nearest. Stupidly, the map selection lists the tiles rather than the complete map, naming each tile as the --series-name, which is the same for all of them! There are stupidities with most aspect of Exits definitions and device handling of it and I can see why support seems to have been dropped on more modern devices, but maybe it works better on other devices, specifically car navigation systems. Ticker

Hi Gerd I looked through LinkDestinationHook early on and concluded that all of the info needed was almost gathered by HighwayHook and just needed to include a few more tag values. Later, when I generalized it a bit more, there were more similarities, but it still seemed better to confine it to HighwayHooks. Ticker On Thu, 2020-06-11 at 12:41 +0000, Gerd Petermann wrote:
Hi Ticker,
did not try it yet. I wonder why the code for the --process-exits (LinkDestinationHook) is not changed by your patch.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap@jagit.co.uk> Gesendet: Donnerstag, 11. Juni 2020 14:27 An: mkgmap development Betreff: [mkgmap-dev] Exits / Service areas improvement
Hi
I've made some improvements to "Exits" handling.
The existing logic looked for tags: exit:road_ref - the highway the exit/services is on exit:to - the destination for the exit exit:facilities - what is available at the services
These don't exist in OSM data. There is some processing in mkgmap to set exit:road_ref in simple circumstances. Without this being set, Exits don't work.
Changes in this patch:
- set exit:road_ref for highway=rest_area as well as motorway_junction and services.
- do the above for motorroad, trunk and primary highways as well as motorways.
- for services and rest_area, if option --link-pois-to-ways is set, handle "Ways" in a similar manner to "Nodes".
- allow the point/area in above to be slightly off the road.
- improve the efficiency of the setting of exit:road_ref for motorway_junction.
- Change the typCode of motorway junction from 0x2100 (Exit with Services) to 0x2000 (Exit without Services) and only do if exit:road_ref is set. Also attempt to set exit:to from standard OSM tags exit_to or destination.
- Change the typCode of services from 0x210f (see above) to 0x230f (Exit Service Area), do even of generated from polygon, set some facilities and show at a lower resolution.
- correct the allowable ranges of the different POI subtypes.
My eTrex HCx supports "Find > Exits" and shows the facility details. However the "Select Map" option for this defaults to "Use Best Maps" and this always chooses the inbuilt Basemap, even when disabled. Selecting the mkgmap generated map shows the junctions and services along the major road that the cursor is nearest. Stupidly, the map selection lists the tiles rather than the complete map, naming each tile as the --series-name, which is the same for all of them!
There are stupidities with most aspect of Exits definitions and device handling of it and I can see why support seems to have been dropped on more modern devices, but maybe it works better on other devices, specifically car navigation systems.
Ticker _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Hi Ticker, thanks, I've committed the patch with r4526. I did not test the effects of the patch because I don't have a device which cares about exits and I don't know what to look for in Basecamp. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap@jagit.co.uk> Gesendet: Donnerstag, 11. Juni 2020 17:44 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Exits / Service areas improvement Hi Gerd I looked through LinkDestinationHook early on and concluded that all of the info needed was almost gathered by HighwayHook and just needed to include a few more tag values. Later, when I generalized it a bit more, there were more similarities, but it still seemed better to confine it to HighwayHooks. Ticker On Thu, 2020-06-11 at 12:41 +0000, Gerd Petermann wrote:
Hi Ticker,
did not try it yet. I wonder why the code for the --process-exits (LinkDestinationHook) is not changed by your patch.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap@jagit.co.uk> Gesendet: Donnerstag, 11. Juni 2020 14:27 An: mkgmap development Betreff: [mkgmap-dev] Exits / Service areas improvement
Hi
I've made some improvements to "Exits" handling.
The existing logic looked for tags: exit:road_ref - the highway the exit/services is on exit:to - the destination for the exit exit:facilities - what is available at the services
These don't exist in OSM data. There is some processing in mkgmap to set exit:road_ref in simple circumstances. Without this being set, Exits don't work.
Changes in this patch:
- set exit:road_ref for highway=rest_area as well as motorway_junction and services.
- do the above for motorroad, trunk and primary highways as well as motorways.
- for services and rest_area, if option --link-pois-to-ways is set, handle "Ways" in a similar manner to "Nodes".
- allow the point/area in above to be slightly off the road.
- improve the efficiency of the setting of exit:road_ref for motorway_junction.
- Change the typCode of motorway junction from 0x2100 (Exit with Services) to 0x2000 (Exit without Services) and only do if exit:road_ref is set. Also attempt to set exit:to from standard OSM tags exit_to or destination.
- Change the typCode of services from 0x210f (see above) to 0x230f (Exit Service Area), do even of generated from polygon, set some facilities and show at a lower resolution.
- correct the allowable ranges of the different POI subtypes.
My eTrex HCx supports "Find > Exits" and shows the facility details. However the "Select Map" option for this defaults to "Use Best Maps" and this always chooses the inbuilt Basemap, even when disabled. Selecting the mkgmap generated map shows the junctions and services along the major road that the cursor is nearest. Stupidly, the map selection lists the tiles rather than the complete map, naming each tile as the --series-name, which is the same for all of them!
There are stupidities with most aspect of Exits definitions and device handling of it and I can see why support seems to have been dropped on more modern devices, but maybe it works better on other devices, specifically car navigation systems.
Ticker _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Hi Gerd I don't think Basecamp knows about the extra features of Exits either. GPSMapEdit shows the extra details but doesn't have the find functionality. I'm just getting MapSource going to see what it makes of them. It occurs to me that my HCx prefers the in-built Basemap because mkgmap doesn't generate any MDR sections for the Highways and Exits but I haven't been able to find any references to MDR sections that might do the job. I'll experiment with MapSource and see if it generates extra MDRs. Ticker On Sat, 2020-06-13 at 06:16 +0000, Gerd Petermann wrote:
Hi Ticker,
thanks, I've committed the patch with r4526. I did not test the effects of the patch because I don't have a device which cares about exits and I don't know what to look for in Basecamp.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap@jagit.co.uk> Gesendet: Donnerstag, 11. Juni 2020 17:44 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Exits / Service areas improvement
Hi Gerd
I looked through LinkDestinationHook early on and concluded that all of the info needed was almost gathered by HighwayHook and just needed to include a few more tag values. Later, when I generalized it a bit more, there were more similarities, but it still seemed better to confine it to HighwayHooks.
Ticker
On Thu, 2020-06-11 at 12:41 +0000, Gerd Petermann wrote:
Hi Ticker,
did not try it yet. I wonder why the code for the --process-exits (LinkDestinationHook) is not changed by your patch.
Gerd
________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Ticker Berkin <rwb-mkgmap@jagit.co.uk> Gesendet: Donnerstag, 11. Juni 2020 14:27 An: mkgmap development Betreff: [mkgmap-dev] Exits / Service areas improvement
Hi
I've made some improvements to "Exits" handling.
The existing logic looked for tags: exit:road_ref - the highway the exit/services is on exit:to - the destination for the exit exit:facilities - what is available at the services
These don't exist in OSM data. There is some processing in mkgmap to set exit:road_ref in simple circumstances. Without this being set, Exits don't work.
Changes in this patch:
- set exit:road_ref for highway=rest_area as well as motorway_junction and services.
- do the above for motorroad, trunk and primary highways as well as motorways.
- for services and rest_area, if option --link-pois-to-ways is set, handle "Ways" in a similar manner to "Nodes".
- allow the point/area in above to be slightly off the road.
- improve the efficiency of the setting of exit:road_ref for motorway_junction.
- Change the typCode of motorway junction from 0x2100 (Exit with Services) to 0x2000 (Exit without Services) and only do if exit:road_ref is set. Also attempt to set exit:to from standard OSM tags exit_to or destination.
- Change the typCode of services from 0x210f (see above) to 0x230f (Exit Service Area), do even of generated from polygon, set some facilities and show at a lower resolution.
- correct the allowable ranges of the different POI subtypes.
My eTrex HCx supports "Find > Exits" and shows the facility details. However the "Select Map" option for this defaults to "Use Best Maps" and this always chooses the inbuilt Basemap, even when disabled. Selecting the mkgmap generated map shows the junctions and services along the major road that the cursor is nearest. Stupidly, the map selection lists the tiles rather than the complete map, naming each tile as the --series-name, which is the same for all of them!
There are stupidities with most aspect of Exits definitions and device handling of it and I can see why support seems to have been dropped on more modern devices, but maybe it works better on other devices, specifically car navigation systems.
Ticker _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
participants (2)
-
Gerd Petermann
-
Ticker Berkin