Include the following patches into trunk -- Patch2 - do not merge lines at resolution 24 and 23 if --merge-lines is used
merge-lines is as discussed quite problematic, because it happens after the routing notes are placed, and therefore causes some problems. The closer you zoom in, the bigger these problems, while the further you zoom out, the bigger the speed improvement of using this option (at resolution 24 and 23 it makes basically no difference) and the smaller the problems (22 vs 24 means 1/4 of the wrong distance for info popup or jumping map when panning). There was a discussion about this - archive here: http://www.mail-archive.com/mkgmap-dev@lists.mkgmap.org.uk/msg07262.html This patch is working pretty well and makes --merge-lines usable. I have been using it since back then without any probs. So for as long as merge-lines cannot be implemented before creation of the routing nodes (which according to the discussion is really difficult) this tiny patch is great.
On 01.03.2011 20:09, Felix Hartmann wrote:
merge-lines is as discussed quite problematic, because it happens after the routing notes are placed, and therefore causes some problems. The closer you zoom in, the bigger these problems, while the further you zoom out, the bigger the speed improvement of using this option (at resolution 24 and 23 it makes basically no difference) and the smaller the problems (22 vs 24 means 1/4 of the wrong distance for info popup or jumping map when panning).
There was a discussion about this - archive here: http://www.mail-archive.com/mkgmap-dev@lists.mkgmap.org.uk/msg07262.html
This patch is working pretty well and makes --merge-lines usable. I have been using it since back then without any probs. So for as long as merge-lines cannot be implemented before creation of the routing nodes (which according to the discussion is really difficult) this tiny patch is great. Sorry, above patch misses one line, here we go again (this happened as I had several patches against the file and recreated it by hand).
Hello Are you sure about the second and third change? They take effect and increase the file size always - even when the --merge-lines option is not given. ..Steve
On 01.03.2011 21:30, Steve Ratcliffe wrote:
Hello
Are you sure about the second and third change?
They take effect and increase the file size always - even when the --merge-lines option is not given.
..Steve I've only used it with --merge-lines given and never looked at 1 vs all of them. Probably you're right and only the first change on --merge-lines should be implemented. I actually cannot understand what the enableLineCleanFilters is and does.
On 01.03.2011 21:30, Steve Ratcliffe wrote:
Hello
Are you sure about the second and third change?
They take effect and increase the file size always - even when the --merge-lines option is not given.
..Steve Okay, rechecked it. Only the first line should be checked. There is no visible difference adding the two further lines, but it is true that the map gets much bigger then (as on resolution 24 the cleanlinefilter - whatever it does I do not know - is not working). So just check in the change of the merge-lines to 22. Because that does make merge-lines usable.
Just for convenience I attached the patch again this time really how it should be.
participants (2)
-
Felix Hartmann -
Steve Ratcliffe