Hi all, please test / review the changes in the branch, because I don't plan any further optimizations for now. You should see no different output compared with r3248 in trunk, but around 15% faster execution time and also a reduction in peak memory usage. @WanMil, Steve: Please let me know if you see problems with the usage of the new TagDict class or the RuleSet.compile() method. The latter uses the toString() method to identify what an Op is doing. Is that okay for you or should I create a different method like getOpIdentifier() to make it clearer that the method should not be changed without good reason? If I hear no complains I'll merge the version to trunk next monday. Gerd
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 02.05.2014 23:21, schrieb Gerd Petermann:
Hi all,
please test / review the changes in the branch, because I don't plan any further optimizations for now. You should see no different output compared with r3248 in trunk, but around 15% faster execution time and also a reduction in peak memory usage.
For me it seems to be a great improvement. Henning -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQEcBAEBAgAGBQJTZJ4nAAoJEKXggIeC16WPzp8H/A2wrljfP2wamkT0bAvTLq3A b4CWMJP5kQHNukgP6KNCtiEIf9/aDnlKJ36Z2c14NNnIQI6/9PMwVcqSn1C2gfh3 NAd/qhbc+3Syr8P9mqVLoP1OFT8OCqTGjSqbBhdN3Qaqa+bDuD6Mj2Th1H85w0pz kEGjIagjNlrRRuvLkkjXJiRykc9Rxtp5mMB2aSNvGH9g/nb8Dhi9E/airp+pji6+ SwqqMuOe88FnYFiIgiidp0QSvWNwI4lt05572wmIvE9sDGRVfe9zYEzAM9mMRnFn bNSl0ZjVbZuPIz0gBzdGq7wwh7VIHzma5JBIr4tFNMRs3y+6Lyvu7ecJBCBiuwg= =iSDS -----END PGP SIGNATURE-----
@WanMil, Steve: Please let me know if you see problems with the usage of the new TagDict class or the RuleSet.compile() method. The latter uses the toString() method to identify what an Op is doing. Is that okay for you or should I create a different method like getOpIdentifier() to make it clearer that the method should not be changed without good reason?
Hi Gerd, I have no time to have a look at the changes. It sounds like a good idea to use the getOpIdentifier() instead of toString(). WanMil
Hi WanMil,
@WanMil, Steve: Please let me know if you see problems with the usage of the new TagDict class or the RuleSet.compile() method. The latter uses the toString() method to identify what an Op is doing. Is that okay for you or should I create a different method like getOpIdentifier() to make it clearer that the method should not be changed without good reason?
I have no time to have a look at the changes. It sounds like a good idea to use the getOpIdentifier() instead of toString().
I thought about this again. A better name for the method would be getExpression(), but I think toString() is already used like that, so the new method simply means duplication of code. So, I have only replaced a few System.err.println(...) by throw new ExitException(...) with r3252. Gerd
participants (3)
-
Gerd Petermann -
Henning Scholland -
WanMil