Hi all, WanMil pointed out that the change in r2610 introduced a bug for large sea areas with islands. Merging all sea-only rectangles could produce polygons with holes: sssss ssoss sssss r2613 fixes this. For the above example, two large sea polygons are created instead of one. Change: The algo merges rectangles only if the result is a singular area. It also tries to avoid creating long narrow areas. The img sizes are not much different to those of r2612, and run time is similar. Gerd
In general overview2 branch runs very well. On Australia-Oceania from geofabrik I got the following errors - dunno if they are important..: SEVERE (Polyline): Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x4a containing 5 points and starting at http://www.openstreetmap.org/?mlat=-33.26660&mlon=160.66406&z om=17 SEVERE (Polyline): Subdivision shift is 7 and its centre is at http://www.openstreetmap.org/?mlat=-14.98535&mlon=-2.19727&zoom=17 SEVERE (Polyline): deltaLong = 59296 SEVERE (Polyline): Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x4a containing 5 points and starting at http://www.openstreetmap.org/?mlat=-21.09375&mlon=160.66406&z om=17 SEVERE (Polyline): Subdivision shift is 7 and its centre is at http://www.openstreetmap.org/?mlat=-14.98535&mlon=-2.19727&zoom=17 SEVERE (Polyline): deltaLong = 59296 SEVERE (Polyline): Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x4a containing 5 points and starting at http://www.openstreetmap.org/?mlat=-55.98633&mlon=168.70605&z om=17 SEVERE (Polyline): Subdivision shift is 7 and its centre is at http://www.openstreetmap.org/?mlat=-14.98535&mlon=-2.19727&zoom=17 SEVERE (Polyline): deltaLong = 62224 SEVERE (Polyline): Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x4a containing 5 points and starting at http://www.openstreetmap.org/?mlat=-45.74707&mlon=170.02441&z om=17 SEVERE (Polyline): Subdivision shift is 7 and its centre is at http://www.openstreetmap.org/?mlat=-14.98535&mlon=-2.19727&zoom=17 SEVERE (Polyline): deltaLong = 62704 SEVERE (Polyline): Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x4a containing 5 points and starting at http://www.openstreetmap.org/?mlat=-43.63770&mlon=172.57324&z om=17 SEVERE (Polyline): Subdivision shift is 7 and its centre is at http://www.openstreetmap.org/?mlat=-14.98535&mlon=-2.19727&zoom=17 SEVERE (Polyline): deltaLong = 63632 SEVERE (Polyline): Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x4a containing 5 points and starting at http://www.openstreetmap.org/?mlat=-42.18750&mlon=174.90234&z om=17 SEVERE (Polyline): Subdivision shift is 7 and its centre is at http://www.openstreetmap.org/?mlat=-14.98535&mlon=-2.19727&zoom=17 SEVERE (Polyline): deltaLong = 64480 SEVERE (Polyline): Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x4a containing 5 points and starting at http://www.openstreetmap.org/?mlat=-40.91309&mlon=175.60547&z om=17 SEVERE (Polyline): Subdivision shift is 7 and its centre is at http://www.openstreetmap.org/?mlat=-14.98535&mlon=-2.19727&zoom=17 SEVERE (Polyline): deltaLong = 64736 SEVERE (Polyline): Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x4a containing 5 points and starting at http://www.openstreetmap.org/?mlat=-36.56250&mlon=173.93555&z om=17 SEVERE (Polyline): Subdivision shift is 7 and its centre is at http://www.openstreetmap.org/?mlat=-14.98535&mlon=-2.19727&zoom=17 SEVERE (Polyline): deltaLong = 64128 SEVERE (Polyline): Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x4a containing 5 points and starting at http://www.openstreetmap.org/?mlat=-39.85840&mlon=176.44043&z om=17 SEVERE (Polyline): Subdivision shift is 7 and its centre is at http://www.openstreetmap.org/?mlat=-14.98535&mlon=-1.77979&zoom=17 SEVERE (Polyline): deltaLong = 64888 SEVERE (Polyline): Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x4a containing 5 points and starting at http://www.openstreetmap.org/?mlat=-38.93555&mlon=177.18750&z om=17 SEVERE (Polyline): Subdivision shift is 7 and its centre is at http://www.openstreetmap.org/?mlat=-14.98535&mlon=-1.40625&zoom=17 SEVERE (Polyline): deltaLong = 65024 SEVERE (MapArea): Point with type 0x9 at http://www.openstreetmap.org/?mlat=-18.13843&mlon=178.43994&zoom=17 is outside of the map area centred on http://www.openstreetmap.org/?mlat=-15.00732&mlon=-1 40625&zoom=17 width = 16646144 height = 3868672 resolution = 11 SEVERE (MapArea): Point with type 0x9 at http://www.openstreetmap.org/?mlat=-17.60010&mlon=177.45117&zoom=17 is outside of the map area centred on http://www.openstreetmap.org/?mlat=-15.00732&mlon=-1 40625&zoom=17 width = 16646144 height = 3868672 resolution = 11 SEVERE (MapArea): Point with type 0x9 at http://www.openstreetmap.org/?mlat=-17.79785&mlon=177.41821&zoom=17 is outside of the map area centred on http://www.openstreetmap.org/?mlat=-15.00732&mlon=-1 40625&zoom=17 width = 16646144 height = 3868672 resolution = 11 SEVERE (MapArea): Point with type 0x9 at http://www.openstreetmap.org/?mlat=-18.14392&mlon=178.43994&zoom=17 is outside of the map area centred on http://www.openstreetmap.org/?mlat=-15.00732&mlon=-1 40625&zoom=17 width = 16646144 height = 3868672 resolution = 11 SEVERE (MapArea): Point with type 0x9 at http://www.openstreetmap.org/?mlat=-17.60559&mlon=177.45117&zoom=17 is outside of the map area centred on http://www.openstreetmap.org/?mlat=-15.00732&mlon=-1 40625&zoom=17 width = 16646144 height = 3868672 resolution = 11 SEVERE (MapArea): Point with type 0x9 at http://www.openstreetmap.org/?mlat=-17.79785&mlon=177.41821&zoom=17 is outside of the map area centred on http://www.openstreetmap.org/?mlat=-15.00732&mlon=-1 40625&zoom=17 width = 16646144 height = 3868672 resolution = 11 SEVERE (MapArea): Point with type 0x9 at http://www.openstreetmap.org/?mlat=-18.14117&mlon=178.44269&zoom=17 is outside of the map area centred on http://www.openstreetmap.org/?mlat=-15.00732&mlon=-1 40625&zoom=17 width = 16646144 height = 3868672 resolution = 11 SEVERE (MapArea): Point with type 0x9 at http://www.openstreetmap.org/?mlat=-17.60559&mlon=177.45392&zoom=17 is outside of the map area centred on http://www.openstreetmap.org/?mlat=-15.00732&mlon=-1 40625&zoom=17 width = 16646144 height = 3868672 resolution = 11 SEVERE (MapArea): Point with type 0x9 at http://www.openstreetmap.org/?mlat=-17.80060&mlon=177.41821&zoom=17 is outside of the map area centred on http://www.openstreetmap.org/?mlat=-15.00732&mlon=-1 40625&zoom=17 width = 16646144 height = 3868672 resolution = 11 SEVERE (MapArea): Point with type 0x9 at http://www.openstreetmap.org/?mlat=-38.66089&mlon=178.02246&zoom=17 is outside of the map area centred on http://www.openstreetmap.org/?mlat=-15.00732&mlon=-1 40625&zoom=17 width = 16646144 height = 3868672 resolution = 11 SEVERE (MapArea): Point with type 0x9 at http://www.openstreetmap.org/?mlat=-38.66089&mlon=178.02246&zoom=17 is outside of the map area centred on http://www.openstreetmap.org/?mlat=-15.00732&mlon=-1 40625&zoom=17 width = 16646144 height = 3868672 resolution = 11 SEVERE (MapArea): Point with type 0x9 at http://www.openstreetmap.org/?mlat=-38.66089&mlon=178.01971&zoom=17 is outside of the map area centred on http://www.openstreetmap.org/?mlat=-15.00732&mlon=-1 40625&zoom=17 width = 16646144 height = 3868672 resolution = 11
Hi Felix, Felix Hartmann-2 wrote
In general overview2 branch runs very well. On Australia-Oceania from geofabrik I got the following errors - dunno if they are important..:
SEVERE (Polyline): Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x4a containing 5 points and starting at http://www.openstreetmap.org/?mlat=-33.26660&mlon=160.66406&z om=17 ...
yes, I think they are important. I was not yet able to reproduce them with the default style. If you are, please let me know how. Do they appear when the overview map is created? Gerd -- View this message in context: http://gis.19327.n5.nabble.com/SeaGenerator-in-overview2-branch-tp5761296p57... Sent from the Mkgmap Development mailing list archive at Nabble.com.
Hi Felix, maybe the change in PolygonSubdivSizeSplitterFilter.java is the problem. Please try to change the line 112 from return shape.getBounds().getMaxDimension() <= Math.max(maxSize, 0x8000); back to return shape.getBounds().getMaxDimension() < maxSize; Does that fix the problem? Gerd
Date: Thu, 16 May 2013 16:36:32 -0400 From: extremecarver@gmail.com To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] SeaGenerator in overview2 branch
In general overview2 branch runs very well. On Australia-Oceania from geofabrik I got the following errors - dunno if they are important..:
SEVERE (Polyline): Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x4a containing 5 points and starting at http://www.openstreetmap.org/?mlat=-33.26660&mlon=160.66406&z om=17 SEVERE (Polyline): Subdivision shift is 7 and its centre is at http://www.openstreetmap.org/?mlat=-14.98535&mlon=-2.19727&zoom=17 SEVERE (Polyline): deltaLong = 59296 SEVERE (Polyline): Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x4a containing 5 points and starting at http://www.openstreetmap.org/?mlat=-21.09375&mlon=160.66406&z om=17 SEVERE (Polyline): Subdivision shift is 7 and its centre is at http://www.openstreetmap.org/?mlat=-14.98535&mlon=-2.19727&zoom=17 SEVERE (Polyline): deltaLong = 59296 SEVERE (Polyline): Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x4a containing 5 points and starting at http://www.openstreetmap.org/?mlat=-55.98633&mlon=168.70605&z om=17 SEVERE (Polyline): Subdivision shift is 7 and its centre is at http://www.openstreetmap.org/?mlat=-14.98535&mlon=-2.19727&zoom=17 SEVERE (Polyline): deltaLong = 62224 SEVERE (Polyline): Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x4a containing 5 points and starting at http://www.openstreetmap.org/?mlat=-45.74707&mlon=170.02441&z om=17 SEVERE (Polyline): Subdivision shift is 7 and its centre is at http://www.openstreetmap.org/?mlat=-14.98535&mlon=-2.19727&zoom=17 SEVERE (Polyline): deltaLong = 62704 SEVERE (Polyline): Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x4a containing 5 points and starting at http://www.openstreetmap.org/?mlat=-43.63770&mlon=172.57324&z om=17 SEVERE (Polyline): Subdivision shift is 7 and its centre is at http://www.openstreetmap.org/?mlat=-14.98535&mlon=-2.19727&zoom=17 SEVERE (Polyline): deltaLong = 63632 SEVERE (Polyline): Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x4a containing 5 points and starting at http://www.openstreetmap.org/?mlat=-42.18750&mlon=174.90234&z om=17 SEVERE (Polyline): Subdivision shift is 7 and its centre is at http://www.openstreetmap.org/?mlat=-14.98535&mlon=-2.19727&zoom=17 SEVERE (Polyline): deltaLong = 64480 SEVERE (Polyline): Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x4a containing 5 points and starting at http://www.openstreetmap.org/?mlat=-40.91309&mlon=175.60547&z om=17 SEVERE (Polyline): Subdivision shift is 7 and its centre is at http://www.openstreetmap.org/?mlat=-14.98535&mlon=-2.19727&zoom=17 SEVERE (Polyline): deltaLong = 64736 SEVERE (Polyline): Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x4a containing 5 points and starting at http://www.openstreetmap.org/?mlat=-36.56250&mlon=173.93555&z om=17 SEVERE (Polyline): Subdivision shift is 7 and its centre is at http://www.openstreetmap.org/?mlat=-14.98535&mlon=-2.19727&zoom=17 SEVERE (Polyline): deltaLong = 64128 SEVERE (Polyline): Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x4a containing 5 points and starting at http://www.openstreetmap.org/?mlat=-39.85840&mlon=176.44043&z om=17 SEVERE (Polyline): Subdivision shift is 7 and its centre is at http://www.openstreetmap.org/?mlat=-14.98535&mlon=-1.77979&zoom=17 SEVERE (Polyline): deltaLong = 64888 SEVERE (Polyline): Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x4a containing 5 points and starting at http://www.openstreetmap.org/?mlat=-38.93555&mlon=177.18750&z om=17 SEVERE (Polyline): Subdivision shift is 7 and its centre is at http://www.openstreetmap.org/?mlat=-14.98535&mlon=-1.40625&zoom=17 SEVERE (Polyline): deltaLong = 65024 SEVERE (MapArea): Point with type 0x9 at http://www.openstreetmap.org/?mlat=-18.13843&mlon=178.43994&zoom=17 is outside of the map area centred on http://www.openstreetmap.org/?mlat=-15.00732&mlon=-1 40625&zoom=17 width = 16646144 height = 3868672 resolution = 11 SEVERE (MapArea): Point with type 0x9 at http://www.openstreetmap.org/?mlat=-17.60010&mlon=177.45117&zoom=17 is outside of the map area centred on http://www.openstreetmap.org/?mlat=-15.00732&mlon=-1 40625&zoom=17 width = 16646144 height = 3868672 resolution = 11 SEVERE (MapArea): Point with type 0x9 at http://www.openstreetmap.org/?mlat=-17.79785&mlon=177.41821&zoom=17 is outside of the map area centred on http://www.openstreetmap.org/?mlat=-15.00732&mlon=-1 40625&zoom=17 width = 16646144 height = 3868672 resolution = 11 SEVERE (MapArea): Point with type 0x9 at http://www.openstreetmap.org/?mlat=-18.14392&mlon=178.43994&zoom=17 is outside of the map area centred on http://www.openstreetmap.org/?mlat=-15.00732&mlon=-1 40625&zoom=17 width = 16646144 height = 3868672 resolution = 11 SEVERE (MapArea): Point with type 0x9 at http://www.openstreetmap.org/?mlat=-17.60559&mlon=177.45117&zoom=17 is outside of the map area centred on http://www.openstreetmap.org/?mlat=-15.00732&mlon=-1 40625&zoom=17 width = 16646144 height = 3868672 resolution = 11 SEVERE (MapArea): Point with type 0x9 at http://www.openstreetmap.org/?mlat=-17.79785&mlon=177.41821&zoom=17 is outside of the map area centred on http://www.openstreetmap.org/?mlat=-15.00732&mlon=-1 40625&zoom=17 width = 16646144 height = 3868672 resolution = 11 SEVERE (MapArea): Point with type 0x9 at http://www.openstreetmap.org/?mlat=-18.14117&mlon=178.44269&zoom=17 is outside of the map area centred on http://www.openstreetmap.org/?mlat=-15.00732&mlon=-1 40625&zoom=17 width = 16646144 height = 3868672 resolution = 11 SEVERE (MapArea): Point with type 0x9 at http://www.openstreetmap.org/?mlat=-17.60559&mlon=177.45392&zoom=17 is outside of the map area centred on http://www.openstreetmap.org/?mlat=-15.00732&mlon=-1 40625&zoom=17 width = 16646144 height = 3868672 resolution = 11 SEVERE (MapArea): Point with type 0x9 at http://www.openstreetmap.org/?mlat=-17.80060&mlon=177.41821&zoom=17 is outside of the map area centred on http://www.openstreetmap.org/?mlat=-15.00732&mlon=-1 40625&zoom=17 width = 16646144 height = 3868672 resolution = 11 SEVERE (MapArea): Point with type 0x9 at http://www.openstreetmap.org/?mlat=-38.66089&mlon=178.02246&zoom=17 is outside of the map area centred on http://www.openstreetmap.org/?mlat=-15.00732&mlon=-1 40625&zoom=17 width = 16646144 height = 3868672 resolution = 11 SEVERE (MapArea): Point with type 0x9 at http://www.openstreetmap.org/?mlat=-38.66089&mlon=178.02246&zoom=17 is outside of the map area centred on http://www.openstreetmap.org/?mlat=-15.00732&mlon=-1 40625&zoom=17 width = 16646144 height = 3868672 resolution = 11 SEVERE (MapArea): Point with type 0x9 at http://www.openstreetmap.org/?mlat=-38.66089&mlon=178.01971&zoom=17 is outside of the map area centred on http://www.openstreetmap.org/?mlat=-15.00732&mlon=-1 40625&zoom=17 width = 16646144 height = 3868672 resolution = 11 _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd, no. I just went back to 2594 - still the same problem. I'll have to check what line in my style-file is responsible for this. (I think it's in the lines file for the first part, the last lines of the error are in the points part). Strangely I only have this error on Australia-Oceania - no other country... Will take some while though, as I'm just lying with fever in my bed, and cannot concentrate very well... On 16.05.2013 17:54, Gerd Petermann wrote:
Hi Felix,
maybe the change in PolygonSubdivSizeSplitterFilter.java is the problem. Please try to change the line 112 from return shape.getBounds().getMaxDimension() <= Math.max(maxSize, 0x8000); back to return shape.getBounds().getMaxDimension() < maxSize;
Does that fix the problem?
Gerd
Hi Felix, I noticed that the problems occur with a polygon of type 0x4a. This type is treated special in some routines and I think it should not be used in the style. For example in the PolygonSubdivSizeSplitterFilter: // do not cut the background shape if (shape.getType() == 0x4a) return true; Maybe that helps... Gerd Felix Hartmann-2 wrote
Hi Gerd, no.
I just went back to 2594 - still the same problem. I'll have to check what line in my style-file is responsible for this. (I think it's in the lines file for the first part, the last lines of the error are in the points part). Strangely I only have this error on Australia-Oceania - no other country...
Will take some while though, as I'm just lying with fever in my bed, and cannot concentrate very well... On 16.05.2013 17:54, Gerd Petermann wrote:
Hi Felix,
maybe the change in PolygonSubdivSizeSplitterFilter.java is the problem. Please try to change the line 112 from return shape.getBounds().getMaxDimension() <= Math.max(maxSize, 0x8000); back to return shape.getBounds().getMaxDimension() < maxSize;
Does that fix the problem?
Gerd
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context: http://gis.19327.n5.nabble.com/SeaGenerator-in-overview2-branch-tp5761296p57... Sent from the Mkgmap Development mailing list archive at Nabble.com.
Hi Felix, I think the problem is caused by the bounding boxes of the tiles. Please send me splitters areas.list (or whatever you have) of all the tiles that you are processing when this error occurs. The data below looks like you have a tile that (almost) spans planet? Gerd Felix Hartmann-2 wrote
SEVERE (Polyline): Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x4a containing 5 points and starting at http://www.openstreetmap.org/?mlat=-33.26660&mlon=160.66406&z om=17 SEVERE (Polyline): Subdivision shift is 7 and its centre is at http://www.openstreetmap.org/?mlat=-14.98535&mlon=-2.19727&zoom=17 SEVERE (Polyline): deltaLong = 59296
-- View this message in context: http://gis.19327.n5.nabble.com/SeaGenerator-in-overview2-branch-tp5761296p57... Sent from the Mkgmap Development mailing list archive at Nabble.com.
Hi Felix, I thik I found the problem. If you combine tiles lying west of 180° with tiles lying east of 180° mkgmap calculates a huge (wrong) bbox. Looking for a fix now... Gerd
Date: Mon, 27 May 2013 23:46:14 -0700 From: gpetermann_muenchen@hotmail.com To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] SeaGenerator in overview2 branch
Hi Felix,
I think the problem is caused by the bounding boxes of the tiles. Please send me splitters areas.list (or whatever you have) of all the tiles that you are processing when this error occurs. The data below looks like you have a tile that (almost) spans planet?
Gerd
Felix Hartmann-2 wrote
SEVERE (Polyline): Problem writing line (class uk.me.parabola.imgfmt.app.trergn.Polygon) of type 0x4a containing 5 points and starting at http://www.openstreetmap.org/?mlat=-33.26660&mlon=160.66406&z om=17 SEVERE (Polyline): Subdivision shift is 7 and its centre is at http://www.openstreetmap.org/?mlat=-14.98535&mlon=-2.19727&zoom=17 SEVERE (Polyline): deltaLong = 59296
-- View this message in context: http://gis.19327.n5.nabble.com/SeaGenerator-in-overview2-branch-tp5761296p57... Sent from the Mkgmap Development mailing list archive at Nabble.com. _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
participants (3)
-
Felix Hartmann -
Gerd Petermann -
GerdP