POI Addresses and POIs for areas, documentation for map-features
Hello, I have just tried the latest version of mkgmap from trunk with --add-pois-to-areas. It looks like the addresses were attached only to the original POIs but not for the generated for areas. Bug? I have tried to change/add/remove displayed POIs and the zoom level where they are visible. Have I properly understood, that information in resources/styles/default/* is identical to map-features.csv. If that is correct, what is the preferred way for modification of the presentation style? What documentation would you recommend? The wiki (http://wiki.openstreetmap.org/wiki/Mkgmap/help/custom) is a bit short ;) Where can I find a readable list of all these hex numbers used in style specification. Thanks, Paul -- Don't take life too seriously; you will never get out of it alive. -- Elbert Hubbard
Hi Paul,
I have just tried the latest version of mkgmap from trunk with --add-pois-to-areas. It looks like the addresses were attached only to the original POIs but not for the generated for areas. Bug?
thanks for testing. You are right. Address information gathering is missing for the area generated pois. I think that should not be to hard to fix. I will have a look later on ... Thanks Berni.
Hi Paul, this patch should add the address support for the area pois. Please let me know if this works for you ... Thanks Berni. Bernhard Heibler schrieb:
I have just tried the latest version of mkgmap from trunk with --add-pois-to-areas. It looks like the addresses were attached only to the original POIs but not for the generated for areas. Bug?
thanks for testing. You are right. Address information gathering is missing for the area generated pois. I think that should not be to hard to fix. I will have a look later on ...
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Index: src/uk/me/parabola/mkgmap/main/MapMaker.java =================================================================== --- src/uk/me/parabola/mkgmap/main/MapMaker.java (revision 304) +++ src/uk/me/parabola/mkgmap/main/MapMaker.java (working copy) @@ -170,6 +170,7 @@ { MapPoint newPoint = new MapPoint(); newPoint.setName(shapeName); + newPoint.copyAddress(shape); newPoint.setType(pointType); newPoint.setLocation(shape.getLocation()); // TODO use centriod src.getPoints().add(newPoint); Index: src/uk/me/parabola/mkgmap/general/MapElement.java =================================================================== --- src/uk/me/parabola/mkgmap/general/MapElement.java (revision 304) +++ src/uk/me/parabola/mkgmap/general/MapElement.java (working copy) @@ -57,7 +57,7 @@ * @return the copy; */ public abstract MapElement copy(); - + public String getName() { return name; } @@ -67,6 +67,15 @@ this.name = name.toUpperCase(); } + public void copyAddress(MapElement orig) + { + zipCode = orig.zipCode; + city = orig.city; + region = orig.region; + country = orig.country; + attributes.putAll(orig.attributes); + } + public String getCity() { return city; }
On Sun, Mar 8, 2009 at 9:54 AM, Bernhard Heibler <bernhard@heibler.de> wrote:
Hi Paul,
this patch should add the address support for the area pois. Please let me know if this works for you ...
This patch works, at least with MapSource. There is, however, one glitch, which seems to show up on all POI-addresses -- the street name and house number are reversed. Usually you get street name and the number (and that is how city navigator shows the address), now the number comes first. Paul -- Don't take life too seriously; you will never get out of it alive. -- Elbert Hubbard
Hi Paul, this order is controlled by the poi display flag in the TRE header. The possible values are: 0x0 -> Housenumber Streetname, City Zip 0x4 -> Streetname Housenumber, City Zip 0x8 -> Housenumber Streetname, Zip City 0xc -> Streetname Housenumber, Zip City You should be able to control this flag per country in resources/LocatorConfig.xml with the poiDispFlag tag. Default is 0x0. For Germany, Austria and Switzerland I have set the poi display flag to 0xc. I just checked with with my Nuvi the order looks ok for germany. Since the flag is global for on TRE file we might get into trouble if the tree file contains more then one country with different settings. I think right now one country might overwrite the flag of another. Berni.
There is, however, one glitch, which seems to show up on all POI-addresses -- the street name and house number are reversed. Usually you get street name and the number (and that is how city navigator shows the address), now the number comes first.
Paul
On Sun, Mar 8, 2009 at 4:26 PM, Bernhard Heibler <bernhard@heibler.de> wrote:
Hi Paul,
this order is controlled by the poi display flag in the TRE header. The possible values are:
0x0 -> Housenumber Streetname, City Zip 0x4 -> Streetname Housenumber, City Zip 0x8 -> Housenumber Streetname, Zip City 0xc -> Streetname Housenumber, Zip City
You should be able to control this flag per country in resources/LocatorConfig.xml with the poiDispFlag tag. Default is 0x0. For Germany, Austria and Switzerland I have set the poi display flag to 0xc. I just checked with with my Nuvi the order looks ok for Germany.
That would explain everything. I have not set the country code in my last tests. I wonder, why not to use addr:country for that? and in case it is not present look up is_in field in neighbouring City of addr:city name... Yeah... much more easily said (written) than done, but still worth thinking about. I am relatively often traveling across country boundaries, so setting one country code for the whole Europe seems not appropriate to me. In the case of address presentation I have seen only "Street_name House_number, Zip City" in my life... so for now I can go with 0xc. In any case I would go strongly against setting anything country-dependend on a global or tile basis, unless the tiles may be cut exactly at the borders, which is not the case at the moment (splitter/routing). Thanks for the explanation, Paul -- Don't take life too seriously; you will never get out of it alive. -- Elbert Hubbard
participants (3)
-
Bernhard Heibler -
Paul Ortyl -
Paul Ortyl