Hi Gerd What a great tool ! Perhaps some suggestions. I keep various styles and --check-styles lists all the errors for each style. a) perhaps list the name of the style first then the possible errors? b) separate each style error list using an extra carriage return? c) perhaps enable checking on one style only using style=mystyle --check-styles? Another query: One of the errors concerns polygons : Warning: invalid type 0x3D00 for POLYGON in style file polygons, line 75 line 175 : landuse=pond [0x3D00 resolution 24] This polygon might be invalid using mkgmap but Garmin uses the 0x3000 to 0x3FFF+ for different water features. As I said, brilliant work! ..Nick -- View this message in context: http://gis.19327.n5.nabble.com/check-styles-tp5758614.html Sent from the Mkgmap Development mailing list archive at Nabble.com.
Hi Nick,
I keep various styles and --check-styles lists all the errors for each style.
a) perhaps list the name of the style first then the possible errors?
yes, would be better. I'll see how to do this. Current implementation first reads the style, prints the warnings, and finally shows what is contained in the info file. I can change it so that check-styles starts with a line containing the current style name.
b) separate each style error list using an extra carriage return? ok c) perhaps enable checking on one style only using style=mystyle --check-styles?
You can do this if you specify style-file=<path_to_styles>/mystyle --check-styles
Another query:
One of the errors concerns polygons : Warning: invalid type 0x3D00 for POLYGON in style file polygons, line 75
line 175 : landuse=pond [0x3D00 resolution 24]
This polygon might be invalid using mkgmap but Garmin uses the 0x3000 to 0x3FFF+ for different water features.
Hm, mkgmap uses only the lowest 8 bits and thus treats 0x3d00 like 0x00, and it is not able to write polygon types with values between 0x7f and 0xffff. With lines the invalid range is 0x3f to 0xffff. Does anybody know how these types would be encoded in the img format that we write? Or does it require NT format? Gerd
Hi Gerd Thanks for your comments < 0x3d00 like 0x00, and it is not able to write polygon types with values between 0x7f and 0xffff> I agree it can't write values 7f+ but I can't see how this affects 0x3d00 as it parses 0x4a00 /0x4b00. ..nick -- View this message in context: http://gis.19327.n5.nabble.com/check-styles-tp5758614p5758712.html Sent from the Mkgmap Development mailing list archive at Nabble.com.
Hi Nick, not sure what you mean. Do you use type 0x4a00 for a polygon and check-styles doesn't complain? Maybe you have 0x4a00 in the overlays file? If yes, I probably did something wrong in the check. If I got this right, overlays are not to be used with points or polygons, but the check uses the overlay values for all types. Gerd nwillink wrote
Hi Gerd
Thanks for your comments
< 0x3d00 like 0x00, and it is not able to write polygon types with values between 0x7f and 0xffff>
I agree it can't write values 7f+ but I can't see how this affects 0x3d00 as it parses 0x4a00 /0x4b00.
..nick
-- View this message in context: http://gis.19327.n5.nabble.com/check-styles-tp5758614p5758714.html Sent from the Mkgmap Development mailing list archive at Nabble.com.
Hi Gerd I see what the problem is I had 0x3d00 for this polygon 'meaning' 0x3d Strangely, I have encountered subtypes for types <&100 in some 'older' topo maps. However, 0x3d00 can only mean 0x3d as the highest polygon seems to be 0x1ff1f have tested: 0x03d (invalid) 0x03d0 (invalid) 0x03d00 (invalid) The last one in my opinion could be valid as with pois and lines Any ideas? ..Nick -- View this message in context: http://gis.19327.n5.nabble.com/check-styles-tp5758614p5758731.html Sent from the Mkgmap Development mailing list archive at Nabble.com.
Hi Nick,
I see what the problem is
I had 0x3d00 for this polygon 'meaning' 0x3d
Strangely, I have encountered subtypes for types <&100 in some 'older' topo maps.
However, 0x3d00 can only mean 0x3d as the highest polygon seems to be 0x1ff1f
Welll, a type > 0x10000 is an extended type. This can be used with points, lines, and polygons and is handled in completey different routines. A good question is how mkgmap should interpret type 0x3d00 used with a polygon or a line. Internally, mkgmap r2578 stores the value as 0x3d00, but it writes only 0x00 to the img file. Note that points are different here: 0x3d00 is written as 0x3d to the img file (no sub type) If the last byte is not 0, e.g. 0x3d05, mkgmap writes type 0x3d and sub type 0x05. Afaik there is no way to write a sub type for lines or polygons, so we may change mkgmap to read 0x??00 as 0x?? when used with a line or polygon.
have tested:
0x03d (invalid) 0x03d0 (invalid) 0x03d00 (invalid)
please check: do you have an overlays file in your style? If yes, please wait for a fix, cause overlays is not correctly handled by the check function. if not: 0x03d should not cause trouble with a polygon, as it is equal to 0x3d, the other two should be flagged as invalid
The last one in my opinion could be valid as with pois and lines
see above Gerd
Afaik there is no way to write a sub type for lines or polygons, so we may change mkgmap to read 0x??00 as 0x?? when used with a line or polygon.
I agree polygons with values <&100 can’t have subtypes given the present typfiles
please check: do you have an overlays file in your style? If yes, please wait for a fix, cause overlays is not correctly handled by the check function. if not: 0x03d should not cause trouble with a polygon, as it is equal to 0x3d, the other two should be flagged as invalid
Yes I had an overlay , which I somehow acquired but never looked at – so don’t worry. Thanks for your help,Gerd ..Nick _______________________________________________ mkgmap-dev mailing list [hidden email] http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -------------------------------------------------------------------------------- If you reply to this email, your message will be added to the discussion below: http://gis.19327.n5.nabble.com/check-styles-tp5758614p5758733.html To unsubscribe from check-styles, click here. NAML No virus found in this message. Checked by AVG - www.avg.com Version: 2013.0.3272 / Virus Database: 3162/6275 - Release Date: 04/26/13 -- View this message in context: http://gis.19327.n5.nabble.com/check-styles-tp5758614p5758736.html Sent from the Mkgmap Development mailing list archive at Nabble.com.
Hi Nick, okay. I've just committed r2580. I've implemented some of the cosmetic changes that you suggested, and - more important - fixed the error in the overlays handling. The binary is here: http://files.mkgmap.org.uk/download/115/mkgmap.jar Ciao, Gerd Date: Sat, 27 Apr 2013 01:14:54 -0700 From: osm@pinns.co.uk To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] check-styles
Afaik there is no way to write a sub type for lines or polygons, so we may change mkgmap to read 0x??00 as 0x?? when used with a line or polygon.
I agree polygons with values <&100 can’t have subtypes given the present typfiles
please check: do you have an overlays file in your style? If yes, please wait for a fix, cause overlays is not correctly handled by the check function. if not: 0x03d should not cause trouble with a polygon, as it is equal to 0x3d, the other two should be flagged as invalid
Yes I had an overlay , which I somehow acquired but never looked at – so don’t worry. Thanks for your help,Gerd ..Nick _______________________________________________ mkgmap-dev mailing list <A href="wlmailhtml:/user/SendEmail.jtp?type=node&node=5758733&i=0" rel=nofollow target=_top link="external">[hidden email] http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev If you reply to this email, your message will be added to the discussion below:http://gis.19327.n5.nabble.com/check-styles-tp5758614p5758733.html To unsubscribe from check-styles, click here. NAML No virus found in this message. Checked by AVG - www.avg.com Version: 2013.0.3272 / Virus Database: 3162/6275 - Release Date: 04/26/13 View this message in context: Re: check-styles Sent from the Mkgmap Development mailing list archive at Nabble.com. _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Excellent Thanks again, Gerd have a nice w/e Nick From: GerdP [via GIS] Sent: Saturday, April 27, 2013 9:22 AM To: nwillink Subject: Re: check-styles Hi Nick, okay. I've just committed r2580. I've implemented some of the cosmetic changes that you suggested, and - more important - fixed the error in the overlays handling. The binary is here: http://files.mkgmap.org.uk/download/115/mkgmap.jar Ciao, Gerd -------------------------------------------------------------------------------- Date: Sat, 27 Apr 2013 01:14:54 -0700 From: [hidden email] To: [hidden email] Subject: Re: [mkgmap-dev] check-styles
Afaik there is no way to write a sub type for lines or polygons, so we may change mkgmap to read 0x??00 as 0x?? when used with a line or polygon.
I agree polygons with values <&100 can’t have subtypes given the present typfiles
please check: do you have an overlays file in your style? If yes, please wait for a fix, cause overlays is not correctly handled by the check function. if not: 0x03d should not cause trouble with a polygon, as it is equal to 0x3d, the other two should be flagged as invalid
Yes I had an overlay , which I somehow acquired but never looked at – so don’t worry. Thanks for your help,Gerd ..Nick _______________________________________________ mkgmap-dev mailing list <A href="wlmailhtml:/user/SendEmail.jtp?type=node&node=5758733&i=0" rel=nofollow target=_top link="external">[hidden email] http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -------------------------------------------------------------------------------- If you reply to this email, your message will be added to the discussion below: http://gis.19327.n5.nabble.com/check-styles-tp5758614p5758733.html To unsubscribe from check-styles, click here. NAML No virus found in this message. Checked by AVG - www.avg.com Version: 2013.0.3272 / Virus Database: 3162/6275 - Release Date: 04/26/13 -------------------------------------------------------------------------------- View this message in context: Re: check-styles Sent from the Mkgmap Development mailing list archive at Nabble.com. _______________________________________________ mkgmap-dev mailing list [hidden email] http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list [hidden email] http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev -------------------------------------------------------------------------------- If you reply to this email, your message will be added to the discussion below: http://gis.19327.n5.nabble.com/check-styles-tp5758614p5758737.html To unsubscribe from check-styles, click here. NAML No virus found in this message. Checked by AVG - www.avg.com Version: 2013.0.3272 / Virus Database: 3162/6276 - Release Date: 04/26/13 -- View this message in context: http://gis.19327.n5.nabble.com/check-styles-tp5758614p5758738.html Sent from the Mkgmap Development mailing list archive at Nabble.com.
participants (3)
-
Gerd Petermann -
GerdP
-
nwillink