Commit: r1581: Move leisure=sports_centre below sport=*
Version 1581 was commited by marko on 2010-02-20 21:35:50 +0000 (Sat, 20 Feb 2010) Move leisure=sports_centre below sport=* so that it will only be used when no matching sport=* is specified.
svn commit wrote:
Version 1581 was commited by marko on 2010-02-20 21:35:50 +0000 (Sat, 20 Feb 2010)
Move leisure=sports_centre below sport=* so that it will only be used when no matching sport=* is specified. Is this in points or polygons?
I may have missed an earlier discussion, but shouldn't sports_centre have priority over sport=*? Sport_centre are more often than not, multi-sports venues. If I have a polygon: leisure=sports_centre sport=swimming;five-a-side football;badminton It renders correctly as a sports centre. Does this get rendered at all?: sport=swimming;five-a-side football;badminton leisure=sports_centre This will render as a swimming pool: sport=swimming leisure=sports_centre This will be incorrectly rendered as swimming. Cheers Dave F.
Hi Dave,
svn commit wrote:
Version 1581 was commited by marko on 2010-02-20 21:35:50 +0000 (Sat, 20 Feb 2010)
Move leisure=sports_centre below sport=* so that it will only be used when no matching sport=* is specified. Is this in points or polygons?
Points. I have not touched any polygon rules yet, as far as I remember.
I may have missed an earlier discussion, but shouldn't sports_centre have priority over sport=*? Sport_centre are more often than not, multi-sports venues.
Sorry, I did not understand that this tweak could be controversial. I should have started a discussion first. I visited a swimming hall whose POI was tagged as: leisure=sports_centre sport=swimming Instead of editing those attributes, I thought that it would be more appropriate to tweak the mkgmap POI rules so that sport=* takes precedence. More often than not, there is a fitness studio at a swimming hall that can use the same shower and sauna facilities, and therefore the leisure=sports_centre is appropriate. Nevertheless, the main purpose of the hall is swimming.
Does this get rendered at all?: sport=swimming;five-a-side football;badminton leisure=sports_centre
Yes. Because none of the specific sport= rules match in default/points, the point will be translated as leisure=sports_centre.
This will render as a swimming pool: sport=swimming leisure=sports_centre
This will be incorrectly rendered as swimming.
Why would you find it incorrect? (On a related note, the Edge 705 menu text says "swimming pool" in Finnish while "swimming place" would be more appropriate.) Marko
Hi Marko Marko Mäkelä wrote:
Hi Dave,
svn commit wrote:
Version 1581 was commited by marko on 2010-02-20 21:35:50 +0000
(Sat, 20 Feb 2010)
Move leisure=sports_centre below sport=* so that it will only be used when no matching sport=* is specified.
Is this in points or polygons?
Points. I have not touched any polygon rules yet, as far as I remember.
I may have missed an earlier discussion, but shouldn't sports_centre have priority over sport=*? Sport_centre are more often than not, multi-sports venues.
Sorry, I did not understand that this tweak could be controversial. I should have started a discussion first.
I visited a swimming hall whose POI was tagged as: leisure=sports_centre sport=swimming Instead of editing those attributes, I thought that it would be more appropriate to tweak the mkgmap POI rules so that sport=* takes precedence. More often than not, there is a fitness studio at a swimming hall that can use the same shower and sauna facilities, and therefore the leisure=sports_centre is appropriate. Nevertheless, the main purpose of the hall is swimming.
This proves my point. You're amendment now excludes the fact it has a multi-use. I don't think it was a good idea to change for all cases based on one. You should have just added something like: leisure=sports_centre sport=swimming; fitness rooms;sauna
Does this get rendered at all?: sport=swimming;five-a-side football;badminton leisure=sports_centre
Yes. Because none of the specific sport= rules match in default/points, the point will be translated as leisure=sports_centre.
Good, that works then.
This will render as a swimming pool: sport=swimming leisure=sports_centre
This will be incorrectly rendered as swimming.
Why would you find it incorrect? (On a related note, the Edge 705 menu text says "swimming pool" in Finnish while "swimming place" would be more appropriate.)
Because it's a multi use facility but renders as swimming. Are you saying your GPS labels it as swimming pool, even though it's tagged as just swimming? Is that in the built in profile? Cheers Dave F.
Hi Dave,
This proves my point. You're amendment now excludes the fact it has a multi-use.
I don't think it was a good idea to change for all cases based on one.
You are right, I did not think it through well enough.
Are you saying your GPS labels it as swimming pool, even though it's tagged as just swimming? Is that in the built in profile?
The Edge 705 calls unnamed POIs "Unnamed Swimming Pool" (English) or "Nimetön Uima-allas" (Finnish). The POI menu entry is Recreation/Swimming Pool. This emphasizes your point. I will revert r1581 and go back to my cave. :-) Marko
participants (3)
-
Dave F. -
Marko Mäkelä -
svn commit