Commit: r2982: performance improvement: use Path2D.append() followed by one
Version mkgmap-r2982 was committed by gerd on Fri, 24 Jan 2014 performance improvement: use Path2D.append() followed by one new Area(path) instead of multiple Area.add() Reduces run time for the generation of precompiled sea data by ~70% without notable changes in memory usage or output
Wow, looks great! The CPUs become bored... WanMil P.S.: I noticed that the sea files have a slightly different size with r2981 and r2982. I guess that's because of different id's used for nodes and ways?
Version mkgmap-r2982 was committed by gerd on Fri, 24 Jan 2014
performance improvement: use Path2D.append() followed by one new Area(path) instead of multiple Area.add() Reduces run time for the generation of precompiled sea data by ~70% without notable changes in memory usage or output _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
P.S.: I noticed that the sea files have a slightly different size with r2981 and r2982. I guess that's because of different id's used for nodes and ways? yes, I noticed that, too, but found no difference in the data in JOSM. Maybe I write a tool to renumber the nodes and ways and order them somehow so that it is easier to compare.
Gerd
P.S.: I noticed that the sea files have a slightly different size with r2981 and r2982. I guess that's because of different id's used for nodes and ways? yes, I noticed that, too, but found no difference in the data in JOSM. Maybe I write a tool to renumber the nodes and ways and order them somehow so that it is easier to compare.
Gerd
Running with one thread should give the same results? That might be easier that writing a separate tool. WanMil
Good hint :-) I'll try that tomorrow. Gerd
Date: Fri, 24 Jan 2014 21:03:05 +0100 From: wmgcnfg@web.de To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] Commit: r2982: performance improvement: use Path2D.append() followed by one
P.S.: I noticed that the sea files have a slightly different size with r2981 and r2982. I guess that's because of different id's used for nodes and ways? yes, I noticed that, too, but found no difference in the data in JOSM. Maybe I write a tool to renumber the nodes and ways and order them somehow so that it is easier to compare.
Gerd
Running with one thread should give the same results? That might be easier that writing a separate tool. WanMil
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi WanMil, I was not yet able to change the PrecompSea* code so that it generates identical output in two runs, so I still can't say for sure that the differences in the output can be ignored :-( Maybe you have an idea? Gerd GerdP wrote
Good hint :-) I'll try that tomorrow.
Gerd
Date: Fri, 24 Jan 2014 21:03:05 +0100 From:
wmgcnfg@
To:
mkgmap-dev@.org
Subject: Re: [mkgmap-dev] Commit: r2982: performance improvement: use Path2D.append() followed by one
P.S.: I noticed that the sea files have a slightly different size with r2981 and r2982. I guess that's because of different id's used for nodes and ways? yes, I noticed that, too, but found no difference in the data in JOSM. Maybe I write a tool to renumber the nodes and ways and order them somehow so that it is easier to compare.
Gerd
Running with one thread should give the same results? That might be easier that writing a separate tool. WanMil
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context: http://gis.19327.n5.nabble.com/Commit-r2982-performance-improvement-use-Path... Sent from the Mkgmap Development mailing list archive at Nabble.com.
Hi Gerd, maybe later this week. I am quite sure that there is no fundamental difference. I compared two files with JOSM and did not find any visual diff. WanMil
Hi WanMil,
I was not yet able to change the PrecompSea* code so that it generates identical output in two runs, so I still can't say for sure that the differences in the output can be ignored :-(
Maybe you have an idea?
Gerd
GerdP wrote
Good hint :-) I'll try that tomorrow.
Gerd
Date: Fri, 24 Jan 2014 21:03:05 +0100 From:
wmgcnfg@
To:
mkgmap-dev@.org
Subject: Re: [mkgmap-dev] Commit: r2982: performance improvement: use Path2D.append() followed by one
P.S.: I noticed that the sea files have a slightly different size with r2981 and r2982. I guess that's because of different id's used for nodes and ways? yes, I noticed that, too, but found no difference in the data in JOSM. Maybe I write a tool to renumber the nodes and ways and order them somehow so that it is easier to compare.
Gerd
Running with one thread should give the same results? That might be easier that writing a separate tool. WanMil
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context: http://gis.19327.n5.nabble.com/Commit-r2982-performance-improvement-use-Path... Sent from the Mkgmap Development mailing list archive at Nabble.com. _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
participants (4)
-
Gerd Petermann -
GerdP
-
svn commit -
WanMil