[PATCH v1] Further reduction of the builtin-tag-list
The patch removes the two tags "type" and "maxspeed" from the builtin-tag-list. This reduces memory requirements (a few) if these tags are not required. Tag "type": The tag is mandatory for relations. So I think it's ok to implement a rule in the relation loader that keeps the "type" tag. For nodes and ways the type tag is used only if it is referenced in the style file. Tag "maxspeed": In case the ignore-maxspeeds option is set the maxspeed tag is loaded anyhow. The new MaxspeedHook adds the maxspeed tag to the used tags only if the ignore-maxspeeds option is not set. Any objections or comments? WanMil
On 19.10.2011 22:36, WanMil wrote:
The patch removes the two tags "type" and "maxspeed" from the builtin-tag-list.
This reduces memory requirements (a few) if these tags are not required.
Tag "type": The tag is mandatory for relations. So I think it's ok to implement a rule in the relation loader that keeps the "type" tag. For nodes and ways the type tag is used only if it is referenced in the style file.
Tag "maxspeed": In case the ignore-maxspeeds option is set the maxspeed tag is loaded anyhow. The new MaxspeedHook adds the maxspeed tag to the used tags only if the ignore-maxspeeds option is not set.
I don't get the treatment... I'm currently using ignore-maxspeed option but I reference maxspeed in my style-file. Need no hard set maxspeed, but I'm happy with maxspeed for classifying wether a street is rural or urban...
Any objections or comments?
WanMil
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
On Wed, Oct 19, 2011 at 11:01:53PM +0200, Felix Hartmann wrote:
I don't get the treatment... I'm currently using ignore-maxspeed option but I reference maxspeed in my style-file. Need no hard set maxspeed, but I'm happy with maxspeed for classifying wether a street is rural or urban...
As far as I understand, the list of tags not to ignore will be updated from the style file. The more attribute names your style has, the more attributes will be parsed. WanMil's patch is about the builtin-tags-list, about attributes that are internally handled by mkgmap, no matter what is in the style files. It feels reasonable to me. Marko
On Wed, Oct 19, 2011 at 11:01:53PM +0200, Felix Hartmann wrote:
I don't get the treatment... I'm currently using ignore-maxspeed option but I reference maxspeed in my style-file. Need no hard set maxspeed, but I'm happy with maxspeed for classifying wether a street is rural or urban...
As far as I understand, the list of tags not to ignore will be updated from the style file. The more attribute names your style has, the more attributes will be parsed.
WanMil's patch is about the builtin-tags-list, about attributes that are internally handled by mkgmap, no matter what is in the style files. It feels reasonable to me.
Marko
That's it. The list of tags that should be loaded is calculated as: Tags to load = + builtin-tag-list + tags referenced in the styles + tags referenced in one of the hooks - tags in the delete-tags-file A hook is an additonal function that can add tags to the list, e.g. RoutingHook adds tags "access", "bicycle", "carpool" etc. if the "route" option is set. The SeaGeneratorHook adds the natural tag if the generate-sea option is set. If a tag is in the builtin-tag-list it is loaded no matter if it is really used or not. The patch changes that for the tags type and maxspeed. The patch has an effect when the --ignore-maxspeed option is set and the maxspeed tag is not referenced in the style. The second tag type will not have a big effect because its usage beside relations is quite small. WanMil
Hi WanMil, could you explain, what mkgmap do with maxspeed-tagg? I haven't care about this and removed maxspeed from all ways in my style-file. Henning
If there are maxspeed tags they are used to set the road speed, overriding the default values (that are defined by the highway class and the style rules) On 20 Oct 2011, at 15:51, Henning Scholland <osm@aighes.de> wrote:
Hi WanMil, could you explain, what mkgmap do with maxspeed-tagg? I haven't care about this and removed maxspeed from all ways in my style-file.
Henning
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
participants (5)
-
Charlie Ferrero -
Felix Hartmann -
Henning Scholland -
Marko Mäkelä -
WanMil