Re: [mkgmap-dev] splitter r386 - version number

Hi Jeremy, thanks for the feedback. I was not sure if you build from svn source or use the binary in the package or if you build from the source in the package. The 3rd variant doesn't work, if I got that right Steve tries to fix that. Gerd
Date: Fri, 23 May 2014 14:40:33 -0400 Subject: Re: [mkgmap-dev] splitter r386 - version number From: ichimonji10@gmail.com To: gpetermann_muenchen@hotmail.com
Gerd,
I can confirm that the --help and --version options work correctly in r389. Thank you for fixing this. No worries on the (very short) delay.
— Jeremy "Ichimonji10" Audet

Hi
thanks for the feedback. I was not sure if you build from svn source or use the binary in the package or if you build from the source in the package. The 3rd variant doesn't work, if I got that right Steve tries to fix that.
The build is OK but building from the source archive does not work, even though the distribution is built from the same directory. This is because the build uses -Dhave.svn=1 which happens to make the right thing happen. This is a bit of a bodge, so the attached patch should make it work with a plain call to 'ant'. BTW the build.xml now has a mixture of unix and windows line endings which I would like to fix too. ..Steve

Hi Steve, the patch works for me, means, I can still build with the svn sources on windows, but I can't compile with the files in the dist directory. Not sure if this should work: cd dist ant -d > ant.log 2> ant.err D:\splitter\dist\build.xml:103: syntax errors in ivy file: java.text.ParseException: D:\splitter\dist\ivy.xml (Das System kann die angegebene Datei nicht finden) in file:/D:/splitter/dist/ivy.xml at org.apache.ivy.plugins.parser.xml.XmlModuleDescriptorParser$Parser.parse(XmlModuleDescriptorParser.java:273) at org.apache.ivy.plugins.parser.xml.XmlModuleDescriptorParser.parseDescriptor(XmlModuleDescriptorParser.java:112) at org.apache.ivy.plugins.parser.ModuleDescriptorParserRegistry.parseDescriptor(ModuleDescriptorParserRegistry.java:86) at org.apache.ivy.plugins.parser.AbstractModuleDescriptorParser.parseDescriptor(AbstractModuleDescriptorParser.java:48) at org.apache.ivy.ant.IvyInfo.doExecute(IvyInfo.java:136) at org.apache.ivy.ant.IvyTask.execute(IvyTask.java:277) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) at org.apache.tools.ant.Task.perform(Task.java:348) at org.apache.tools.ant.Target.execute(Target.java:392) at org.apache.tools.ant.Target.performTasks(Target.java:413) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1399) at org.apache.tools.ant.Project.executeTarget(Project.java:1368) at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) at org.apache.tools.ant.Project.executeTargets(Project.java:1251) at org.apache.tools.ant.Main.runBuild(Main.java:811) at org.apache.tools.ant.Main.startAnt(Main.java:217) at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280) at org.apache.tools.ant.launch.Launcher.main(Launcher.java:109) Caused by: java.io.FileNotFoundException: D:\splitter\dist\ivy.xml (Das System kann die angegebene Datei nicht finden) at java.io.FileInputStream.open(Native Method) at java.io.FileInputStream.<init>(FileInputStream.java:146) at java.io.FileInputStream.<init>(FileInputStream.java:101) at sun.net.www.protocol.file.FileURLConnection.connect(FileURLConnection.java:90) at sun.net.www.protocol.file.FileURLConnection.getInputStream(FileURLConnection.java:188) at org.apache.ivy.util.url.BasicURLHandler.openStream(BasicURLHandler.java:132) at org.apache.ivy.util.url.URLHandlerDispatcher.openStream(URLHandlerDispatcher.java:74) at org.apache.ivy.util.XMLHelper.parse(XMLHelper.java:90) at org.apache.ivy.util.XMLHelper.parse(XMLHelper.java:84) at org.apache.ivy.plugins.parser.xml.XmlModuleDescriptorParser$Parser.parse(XmlModuleDescriptorParser.java:248) ... 21 more Total time: 3 seconds Gerd Steve Ratcliffe wrote
Hi
thanks for the feedback. I was not sure if you build from svn source or use the binary in the package or if you build from the source in the package. The 3rd variant doesn't work, if I got that right Steve tries to fix that.
The build is OK but building from the source archive does not work, even though the distribution is built from the same directory. This is because the build uses -Dhave.svn=1 which happens to make the right thing happen.
This is a bit of a bodge, so the attached patch should make it work with a plain call to 'ant'.
BTW the build.xml now has a mixture of unix and windows line endings which I would like to fix too.
..Steve
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
splitter-vers.patch (1K) <http://gis.19327.n5.nabble.com/attachment/5807183/0/splitter-vers.patch>
-- View this message in context: http://gis.19327.n5.nabble.com/splitter-r386-version-number-tp5806858p580719... Sent from the Mkgmap Development mailing list archive at Nabble.com.

On 24/05/14 21:12, GerdP wrote:
Hi Steve,
the patch works for me, means, I can still build with the svn sources on windows, but I can't compile with the files in the dist directory. Not sure if this should work:
Yes, that is another thing... the distribution tries to be both a binary and source distribution. I think mkgmap started off that way too, then it was split into separate binary and source downloads. I would be quite happy if all the source was removed from dist, but if you want to keep it then you will also have to copy the new ivy files (and perhaps other stuff too). ..Steve

Hi Steve, I would also prefer not to have the sources in the dist directory. In the past, it happened that I used the ant dist command in the dist directory by mistake, I even modified the sources in the wrong directory and lost a lot of time. Please change it to be similar to mkgmap. Gerd
Date: Sat, 24 May 2014 22:31:03 +0100 From: steve@parabola.me.uk To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] splitter r386 - version number
On 24/05/14 21:12, GerdP wrote:
Hi Steve,
the patch works for me, means, I can still build with the svn sources on windows, but I can't compile with the files in the dist directory. Not sure if this should work:
Yes, that is another thing... the distribution tries to be both a binary and source distribution. I think mkgmap started off that way too, then it was split into separate binary and source downloads.
I would be quite happy if all the source was removed from dist, but if you want to keep it then you will also have to copy the new ivy files (and perhaps other stuff too).
..Steve _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
participants (3)
-
Gerd Petermann
-
GerdP
-
Steve Ratcliffe