Copyright & License file reader improvements
Hi Gerd, please find attached a small patch that improves the loading of copyright and license data when the --copyright-file and --license-file options are used. It will attempt to load the data using ANSI, UTF-8, UTF-16 and the default code page. If it fails, more information is provided as to the reason why. Please try and if happy commit. Thanks, Mike
On Tue, Dec 27, 2016 at 06:07:11PM -0000, Mike Baggaley wrote:
Hi Gerd, please find attached a small patch that improves the loading of copyright and license data when the --copyright-file and --license-file options are used. It will attempt to load the data using ANSI, UTF-8, UTF-16 and the default code page. If it fails, more information is provided as to the reason why.
I am not Gerd, and I am not that active with mkgmap any more, but I have some interest in character encodings. I had a quick look at the patch. It first tries ASCII (which is a proper subset of UTF-8), then UTF-8, UTF-16 and the default code page. I do not think that there is any need to try ASCII separately. Any valid ASCII input is also valid UTF-8. If the input is not valid UTF-8, things get tricky. I am not sure if UTF-16 is a good thing to try. Here is an example where 6 ASCII characters (which could be part of a non-ASCII, non-UTF-8 input) get misinterpreted as 3 Chinese glyphs in UTF-16: $ echo -n foobar|recode utf16..utf8;echo 景潢慲 Because of this, I would omit the UTF-16 pass altogether. If UTF-16 input is truly needed, the default code page could be set to it. Also, some non-UTF-8 superset of ASCII could accidentally look like valid UTF-8. For example, the bytes 0xc2 0xa0 could represent the two-character string U+00C2 U+00A0 in ISO 8859-1. But the same bytes could also be interpreted as the single UTF-8 encoded character U+00A0. I think that if multiple input formats are supported (which would be against the Unix philosophy of keeping programs simple), the selection must be explicit, by some command line switch that chooses to use the default code page instead of UTF-8. In my opinion, the current code is good as it is. Because mkgmap already deals with mostly UTF-8 input (the OSM data), I think it is consistent to assume that all text files are encoded in UTF-8. Best regards, Marko
Hi Marko (and anyone else who is interested), I'm happy to take note of your comments on ANSI and UTF-16, however, I disagree with your assessment of the code being good at present. The OSM data files may well be in utf-8 format, but are not (usually) files generated by the user and they have an XML header indicating the encoding. The copyright and license files are text files provided as inputs by the user and hence have no encoding information provided. I can see no reason to consider that the user generated text files should be expected to be utf-8 encoded just because the OSM data files are encoded that way. There is no mention anywhere of utf-8 in the documentation, and when a copyright or license file is not utf-8 encoded then we get an error message that doesn't explain why the file failed to load. This is a recipe for frustrated users and questions being asked about why files won't load. It seems to me that if only a single file format is to be loaded then mkgmap should expect it to be using the default code page, which is how a text editor will normally save the file, unless specifically asked to do otherwise. Of course some systems may well be set up with utf-8 as the default. Up until very recently, the copyright file was not expected to be in utf-8 format. I suggest that perhaps one of the following options might be the way to go: 1: Load the two files using the default code page. If there is a failure, include the reason for the failure in the exit exception message. 2: Update the documentation to indicate that utf-8 must be used for license and copyright file If there is a failure, include the reason for the failure in the exit exception message. 3: Use the existing --code-page option to also determine the code page for the copyright and license files. If not specified, use the default code page. If there is a failure, include the reason for the failure in the exit exception message. I am happy to rework the patch for any of the above, but will wait for further comments/feedback before proceeding. Regards, Mike -----Original Message----- From: Marko Mäkelä [mailto:marko.makela@iki.fi] Sent: 27 December 2016 20:30 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Copyright & License file reader improvements On Tue, Dec 27, 2016 at 06:07:11PM -0000, Mike Baggaley wrote:
Hi Gerd, please find attached a small patch that improves the loading of copyright and license data when the --copyright-file and --license-file options are used. It will attempt to load the data using ANSI, UTF-8, UTF-16 and the default code page. If it fails, more information is provided as to the reason why.
I am not Gerd, and I am not that active with mkgmap any more, but I have some interest in character encodings. I had a quick look at the patch. It first tries ASCII (which is a proper subset of UTF-8), then UTF-8, UTF-16 and the default code page. I do not think that there is any need to try ASCII separately. Any valid ASCII input is also valid UTF-8. If the input is not valid UTF-8, things get tricky. I am not sure if UTF-16 is a good thing to try. Here is an example where 6 ASCII characters (which could be part of a non-ASCII, non-UTF-8 input) get misinterpreted as 3 Chinese glyphs in UTF-16: $ echo -n foobar|recode utf16..utf8;echo 景潢慲 Because of this, I would omit the UTF-16 pass altogether. If UTF-16 input is truly needed, the default code page could be set to it. Also, some non-UTF-8 superset of ASCII could accidentally look like valid UTF-8. For example, the bytes 0xc2 0xa0 could represent the two-character string U+00C2 U+00A0 in ISO 8859-1. But the same bytes could also be interpreted as the single UTF-8 encoded character U+00A0. I think that if multiple input formats are supported (which would be against the Unix philosophy of keeping programs simple), the selection must be explicit, by some command line switch that chooses to use the default code page instead of UTF-8. In my opinion, the current code is good as it is. Because mkgmap already deals with mostly UTF-8 input (the OSM data), I think it is consistent to assume that all text files are encoded in UTF-8. Best regards, Marko
Hi Mike, Mike Baggaley wrote
2: Update the documentation to indicate that utf-8 must be used for license and copyright file If there is a failure, include the reason for the failure in the exit exception message.
I have not much experience with this problem, but that would be my favorite. What is the current status with the style files? I think they also must be in utf-8 nowadays? Gerd -- View this message in context: http://gis.19327.n8.nabble.com/Copyright-License-file-reader-improvements-tp... Sent from the Mkgmap Development mailing list archive at Nabble.com.
Hello, I think similar. No3 seems to be a very bad idea, as code-page is different for different maps. Henning On 28/12/2016 15:18, Gerd Petermann wrote:
Hi Mike,
Mike Baggaley wrote
2: Update the documentation to indicate that utf-8 must be used for license and copyright file If there is a failure, include the reason for the failure in the exit exception message.
I have not much experience with this problem, but that would be my favorite.
What is the current status with the style files? I think they also must be in utf-8 nowadays?
Gerd
-- View this message in context: http://gis.19327.n8.nabble.com/Copyright-License-file-reader-improvements-tp... Sent from the Mkgmap Development mailing list archive at Nabble.com. _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Henning, I assume you are creating maps with different code pages but using the same copyright/license file for them. Hadn't thought of that scenario. That would rule out option 3 as you say. Cheers, Mike -----Original Message----- From: Henning Scholland [mailto:osm@aighes.de] Sent: 29 December 2016 09:31 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Copyright & License file reader improvements Hello, I think similar. No3 seems to be a very bad idea, as code-page is different for different maps. Henning On 28/12/2016 15:18, Gerd Petermann wrote:
Hi Mike,
Mike Baggaley wrote
2: Update the documentation to indicate that utf-8 must be used for license and copyright file If there is a failure, include the reason for the failure in the exit exception message.
I have not much experience with this problem, but that would be my favorite.
What is the current status with the style files? I think they also must be in utf-8 nowadays?
Gerd
-- View this message in context: http://gis.19327.n8.nabble.com/Copyright-License-file-reader-improvements-tp 5888214p5888257.html Sent from the Mkgmap Development mailing list archive at Nabble.com. _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd, please find an updated patch for improvements to the copyright reader. As discussed, this updates the documentation to say that the files must be UTF-8 encoded, and improves the error message to give the cause of the failure if the copyright or license file cannot be read. The code for reading style files does not appear to specify UTF-8. Please try and commit if happy. Thanks, Mike
Hi Mike, if I got that right the original code ignores empty lines in the licence file, the patch doesn't. Is that intended? I have no idea what's better, so I'll wait for a comment from Steve. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Donnerstag, 29. Dezember 2016 12:53:15 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] Copyright & License file reader improvements Hi Gerd, please find an updated patch for improvements to the copyright reader. As discussed, this updates the documentation to say that the files must be UTF-8 encoded, and improves the error message to give the cause of the failure if the copyright or license file cannot be read. The code for reading style files does not appear to specify UTF-8. Please try and commit if happy. Thanks, Mike
Gents, skipping empty lines might be a problem.... or at least was one. According documentation and my own experience the first line of the file handed over via --copyright-file is not shown on the garmin devices, but on BaseCamp. In order to have all licenses properly shown on the device with no 'garbage' in BaseCamp, empty lines should not be skipped. In my environment I use the same file for the options --copyright-file and --license file... with the effect, that BaseCamp shows it twice whereas GarminDevice shows it once. Regarding UTF8 in style files: My style files are in UTF-8 Encoding with BOM. This independant if I build a cp1252, cp1251 or unicode map. Cheers Patrik On 29.12.2016 14:40, Gerd Petermann wrote:
Hi Mike,
if I got that right the original code ignores empty lines in the licence file, the patch doesn't. Is that intended? I have no idea what's better, so I'll wait for a comment from Steve.
Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Donnerstag, 29. Dezember 2016 12:53:15 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] Copyright & License file reader improvements
Hi Gerd, please find an updated patch for improvements to the copyright reader. As discussed, this updates the documentation to say that the files must be UTF-8 encoded, and improves the error message to give the cause of the failure if the copyright or license file cannot be read.
The code for reading style files does not appear to specify UTF-8.
Please try and commit if happy.
Thanks, Mike _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd, yes I intentionally changed that, as it is illogical to remove blank lines from a file that has been specifically specified. Especially as the default message includes blank lines - with blank line removal it is not possible to create a copy of the standard text from a file. If you have a license file containing paragraphs of information, you are likely to want to see the paragraphs separated, rather than merged into an amorphous block. I forgot to mention this when posting the patch. Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:GPetermann_muenchen@hotmail.com] Sent: 29 December 2016 13:40 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Copyright & License file reader improvements Hi Mike, if I got that right the original code ignores empty lines in the licence file, the patch doesn't. Is that intended? I have no idea what's better, so I'll wait for a comment from Steve. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Donnerstag, 29. Dezember 2016 12:53:15 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] Copyright & License file reader improvements Hi Gerd, please find an updated patch for improvements to the copyright reader. As discussed, this updates the documentation to say that the files must be UTF-8 encoded, and improves the error message to give the cause of the failure if the copyright or license file cannot be read. The code for reading style files does not appear to specify UTF-8. Please try and commit if happy. Thanks, Mike
Hi all, if I hear no complains I'll commit this path on monday. @Steve: Do you remember a reason for the removal of empty lines? Gerd Mike Baggaley wrote
Hi Gerd, yes I intentionally changed that, as it is illogical to remove blank lines from a file that has been specifically specified. Especially as the default message includes blank lines - with blank line removal it is not possible to create a copy of the standard text from a file. If you have a license file containing paragraphs of information, you are likely to want to see the paragraphs separated, rather than merged into an amorphous block. I forgot to mention this when posting the patch.
-- View this message in context: http://gis.19327.n8.nabble.com/Copyright-License-file-reader-improvements-tp... Sent from the Mkgmap Development mailing list archive at Nabble.com.
On 06/01/17 09:04, Gerd Petermann wrote:
@Steve: Do you remember a reason for the removal of empty lines?
I don't remember. It would have been for devices and not for mapsource, I vaguely remember something about it not displaying after the blank, or a strange character, but this is probably I should have proper internet again later today I may be able to find out more. ..Steve
Hi Steve, that rang a bell. I found this thread: http://gis.19327.n8.nabble.com/Copyright-text-scrambled-td5764455.html#a5764... and esp. my reply here: http://gis.19327.n8.nabble.com/Copyright-text-scrambled-tp5764455p5764513.ht... which also has a patch which that introduced the special handling of empty lines. @Mike: Please check how your patch handles this. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Steve Ratcliffe <steve@parabola.me.uk> Gesendet: Freitag, 6. Januar 2017 11:59 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Copyright & License file reader improvements On 06/01/17 09:04, Gerd Petermann wrote:
@Steve: Do you remember a reason for the removal of empty lines?
I don't remember. It would have been for devices and not for mapsource, I vaguely remember something about it not displaying after the blank, or a strange character, but this is probably I should have proper internet again later today I may be able to find out more. ..Steve _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd, I seem to have forgotten how to display the license info in Basecamp or the on the device (I know how to display the copyright info). Can you point me in the right direction? BTW I do not have MapSource - is this still available for download or is it now outdated? Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:GPetermann_muenchen@hotmail.com] Sent: 06 January 2017 13:09 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Copyright & License file reader improvements Hi Steve, that rang a bell. I found this thread: http://gis.19327.n8.nabble.com/Copyright-text-scrambled-td5764455.html#a5764 487 and esp. my reply here: http://gis.19327.n8.nabble.com/Copyright-text-scrambled-tp5764455p5764513.ht ml which also has a patch which that introduced the special handling of empty lines. @Mike: Please check how your patch handles this. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Steve Ratcliffe <steve@parabola.me.uk> Gesendet: Freitag, 6. Januar 2017 11:59 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Copyright & License file reader improvements On 06/01/17 09:04, Gerd Petermann wrote:
@Steve: Do you remember a reason for the removal of empty lines?
I don't remember. It would have been for devices and not for mapsource, I vaguely remember something about it not displaying after the blank, or a strange character, but this is probably I should have proper internet again later today I may be able to find out more. ..Steve _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Mike, I am sorry, I don't remember where to look at the licence info. Mapsource is still available: http://www8.garmin.com/support/download_details.jsp?id=209 Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Freitag, 6. Januar 2017 18:07:37 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] Copyright & License file reader improvements Hi Gerd, I seem to have forgotten how to display the license info in Basecamp or the on the device (I know how to display the copyright info). Can you point me in the right direction? BTW I do not have MapSource - is this still available for download or is it now outdated? Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:GPetermann_muenchen@hotmail.com] Sent: 06 January 2017 13:09 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Copyright & License file reader improvements Hi Steve, that rang a bell. I found this thread: http://gis.19327.n8.nabble.com/Copyright-text-scrambled-td5764455.html#a5764 487 and esp. my reply here: http://gis.19327.n8.nabble.com/Copyright-text-scrambled-tp5764455p5764513.ht ml which also has a patch which that introduced the special handling of empty lines. @Mike: Please check how your patch handles this. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Steve Ratcliffe <steve@parabola.me.uk> Gesendet: Freitag, 6. Januar 2017 11:59 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Copyright & License file reader improvements On 06/01/17 09:04, Gerd Petermann wrote:
@Steve: Do you remember a reason for the removal of empty lines?
I don't remember. It would have been for devices and not for mapsource, I vaguely remember something about it not displaying after the blank, or a strange character, but this is probably I should have proper internet again later today I may be able to find out more. ..Steve _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi, you can see license info in GMapTool's detailed log. GMapTool ignore img code page when displaying this info, it could be mangled if you put there something else than ASCII. When you are at this task, I would like to suggest, that mkgmap could always add compiler info and version to license data. This would be helpful, when tracing problems. -- Best regards, Andrzej
Thanks Andrzej, I've now downloaded a copy of GMapTool and can see the license info there. I would not want to force the compiler info to always be written, but it seems sensible to allow codes to be specified in the license file or copyright file to be substituted by mkgmap. Not sure if there is a preference for the format, but we could do something like $MKGMAP_VERSION$, $JAVA_VERSION$, $YEAR$, $DATE$ and $TIME$, which would enable you to have a file with something like the following in it: World Map copyright 2012-$YEAR$ Compiled by mkgmap version $MKGMAP_VERSION$ java version $JAVA_VERSION$ at $TIME$ on $DATE$. Are there any other substitutions that would be useful? Regards, Mike -----Original Message----- From: Andrzej Popowski [mailto:popej@poczta.onet.pl] Sent: 09 January 2017 14:33 To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] Copyright & License file reader improvements Hi, you can see license info in GMapTool's detailed log. GMapTool ignore img code page when displaying this info, it could be mangled if you put there something else than ASCII. When you are at this task, I would like to suggest, that mkgmap could always add compiler info and version to license data. This would be helpful, when tracing problems. -- Best regards, Andrzej
Hi Mike, it is a nice idea, some variables in license text would be useful. As for mkgmap version, this is a kind of information, that people usually won't put inside their license, but that can be useful when analyzing mkgmap problems. That's why I suggest to put it always, it won't take much space. -- Best regards, Andrzej
Hi Gerd, I've updated the copyright and license file patch to include handling of variables (attached). I also found that the Java file reader doesn't strip out the BOM marker at the beginning of the file, so I've added code to strip that if it appears. Using GMapTool, the license file displays fine whether or not there are embedded blank lines. No blank lines are shown in GMapTool whether they are stripped at initial read in the license file reader or not. Regards, Mike -----Original Message----- From: Andrzej Popowski [mailto:popej@poczta.onet.pl] Sent: 10 January 2017 03:42 To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] Copyright & License file reader improvements Hi Mike, it is a nice idea, some variables in license text would be useful. As for mkgmap version, this is a kind of information, that people usually won't put inside their license, but that can be useful when analyzing mkgmap problems. That's why I suggest to put it always, it won't take much space. -- Best regards, Andrzej
Hi Mike, today I noticed that MapSource and Basecamp display the licence together with the copyright info when you click on the Copyright button in the "Map Product Manager". Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Freitag, 6. Januar 2017 18:07:37 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] Copyright & License file reader improvements Hi Gerd, I seem to have forgotten how to display the license info in Basecamp or the on the device (I know how to display the copyright info). Can you point me in the right direction? BTW I do not have MapSource - is this still available for download or is it now outdated? Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:GPetermann_muenchen@hotmail.com] Sent: 06 January 2017 13:09 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Copyright & License file reader improvements Hi Steve, that rang a bell. I found this thread: http://gis.19327.n8.nabble.com/Copyright-text-scrambled-td5764455.html#a5764 487 and esp. my reply here: http://gis.19327.n8.nabble.com/Copyright-text-scrambled-tp5764455p5764513.ht ml which also has a patch which that introduced the special handling of empty lines. @Mike: Please check how your patch handles this. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Steve Ratcliffe <steve@parabola.me.uk> Gesendet: Freitag, 6. Januar 2017 11:59 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Copyright & License file reader improvements On 06/01/17 09:04, Gerd Petermann wrote:
@Steve: Do you remember a reason for the removal of empty lines?
I don't remember. It would have been for devices and not for mapsource, I vaguely remember something about it not displaying after the blank, or a strange character, but this is probably I should have proper internet again later today I may be able to find out more. ..Steve _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
HI Gerd, I only see the copyright info when I click on it! Bizarre! Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:GPetermann_muenchen@hotmail.com] Sent: 15 January 2017 08:14 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Copyright & License file reader improvements Hi Mike, today I noticed that MapSource and Basecamp display the licence together with the copyright info when you click on the Copyright button in the "Map Product Manager". Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Freitag, 6. Januar 2017 18:07:37 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] Copyright & License file reader improvements Hi Gerd, I seem to have forgotten how to display the license info in Basecamp or the on the device (I know how to display the copyright info). Can you point me in the right direction? BTW I do not have MapSource - is this still available for download or is it now outdated? Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:GPetermann_muenchen@hotmail.com] Sent: 06 January 2017 13:09 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Copyright & License file reader improvements Hi Steve, that rang a bell. I found this thread: http://gis.19327.n8.nabble.com/Copyright-text-scrambled-td5764455.html#a5764 487 and esp. my reply here: http://gis.19327.n8.nabble.com/Copyright-text-scrambled-tp5764455p5764513.ht ml which also has a patch which that introduced the special handling of empty lines. @Mike: Please check how your patch handles this. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Steve Ratcliffe <steve@parabola.me.uk> Gesendet: Freitag, 6. Januar 2017 11:59 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Copyright & License file reader improvements On 06/01/17 09:04, Gerd Petermann wrote:
@Steve: Do you remember a reason for the removal of empty lines?
I don't remember. It would have been for devices and not for mapsource, I vaguely remember something about it not displaying after the blank, or a strange character, but this is probably I should have proper internet again later today I may be able to find out more. ..Steve _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Mike, I do not specify a licence info or copyright in my options file. So, I see the default settings. Maybe that is a hint that something is wrong? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Sonntag, 15. Januar 2017 10:02:54 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] Copyright & License file reader improvements HI Gerd, I only see the copyright info when I click on it! Bizarre! Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:GPetermann_muenchen@hotmail.com] Sent: 15 January 2017 08:14 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Copyright & License file reader improvements Hi Mike, today I noticed that MapSource and Basecamp display the licence together with the copyright info when you click on the Copyright button in the "Map Product Manager". Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Freitag, 6. Januar 2017 18:07:37 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] Copyright & License file reader improvements Hi Gerd, I seem to have forgotten how to display the license info in Basecamp or the on the device (I know how to display the copyright info). Can you point me in the right direction? BTW I do not have MapSource - is this still available for download or is it now outdated? Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:GPetermann_muenchen@hotmail.com] Sent: 06 January 2017 13:09 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Copyright & License file reader improvements Hi Steve, that rang a bell. I found this thread: http://gis.19327.n8.nabble.com/Copyright-text-scrambled-td5764455.html#a5764 487 and esp. my reply here: http://gis.19327.n8.nabble.com/Copyright-text-scrambled-tp5764455p5764513.ht ml which also has a patch which that introduced the special handling of empty lines. @Mike: Please check how your patch handles this. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Steve Ratcliffe <steve@parabola.me.uk> Gesendet: Freitag, 6. Januar 2017 11:59 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Copyright & License file reader improvements On 06/01/17 09:04, Gerd Petermann wrote:
@Steve: Do you remember a reason for the removal of empty lines?
I don't remember. It would have been for devices and not for mapsource, I vaguely remember something about it not displaying after the blank, or a strange character, but this is probably I should have proper internet again later today I may be able to find out more. ..Steve _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi, Product Map Manager displays copyright from TDB file. Probably good opportunity to check, if creating TDB is correct too. -- Best regards, Andrzej
participants (8)
-
Andrzej Popowski -
Gerd Petermann -
Gerd Petermann
-
Henning Scholland -
Marko Mäkelä -
Mike Baggaley -
Patrik Brunner -
Steve Ratcliffe