[Patch v5] drive-on-left/drive-on-right handling
Hi all, attached is v5 of the patch, only change to v4 is corrected documentation of the options. Please test this with your data, if I hear no complains I'll commit it next monday. Note that the patch will issue an error message for each tile containing both drive-on-left and drive-on-right roads: Time started: Thu Dec 04 11:12:38 CET 2014 SCHWERWIEGEND (StyledConverter): e:\osm_out_work\africa\20130428_142650\63240015.o5m: Attention: Tile contains both drive-on-left (2963) and drive-on-right roads (27376) SCHWERWIEGEND (StyledConverter): e:\osm_out_work\africa\20130428_142650\63240022.o5m: Attention: Tile contains both drive-on-left (2029) and drive-on-right roads (31251) SCHWERWIEGEND (StyledConverter): e:\osm_out_work\africa\20130428_142650\63240023.o5m: Attention: Tile contains both drive-on-left (2820) and drive-on-right roads (20553) SCHWERWIEGEND (StyledConverter): e:\osm_out_work\africa\20130428_142650\63240025.o5m: Attention: Tile contains both drive-on-left (33305) and drive-on-right roads (39882) ... Let me know when this causes trouble! A compiled binary based on r3361 is here: http://files.mkgmap.org.uk/download/235/mkgmap.jar Gerd
Hi Gerd, I have compiled Europe with your mkgmap and all seems to be ok. I have used option drive-on=detect,right and then checked flags in TRE. All flags are as expected. One note, this message is probably a typo: internal error: was that is used in valid restriction relation was removed, id: 146371635 Maye it should be "way" instead of "was"? -- Best regards, Andrzej
Hi Andrzej, great, thanks for testing. I'll correct the typo in the error message, but I'd also like to know in what case it happened. Please send me the data to reproduce it. Gerd
Date: Thu, 4 Dec 2014 18:16:43 +0100 From: popej@poczta.onet.pl To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] [Patch v5] drive-on-left/drive-on-right handling
Hi Gerd,
I have compiled Europe with your mkgmap and all seems to be ok. I have used option drive-on=detect,right and then checked flags in TRE. All flags are as expected.
One note, this message is probably a typo:
internal error: was that is used in valid restriction relation was removed, id: 146371635
Maye it should be "way" instead of "was"?
-- Best regards, Andrzej _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Andrzej, forget it, the way id 146371635 was all that I needed to reproduce the problem. The way is extremely short, I'll have a look at it tomorrow. The problem is not related to the patch. Gerd From: gpetermann_muenchen@hotmail.com To: mkgmap-dev@lists.mkgmap.org.uk Date: Thu, 4 Dec 2014 20:31:30 +0100 Subject: Re: [mkgmap-dev] [Patch v5] drive-on-left/drive-on-right handling Hi Andrzej, great, thanks for testing. I'll correct the typo in the error message, but I'd also like to know in what case it happened. Please send me the data to reproduce it. Gerd
Date: Thu, 4 Dec 2014 18:16:43 +0100 From: popej@poczta.onet.pl To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] [Patch v5] drive-on-left/drive-on-right handling
Hi Gerd,
I have compiled Europe with your mkgmap and all seems to be ok. I have used option drive-on=detect,right and then checked flags in TRE. All flags are as expected.
One note, this message is probably a typo:
internal error: was that is used in valid restriction relation was removed, id: 146371635
Maye it should be "way" instead of "was"?
-- Best regards, Andrzej _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi all, The way http://www.openstreetmap.org/way/146371635 has two points which are rounded to the same Garmin coordinates, the way is only ~0.5 m long, and it connects a crossing with an area http://www.openstreetmap.org/way/303979156 that is not converted to a routable way. I think it is okay to remove the way. The error message is caused by the fact that the way is also part of no_u_turn restriction relation which looks otherwise correct. When I coded the error message I was sure that mkgmap should never delete ways which are part of a restriction relation, but now I no longer think so. I've changed the message to a warning with r3363. Gerd GerdP wrote
Hi Andrzej,
forget it, the way id 146371635 was all that I needed to reproduce the problem. The way is extremely short, I'll have a look at it tomorrow. The problem is not related to the patch.
Gerd
From:
gpetermann_muenchen@
To:
mkgmap-dev@.org
Date: Thu, 4 Dec 2014 20:31:30 +0100 Subject: Re: [mkgmap-dev] [Patch v5] drive-on-left/drive-on-right handling
Hi Andrzej,
great, thanks for testing. I'll correct the typo in the error message, but I'd also like to know in what case it happened. Please send me the data to reproduce it.
Gerd
Date: Thu, 4 Dec 2014 18:16:43 +0100 From:
popej@.onet
To:
mkgmap-dev@.org
Subject: Re: [mkgmap-dev] [Patch v5] drive-on-left/drive-on-right handling
Hi Gerd,
I have compiled Europe with your mkgmap and all seems to be ok. I have used option drive-on=detect,right and then checked flags in TRE. All flags are as expected.
One note, this message is probably a typo:
internal error: was that is used in valid restriction relation was removed, id: 146371635
Maye it should be "way" instead of "was"?
-- Best regards, Andrzej _______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context: http://gis.19327.n5.nabble.com/Patch-v5-drive-on-left-drive-on-right-handlin... Sent from the Mkgmap Development mailing list archive at Nabble.com.
participants (3)
-
Andrzej Popowski -
Gerd Petermann -
GerdP