Hi all, I have set logging to enable warnings in StyledConverter, and have been getting a few unexpected results from the dead end check. It seems that using the default style and latest mkgmap release, if a way has mkgmap:dead-end-check=no set in OSM, this information is not loaded, so when the dead end check is run, ways with this tag are not omitted from the check. I have worked around this by adding a dummy line to the lines file: mkgmap:dead-end-check=no {set mkgmap:dead-end-check=no} The tag data is then loaded. It seems to me though that the code should include mkgmap:dead-end-check in the list of standard tags to be loaded, without needing anything specific in the style (or at least if dead end check is enabled). I would not expect OSM to have many of these, so it should not make any significant difference to the amount of memory needed by mkgmap or affect the execution time. An example is way 108322149 which is one of the ways where cars get on the train at Ashford. I suspect the same thing will happen with mkgmap:flare-check, mkgmap:dir-check and mkgmap:no-dir-check. Regards, Mike
Hi It is standard mkgmap behaviour to not load OSM tags that it doesn't see the need for. It detects tags referenced in the style and has a list of other tags known to be processed by the java code (resources/styles/builtin-tag-list). Add extra ones to your style options file: ... extra-used-tags=mkgmap:dead-end-check,etc,etc or equiv command line option. Ticker On Mon, 2020-02-17 at 19:17 +0000, Mike Baggaley wrote:
Hi all,
I have set logging to enable warnings in StyledConverter, and have been getting a few unexpected results from the dead end check. It seems that using the default style and latest mkgmap release, if a way has mkgmap:dead-end-check=no set in OSM, this information is not loaded, so when the dead end check is run, ways with this tag are not omitted from the check. I have worked around this by adding a dummy line to the lines file:
mkgmap:dead-end-check=no {set mkgmap:dead-end-check=no}
The tag data is then loaded.
It seems to me though that the code should include mkgmap:dead-end -check in the list of standard tags to be loaded, without needing anything specific in the style (or at least if dead end check is enabled). I would not expect OSM to have many of these, so it should not make any significant difference to the amount of memory needed by mkgmap or affect the execution time.
An example is way 108322149 which is one of the ways where cars get on the train at Ashford.
I suspect the same thing will happen with mkgmap:flare-check, mkgmap:dir-check and mkgmap:no-dir-check.
Regards, Mike
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Thanks Ticker. Hadn't noticed that facility in the style manual - there's no mention of the command line option in the help. Regards, Mike -----Original Message----- From: Ticker Berkin [mailto:rwb-mkgmap@jagit.co.uk] Sent: 17 February 2020 19:52 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Dead end check Hi It is standard mkgmap behaviour to not load OSM tags that it doesn't see the need for. It detects tags referenced in the style and has a list of other tags known to be processed by the java code (resources/styles/builtin-tag-list). Add extra ones to your style options file: ... extra-used-tags=mkgmap:dead-end-check,etc,etc or equiv command line option. Ticker On Mon, 2020-02-17 at 19:17 +0000, Mike Baggaley wrote:
Hi all,
I have set logging to enable warnings in StyledConverter, and have been getting a few unexpected results from the dead end check. It seems that using the default style and latest mkgmap release, if a way has mkgmap:dead-end-check=no set in OSM, this information is not loaded, so when the dead end check is run, ways with this tag are not omitted from the check. I have worked around this by adding a dummy line to the lines file:
mkgmap:dead-end-check=no {set mkgmap:dead-end-check=no}
The tag data is then loaded.
It seems to me though that the code should include mkgmap:dead-end -check in the list of standard tags to be loaded, without needing anything specific in the style (or at least if dead end check is enabled). I would not expect OSM to have many of these, so it should not make any significant difference to the amount of memory needed by mkgmap or affect the execution time.
An example is way 108322149 which is one of the ways where cars get on the train at Ashford.
I suspect the same thing will happen with mkgmap:flare-check, mkgmap:dir-check and mkgmap:no-dir-check.
Regards, Mike
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Mike, Ticker is right. Please don't add mkgmap special tags to the OSM database. Those tags should be used in the style. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Montag, 17. Februar 2020 20:17 An: 'Development list for mkgmap' Betreff: [mkgmap-dev] Dead end check Hi all, I have set logging to enable warnings in StyledConverter, and have been getting a few unexpected results from the dead end check. It seems that using the default style and latest mkgmap release, if a way has mkgmap:dead-end-check=no set in OSM, this information is not loaded, so when the dead end check is run, ways with this tag are not omitted from the check. I have worked around this by adding a dummy line to the lines file: mkgmap:dead-end-check=no {set mkgmap:dead-end-check=no} The tag data is then loaded. It seems to me though that the code should include mkgmap:dead-end-check in the list of standard tags to be loaded, without needing anything specific in the style (or at least if dead end check is enabled). I would not expect OSM to have many of these, so it should not make any significant difference to the amount of memory needed by mkgmap or affect the execution time. An example is way 108322149 which is one of the ways where cars get on the train at Ashford. I suspect the same thing will happen with mkgmap:flare-check, mkgmap:dir-check and mkgmap:no-dir-check. Regards, Mike _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd, there are a number of mkgmap special tags in the OSM database. Some of them are rather dubious (e.g. there are 4 mkgmap:area2poi tags). This one I added as all the surrounding ways had it set already with just that one not having it. The change log for the other ways shows the tag was added by tms13 in 2015. This information cannot be added in the style with the existing OSM data unless you specify something like id=108322149 {set mkgmap:dead-end-check=false}, which is not an ideal solution. If you can suggest what should go in OSM to indicate it is a known dead end so that it can be detected by the style then that would be great. Regards, Mike -----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 17 February 2020 20:04 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Dead end check Hi Mike, Ticker is right. Please don't add mkgmap special tags to the OSM database. Those tags should be used in the style. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Montag, 17. Februar 2020 20:17 An: 'Development list for mkgmap' Betreff: [mkgmap-dev] Dead end check Hi all, I have set logging to enable warnings in StyledConverter, and have been getting a few unexpected results from the dead end check. It seems that using the default style and latest mkgmap release, if a way has mkgmap:dead-end-check=no set in OSM, this information is not loaded, so when the dead end check is run, ways with this tag are not omitted from the check. I have worked around this by adding a dummy line to the lines file: mkgmap:dead-end-check=no {set mkgmap:dead-end-check=no} The tag data is then loaded. It seems to me though that the code should include mkgmap:dead-end-check in the list of standard tags to be loaded, without needing anything specific in the style (or at least if dead end check is enabled). I would not expect OSM to have many of these, so it should not make any significant difference to the amount of memory needed by mkgmap or affect the execution time. An example is way 108322149 which is one of the ways where cars get on the train at Ashford. I suspect the same thing will happen with mkgmap:flare-check, mkgmap:dir-check and mkgmap:no-dir-check. Regards, Mike _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Mike, if you get too many false positives with the dead-end check you may add mkgmap:dead-end-check=false for all highway=service. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Dienstag, 18. Februar 2020 17:46 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] Dead end check Hi Gerd, there are a number of mkgmap special tags in the OSM database. Some of them are rather dubious (e.g. there are 4 mkgmap:area2poi tags). This one I added as all the surrounding ways had it set already with just that one not having it. The change log for the other ways shows the tag was added by tms13 in 2015. This information cannot be added in the style with the existing OSM data unless you specify something like id=108322149 {set mkgmap:dead-end-check=false}, which is not an ideal solution. If you can suggest what should go in OSM to indicate it is a known dead end so that it can be detected by the style then that would be great. Regards, Mike -----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 17 February 2020 20:04 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Dead end check Hi Mike, Ticker is right. Please don't add mkgmap special tags to the OSM database. Those tags should be used in the style. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Montag, 17. Februar 2020 20:17 An: 'Development list for mkgmap' Betreff: [mkgmap-dev] Dead end check Hi all, I have set logging to enable warnings in StyledConverter, and have been getting a few unexpected results from the dead end check. It seems that using the default style and latest mkgmap release, if a way has mkgmap:dead-end-check=no set in OSM, this information is not loaded, so when the dead end check is run, ways with this tag are not omitted from the check. I have worked around this by adding a dummy line to the lines file: mkgmap:dead-end-check=no {set mkgmap:dead-end-check=no} The tag data is then loaded. It seems to me though that the code should include mkgmap:dead-end-check in the list of standard tags to be loaded, without needing anything specific in the style (or at least if dead end check is enabled). I would not expect OSM to have many of these, so it should not make any significant difference to the amount of memory needed by mkgmap or affect the execution time. An example is way 108322149 which is one of the ways where cars get on the train at Ashford. I suspect the same thing will happen with mkgmap:flare-check, mkgmap:dir-check and mkgmap:no-dir-check. Regards, Mike _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
HI Gerd, I am not getting too many positives - I am trying to differentiate those which are real OSM errors from those which are because the software isn't clever enough or doesn't have enough information. So what is needed for this situation is to tag a way to indicate that it is a known dead end. Setting mkgmap:dead-end-check=false on the way does pretty much that, albeit only for mkgmap, and only if the mkgmap:dead-end-check information is loaded from OSM. I also have nodes that have amenity=parking_entrance at the end of one-way roads. Is there a way to get a tag on a node to set mkgmap:dead-end-check on the way it belongs to? Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 18 February 2020 17:02 To: Mike Baggaley <mike@tvage.co.uk>; 'Development list for mkgmap' <mkgmap-dev@lists.mkgmap.org.uk> Subject: AW: [mkgmap-dev] Dead end check Hi Mike, if you get too many false positives with the dead-end check you may add mkgmap:dead-end-check=false for all highway=service. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Dienstag, 18. Februar 2020 17:46 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] Dead end check Hi Gerd, there are a number of mkgmap special tags in the OSM database. Some of them are rather dubious (e.g. there are 4 mkgmap:area2poi tags). This one I added as all the surrounding ways had it set already with just that one not having it. The change log for the other ways shows the tag was added by tms13 in 2015. This information cannot be added in the style with the existing OSM data unless you specify something like id=108322149 {set mkgmap:dead-end-check=false}, which is not an ideal solution. If you can suggest what should go in OSM to indicate it is a known dead end so that it can be detected by the style then that would be great. Regards, Mike -----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 17 February 2020 20:04 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Dead end check Hi Mike, Ticker is right. Please don't add mkgmap special tags to the OSM database. Those tags should be used in the style. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Montag, 17. Februar 2020 20:17 An: 'Development list for mkgmap' Betreff: [mkgmap-dev] Dead end check Hi all, I have set logging to enable warnings in StyledConverter, and have been getting a few unexpected results from the dead end check. It seems that using the default style and latest mkgmap release, if a way has mkgmap:dead-end-check=no set in OSM, this information is not loaded, so when the dead end check is run, ways with this tag are not omitted from the check. I have worked around this by adding a dummy line to the lines file: mkgmap:dead-end-check=no {set mkgmap:dead-end-check=no} The tag data is then loaded. It seems to me though that the code should include mkgmap:dead-end-check in the list of standard tags to be loaded, without needing anything specific in the style (or at least if dead end check is enabled). I would not expect OSM to have many of these, so it should not make any significant difference to the amount of memory needed by mkgmap or affect the execution time. An example is way 108322149 which is one of the ways where cars get on the train at Ashford. I suspect the same thing will happen with mkgmap:flare-check, mkgmap:dir-check and mkgmap:no-dir-check. Regards, Mike _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Mike, I don't know if there is an established tag in OSM to say "this is not a dead end". (1) The current code checks if the end node has a fixme=* or FIXME=* tag. If found, the dead-end-check is disabled for that way. I did not try it but I think you can use a rule in nodes to set fixme. Your example way has railway=car_shuttle, so maybe this rule will help for your case: railway=car_shuttle {add fixme=1} (1) I suggest to discuss this in the tagging list. http://gis.19327.n8.nabble.com/Tagging-f5258744.html Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Dienstag, 18. Februar 2020 18:30 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] Dead end check HI Gerd, I am not getting too many positives - I am trying to differentiate those which are real OSM errors from those which are because the software isn't clever enough or doesn't have enough information. So what is needed for this situation is to tag a way to indicate that it is a known dead end. Setting mkgmap:dead-end-check=false on the way does pretty much that, albeit only for mkgmap, and only if the mkgmap:dead-end-check information is loaded from OSM. I also have nodes that have amenity=parking_entrance at the end of one-way roads. Is there a way to get a tag on a node to set mkgmap:dead-end-check on the way it belongs to? Cheers, Mike -----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 18 February 2020 17:02 To: Mike Baggaley <mike@tvage.co.uk>; 'Development list for mkgmap' <mkgmap-dev@lists.mkgmap.org.uk> Subject: AW: [mkgmap-dev] Dead end check Hi Mike, if you get too many false positives with the dead-end check you may add mkgmap:dead-end-check=false for all highway=service. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Dienstag, 18. Februar 2020 17:46 An: 'Development list for mkgmap' Betreff: Re: [mkgmap-dev] Dead end check Hi Gerd, there are a number of mkgmap special tags in the OSM database. Some of them are rather dubious (e.g. there are 4 mkgmap:area2poi tags). This one I added as all the surrounding ways had it set already with just that one not having it. The change log for the other ways shows the tag was added by tms13 in 2015. This information cannot be added in the style with the existing OSM data unless you specify something like id=108322149 {set mkgmap:dead-end-check=false}, which is not an ideal solution. If you can suggest what should go in OSM to indicate it is a known dead end so that it can be detected by the style then that would be great. Regards, Mike -----Original Message----- From: Gerd Petermann [mailto:gpetermann_muenchen@hotmail.com] Sent: 17 February 2020 20:04 To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk> Subject: Re: [mkgmap-dev] Dead end check Hi Mike, Ticker is right. Please don't add mkgmap special tags to the OSM database. Those tags should be used in the style. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike@tvage.co.uk> Gesendet: Montag, 17. Februar 2020 20:17 An: 'Development list for mkgmap' Betreff: [mkgmap-dev] Dead end check Hi all, I have set logging to enable warnings in StyledConverter, and have been getting a few unexpected results from the dead end check. It seems that using the default style and latest mkgmap release, if a way has mkgmap:dead-end-check=no set in OSM, this information is not loaded, so when the dead end check is run, ways with this tag are not omitted from the check. I have worked around this by adding a dummy line to the lines file: mkgmap:dead-end-check=no {set mkgmap:dead-end-check=no} The tag data is then loaded. It seems to me though that the code should include mkgmap:dead-end-check in the list of standard tags to be loaded, without needing anything specific in the style (or at least if dead end check is enabled). I would not expect OSM to have many of these, so it should not make any significant difference to the amount of memory needed by mkgmap or affect the execution time. An example is way 108322149 which is one of the ways where cars get on the train at Ashford. I suspect the same thing will happen with mkgmap:flare-check, mkgmap:dir-check and mkgmap:no-dir-check. Regards, Mike _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
participants (3)
-
Gerd Petermann -
Mike Baggaley -
Ticker Berkin