[PATCH v1] - when removing short arcs, don't zap looped ways whose ends almost touch
The short arc removal code was removing (non-short) arcs when their ends were close enough to be considered the same point. Now it just leaves them be. Please test this patch if possible because I have reworked the short arc removal code (and some badness could have crept in). You will probably find some (loopy) ways appearing in your maps that were not there before because they were being trashed. Garvan, can you try this patch or shall I send you a mkgmap.jar? Mark
Has quite heavy impact on routing descriptions. In general fewer (but still too many) indications. Overall time on same way decreases, so in theory it is slightly better, in practice it makes no difference. I still have too many turn right / turn left even though the direction is straight on (like 10° direction change on same road).
On 02.03.2010 23:56, Mark Burton wrote:
Felix,
I still have too many turn right / turn left even though the direction is straight on (like 10° direction change on same road).
Please provide an example of that (snapshot of route in mapsource + OSM URL so I can grab the data).
Ups, sorry just noticed that the patch made no difference at all. Must have been another patch that changed the routing. I don't think that my maps are really good indicator for correct right/left vs no indication as I put so many double roads with different speed inside. I'll send you some screenshots to your private mail (in order not to break size limit for ML).
Quoting Mark Burton <markb@ordern.com>:
The short arc removal code was removing (non-short) arcs when their ends were close enough to be considered the same point.
Now it just leaves them be.
Please test this patch if possible because I have reworked the short arc removal code (and some badness could have crept in).
You will probably find some (loopy) ways appearing in your maps that were not there before because they were being trashed.
Garvan, can you try this patch or shall I send you a mkgmap.jar?
Mark
Thanks. I will test at lunch time. No need to send mkgmap.jar Garvan
Mark Burton wrote:
The short arc removal code was removing (non-short) arcs when their ends were close enough to be considered the same point.
Now it just leaves them be.
Please test this patch if possible because I have reworked the short arc removal code (and some badness could have crept in).
You will probably find some (loopy) ways appearing in your maps that were not there before because they were being trashed.
Garvan, can you try this patch or shall I send you a mkgmap.jar?
Mark
All looks well from a visual inspection or a compiled map - the contour lines are displaying properly. Thanks, Garvan
As this patch fixes the problem that Garvan reported and no one has reported that it has broken anything I will commit it in a day or so unless any -ve reports come in. Mark
participants (4)
-
Felix Hartmann -
Garvan & maew -
garvan.maew＠online.com.kh
-
Mark Burton