sea-generate=multipolygon : seems to be broken since v1512
Hello, After many tries from latest version 1560 to 1494, I cannot use sea generation with multipolygon option after version 1512. Something seems to be broken or you might forget to explain how to use it with latest changes. I made my test with Ireland OSM file from geofabrik.de. David
David schrieb:
After many tries from latest version 1560 to 1494, I cannot use sea generation with multipolygon option after version 1512. Something seems to be broken or you might forget to explain how to use it with latest changes. I made my test with Ireland OSM file from geofabrik.de.
Yes, that's the bad news. The good news is, when you add a multipolygon be hand around an area containing islands, the new multipolygon code does a good job in creating non-flooded islands. (Tried the baleares and the canarean islands). Chris
Hi everyone,
After many tries from latest version 1560 to 1494, I cannot use sea generation with multipolygon option after version 1512. Something seems to be broken or you might forget to explain how to use it with latest changes.
I have tracked down what is happening. It is due to the change 1517 (Reduce multipolygon error messages. (WanMil)) In my example I use --generate-sea=multipolygon,no-sea-sectors In removeWaysOutsideBox(), exactly one way gets removed but that is enough to completely remove the sea. The way that is removed is exactly one unit outside the bounding box on all four corners. It is thus removed because no point is actually inside the bounding box, even though it completely surrounds the bounding box. ..Steve
In removeWaysOutsideBox(), exactly one way gets removed but that is enough to completely remove the sea.
The way that is removed is exactly one unit outside the bounding box on all four corners. It is thus removed because no point is actually inside the bounding box, even though it completely surrounds the bounding box.
Ouch... This check is missing. Attached patch does not remove ways that completely contain the bounding box. WanMil
participants (4)
-
Chris-Hein Lunkhusen -
David -
Steve Ratcliffe -
WanMil