Hi Steve, I think you mentioned this before but I can't find it. What / where is the RulesTest program? Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Steve Ratcliffe <steve@parabola.me.uk> Gesendet: Samstag, 14. April 2018 22:58:38 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] area size in r4160 Hi Harri

I have this rule in my style (polygons-file): area_size() < 25000 & (fixme = * | FIXME=* |Fixme=*) {name '${fixme}' | '${FIXME}' | '${Fixme}' } [0x53 resolution 24]

It gives an error: Error in style: Error: (polygons:8): Expression cannot be indexed

Thanks for reporting this. I should have caught it as the RulesTest program finds it. Looking for a fix now. Best wishes Steve _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Hi Steve, thanks, tried it with expr4.patch and option --rand and got some errors: ERROR: Syntax: $b~2 & length()>=1 {name 'n195'} [0x2] Message: Error: (lines:1): Expression cannot be indexed ERROR: Syntax: $b~1 | ($b=* | $a>=2) & length()>=2 {name 'n257'} [0x2] Message: Error: (lines:1): Expression cannot be indexed ERROR: Syntax: $a~2 & !($b~1) & length()>=2 {name 'n311'} [0x2] Message: Error: (lines:1): Expression cannot be indexed ERROR: Syntax: (($b>=2 | !($b!=2)) & $b!=2 | $a=2 & $b>=2) & length()>=2 {name 'n339'} [0x2] Message: Error: (lines:1): Expression cannot be indexed ERROR: Syntax: length()>=2 & $a<2 {name 'n486'} [0x2] Message: Error: (lines:1): Expression cannot be indexed ERROR: Syntax: length()>=2 & $b~1 & $b<2 {name 'n500'} [0x2] Message: Error: (lines:1): Expression cannot be indexed Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Steve Ratcliffe <steve@parabola.me.uk> Gesendet: Sonntag, 15. April 2018 11:15:41 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] area size in r4160 Hi Gerd

I think you mentioned this before but I can't find it. What / where is the RulesTest program?

It is test/main/RulesTest.java I run it something like: java -cp build/test:build/classes:lib/test/* main.RulesTest --use-length There are useful options such as --errors to only show errors. Ignore the help text that says that there may be errors when using the --use-length option. This is no longer true and there should be no errors ever. The options should be on by default. I will fix that. Steve _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Hi Steve, you are right, I ran the test without the patch. Sorry for the noise. Seems I mixed branch and trunk versions :-( I've executed the tests with the patched version a few times and it found no more errors, so I think you should commit it. Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Steve Ratcliffe <steve@parabola.me.uk> Gesendet: Montag, 16. April 2018 11:48:47 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] area size in r4160 Hi Gerd

thanks, tried it with expr4.patch and option --rand and got some errors:

ERROR: Syntax: $b~2 & length()>=1 {name 'n195'} [0x2] Message: Error: (lines:1): Expression cannot be indexed

This rule works for me on the patched code base, and fails on trunk. Could you check you are running with the patch. When running with --rand, there will be a "Seed was 1523871038110" at the end of the status line that is printed. If you save that value then we can reproduce the test run with --seed 1523871038110 ..Steve _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Thanks for noticing me Gerd.

From which version it didnt work? My latest maps I've compiled with

mkgmap-r4136 ________________________________ Van: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> namens Gerd Petermann <gpetermann_muenchen@hotmail.com> Verzonden: zaterdag 14 april 2018 23:20:37 Aan: Development list for mkgmap Onderwerp: Re: [mkgmap-dev] area size in r4160 Hi all, I've created a binary with this patch: http://files.mkgmap.org.uk/download/430/mkgmap.jar @Steve and Minko: I've now found this line in Minkos style which also doesn't work without the patch: (landuse=forest | natural=wood) & area_size() > 500000 [0x50 resolution 14-19 continue] Gerd ________________________________________ Von: mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von Steve Ratcliffe <steve@parabola.me.uk> Gesendet: Samstag, 14. April 2018 23:21:36 An: mkgmap-dev@lists.mkgmap.org.uk Betreff: Re: [mkgmap-dev] area size in r4160 Hi The attached patch fixes this properly I believe. Also includes a test for your particular rule. ..Steve

I have this rule in my style (polygons-file): area_size() < 25000 & (fixme = * | FIXME=* |Fixme=*) {name '${fixme}' | '${FIXME}' | '${Fixme}' } [0x53 resolution 24]

It gives an error: Error in style: Error: (polygons:8): Expression cannot be indexed

I think this has started in last dev version (or at least within a day or so)

-- Harri

_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev