Name-tag-list parameter not used in relations processing
Hi, I noticed that the name-tag-list parameter is ignored by mkgmap when processing relations with the "apply" directive. It works as expected for all the other types. If I hard-code the name:xx tag in my relations file, mkgmap uses it and the right language is displayed. I tried putting the parameter in the "-c" config file and on the command line, same buggy behaviour (tested on r2673 and r2889). Regards, Paco
Hi Paco, do you see this error also with r2960? Gerd
Date: Fri, 10 Jan 2014 17:01:07 +0100 From: paco.tyson@free.fr To: mkgmap-dev@lists.mkgmap.org.uk Subject: [mkgmap-dev] Name-tag-list parameter not used in relations processing
Hi,
I noticed that the name-tag-list parameter is ignored by mkgmap when processing relations with the "apply" directive. It works as expected for all the other types.
If I hard-code the name:xx tag in my relations file, mkgmap uses it and the right language is displayed.
I tried putting the parameter in the "-c" config file and on the command line, same buggy behaviour (tested on r2673 and r2889).
Regards, Paco _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Selon Gerd Petermann <gpetermann_muenchen@hotmail.com>:
Hi Paco,
Hi Gerd,
do you see this error also with r2960?
Yes.
Gerd
Date: Fri, 10 Jan 2014 17:01:07 +0100 From: paco.tyson@free.fr To: mkgmap-dev@lists.mkgmap.org.uk Subject: [mkgmap-dev] Name-tag-list parameter not used in relations processing
Hi,
I noticed that the name-tag-list parameter is ignored by mkgmap when processing relations with the "apply" directive. It works as expected for all the other types.
If I hard-code the name:xx tag in my relations file, mkgmap uses it and the right language is displayed.
I tried putting the parameter in the "-c" config file and on the command line, same buggy behaviour (tested on r2673 and r2889).
Regards, Paco _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Gerd, The bug still appears with the latest stable, is it still in your todo list ? Do you need more information from me ? Regards, Paco Selon paco.tyson@free.fr:
Selon Gerd Petermann <gpetermann_muenchen@hotmail.com>:
Hi Paco,
Hi Gerd,
do you see this error also with r2960?
Yes.
Gerd
Date: Fri, 10 Jan 2014 17:01:07 +0100 From: paco.tyson@free.fr To: mkgmap-dev@lists.mkgmap.org.uk Subject: [mkgmap-dev] Name-tag-list parameter not used in relations processing
Hi,
I noticed that the name-tag-list parameter is ignored by mkgmap when processing relations with the "apply" directive. It works as expected for all the other types.
If I hard-code the name:xx tag in my relations file, mkgmap uses it and
the
right language is displayed.
I tried putting the parameter in the "-c" config file and on the command line, same buggy behaviour (tested on r2673 and r2889).
Regards, Paco _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Pcao, I am not familiar with that part of the code, so I hoped that someone else takes care. No one did, so yes, please post more details. Gerd paco.tyson wrote
Hi Gerd,
The bug still appears with the latest stable, is it still in your todo list ? Do you need more information from me ?
Regards, Paco
Selon
paco.tyson@
:
Selon Gerd Petermann <
gpetermann_muenchen@
>:
Hi Paco,
Hi Gerd,
do you see this error also with r2960?
Yes.
Gerd
Date: Fri, 10 Jan 2014 17:01:07 +0100 From:
paco.tyson@
To:
mkgmap-dev@.org
Subject: [mkgmap-dev] Name-tag-list parameter not used in relations processing
Hi,
I noticed that the name-tag-list parameter is ignored by mkgmap when processing relations with the "apply" directive. It works as expected for all the other types.
If I hard-code the name:xx tag in my relations file, mkgmap uses it and the right language is displayed.
I tried putting the parameter in the "-c" config file and on the command line, same buggy behaviour (tested on r2673 and r2889).
Regards, Paco _______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context: http://gis.19327.n5.nabble.com/Name-tag-list-parameter-not-used-in-relations... Sent from the Mkgmap Development mailing list archive at Nabble.com.
Well, I don't know what else to add to my initial email : I noticed that the name-tag-list parameter is ignored by mkgmap when processing relations with the "apply" directive. It works as expected for all the other types. If I hard-code the name:xx tag in my relations file, mkgmap uses it and the right language is displayed. I tried putting the parameter in the "-c" config file and on the command line. Selon GerdP <gpetermann_muenchen@hotmail.com>:
Hi Pcao,
I am not familiar with that part of the code, so I hoped that someone else takes care. No one did, so yes, please post more details.
Gerd
paco.tyson wrote
Hi Gerd,
The bug still appears with the latest stable, is it still in your todo list ? Do you need more information from me ?
Regards, Paco
Selon
paco.tyson@
:
Selon Gerd Petermann <
gpetermann_muenchen@
>:
Hi Paco,
Hi Gerd,
do you see this error also with r2960?
Yes.
Gerd
Date: Fri, 10 Jan 2014 17:01:07 +0100 From:
paco.tyson@
To:
mkgmap-dev@.org
Subject: [mkgmap-dev] Name-tag-list parameter not used in relations processing
Hi,
I noticed that the name-tag-list parameter is ignored by mkgmap when processing relations with the "apply" directive. It works as expected for all the other types.
If I hard-code the name:xx tag in my relations file, mkgmap uses it and the right language is displayed.
I tried putting the parameter in the "-c" config file and on the command line, same buggy behaviour (tested on r2673 and r2889).
Regards, Paco _______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context:
http://gis.19327.n5.nabble.com/Name-tag-list-parameter-not-used-in-relations...
Sent from the Mkgmap Development mailing list archive at Nabble.com. _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Hi Paco, I think it is a very simple change, see attached patch. I don't know why it wasn't always done. Does anybody expect a problem if we add/replace the name=* tag of a Relation? Gerd
Date: Sun, 23 Mar 2014 23:09:02 +0100 From: paco.tyson@free.fr To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] Name-tag-list parameter not used in relations processing
Well, I don't know what else to add to my initial email :
I noticed that the name-tag-list parameter is ignored by mkgmap when processing relations with the "apply" directive. It works as expected for all the other types. If I hard-code the name:xx tag in my relations file, mkgmap uses it and the right language is displayed. I tried putting the parameter in the "-c" config file and on the command line.
Selon GerdP <gpetermann_muenchen@hotmail.com>:
Hi Pcao,
I am not familiar with that part of the code, so I hoped that someone else takes care. No one did, so yes, please post more details.
Gerd
paco.tyson wrote
Hi Gerd,
The bug still appears with the latest stable, is it still in your todo list ? Do you need more information from me ?
Regards, Paco
Selon
paco.tyson@
:
Selon Gerd Petermann <
gpetermann_muenchen@
>:
Hi Paco,
Hi Gerd,
do you see this error also with r2960?
Yes.
Gerd
Date: Fri, 10 Jan 2014 17:01:07 +0100 From:
paco.tyson@
To:
mkgmap-dev@.org
Subject: [mkgmap-dev] Name-tag-list parameter not used in relations processing
Hi,
I noticed that the name-tag-list parameter is ignored by mkgmap when processing relations with the "apply" directive. It works as expected for all the other types.
If I hard-code the name:xx tag in my relations file, mkgmap uses it and the right language is displayed.
I tried putting the parameter in the "-c" config file and on the command line, same buggy behaviour (tested on r2673 and r2889).
Regards, Paco _______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context:
http://gis.19327.n5.nabble.com/Name-tag-list-parameter-not-used-in-relations...
Sent from the Mkgmap Development mailing list archive at Nabble.com. _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Selon Gerd Petermann <gpetermann_muenchen@hotmail.com>:
Hi Paco,
Hi Gerd,
I think it is a very simple change, see attached patch. I don't know why it wasn't always done. Does anybody expect a problem if we add/replace the name=* tag of a Relation?
I looked at the patch but I can't guess if it's effective. I can give you an example of what I'd like. When mkgmap analyses a route relation (e.g. bicycle route), I'd like the mkgmap name variable set to the OSM "name:xx" tag as per the name-tag-list parameter instead of the OSM "name" tag. If your patch does this, then fine for me :)
Hi Paco, you can try it, I've uploaded the binary : http://files.mkgmap.org.uk/download/192/mkgmap.jar Gerd paco.tyson wrote
Selon Gerd Petermann <
gpetermann_muenchen@
>:
Hi Paco,
Hi Gerd,
I think it is a very simple change, see attached patch. I don't know why it wasn't always done. Does anybody expect a problem if we add/replace the name=* tag of a Relation?
I looked at the patch but I can't guess if it's effective.
I can give you an example of what I'd like. When mkgmap analyses a route relation (e.g. bicycle route), I'd like the mkgmap name variable set to the OSM "name:xx" tag as per the name-tag-list parameter instead of the OSM "name" tag.
If your patch does this, then fine for me :)
_______________________________________________ mkgmap-dev mailing list
mkgmap-dev@.org
-- View this message in context: http://gis.19327.n5.nabble.com/Name-tag-list-parameter-not-used-in-relations... Sent from the Mkgmap Development mailing list archive at Nabble.com.
Selon GerdP <gpetermann_muenchen@hotmail.com>:
Hi Paco,
you can try it, I've uploaded the binary : http://files.mkgmap.org.uk/download/192/mkgmap.jar
Gerd
Hi Gerd, I'm afraid the patch isn't effective. For your information, the relations file contains : network=icn & state!=proposed { apply { set icn_from_relation=yes; set icn_name='${name}'; set icn_ref='${ref}'; }; echotags "Relation ICN"; } and the corresponding lines file : highway=* & icn_from_relation=yes {name '${icn_ref} (${icn_name|not-equal:icn_ref})' | '${icn_ref}'; echotags "ICN way"; } [0x00 resolution 15-15 continue] Mkgmap r3116, without name-tag-list parameter set : [java] 2345035 - [route=bicycle,type=route,name=EuroVelo 3 - part France,ref=EV3,network=icn] Relation ICN [java] 254539829 - [motorcar=yes,mkgmap:label:1=EV3 (EuroVelo 3 - part France),mkgmap:admin_level2=FRA,mkgmap:admin_level3=France métropolitaine,mkgmap:admin_level4=Picardie,icn_from_relation=yes,mkgmap:admin_level6=Oise,icn_ref=EV3,mkgmap:admin_level8=Pontpoint,mkgmap:admin_level7=Senlis,name=Trans'Oise,surface=paved,highway=cycleway,foot=designated,mkgmap:street=Trans'Oise,mkgmap:country=FRA,mkgmap:city=Pontpoint,icn_name=EuroVelo 3 - part France,bicycleroute=yes,source=GPS,mkgmap:region=Picardie,toll=no,tollroad=no,bicycle=yes] ICN way Mkgmap r3116, name-tag-list parameter set to name:fr,name,int_name : [java] 2345035 - [route=bicycle,type=route,name=EuroVelo 3 - part France,name:fr=La route des pèlerins - portion France,ref=EV3,network=icn] Relation ICN [java] 254539829 - [motorcar=yes,mkgmap:label:1=EV3 (EuroVelo 3 - part France),mkgmap:admin_level2=FRA,mkgmap:admin_level3=France métropolitaine,mkgmap:admin_level4=Picardie,icn_from_relation=yes,mkgmap:admin_level6=Oise,icn_ref=EV3,mkgmap:admin_level8=Pontpoint,mkgmap:admin_level7=Senlis,name=Trans'Oise,surface=paved,highway=cycleway,foot=designated,mkgmap:street=Trans'Oise,mkgmap:country=FRA,mkgmap:city=Pontpoint,icn_name=EuroVelo 3 - part France,bicycleroute=yes,source=GPS,mkgmap:region=Picardie,toll=no,tollroad=no,bicycle=yes] ICN way Mkgmap r3118, with jar file overwritten with your patched jar, without name-tag-list-parameter: [java] 2345035 - [route=bicycle,type=route,name=EuroVelo 3 - part France,ref=EV3,network=icn] Relation ICN [java] 254539829 - [motorcar=yes,mkgmap:label:1=EV3 (EuroVelo 3 - part France),mkgmap:admin_level2=FRA,mkgmap:admin_level3=France métropolitaine,mkgmap:admin_level4=Picardie,icn_from_relation=yes,mkgmap:admin_level6=Oise,icn_ref=EV3,mkgmap:admin_level8=Pontpoint,mkgmap:admin_level7=Senlis,name=Trans'Oise,surface=paved,highway=cycleway,foot=designated,mkgmap:street=Trans'Oise,mkgmap:country=FRA,mkgmap:city=Pontpoint,icn_name=EuroVelo 3 - part France,bicycleroute=yes,source=GPS,mkgmap:region=Picardie,toll=no,tollroad=no,bicycle=yes] ICN way Mkgmap r3118, with jar file overwritten with your patched jar, name-tag-list parameter set to name:fr,name,int_name : [java] 2345035 - [route=bicycle,type=route,name=EuroVelo 3 - part France,name:fr=La route des pèlerins - portion France,ref=EV3,network=icn] Relation ICN [java] 254539829 - [motorcar=yes,mkgmap:label:1=EV3 (EuroVelo 3 - part France),mkgmap:admin_level2=FRA,mkgmap:admin_level3=France métropolitaine,mkgmap:admin_level4=Picardie,icn_from_relation=yes,mkgmap:admin_level6=Oise,icn_ref=EV3,mkgmap:admin_level8=Pontpoint,mkgmap:admin_level7=Senlis,name=Trans'Oise,surface=paved,highway=cycleway,foot=designated,mkgmap:street=Trans'Oise,mkgmap:country=FRA,mkgmap:city=Pontpoint,icn_name=EuroVelo 3 - part France,bicycleroute=yes,source=GPS,mkgmap:region=Picardie,toll=no,tollroad=no,bicycle=yes] ICN way What I want is to get for way 254539829 the tag "mkgmap:label:1=La route des pèlerins - portion France". So I expect the relation to automatically get the tag "name=La route des pèlerins - portion France". Or did I misunderstood the way this parameter works ?
Hi Paco, thanks for the details, that helped a lot. I found out that I have to patch RelationStyleHook, not StyledConverter. patch v1 works, but the apply rules are processed before, so it has not much effect ;-) Attached is a version 2 of the patch, a compiled binary based on r3138 is here: http://files.mkgmap.org.uk/download/195/mkgmap.jar Gerd
Date: Sat, 29 Mar 2014 21:54:29 +0100 From: paco.tyson@free.fr To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] Name-tag-list parameter not used in relations processing
Selon GerdP <gpetermann_muenchen@hotmail.com>:
Hi Paco,
you can try it, I've uploaded the binary : http://files.mkgmap.org.uk/download/192/mkgmap.jar
Gerd
Hi Gerd, I'm afraid the patch isn't effective.
For your information, the relations file contains :
network=icn & state!=proposed { apply { set icn_from_relation=yes; set icn_name='${name}'; set icn_ref='${ref}'; }; echotags "Relation ICN"; }
and the corresponding lines file : highway=* & icn_from_relation=yes {name '${icn_ref} (${icn_name|not-equal:icn_ref})' | '${icn_ref}'; echotags "ICN way"; } [0x00 resolution 15-15 continue]
Mkgmap r3116, without name-tag-list parameter set : [java] 2345035 - [route=bicycle,type=route,name=EuroVelo 3 - part France,ref=EV3,network=icn] Relation ICN [java] 254539829 - [motorcar=yes,mkgmap:label:1=EV3 (EuroVelo 3 - part France),mkgmap:admin_level2=FRA,mkgmap:admin_level3=France métropolitaine,mkgmap:admin_level4=Picardie,icn_from_relation=yes,mkgmap:admin_level6=Oise,icn_ref=EV3,mkgmap:admin_level8=Pontpoint,mkgmap:admin_level7=Senlis,name=Trans'Oise,surface=paved,highway=cycleway,foot=designated,mkgmap:street=Trans'Oise,mkgmap:country=FRA,mkgmap:city=Pontpoint,icn_name=EuroVelo 3 - part France,bicycleroute=yes,source=GPS,mkgmap:region=Picardie,toll=no,tollroad=no,bicycle=yes] ICN way
Mkgmap r3116, name-tag-list parameter set to name:fr,name,int_name : [java] 2345035 - [route=bicycle,type=route,name=EuroVelo 3 - part France,name:fr=La route des pèlerins - portion France,ref=EV3,network=icn] Relation ICN [java] 254539829 - [motorcar=yes,mkgmap:label:1=EV3 (EuroVelo 3 - part France),mkgmap:admin_level2=FRA,mkgmap:admin_level3=France métropolitaine,mkgmap:admin_level4=Picardie,icn_from_relation=yes,mkgmap:admin_level6=Oise,icn_ref=EV3,mkgmap:admin_level8=Pontpoint,mkgmap:admin_level7=Senlis,name=Trans'Oise,surface=paved,highway=cycleway,foot=designated,mkgmap:street=Trans'Oise,mkgmap:country=FRA,mkgmap:city=Pontpoint,icn_name=EuroVelo 3 - part France,bicycleroute=yes,source=GPS,mkgmap:region=Picardie,toll=no,tollroad=no,bicycle=yes] ICN way
Mkgmap r3118, with jar file overwritten with your patched jar, without name-tag-list-parameter: [java] 2345035 - [route=bicycle,type=route,name=EuroVelo 3 - part France,ref=EV3,network=icn] Relation ICN [java] 254539829 - [motorcar=yes,mkgmap:label:1=EV3 (EuroVelo 3 - part France),mkgmap:admin_level2=FRA,mkgmap:admin_level3=France métropolitaine,mkgmap:admin_level4=Picardie,icn_from_relation=yes,mkgmap:admin_level6=Oise,icn_ref=EV3,mkgmap:admin_level8=Pontpoint,mkgmap:admin_level7=Senlis,name=Trans'Oise,surface=paved,highway=cycleway,foot=designated,mkgmap:street=Trans'Oise,mkgmap:country=FRA,mkgmap:city=Pontpoint,icn_name=EuroVelo 3 - part France,bicycleroute=yes,source=GPS,mkgmap:region=Picardie,toll=no,tollroad=no,bicycle=yes] ICN way
Mkgmap r3118, with jar file overwritten with your patched jar, name-tag-list parameter set to name:fr,name,int_name : [java] 2345035 - [route=bicycle,type=route,name=EuroVelo 3 - part France,name:fr=La route des pèlerins - portion France,ref=EV3,network=icn] Relation ICN [java] 254539829 - [motorcar=yes,mkgmap:label:1=EV3 (EuroVelo 3 - part France),mkgmap:admin_level2=FRA,mkgmap:admin_level3=France métropolitaine,mkgmap:admin_level4=Picardie,icn_from_relation=yes,mkgmap:admin_level6=Oise,icn_ref=EV3,mkgmap:admin_level8=Pontpoint,mkgmap:admin_level7=Senlis,name=Trans'Oise,surface=paved,highway=cycleway,foot=designated,mkgmap:street=Trans'Oise,mkgmap:country=FRA,mkgmap:city=Pontpoint,icn_name=EuroVelo 3 - part France,bicycleroute=yes,source=GPS,mkgmap:region=Picardie,toll=no,tollroad=no,bicycle=yes] ICN way
What I want is to get for way 254539829 the tag "mkgmap:label:1=La route des pèlerins - portion France". So I expect the relation to automatically get the tag "name=La route des pèlerins - portion France". Or did I misunderstood the way this parameter works ? _______________________________________________ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Selon Gerd Petermann <gpetermann_muenchen@hotmail.com>:
Hi Paco,
thanks for the details, that helped a lot.
I found out that I have to patch RelationStyleHook, not StyledConverter. patch v1 works, but the apply rules are processed before, so it has not much effect ;-)
Attached is a version 2 of the patch, a compiled binary based on r3138 is here: http://files.mkgmap.org.uk/download/195/mkgmap.jar
Gerd
Hi Gerd, Great, it works as expected! :) Now my map is completely localized.
From my point of view, you can commit the patch.
participants (3)
-
Gerd Petermann -
GerdP
-
paco.tyson＠free.fr